idrac 0.1.28 → 0.1.30

data/lib/idrac/firmware.rb

@@ -5,6 +5,8 @@ require 'json'
 require 'nokogiri'
 require 'fileutils'
 require 'securerandom'
+require 'set'
+require 'colorize'
 require_relative 'firmware_catalog'
 
 module IDRAC
@@ -125,39 +127,59 @@ module IDRAC
       system_model = inventory[:system][:model]
       service_tag = inventory[:system][:service_tag]
       
-      puts "Checking updates for system with service tag: #{service_tag}"
-      puts "Searching for updates for model: #{system_model}"
+      puts "Checking updates for system with service tag: #{service_tag}".light_cyan
+      puts "Searching for updates for model: #{system_model}".light_cyan
       
       # Find system models in the catalog
-      models = catalog.find_system_models(system_model.split.first)
+      models = catalog.find_system_models(system_model)
       
       if models.empty?
-        puts "No matching system model found in catalog"
+        puts "No matching system model found in catalog".yellow
         return []
       end
       
       # Use the first matching model
       model = models.first
-      puts "Found system IDs for #{model[:name]}: #{model[:id]}"
+      puts "Found system IDs for #{model[:name]}: #{model[:id]}".green
       
       # Find updates for this system
       catalog_updates = catalog.find_updates_for_system(model[:id])
-      puts "Found #{catalog_updates.size} firmware updates for #{model[:name]}"
+      puts "Found #{catalog_updates.size} firmware updates for #{model[:name]}".green
       
       # Compare current firmware with available updates
       updates = []
       
       # Print header for firmware comparison table
-      puts "\nFirmware Version Comparison:"
+      puts "\nFirmware Version Comparison:".green.bold
       puts "=" * 100
-      puts "%-30s %-20s %-20s %-10s %-15s %-20s" % ["Component", "Current Version", "Available Version", "Updateable", "Category", "Status"]
+      puts "%-30s %-20s %-20s %-10s %-15s %s" % ["Component", "Current Version", "Available Version", "Updateable", "Category", "Status"]
       puts "-" * 100
       
-      # Process each firmware component
+      # Track components we've already displayed to avoid duplicates
+      displayed_components = Set.new
+      
+      # First show current firmware with available updates
       inventory[:firmware].each do |fw|
-        # Find matching updates in catalog
+        # Make sure firmware name is not nil
+        firmware_name = fw[:name] || ""
+        
+        # Skip if we've already displayed this component
+        next if displayed_components.include?(firmware_name.downcase)
+        displayed_components.add(firmware_name.downcase)
+        
+        # Extract key identifiers from the firmware name
+        identifiers = extract_identifiers(firmware_name)
+        
+        # Try to find a matching update
         matching_updates = catalog_updates.select do |update|
-          catalog.match_component(fw[:name], update[:name])
+          update_name = update[:name] || ""
+          
+          # Check if any of our identifiers match the update name
+          identifiers.any? { |id| update_name.downcase.include?(id.downcase) } ||
+          # Or if the update name contains the firmware name
+          update_name.downcase.include?(firmware_name.downcase) ||
+          # Or if the firmware name contains the update name
+          firmware_name.downcase.include?(update_name.downcase)
         end
         
         if matching_updates.any?
@@ -180,73 +202,117 @@ module IDRAC
             }
             
             # Print row with update available
-            puts "%-30s %-20s %-20s %-10s %-15s %-20s" % [
-              fw[:name][0..29],
+            puts "%-30s %-20s %-20s %-10s %-15s %s" % [
+              fw[:name].to_s[0..29],
               fw[:version],
               update[:version],
-              fw[:updateable] ? "Yes" : "No",
+              fw[:updateable] ? "Yes".light_green : "No".light_red,
               update[:category] || "N/A",
-              "UPDATE AVAILABLE"
+              "UPDATE AVAILABLE".light_green.bold
             ]
           else
-            # Print row with no update available
-            puts "%-30s %-20s %-20s %-10s %-15s %-20s" % [
-              fw[:name][0..29],
+            # Print row with no update needed
+            status = if !needs_update
+                       "Current".light_blue
+                     elsif !fw[:updateable]
+                       "Not updateable".light_red
+                     else
+                       "No update needed".light_yellow
+                     end
+            
+            puts "%-30s %-20s %-20s %-10s %-15s %s" % [
+              fw[:name].to_s[0..29],
               fw[:version],
               update[:version] || "N/A",
-              fw[:updateable] ? "Yes" : "No",
+              fw[:updateable] ? "Yes".light_green : "No".light_red,
               update[:category] || "N/A",
-              "No update available"
+              status
             ]
           end
         else
           # No matching update found
-          puts "%-30s %-20s %-20s %-10s %-15s %-20s" % [
-            fw[:name][0..29],
+          puts "%-30s %-20s %-20s %-10s %-15s %s" % [
+            fw[:name].to_s[0..29],
             fw[:version],
             "N/A",
-            fw[:updateable] ? "Yes" : "No",
+            fw[:updateable] ? "Yes".light_green : "No".light_red,
             "N/A",
-            "No update available"
+            "No update available".light_yellow
           ]
         end
       end
       
+      # Then show available updates that don't match any current firmware
+      catalog_updates.each do |update|
+        update_name = update[:name] || ""
+        
+        # Skip if we've already displayed this component
+        next if displayed_components.include?(update_name.downcase)
+        displayed_components.add(update_name.downcase)
+        
+        # Skip if this update was already matched to a current firmware
+        next if inventory[:firmware].any? do |fw|
+          firmware_name = fw[:name] || ""
+          identifiers = extract_identifiers(firmware_name)
+          
+          identifiers.any? { |id| update_name.downcase.include?(id.downcase) } ||
+          update_name.downcase.include?(firmware_name.downcase) ||
+          firmware_name.downcase.include?(update_name.downcase)
+        end
+        
+        puts "%-30s %-20s %-20s %-10s %-15s %s" % [
+          update_name.to_s[0..29],
+          "Not Installed".light_red,
+          update[:version] || "Unknown",
+          "N/A",
+          update[:category] || "N/A",
+          "NEW COMPONENT".light_blue
+        ]
+      end
+      
+      puts "=" * 100
+      
       updates
     end
     
-    def interactive_update(catalog_path = nil)
-      updates = check_updates(catalog_path)
+    def interactive_update(catalog_path = nil, selected_updates = nil)
+      updates = selected_updates || check_updates(catalog_path)
       
       if updates.empty?
-        puts "No updates available for your system."
+        puts "No updates available for your system.".yellow
         return
       end
       
-      puts "\nAvailable updates:"
+      puts "\nAvailable Updates:".green.bold
       updates.each_with_index do |update, index|
-        puts "#{index + 1}. #{update[:name]}: #{update[:current_version]} -> #{update[:available_version]}"
+        puts "#{index + 1}. #{update[:name]}: #{update[:current_version]} -> #{update[:available_version]}".light_cyan
       end
       
-      puts "\nEnter the number of the update to install (or 'all' for all updates, 'q' to quit):"
-      choice = STDIN.gets.chomp
-      
-      return if choice.downcase == 'q'
-      
-      selected_updates = if choice.downcase == 'all'
-                          updates
-                        else
-                          index = choice.to_i - 1
-                          if index >= 0 && index < updates.size
-                            [updates[index]]
-                          else
-                            puts "Invalid selection."
-                            return
-                          end
-                        end
-      
-      selected_updates.each do |update|
-        puts "Downloading #{update[:name]} version #{update[:available_version]}..."
+      # If selected_updates is provided, use those directly
+      if selected_updates
+        selected = selected_updates
+      else
+        # Otherwise prompt the user for selection
+        puts "\nEnter the number of the update to install (or 'all' for all updates, 'q' to quit):".light_yellow
+        choice = STDIN.gets.chomp
+        
+        return if choice.downcase == 'q'
+        
+        selected = if choice.downcase == 'all'
+                      updates
+                    else
+                      index = choice.to_i - 1
+                      if index >= 0 && index < updates.size
+                        [updates[index]]
+                      else
+                        puts "Invalid selection.".red
+                        return
+                      end
+                    end
+      end
+      
+      selected.each do |update|
+        puts "Downloading #{update[:name]} version #{update[:available_version]}...".light_cyan.bold
         
         # Create temp directory
         temp_dir = Dir.mktmpdir
@@ -267,15 +333,35 @@ module IDRAC
                   end
                 end
               else
-                puts "Failed to download update: #{response.code} #{response.message}"
+                puts "Failed to download update: #{response.code} #{response.message}".red
                 next
               end
             end
           end
           
-          puts "Installing #{update[:name]} version #{update[:available_version]}..."
-          job_id = update(update_path, wait: true)
-          puts "Update completed with job ID: #{job_id}"
+          puts "Installing #{update[:name]} version #{update[:available_version]}...".light_cyan.bold
+          
+          begin
+            job_id = update(update_path, wait: true)
+            puts "Update completed with job ID: #{job_id}".green.bold
+          rescue IDRAC::Error => e
+            if e.message.include?("already in progress")
+              puts "Error: #{e.message}".red.bold
+              puts "\nTips for resolving this issue:".yellow.bold
+              puts "1. Wait for any existing firmware updates to complete (check iDRAC web interface)".light_yellow
+              puts "2. Restart the iDRAC if no updates appear to be in progress (Settings > iDRAC Settings > Reset iDRAC)".light_yellow
+              puts "3. Try again after a few minutes".light_yellow
+            elsif e.message.include?("job ID") || e.message.include?("job not found")
+              puts "Error: #{e.message}".red.bold
+              puts "\nThe job ID could not be found or monitored. This could be because:".yellow
+              puts "1. The iDRAC is busy processing other requests".light_yellow
+              puts "2. The job was created but not properly tracked".light_yellow
+              puts "3. The iDRAC firmware may need to be updated first".light_yellow
+              puts "\nCheck the iDRAC web interface to see if the update was actually initiated.".light_cyan
+            else
+              puts "Error during firmware update: #{e.message}".red.bold
+            end
+          end
           
         ensure
           # Clean up temp directory
@@ -323,28 +409,103 @@ module IDRAC
       post_body << "\r\n--#{boundary}--\r\n"
       
       # Upload the firmware
-      response = client.authenticated_request(
+      begin
+        response = client.authenticated_request(
+          :post,
+          http_push_uri,
+          {
+            headers: {
+              'Content-Type' => "multipart/form-data; boundary=#{boundary}",
+              'If-Match' => etag
+            },
+            body: post_body.join
+          }
+        )
+      rescue => e
+        # Check if the error is about a deployment already in progress
+        if e.message.include?("A deployment or update operation is already in progress")
+          raise Error, "A firmware update is already in progress on the iDRAC. Please wait for it to complete before starting another update. You can check the status in the iDRAC web interface under Maintenance > System Update."
+        else
+          # Re-raise the original error
+          raise
+        end
+      end
+      
+      if response.status < 200 || response.status >= 300
+        error_message = response.body.to_s
+        
+        # Check for specific error messages in the response
+        if error_message.include?("A deployment or update operation is already in progress")
+          raise Error, "A firmware update is already in progress on the iDRAC. Please wait for it to complete before starting another update. You can check the status in the iDRAC web interface under Maintenance > System Update."
+        elsif error_message.include?("SUP0108")
+          raise Error, "iDRAC Error SUP0108: A deployment or update operation is already in progress. Wait for the operation to conclude and then try again."
+        else
+          raise Error, "Firmware upload failed with status #{response.status}: #{response.body}"
+        end
+      end
+      
+      # Extract upload ID from response
+      response_data = JSON.parse(response.body)
+      upload_id = response_data['Id'] || response_data['TaskId']
+      
+      if upload_id.nil?
+        raise Error, "Failed to extract upload ID from firmware upload response"
+      end
+      
+      puts "Firmware file uploaded successfully with ID: #{upload_id}"
+      
+      # Step 2: Initiate the firmware update using SimpleUpdate
+      puts "Initiating firmware update using SimpleUpdate..."
+      
+      # Construct the image URI using the uploaded file
+      image_uri = "#{http_push_uri}/#{upload_id}"
+      puts "Using ImageURI: #{image_uri}"
+      
+      # Call the SimpleUpdate action
+      simple_update_response = client.authenticated_request(
         :post,
-        http_push_uri,
+        "/redfish/v1/UpdateService/Actions/UpdateService.SimpleUpdate",
         {
           headers: {
-            'Content-Type' => "multipart/form-data; boundary=#{boundary}",
-            'If-Match' => etag
+            'Content-Type' => 'application/json'
           },
-          body: post_body.join
+          body: JSON.generate({
+            'ImageURI' => image_uri,
+            '@Redfish.OperationApplyTime' => 'Immediate'
+          })
         }
       )
       
-      if response.status < 200 || response.status >= 300
-        raise Error, "Firmware upload failed with status #{response.status}: #{response.body}"
+      if simple_update_response.status < 200 || simple_update_response.status >= 300
+        raise Error, "Firmware update initiation failed with status #{simple_update_response.status}: #{simple_update_response.body}"
       end
       
       # Extract job ID from response
-      response_data = JSON.parse(response.body)
-      job_id = response_data['Id'] || response_data['TaskId']
+      job_id = nil
+      
+      # Try to get job ID from Location header
+      if simple_update_response.headers['location']
+        job_id = simple_update_response.headers['location'].split('/').last
+      end
       
+      # If not found in header, try to get from response body
+      if job_id.nil? && !simple_update_response.body.empty?
+        begin
+          update_data = JSON.parse(simple_update_response.body)
+          if update_data['@odata.id']
+            job_id = update_data['@odata.id'].split('/').last
+          elsif update_data['Id']
+            job_id = update_data['Id']
+          end
+        rescue JSON::ParserError
+          # Not JSON, ignore
+        end
+      end
+      
+      # If still no job ID, use the upload ID as a fallback
       if job_id.nil?
-        raise Error, "Failed to extract job ID from firmware upload response"
+        job_id = upload_id
+        puts "No job ID found in SimpleUpdate response, using upload ID as job ID"
       end
       
       puts "Firmware update job created with ID: #{job_id}"
@@ -392,5 +553,54 @@ module IDRAC
       response_data = JSON.parse(response.body)
       response_data['TaskState'] || 'Unknown'
     end
+
+    # Helper method to extract identifiers from component names
+    def extract_identifiers(name)
+      return [] unless name
+      
+      identifiers = []
+      
+      # Extract model numbers like X520, I350, etc.
+      model_matches = name.scan(/[IX]\d{3,4}/)
+      identifiers.concat(model_matches)
+      
+      # Extract PERC model like H730
+      perc_matches = name.scan(/[HP]\d{3,4}/)
+      identifiers.concat(perc_matches)
+      
+      # Extract other common identifiers
+      if name.include?("NIC") || name.include?("Ethernet") || name.include?("Network")
+        identifiers << "NIC"
+      end
+      
+      if name.include?("PERC") || name.include?("RAID")
+        identifiers << "PERC"
+        # Extract PERC model like H730
+        perc_match = name.match(/PERC\s+([A-Z]\d{3})/)
+        identifiers << perc_match[1] if perc_match
+      end
+      
+      if name.include?("BIOS")
+        identifiers << "BIOS"
+      end
+      
+      if name.include?("iDRAC") || name.include?("IDRAC") || name.include?("Remote Access Controller")
+        identifiers << "iDRAC"
+      end
+      
+      if name.include?("Power Supply") || name.include?("PSU")
+        identifiers << "PSU"
+      end
+      
+      if name.include?("Lifecycle Controller")
+        identifiers << "LC"
+      end
+      
+      if name.include?("CPLD")
+        identifiers << "CPLD"
+      end
+      
+      identifiers
+    end
   end
 end