idnow 1.0.0 → 2.3.0

data/lib/idnow/models/identification_process.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module Idnow
   class IdentificationProcess
     include Idnow::Jsonable
 
-    SUCCESSFUL_RESPONSES = %w(SUCCESS SUCCESS_DATA_CHANGED).freeze
+    SUCCESSFUL_RESPONSES = %w[SUCCESS SUCCESS_DATA_CHANGED].freeze
     attr_accessor :result, :reason, :company_id, :filename, :agentname, :identification_time, :id, :href, :type, :transaction_number
 
     def initialize(data)
@@ -23,7 +25,7 @@ module Idnow
     end
 
     def review_pending?
-      result == 'REVIEW_PENDING'
+      result == 'REVIEW_PENDING' || result == 'FRAUD_SUSPICION_PENDING'
     end
   end
 end

data/lib/idnow/models/identification_request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   class IdentificationRequest
     attr_accessor :id, :transaction_number

data/lib/idnow/models/login.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   class Login
     attr_accessor :auth_token

data/lib/idnow/models/login_data.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 
 module Idnow
@@ -6,7 +8,7 @@ module Idnow
       @api_key = api_key
     end
 
-    def to_json
+    def to_json(*_args)
       { apiKey: @api_key }.to_json
     end
   end

data/lib/idnow/models/user_data.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   class UserData
     include Idnow::Jsonable
@@ -19,12 +21,17 @@ module Idnow
       @streetnumber = dig_value('address', 'streetnumber', data)
       @title        = dig_value('title', data)
       @zipcode      = dig_value('address', 'zipcode', data)
+      @raw_data     = data
     end
 
     def address
       "#{street} #{streetnumber}, #{zipcode} #{city}, #{country}"
     end
 
+    def address_changed?
+      @raw_data['address'].values.any? { |field| field['status'] == 'CHANGE' }
+    end
+
     private
 
     def dig_value(*keys, data)

data/lib/idnow/modules/jsonable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   module Jsonable
     def to_h
@@ -12,7 +14,7 @@ module Idnow
       end
     end
 
-    def to_json
+    def to_json(*_args)
       keys_without_underscores(to_h).to_json
     end
 
@@ -20,6 +22,7 @@ module Idnow
 
     def keys_without_underscores(obj)
       return obj unless obj.is_a?(Hash)
+
       obj.each_with_object({}) do |(k, v), result|
         result[k.to_s.delete('_')] = keys_without_underscores(v)
       end

data/lib/idnow/post_binary_request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'net/http'
 
 module Idnow

data/lib/idnow/post_json_request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # require 'json'
 require 'net/http'
 

data/lib/idnow/raw_response.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Idnow
   class RawResponse
     attr_reader :raw
@@ -11,7 +13,7 @@ module Idnow
     def errors
       if valid_json?(@raw)
         json_data = JSON.parse(@raw)
-        json_data['errors'] if json_data.class == Hash
+        json_data['errors'] if json_data.instance_of?(Hash)
       end
     end
 
@@ -23,9 +25,9 @@ module Idnow
 
     def valid_json?(json)
       JSON.parse(json)
-      return true
+      true
     rescue JSON::ParserError
-      return false
+      false
     end
   end
 end

data/lib/idnow/sftp_client.rb

@@ -1,17 +1,22 @@
+# frozen_string_literal: true
+
 require 'net/sftp'
 
 module Idnow
   class SftpClient
-    def initialize(host:, username:, password:)
+    def initialize(host:, username:, password:, options: {})
       @host = URI.parse(host).host
       @username = username
       @password = password
+      @options = options
     end
 
     def download(file_name)
       data = nil
-      Net::SFTP.start(@host, @username, password: @password) do |sftp|
-        fail Idnow::Exception, "Invalid path. No identification file found under #{file_name}" if sftp.dir['.', file_name].empty?
+      options = @options.merge(password: @password)
+      Net::SFTP.start(@host, @username, options) do |sftp|
+        raise Idnow::Exception, "Invalid path. No identification file found under #{file_name}" unless file_exists(sftp, file_name)
+
         begin
           data = sftp.download!(file_name)
         rescue Net::SFTP::Exception => e
@@ -20,5 +25,12 @@ module Idnow
       end
       data
     end
+
+    private
+
+    def file_exists(sftp, file_name)
+      sftp.dir.entries('.').each { |entry| return true if file_name == entry.name }
+      false
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: idnow
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Joan Martinez, Tobias Bielohlawek
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-05-04 00:00:00.000000000 Z
+date: 2021-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-sftp
@@ -25,105 +25,107 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.1'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.22'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.22'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: shoulda-matchers
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.36.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.36.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: factory_girl
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.5'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.5'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: shoulda-matchers
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '0'
 description: Library to consume the IDnow API in Ruby, http://www.idnow.eu/developers
 email:
-- joan.martinez.ripoll@gmail.com
+- joan.martinez@solarisbank.de
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/gem-push.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
 - ".travis.yml"
+- CODE_OF_CONDUCT.md
+- Dockerfile
 - Gemfile
 - LICENSE.txt
 - Makefile
 - README.md
-- circle.yml
 - docs/IDnow_API.pdf
 - examples/idnow_automated_testing.rb
 - examples/idnow_download_identification.rb
@@ -172,15 +174,17 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.5'
+  - - "<"
+    - !ruby/object:Gem::Version
+      version: '3.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Ruby client for the IDnow API

data/circle.yml

@@ -1,7 +0,0 @@
-machine:
-  ruby:
-    version: 2.2.3
-
-test:
-  override:
-    - make test