idml 0.7.4 → 0.7.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2f60e795f4325dcc4006a28915a18baf7069e21767694ca670c41f84db62d98d
-  data.tar.gz: 4f1f4846d41050b518c8add338ce431951b45ea58891b2c56154b47e59478bc7
+  metadata.gz: a713a0a63c6af7b6090c9a6260467db40ee9a7c497f37561dccf2526ceadaa71
+  data.tar.gz: a6695a7318b96ed6664e15b9e2a99e40d2da6ef05139154ba7ccfab73e3eeecf
 SHA512:
-  metadata.gz: bbf7caac497ce2ab01a8c35af7bad78a24b7a706db6baa582b7d416cae1ce4995f18a3903379c4e994ab49ca1f28efd33e162821dead95250ae8248c041d16cd
-  data.tar.gz: ed5d2ae0abf40c0c6bf101d3c05ca35f59bc48aefed14366de7f5ac0f15979ff458ca7cf8493d012c4f6a78b0c1889815f987ea3dc9f24971f31ae34583f6fc4
+  metadata.gz: 92e8aff4adbb8935c2e3ec7b7ead236458ec2f7171a2923eee9de63b4b4f0ed96d95f7f39c9c184d97643b0aa9096e3aa1b40e890610e82d514bb36b17c6f14b
+  data.tar.gz: 88c470bb2d55962f57a950fe6c1ef526d34ce36d7fafe38ed045d4f7019821586a9045d1f027e28eb304a1d0a57da9f157256603a83e48e873decd3f2620554c

data/TODO.pdf/116-applied-style-resolution.md

@@ -0,0 +1,62 @@
+# TODO PDF 116: AppliedParagraphStyle / AppliedCharacterStyle resolution from Resources/Styles.xml
+
+## Status: OPEN — critical gap identified in 2026-08-10 audit
+
+## Problem
+
+In real IDML documents, the `<ParagraphStyleRange>` element often
+carries ONLY an `AppliedParagraphStyle` reference and NO inline
+formatting attributes. The actual formatting (Justification,
+SpaceBefore, PointSize, etc.) lives in the referenced
+`<ParagraphStyle>` definition in `Resources/Styles.xml`.
+
+Example from the sample-with-table-more fixture:
+```xml
+<ParagraphStyleRange AppliedParagraphStyle="ParagraphStyle/$ID/NormalParagraphStyle">
+  <CharacterStyleRange AppliedCharacterStyle="CharacterStyle/$ID/[No character style]">
+    ...
+  </CharacterStyleRange>
+</ParagraphStyleRange>
+```
+
+The PSR has NO inline Justification, SpaceBefore, etc. Those values
+are on `ParagraphStyle Self="ParagraphStyle/$ID/NormalParagraphStyle"`
+in Styles.xml.
+
+Today StyleResolver reads attributes directly from the PSR element.
+When the PSR has only a style reference (common in real documents),
+the renderer uses default values for everything.
+
+## Impact
+
+For the `sample-with-table-more` fixture, every PSR uses
+`NormalParagraphStyle` — which in InDesign maps to 12pt Regular with
+left alignment. The renderer happens to produce approximately right
+output because the defaults match. But for documents that use custom
+paragraph styles (Heading 1 = 24pt Bold Centered, Body Text = 11pt
+Justified with 6pt SpaceAfter), the output would be wrong.
+
+## What needs to happen
+
+1. `Render::StyleResolver` resolves `AppliedParagraphStyle` to a
+   `ParagraphStyle` from `Parts::Style` (Resources/Styles.xml).
+2. PSR inline attributes override the style's attributes (when both
+   are present — this is the IDML "local override" mechanism).
+3. Same for `AppliedCharacterStyle` → `CharacterStyle` resolution.
+4. The merged attributes become the Paragraph/StyledRun's values.
+
+Architecture: `Parts::Style` already parses `<ParagraphStyle>` and
+`<CharacterStyle>` entries. StyleResolver needs access to the style
+part (via `context.package.styles` or similar).
+
+## Acceptance criteria
+
+- [ ] PSR with only AppliedParagraphStyle resolves formatting from
+      the referenced ParagraphStyle.
+- [ ] PSR inline attributes override style attributes.
+- [ ] CharacterStyle resolution for CSR's AppliedCharacterStyle.
+- [ ] Spec: fixture with custom paragraph style renders correctly.
+
+## Dependencies
+
+- None — pure feature work on existing models.

data/TODO.pdf/99-table-column-widths.md

@@ -1,10 +1,10 @@
-# TODO PDF 99: Table column widths from ColumnAttributes
+# TODO PDF 99: Table column widths from Column elements
 
-## Status: DONE — Table now models `column_count` and
-`single_column_width`; SchemaLayout uses SingleColumnWidth when
-declared, else falls back to even division. (IDML has no separate
-ColumnAttributes element — column widths live on Table directly
-when uniform.)
+## Status: DONE — Table now models both `single_column_width`
+(uniform) and per-column `<Column>` elements with individual
+`SingleColumnWidth` values. SchemaLayout uses per-column widths
+when `<Column>` children are present; falls back to uniform when
+not.
 
 ## Problem
 

data/lib/idml/elements/column.rb

@@ -0,0 +1,45 @@
+# frozen_string: true
+
+module Idml
+  module Elements
+    # `<Column>` — a column definition within an IDML Table. Carries
+    # the column's width (SingleColumnWidth), type (HeaderColumn /
+    # BodyColumn), insets, and visual properties (fill, diagonal lines).
+    #
+    # Schema: `Column_Object` in
+    # `reference-docs/schemas/package/Stories/Story.rnc`. Real IDML
+    # tables have `<Column>` children alongside `<Row>` and `<Cell>`
+    # siblings. The `Name` attribute is the column index as a string
+    # (e.g., "0", "1", "2").
+    #
+    # The renderer's SchemaLayout reads `SingleColumnWidth` per column
+    # to compute per-column x positions and widths (replaces the
+    # even-division / uniform-width fallback).
+    class Column < Lutaml::Model::Serializable
+      attribute :self_attr, :string
+      attribute :name, :string
+      attribute :single_column_width, :float
+      attribute :column_type, :string
+      attribute :fill_color, :string
+      attribute :fill_tint, :float
+
+      xml do
+        root "Column"
+        map_attribute "Self", to: :self_attr
+        map_attribute "Name", to: :name
+        map_attribute "SingleColumnWidth", to: :single_column_width
+        map_attribute "ColumnType", to: :column_type
+        map_attribute "FillColor", to: :fill_color
+        map_attribute "FillTint", to: :fill_tint
+      end
+
+      # Column Name is a string integer (e.g., "0", "1").
+      # Returns the integer index or nil if Name is missing/invalid.
+      def index
+        return nil unless name
+
+        Integer(name, 10, exception: false) # rubocop:disable Style/RescueModifier
+      end
+    end
+  end
+end

data/lib/idml/elements/table.rb

@@ -46,6 +46,7 @@ module Idml
       attribute :table_row, Idml::Elements::TableRow, collection: true
       attribute :cell, Idml::Elements::Cell, collection: true
       attribute :row, Idml::Elements::Row, collection: true
+      attribute :column, Idml::Elements::Column, collection: true
       attribute :properties, Idml::Elements::Properties, collection: true
 
       xml do
@@ -77,6 +78,7 @@ module Idml
         map_element "TableRow", to: :table_row
         map_element "Cell", to: :cell
         map_element "Row", to: :row
+        map_element "Column", to: :column
         map_element "Properties", to: :properties
       end
 

data/lib/idml/elements.rb

@@ -17,6 +17,7 @@ module Idml
     autoload :ButtonPreference, "idml/elements/pref_button_preference"
     autoload :Bookmark, "idml/elements/bookmark"
     autoload :Cell, "idml/elements/cell"
+    autoload :Column, "idml/elements/column"
     autoload :Condition, "idml/elements/condition"
     autoload :CellStyle, "idml/elements/cell_style"
     autoload :CellStyleGroup, "idml/elements/cell_style_group"

data/lib/idml/render/renderers/table_renderer.rb

@@ -243,7 +243,8 @@ module Idml
                 mark_covered(covered, col_idx, row_idx, col_span, row_span)
 
                 yield cell_x(col_idx), cell_y(row_idx, col_span, row_span),
-                      cell_w(col_span), cell_h(row_idx, row_span), cell
+                      cell_w(col_idx, col_span), cell_h(row_idx, row_span),
+                      cell
               end
             end
           end
@@ -286,7 +287,7 @@ module Idml
           private :mark_covered
 
           def cell_x(col)
-            box[:x] + (col * per_col_width)
+            box[:x] + cumulative_col_width(col)
           end
 
           # PDF-coordinate bottom y of the cell's rectangle. For a
@@ -297,9 +298,11 @@ module Idml
             box[:y] + total_height - cumulative_height(last_row + 1)
           end
 
-          # Width covered by `span` columns starting at the cell's col.
-          def cell_w(span)
-            per_col_width * (span || 1)
+          # Width covered by `span` columns starting at `col`. Uses
+          # per-column widths from Column elements when available;
+          # falls back to uniform width when not.
+          def cell_w(col, span)
+            span.to_i.times.sum { |i| column_width_at(col + i) }
           end
 
           # Total height covered by `span` rows starting at `row_idx`.
@@ -318,6 +321,41 @@ module Idml
                              end
           end
 
+          # Returns per-column widths from Column elements when
+          # present; empty array otherwise. When non-empty, the
+          # renderer uses per-column widths for x positions and
+          # span widths instead of uniform per_col_width.
+          def per_column_widths
+            return @per_column_widths if defined?(@per_column_widths)
+
+            cols = table.column
+            @per_column_widths = if cols.empty?
+                                   []
+                                 else
+                                   cols.filter_map do |col|
+                                     w = col.single_column_width
+                                     w&.positive? ? w : nil
+                                   end
+                                 end
+          end
+
+          # Width of a single column at index `idx`. Uses per-column
+          # widths when available; falls back to uniform.
+          def column_width_at(idx)
+            return per_col_width if per_column_widths.empty?
+            return per_col_width unless idx.between?(0, per_column_widths.length - 1)
+
+            per_column_widths[idx]
+          end
+
+          # Cumulative width from column 0 up to (but not including)
+          # column `col`. Used for x positioning.
+          def cumulative_col_width(col)
+            return col * per_col_width if per_column_widths.empty?
+
+            col.times.sum { |i| column_width_at(i) }
+          end
+
           def row_height(idx)
             return 0.0 unless idx.between?(0, row_count - 1)
 

data/lib/idml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Idml
-  VERSION = "0.7.4"
+  VERSION = "0.7.5"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: idml
 version: !ruby/object:Gem::Version
-  version: 0.7.4
+  version: 0.7.5
 platform: ruby
 authors:
 - Ribose
@@ -172,6 +172,7 @@ files:
 - TODO.pdf/113-multi-column-text-frames.md
 - TODO.pdf/114-text-wrap-around-shapes.md
 - TODO.pdf/115-bullet-numbered-lists.md
+- TODO.pdf/116-applied-style-resolution.md
 - TODO.pdf/12-idml-to-pdf-pipeline.md
 - TODO.pdf/13-cjk-text-layout.md
 - TODO.pdf/14-page-item-element-models.md
@@ -280,6 +281,7 @@ files:
 - lib/idml/elements/character_style_group.rb
 - lib/idml/elements/character_style_range.rb
 - lib/idml/elements/color.rb
+- lib/idml/elements/column.rb
 - lib/idml/elements/condition.rb
 - lib/idml/elements/content.rb
 - lib/idml/elements/content_transparency_setting.rb