idml 0.5.3 → 0.5.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2956308b8fe6f09356fea8016d6a0b24591886d2d4b04071ddfaff55256f0200
-  data.tar.gz: 424536bb8501ceb97d6654c2b61429e4294104c3c75a77706ba9b8157760c9ab
+  metadata.gz: ce8ffd92b6fd96bc1b018ed0875a0344e4c96692b18a12f3ab7999db3bc0c257
+  data.tar.gz: b454cdc91f17dabacd2c35a8f1b808aacbb23b40a91b7b392eab68c7b109935c
 SHA512:
-  metadata.gz: d85d3a00384ed297258957fece3cc099312205819810455b678b5b6db48d05c0b67507b787c7f3cd0d2e9f8790a58e44493fef8420a7ec08b3fd20c4974bc6f6
-  data.tar.gz: f4f8a104afeefc576fd7246eb6d87107232881de180883ffe0cbaa617b7dbb1216feff20e92b4f374cad84a4aeed0ef0e3944c5cc3180d02bd96cd9948d45d5f
+  metadata.gz: 9d1c153af76705ddef5cdf58334d1f23010dd0a88c3559f9fd7da87cf94a52f2a48c386dddd6a443f2877c0df25e9ae618a3388e117d5c825b99814ee2d35973
+  data.tar.gz: 86eaa92d00b471cb085dc32f81e6c7618a856583ff340bd88f5b535378cfa8e46c73685d5fb6090a10be22e3c3425066b54859ce98be78cb31a2dcfc598a71b2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    idml (0.5.3)
+    idml (0.5.5)
       bigdecimal
       lutaml-model (~> 0.8.18)
       pdfrb
@@ -183,7 +183,7 @@ CHECKSUMS
   ffi (1.17.4-x86_64-darwin) sha256=aa70390523cf3235096cf64962b709b4cfbd5c082a2cb2ae714eb0fe2ccda496
   ffi (1.17.4-x86_64-linux-gnu) sha256=9d3db14c2eae074b382fa9c083fe95aec6e0a1451da249eab096c34002bc752d
   ffi (1.17.4-x86_64-linux-musl) sha256=3fdf9888483de005f8ef8d1cf2d3b20d86626af206cbf780f6a6a12439a9c49e
-  idml (0.5.3)
+  idml (0.5.5)
   json (2.21.2) sha256=1f1d3b7cf2b3ba1a69beca0bb6db13d5438b80bff3cd54cdaaa620b9b07c1c6a
   language_server-protocol (3.17.0.6) sha256=5ef2c0c138f8267e1bc631d3328347d354f96724b0af22f2c79516120443b7f0
   lint_roller (1.1.0) sha256=2c0c845b632a7d172cb849cc90c1bce937a28c5c8ccccb50dfd46a485003cc87

data/TODO.pdf/89-deep-audit-idml-vs-indesign.md

@@ -1,18 +1,28 @@
 # TODO PDF 89: Deep audit — idml-generated PDF vs InDesign PDF
 
-## Status: PARTIAL — font + lossless compression fixed; no downsampling
+## Status: COMPLETE — all fixable gaps closed; remaining gap is no-data-loss constraint
 
 ## TL;DR
 
-**No** — the generated PDF is still not byte-identical to InDesign's
-output. Two of three substantive gaps closed without data loss:
-
-1. **Font selection (closed, v0.5.0)** — FontSetup now prefers the
-   family's Regular/Normal/Book/Roman variant over first-in-family.
-   Sample-with-table-more now embeds `MinionPro-Regular` (matching
-   InDesign).
-2. **Lossless FlateDecode compression (closed, v0.5.1)** — pdfrb
-   writes FlateDecode-compressed content streams, XRef streams, and
+**No** — the generated PDF is not byte-identical to InDesign's output.
+This is by design: the user requirement is **no data loss**. InDesign's
+100KB output downsamples the 1.94MB source image to ~12KB; we preserve
+the image at full resolution. All other gaps (font selection, font
+embedding type, subset prefix, xref compliance, Info dict, lossless
+compression) are now closed.
+
+Closed gaps (v0.5.0–v0.5.4):
+1. Font selection — Regular weight preferred over first-in-family.
+2. Font embedding via IO (not string path) — properly embeds as CFF.
+3. Font type — Type1/CFF (not TrueType), matching InDesign.
+4. Font subset prefix — 6-char uppercase tag (not FileFont-).
+5. xref compliance — 20-byte entries (pdfrb 0.6.0 fix).
+6. Info dict — no spurious /Type/Metadata.
+7. Lossless FlateDecode compression — opt-in via --compress.
+
+Remaining gap (cannot close without data loss):
+- File size: 2.1MB vs 100KB. The 1.94MB embedded JPEG is preserved
+  at source resolution per the no-data-loss requirement.
    object streams when `compress: true`. Saves ~96KB (4%) on the
    sample-with-table-more fixture without any data loss.
 3. **Image downsampling** — **not pursued**. The user requirement is

data/TODO.pdf/92-xref-entry-byte-count.md

@@ -1,6 +1,6 @@
 # TODO PDF 92: XRef entry byte-count compliance (21 vs 20 bytes)
 
-## Status: IDENTIFIED — pdfrb upstream bug
+## Status: FIXED (pdfrb 0.6.0, issue claricle/pdfrb#59)
 
 ## Problem
 

data/TODO.pdf/93-per-run-font-resolution.md

@@ -0,0 +1,67 @@
+# TODO PDF 93: Per-run font resolution from CharacterStyleRange
+
+## Status: PLANNED (last major rendering fidelity gap)
+
+## Problem
+
+All text in the rendered PDF uses the same font (the document's
+default Regular weight). Real IDML documents specify per-run fonts
+via `CharacterStyleRange#AppliedCharacterStyle` → `CharacterStyle`
+→ `Properties/AppliedFont` (family name) + style attributes.
+
+For the `sample-with-table-more` fixture, all text happens to use
+`[No character style]` with `NormalParagraphStyle`, so the default
+Regular weight is correct. But other IDML documents have bold,
+italic, and mixed-family text that our renderer can't express.
+
+## What needs to happen
+
+1. **StyleResolver enhancement**: extract `applied_font` from each
+   CSR via its `AppliedCharacterStyle` reference. The chain is:
+   - CSR `AppliedCharacterStyle="CharacterStyle/$ID/bold_text"`
+   - → CharacterStyle `Self="CharacterStyle/$ID/bold_text"`
+   - → CharacterStyle `Properties/AppliedFont` → family name
+   - → CharacterStyle `FontStyle` → style (Bold, Italic, etc.)
+   - → Fonts.xml lookup → PostScriptName
+   - → Pdfrb::FontResolver → file path → pdfrb font resource
+
+2. **Multi-font registration**: FontSetup registers each distinct
+   font used by any CSR, not just the document default. Returns a
+   map of `applied_font_ref → pdfrb_symbol`.
+
+3. **StyledRun enhancement**: carries the resolved pdfrb font
+   resource Symbol (not just the PS name string).
+
+4. **TextFrameRenderer**: uses `run.font_resource` for each
+   `canvas.text` / `canvas.text_rich` call instead of the single
+   `context.font_ps_name`.
+
+5. **TableRenderer**: same — per-cell font resolution from the
+   cell's CSR.
+
+## Scope
+
+- For documents with uniform styling (like the test fixture), no
+  visible change — the default Regular font is already correct.
+- For documents with bold/italic/mixed-family runs, text would
+  render in the correct font per run.
+- Font subsetting becomes per-font: each registered font gets its
+  own used-codepoint set and subset.
+
+## Dependencies
+
+- pdfrb 0.6.0 with IO-based font loading (DONE, v0.5.3).
+- CharacterStyle element model (exists — verify AppliedFont
+  extraction from Properties).
+- FontReferenceResolver (exists — already builds family → PSName
+  lookup from Fonts.xml).
+
+## Acceptance criteria
+
+- [ ] StyledRun carries a resolved pdfrb font resource Symbol.
+- [ ] CSR with `AppliedCharacterStyle` referencing a bold style
+      renders in bold font.
+- [ ] CSR with no applied style renders in the document default.
+- [ ] Multiple fonts embedded when document uses multiple families.
+- [ ] Font subsetting works per-font (each font subsetted to its
+      own used codepoints).

data/lib/idml/render.rb

@@ -2,6 +2,16 @@
 
 require "pdfrb"
 
+# pdfrb 0.6.0 autoloads OptContentUsage from opt_content_ext.rb but
+# that file doesn't define it, causing eager_load! to crash.
+# Trigger the autoload (catching the failure) then define a stub.
+begin
+  Pdfrb::Model::Type::OptContentUsage
+rescue NameError
+  Pdfrb::Model::Type.const_set(:OptContentUsage,
+                               Class.new(Pdfrb::Model::Cos::Dictionary))
+end
+
 module Idml
   module Render
     autoload :ColorHelper,         "#{__dir__}/render/color_helper"

data/lib/idml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Idml
-  VERSION = "0.5.3"
+  VERSION = "0.5.5"
 end

data/lib/idml.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
+require "pdfrb"
 require "zip"
 require "fileutils"
 require "tempfile"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: idml
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.5.5
 platform: ruby
 authors:
 - Ribose
@@ -215,9 +215,9 @@ files:
 - TODO.pdf/86-caching-performance.md
 - TODO.pdf/87-final-state-summary.md
 - TODO.pdf/89-deep-audit-idml-vs-indesign.md
-- TODO.pdf/90-per-run-font-resolution.md
 - TODO.pdf/91-image-downsampling.md
 - TODO.pdf/92-xref-entry-byte-count.md
+- TODO.pdf/93-per-run-font-resolution.md
 - TODO.pdf/README.md
 - exe/idml
 - idml.gemspec

data/TODO.pdf/90-per-run-font-resolution.md

@@ -1,55 +0,0 @@
-# TODO PDF 90: Per-run font resolution
-
-## Status: PLANNED (TODO 89 audit follow-up)
-
-## Problem
-
-`Idml::Render::FontSetup#register` picks the first non-missing font
-in the document's `font_family` collection. For the
-`sample-with-table-more` fixture that's `MinionPro-BoldCn` — but
-InDesign's reference PDF embeds `MinionPro-Regular` because each
-text run's `CharacterStyleRange#AppliedFont` specifies a per-run font.
-
-The current `Idml::Render::StyleResolver::StyledRun` carries font
-metadata but not the resolved per-run font. All text renders with
-the first-available font, which may not match what the CSR's
-`AppliedFont` references.
-
-## Plan
-
-1. **Extract per-run font** — `StyleResolver` adds
-   `applied_font: <PSName>` to `StyledRun`, populated from
-   `csr.applied_font` (a `CharacterStyle` reference, not a font
-   directly).
-
-2. **Resolve to font resource** — `FontSetup` exposes a
-   `font_for_ps_name(ps_name)` that returns a registered font
-   resource (Symbol) or nil. Pre-registers all non-missing fonts
-   in the document upfront so the lookup is constant-time.
-
-3. **Pass per-run font through the renderer** — the render path
-   resolves `run.applied_font` → font resource once, registers if
-   needed, and uses that for the canvas.text / text_rich /
-   text_lines calls.
-
-4. **Track font-by-font used codepoints** — each font tracks its
-   own set of used codepoints so `subset_fonts!` can produce
-   per-font subsets.
-
-## Verification
-
-After implementation:
-- `Idml::Render::FontSetup#register_resolved(ps_name)` returns a
-  Symbol for each `ps_name` it knows about.
-- `StyleResolver::StyledRun#applied_font` returns the PSName string
-  when set.
-- TextFrameRenderer resolves `run.applied_font` once per run and
-  uses the returned Symbol for all canvas text ops.
-- subset_fonts! produces a smaller output for sample-with-table-more.
-
-## Acceptance criteria
-
-- [ ] The idml render's embedded font for sample-with-table-more is
-      `MinionPro-Regular`, not `MinionPro-BoldCn`.
-- [ ] Font stream size shrinks from 232KB to <50KB after subsetting.
-- [ ] Spec asserts the correct font is selected per run.