idml 0.10.11 → 0.10.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ea3cefcb949b7fd6399d850354df7fe37e6f822e766994522b9df4ceaa13cfd7
-  data.tar.gz: 531db1a6a0d5ccb32cd7f3fddd751b99d140a5504a3ab7645913167e34fdeb7e
+  metadata.gz: 49122b9c9f5974361567afb8fc2e063602e370141f0d5990f8de156275c312c4
+  data.tar.gz: c4f21424d6cd5d2f9345801aeb53be0b78d26f3d0c423b8ad20b179dff4ef38f
 SHA512:
-  metadata.gz: 6659beee3fa4e1d325bed4d0ed86a4a1db4c2944010d8a3deffbe3bf029df137187cb3b34fa064b5feecd000abad671fd712fb083caae837796339157bde9e25
-  data.tar.gz: d225c68cea43b34da224e37809cbfa5c0be3abc8775c7f10baee3d1756c69c325a002562070a54a5994ecc7da3883f58bbd407b337b66d9994a99b3532436049
+  metadata.gz: 6c06eb1149c2fed295382a4ce65504d12c821d884ffa6cd145f9ac96e0837c82b1dbfdd16abd082e84366dd6c0bfd6edc8670e187d71785f1de0e7a415cc9892
+  data.tar.gz: 12352d559b36427ec1be4ce71e31cfc149e24ec52a1fe70b65c3ecc720575c1a4f7a9aab8b96e67329747f33bc2005494c6f0c2034508b642edf37ba917a45ca

data/TODO.pdf/150-architecture-round-three.md

@@ -0,0 +1,41 @@
+# TODO PDF 150: Architecture review round three — seam repairs
+
+## Status: COMPLETE — implemented 2026-08-30
+
+## Problem
+
+Round-three review findings (after TODOs 148-149):
+
+1. **Page-dimensions seam leak (bug)**: `ImageCollector` and
+   `HyperlinkEmitter` received a hardcoded `DEFAULT_HEIGHT = 792`
+   while pages rendered at per-page dimensions — both use the
+   height for the IDML→PDF y-flip, so images and link rectangles
+   misplaced on any non-letter page.
+2. **Dead interface kept alive by its tests**:
+   `TextWrapResolver#overlap_width` (+ `line_overlap`) had zero
+   lib callers since TODO 138 — only its own spec — and encoded
+   sum-semantics for multiple contours where the real interface
+   (`wrap_adjustment`) uses max. The spec suite asserted behavior
+   the renderer no longer had.
+3. **Thirteen copies of the synthetic-package triplet**: every
+   engine-path spec repeated `Dir.mktmpdir → Package.write →
+   Package.new`, with drifting names and inconsistent part sets.
+
+## Solution
+
+- Pipeline threads per-page `dims[:height]` into both consumers;
+  the constants stay only as `page_dimensions_for` fallbacks.
+- `overlap_width` / `line_overlap` deleted; all 15 spec call
+  sites migrated to `wrap_adjustment` (the "sums contours" spec
+  now documents max-combination honestly). The polygon variant
+  `WrapContour.overlap_width` stays — it is load-bearing.
+- `build_package(parts, name)` helper in spec_helper; thirteen
+  triplet copies replaced; three local helpers that shadowed the
+  global renamed (`anchored_fixture`, `decorated_fixture`,
+  `footnote_fixture`, `endnote_fixture`, `footnote_package`).
+
+## Files
+
+- `lib/idml/render/pipeline.rb`
+- `lib/idml/render/text_wrap_resolver.rb`
+- `spec/spec_helper.rb` + 13 spec files

data/lib/idml/render/pipeline.rb

@@ -96,9 +96,6 @@ module Idml
                         position_tracker, condition_filter, style_lookup,
                         page_offset)
         pages = spread.spread.flat_map(&:page)
-        image_refs = ImageCollector.new(writer: writer,
-                                        base_dir: File.dirname(@package.path),
-                                        page_height: DEFAULT_HEIGHT).collect(spread)
         renderer = build_renderer(layer_filter, font_ref_resolver,
                                   font_resource, font_metrics, font_map,
                                   structure, position_tracker, condition_filter,
@@ -108,21 +105,26 @@ module Idml
         pages.each do |page|
           current += 1
           dims = page_dimensions_for(page)
+          image_refs = ImageCollector.new(
+            writer: writer,
+            base_dir: File.dirname(@package.path),
+            page_height: dims[:height],
+          ).collect(spread)
           canvas = writer.add_page(width: dims[:width], height: dims[:height])
           renderer.render(canvas, spread, page_width: dims[:width],
                                           page_height: dims[:height],
                                           image_refs: image_refs,
                                           page_index: current)
-          emit_hyperlinks(writer, spread, current, layer_filter,
-                          position_tracker)
+          emit_hyperlinks(writer, spread, current, dims[:height],
+                          layer_filter, position_tracker)
         end
         current
       end
 
-      def emit_hyperlinks(writer, spread, page_index, layer_filter,
-                          position_tracker)
+      def emit_hyperlinks(writer, spread, page_index, page_height,
+                          layer_filter, position_tracker)
         HyperlinkEmitter.new(writer: writer, package: @package,
-                             page_height: DEFAULT_HEIGHT,
+                             page_height: page_height,
                              layer_filter: layer_filter,
                              position_tracker: position_tracker)
           .emit_for(spread, page_index)

data/lib/idml/render/text_wrap_resolver.rb

@@ -159,28 +159,6 @@ module Idml
       end
       private :interval_side_adjustment
 
-      # Returns the total horizontal overlap of all contours with a
-      # text line at the given y range within the given x range.
-      # Sum, not max — multiple overlapping contours compound.
-      # Returns 0.0 when there's no overlap. Inverse contours
-      # reduce by the frame width minus their own width (text may
-      # only flow inside).
-      def overlap_width(line_y, line_height, frame_x, frame_right)
-        @contours.sum do |contour|
-          width = if contour.is_a?(WrapContour::Shape)
-                    WrapContour.overlap_width(contour, line_y,
-                                              line_height, frame_x,
-                                              frame_right)
-                  else
-                    line_overlap(contour, line_y, line_height,
-                                 frame_x, frame_right)[:width]
-                  end
-          next width unless contour.inverse
-
-          (frame_right - frame_x) - width
-        end
-      end
-
       # The wrap shape for an item: a bounding-box rectangle
       # (BoundingBoxTextWrap — the legacy "BoundingBox" spelling is
       # also accepted from early synthetic fixtures) or a flattened
@@ -250,13 +228,6 @@ module Idml
       end
       private_class_method :contour_mode?
 
-      def line_overlap(contour, line_y, line_height, frame_x, frame_right)
-        return { width: 0.0 } unless y_overlap?(contour, line_y, line_height)
-        return { width: 0.0 } unless x_overlap?(contour, frame_x, frame_right)
-
-        { width: x_overlap_width(contour, frame_x, frame_right) }
-      end
-
       def y_overlap?(contour, line_y, line_height)
         line_top = line_y + line_height
         line_bottom = line_y

data/lib/idml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Idml
-  VERSION = "0.10.11"
+  VERSION = "0.10.12"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: idml
 version: !ruby/object:Gem::Version
-  version: 0.10.11
+  version: 0.10.12
 platform: ruby
 authors:
 - Ribose
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-08-29 00:00:00.000000000 Z
+date: 2026-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bigdecimal
@@ -214,6 +214,7 @@ files:
 - TODO.pdf/148-architecture-improvements.md
 - TODO.pdf/149-architecture-round-two.md
 - TODO.pdf/15-wire-spread-children.md
+- TODO.pdf/150-architecture-round-three.md
 - TODO.pdf/16-typed-model-pipeline.md
 - TODO.pdf/17-shape-rendering.md
 - TODO.pdf/18-text-rendering.md