identity_cache 1.0.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9236be16375bc831c91f69bcc86968cf036c361c173e79cfd8ea4eb43d707787
-  data.tar.gz: 45e4acef2ef66d7262ce1b4c6d7b7fa33762c26fa99f31700cd44a4091dde8c4
+  metadata.gz: 561965856845fc5d5094581d735584924eda58557edfb3831c39bce2498635aa
+  data.tar.gz: 33a85428a3b2a298076d81a79b662b742c00a25971bf453f8f57eeab7cba2681
 SHA512:
-  metadata.gz: 7f9c79056ccbb938299b3fb6fd3e62af44f9117140df1b714a758be2aa4d864ffb1df589ba0a6220786db3bdb005326e794ea9340629146e478ffb2f3a3574cf
-  data.tar.gz: abc0e209fe35c8fc5ed6e470221a3e86cdeca23e81fc5c294d817cf3011c9ccf3a8dbf58096414c84be4b6b1e40ce4816b36703ed2b72da7dbafa4a78235e51d
+  metadata.gz: 6a8c691d8883acfd69f11724dfff13a3ef4858a2abd2ca658659981f1d08b36dea244100c4030b8ef5d39ac8509e639fea6cd02127e09d157be636fcc2bee77a
+  data.tar.gz: e357c3a4f02a288a5ddb3290cbd11176937821bb3c9052fb318d9139ac253650f7018a8249b2ebc9f115015a6434baf7cb1b7e76bfb0dbf1e98ee745e3e95ed7

data/.github/workflows/ci.yml

@@ -1,26 +1,93 @@
 name: CI
 
-on: [push]
+on:
+  push: {}
+  pull_request:
+    types: [opened, synchronize]
 
 jobs:
   build:
+    if: github.event_name == 'push' || github.event.pull_request.head.repo.owner.login != 'Shopify'
 
     runs-on: ubuntu-latest
 
+    strategy:
+      fail-fast: false
+      matrix:
+        entry:
+          - name: 'Minimum supported'
+            ruby: '2.5'
+            gemfile: "Gemfile.min-supported"
+          - name: 'Latest released & run rubocop'
+            ruby: '3.0'
+            gemfile: "Gemfile.latest-release"
+            rubocop: true
+          - name: 'Rails edge'
+            ruby: '3.0'
+            gemfile: "Gemfile.rails-edge"
+            edge: true
+
+    name: ${{ matrix.entry.name }}
+
+    continue-on-error: ${{ matrix.entry.edge || false }}
+
+    env:
+      BUNDLE_GEMFILE: gemfiles/${{ matrix.entry.gemfile }}
+
+    services:
+      memcached:
+        image: memcached
+        ports:
+          - 11211:11211
+      mysql:
+        image: mysql:5.7
+        env:
+          MYSQL_ALLOW_EMPTY_PASSWORD: yes
+          MYSQL_DATABASE: identity_cache_test
+        options: >-
+          --health-cmd="mysqladmin ping"
+          --health-interval=10s
+          --health-timeout=5s
+          --health-retries=5
+        ports:
+          - 3306:3306
+      postgres:
+        image: postgres
+        env:
+          POSTGRES_PASSWORD: postgres
+          POSTGRES_DB: identity_cache_test
+        options: >-
+          --health-cmd pg_isready
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+        ports:
+          - 5432:5432
+
     steps:
-    - uses: actions/checkout@v2
-    - name: Set up Ruby 2.6
-      uses: actions/setup-ruby@v1
-      with:
-        ruby-version: 2.6.x
     - name: Install required packages
       run: |
         sudo apt-get update
-        sudo apt-get -y install libmysqlclient-dev libpq-dev libsasl2-dev
+        sudo apt-get -y install libmemcached-dev libmysqlclient-dev libpq-dev libsasl2-dev
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.entry.ruby }}
     - name: Install bundler and gems
       run: |
         gem install bundler
         bundle install --jobs 4 --retry 3
+    - name: Test with mysql
+      env:
+        DB: mysql2
+      run: bundle exec rake test
+    - name: Test with postgres and memcached_store
+      env:
+        DB: postgresql
+        POSTGRES_PASSWORD: postgres
+        ADAPTER: memcached
+      run: bundle exec rake test
     - name: Run rubocop
-      run: |
-        bundle exec rubocop
+      if: matrix.entry.rubocop
+      run: bundle exec rubocop

data/.github/workflows/cla.yml

@@ -0,0 +1,22 @@
+name: Contributor License Agreement (CLA)
+
+on:
+  pull_request_target:
+    types: [opened, synchronize]
+  issue_comment:
+    types: [created]
+
+jobs:
+  cla:
+    runs-on: ubuntu-latest
+    if: |
+      (github.event.issue.pull_request 
+        && !github.event.issue.pull_request.merged_at
+        && contains(github.event.comment.body, 'signed')
+      ) 
+      || (github.event.pull_request && !github.event.pull_request.merged)
+    steps:
+      - uses: Shopify/shopify-cla-action@v1
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          cla-token: ${{ secrets.CLA_TOKEN }}

data/.gitignore

@@ -16,3 +16,4 @@ test/tmp
 test/version_tmp
 tmp
 .rubocop-http*
+.byebug_history

data/.rubocop.yml

@@ -1,5 +1,9 @@
-inherit_from:
-  - https://shopify.github.io/ruby-style-guide/rubocop.yml
+inherit_gem:
+  rubocop-shopify: rubocop.yml
 
 AllCops:
-  TargetRubyVersion: 2.6
+  TargetRubyVersion: 2.5
+  NewCops: disable
+
+Layout/BeginEndAlignment:
+  EnforcedStyleAlignWith: start_of_line

data/.spin/bootstrap

@@ -0,0 +1,7 @@
+#!/bin/bash
+
+set -e
+
+sudo apt-get install -y libsasl2-dev libpq-dev
+mysql -u root -P "$MYSQL_PORT" -e 'create database identity_cache_test'
+bundle install

data/.spin/svc.yml

@@ -0,0 +1,2 @@
+- memcached
+- mysql

data/CAVEATS.md

@@ -0,0 +1,25 @@
+While IdentityCache allows to massively scale access to ActiveRecord objects, it's important to note what problems might arise with it over time and what are things that it's not solving in the current design.
+
+## Large blobs
+
+For [god objects](https://en.wikipedia.org/wiki/God_object) (like the Shop model at Shopify), it’s typical to have many associations. It’s appealing for developers to embed many of those associations into the god model’s IDC blob, such as `cache_has_many :images, embed: true`. As a side effect, over time, the god model’s IDC blob may grow very large. It gets even worse when some of the embedded records get larger themselves, and the total IDC blob gets into as much as a megabyte in size. This puts pressure on both the application, memcached, and the network fibre because this large blob needs to be serialized and unserialized each time and transferred over the network.
+
+If the cache blob gets larger than the maximum cache value in memcached, then the cache fill would always fail, causing it to have to load all that data from the database each time.
+
+### Overfetching
+
+There's currently no way to retrieve/fill the cache with a subset of a model's associations. So, for models with many embedded associations, every `Model.fetch` would result in fetching all of the blob over the network and unserializing all embedded records, even if the client has only accessed one of those associations. That's a lot of useless CPU cycles and IO operations that happen on each access. It will also increase the network and memory bandwidth used on both the client and the server.
+
+Another possible issue is that cache invalidations for a model can be amplified by the number of models that embed them. This can further aggravate the large cache blob problem by embedding an association that gets invalidated more frequently.
+
+## Hot keys
+
+To scale out memcache, it’s typical to arrange memcached instances in rings. Most memcache clients/proxies use [consistent hashing](https://github.com/facebook/mcrouter/wiki/Pools#hash-functions) to route the operation to one of the instances in the ring. This means that an IDC entry will always end up in the same memcached instance.
+
+If the key associated with a record is on a hot codepath, that memcached instance will possibly experience saturation on the network and the number of bytes that it can send out. In cloud environments, this is a limit that is easy to hit. This especially aggravates the server-side large blob problem.
+
+## Thundering herd
+
+When a record gets updated, its IDC entry in memcache is expired, and it only gets populated the next time it is accessed. When many clients request the same key concurrently (e.g. on a hot codepath), they all find out that the IDC entry is missing at the same, and hence they will all go to the database to fill the IDC key at the same time. The massive number of clients hitting the DB will create a [thundering herd problem](https://en.wikipedia.org/wiki/Thundering_herd_problem) and overload the DB.
+
+Check out https://github.com/Shopify/identity_cache/pull/373 for more context and for the proposed solution for this problem.

data/CHANGELOG.md

@@ -1,6 +1,40 @@
-# IdentityCache changelog
+# Identity Cache Changelog
 
-#### 1.0.0
+## 1.2.0
+
+### Fixes
+- Fix mem_cache_store adapter with pool_size (#489)
+- Fix dalli deprecation warning about requiring 'dalli/cas/client' (#511)
+- Make transitionary method IdentityCache.with_fetch_read_only_records thread-safe (#503)
+
+### Features
+- Add support for fill lock with lock wait to avoid thundering herd problem (#373)
+
+## 1.1.0
+
+### Fixes
+- Fix double debug logging of cache hits and misses (#474)
+- Fix a Rails 6.1 deprecation warning for Rails 7.0 compatibility (#482)
+- Recursively install parent expiry hooks when expiring parent caches (#476)
+- Expire caches before other `after_commit` callbacks (#471)
+- Avoid unnecessary record cache expiry on save with no DB update (#464)
+- Fix an Active Record deprecation warning by not using `Connection#type_cast` (#459)
+- Fix broken `prefetch_associations` of a polymorphic `cache_belongs_to` (#461)
+- Fix `should_use_cache?` check to avoid calling it on the wrong class (#454)
+- Fix fetch `has_many` embedded association on record after adding to it (#449)
+
+### Features
+- Support multiple databases and transactional tests in `IdentityCache.should_use_cache?` (#293)
+- Add support for the default `MemCacheStore` from `ActiveSupport` (#465)
+
+### Breaking Changes
+- Drop ruby 2.4 support, since it is no longer supported upstream (#468)
+
+## 1.0.1
+
+- Fix expiry of cache_has_one association with scope and `embed: :id` (#442)
+
+## 1.0.0
 
 - Remove inverse_name option. Specify inverse_of on the Active Record association instead. (#439)
 - Bump the minimum Active Record version to 5.2 (#438)
@@ -21,16 +55,16 @@
 - Remove deprecated `never_set_inverse_association` option (#319)
 - Lazy load associated classes (#306)
 
-#### 0.5.1
+## 0.5.1
 
 - Fix bug in prefetch_associations for cache_has_one associations that may be nil
 
-#### 0.5.0
+## 0.5.0
 
 - `never_set_inverse_association` and `fetch_read_only_records` are now `true` by default (#315)
 - Store the class name instead of the class itself (#311)
 
-#### 0.4.1
+## 0.4.1
 
 - Deprecated embedded associations on models that don't use IDC (#305)
 - Remove a respond_to? check that hides mistakes in includes hash (#307)
@@ -41,11 +75,11 @@
 - Clone instead of dup record when readonlyifying fetched records (#292)
 - Consistently store the array for cached has many associations (#288)
 
-#### 0.4.0
+## 0.4.0
 
 - Return an array from fetched association to prevent chaining. Up to now, a relation was returned by default. (#287)
 
-#### 0.3.2
+## 0.3.2
 
 - Deprecate returning non read-only records when cache is used. Set IdentityCache.fetch_readonly_records to true to avoid this. (#282)
 - Use loaded association first when fetching a cache_has_many id embedded association (#280)
@@ -53,11 +87,11 @@
 - Fetch association returns relation or array depending on the configuration. It was only returning a relation for cache_has_many fetch association methods. (#276)
 - Stop sharing the same attributes hash between the fetched record and the memoized cache, which could interfere with dirty tracking (#267)
 
-#### 0.3.1
+## 0.3.1
 
 - Fix cache_index for non-id primary key
 
-#### 0.3.0
+## 0.3.0
 
 - Add support for includes option on cache_index and fetch_by_id
 - Use ActiveRecord instantiate
@@ -70,37 +104,37 @@
 - Fix cache_belongs_to on polymorphic assocations.
 - Fetching a cache_belongs_to association no longer loads the belongs_to association
 
-#### 0.2.5
+## 0.2.5
 
 - Fixed support for namespaced model classes
 - Added some deduplication for parent cache expiry
 - Fixed some deprecation warnings in rails 4.2
 
-#### 0.2.4
+## 0.2.4
 
 - Refactoring, documentation and test changes
 
-#### 0.2.3
+## 0.2.3
 
 - PostgreSQL support
 - Rails 4.2 compatibility
 - Fix: Don't connect to database when calling `IdentityCache.should_use_cache?`
 - Fix: Fix invalid parent cache invalidation if object is embedded in different parents
 
-#### 0.2.2
+## 0.2.2
 
 - Change: memcached is no longer a runtime dependency
 - Use cache for read-only models.
 
-#### 0.2.1
+## 0.2.1
 
 - Add a fallback backend using local memory.
 
-#### 0.2.0
+## 0.2.0
 
 - Memcache CAS support
 
-#### 0.1.0
+## 0.1.0
 
 - Backwards incompatible change: Stop expiring cache on after_touch callback.
 - Change: fetch_multi accepts an array of keys as argument
@@ -111,29 +145,29 @@
 - Fix: Avoid unused preload on fetch_multi with :includes option for cache miss
 - Fix: reload will invalidate the local instance cache
 
-#### 0.0.7
+## 0.0.7
 
 - Add support for non-integer primary keys
 - Fix: Not implemented error for cache_has_one with embed: false
 - Fix: cache key to change when adding a cache_has_many association with :embed => false
 - Fix: Compatibility rails 4.1 for `quote_value`, which needs default column.
 
-#### 0.0.6
+## 0.0.6
 
 - Fix: bug where previously nil-cached attribute caches weren't expired on record creation
 - Fix: cache key to not change when adding a non-embedded association.
 - Perf: Rails 4 Only create `CollectionProxy` when using it
 
-#### 0.0.5
+## 0.0.5
 
 
-#### 0.0.4
+## 0.0.4
 
 - Fix: only marshal attributes, embedded associations and normalized association IDs
 - Add cache version number to cache keys
 - Add test case to ensure version number is updated when the marshalled format changes
 
-#### 0.0.3
+## 0.0.3
 
 - Fix: memoization for multi hits actually work
 - Fix: quotes `SELECT` projection elements on cache misses
@@ -141,7 +175,7 @@
 - Fix: table names are not hardcoded anymore
 - Logger now differentiates memoized vs non memoized hits
 
-#### 0.0.2
+## 0.0.2
 
 - Fix: Existent embedded entries will no longer raise when `ActiveModel::MissingAttributeError` when accessing a newly created attribute.
 - Fix: Do not marshal raw ActiveRecord associations

data/Gemfile

@@ -1,8 +1,18 @@
 # frozen_string_literal: true
-source 'https://rubygems.org'
+
+source "https://rubygems.org"
 gemspec
 
-gem 'mysql2', '~> 0.5.3'
-gem 'pg', '~> 0.21.0'
-gem 'rubocop'
-gem 'byebug', platform: :mri
+gem "rubocop", "~> 1.5"
+
+gem "rubocop-shopify", "~> 2.9.0", require: false
+
+gem "mysql2", "~> 0.5.3", platform: :mri
+gem "pg", ">= 0.18", "< 2.0", platform: :mri
+gem "memcached", "~> 1.8.0", platform: :mri
+gem "memcached_store", "~> 1.0.0", platform: :mri
+gem "dalli", "~> 2.7.11"
+gem "cityhash", "~> 0.6.0", platform: :mri
+
+gem "byebug", platform: :mri
+gem "stackprof", platform: :mri

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2013 Shopify
+Copyright (c) 2013-2022 Shopify
 
 MIT License
 

data/README.md

@@ -1,5 +1,5 @@
 # IdentityCache
-[![Build Status](https://travis-ci.org/Shopify/identity_cache.svg?branch=master)](https://travis-ci.org/Shopify/identity_cache)
+[![Build Status](https://github.com/Shopify/identity_cache/workflows/CI/badge.svg?branch=main)](https://github.com/Shopify/identity_cache/actions?query=branch%3Amain)
 
 Opt in read through ActiveRecord caching used in production and extracted from Shopify. IdentityCache lets you specify how you want to cache your model objects, at the model level, and adds a number of convenience methods for accessing those objects through the cache. Memcached is used as the backend cache store, and the database is only hit when a copy of the object cannot be found in Memcached.
 
@@ -12,7 +12,10 @@ Add this line to your application's Gemfile:
 ```ruby
 gem 'identity_cache'
 gem 'cityhash'        # optional, for faster hashing (C-Ruby only)
-gem 'memcached_store' # for CAS support, needed for cache consistency
+
+gem 'dalli' # To use :mem_cache_store
+# alternatively
+gem 'memcached_store' # to use the old libmemcached based client
 ```
 
 And then execute:
@@ -22,13 +25,30 @@ And then execute:
 
 Add the following to all your environment/*.rb files (production/development/test):
 
+### If you use Dalli (recommended)
+
+```ruby
+config.identity_cache_store = :mem_cache_store, "mem1.server.com", "mem2.server.com", {
+  expires_in: 6.hours.to_i, # in case of network errors when sending a cache invalidation
+  failover: false, # avoids more cache consistency issues
+}
+```
+
+Add an initializer with this code:
+
+```ruby
+IdentityCache.cache_backend = ActiveSupport::Cache.lookup_store(*Rails.configuration.identity_cache_store)
+```
+
+
+### If you use Memcached (old client)
+
 ```ruby
 config.identity_cache_store = :memcached_store,
-  Memcached::Rails.new(servers: ["mem1.server.com"],
+  Memcached.new(["mem1.server.com"],
     support_cas: true,
     auto_eject_hosts: false,  # avoids more cache consistency issues
-    expires_in: 6.hours.to_i, # in case of network errors when sending a delete
-  )
+  ), { expires_in: 6.hours.to_i } # in case of network errors when sending a cache invalidation
 ```
 
 Add an initializer with this code:
@@ -234,14 +254,13 @@ Cache keys include a version number by default, specified in `IdentityCache::CAC
 
 ## Caveats
 
-A word of warning. Some versions of rails will silently rescue all exceptions in `after_commit` hooks. If an `after_commit` fails before the cache expiry `after_commit` the cache will not be expired and you will be left with stale data.
+A word of warning. If an `after_commit` fails before the cache expiry `after_commit` the cache will not be expired and you will be left with stale data.
 
 Since everything is being marshalled and unmarshalled from Memcached changing Ruby or Rails versions could mean your objects cannot be unmarshalled from Memcached. There are a number of ways to get around this such as namespacing keys when you upgrade or rescuing marshal load errors and treating it as a cache miss. Just something to be aware of if you are using IdentityCache and upgrade Ruby or Rails.
 
-IdentityCache is also very much _opt-in_ by deliberate design. This means IdentityCache does not mess with the way normal Rails associations work, and including it in a model won't change any clients of that model until you switch them to use `fetch` instead of `find`. This is because there is no way IdentityCache is ever going to be 100% consistent. Processes die, execeptions happen, and network blips occur, which means there is a chance that some database transaction might commit but the corresponding memcached DEL operation does not make it. This means that you need to think carefully about when you use `fetch` and when you use `find`. For example, at Shopify, we never use any `fetch`ers on the path which moves money around, because IdentityCache could simply be wrong, and we want to charge people the right amount of money. We do however use the fetchers on performance critical paths where absolute correctness isn't the most important thing, and this is what IdentityCache is intended for.
+IdentityCache is also very much _opt-in_ by deliberate design. This means IdentityCache does not mess with the way normal Rails associations work, and including it in a model won't change any clients of that model until you switch them to use `fetch` instead of `find`. This is because there is no way IdentityCache is ever going to be 100% consistent. Processes die, exceptions happen, and network blips occur, which means there is a chance that some database transaction might commit but the corresponding memcached cache invalidation operation does not make it. This means that you need to think carefully about when you use `fetch` and when you use `find`. For example, at Shopify, we never use any `fetch`ers on the path which moves money around, because IdentityCache could simply be wrong, and we want to charge people the right amount of money. We do however use the fetchers on performance critical paths where absolute correctness isn't the most important thing, and this is what IdentityCache is intended for.
 
 ## Notes
 
-- JRuby will not work with this current version, as we are using the memcached gem internally to interface with memcache.
 - See CHANGELOG.md for a list of changes to the library over time.
 - The library is MIT licensed and we welcome contributions. See CONTRIBUTING.md for more information.

data/Rakefile

@@ -1,31 +1,32 @@
 #!/usr/bin/env rake
 # frozen_string_literal: true
-require 'bundler/gem_tasks'
 
-require 'rake/testtask'
-require 'rdoc/task'
+require "bundler/gem_tasks"
 
-desc('Default: run tests and style checks.')
+require "rake/testtask"
+require "rdoc/task"
+
+desc("Default: run tests and style checks.")
 task(default: [:test, :rubocop])
 
-desc('Test the identity_cache plugin.')
+desc("Test the identity_cache plugin.")
 Rake::TestTask.new(:test) do |t|
-  t.libs << 'lib'
-  t.libs << 'test'
-  t.pattern = 'test/**/*_test.rb'
+  t.libs << "lib"
+  t.libs << "test"
+  t.pattern = "test/**/*_test.rb"
   t.verbose = true
 end
 
 task :rubocop do
-  require 'rubocop/rake_task'
+  require "rubocop/rake_task"
   RuboCop::RakeTask.new
 end
 
-desc('Update serialization format test fixture.')
+desc("Update serialization format test fixture.")
 task :update_serialization_format do
-  %w(mysql2 postgresql).each do |db|
+  ["mysql2", "postgresql"].each do |db|
     ENV["DB"] = db
-    ruby './test/helpers/update_serialization_format.rb'
+    ruby "./test/helpers/update_serialization_format.rb"
   end
 end
 

data/dev.yml

@@ -2,15 +2,16 @@ name: identity-cache
 
 up:
   - homebrew:
-    - postgresql
-  - ruby: 2.4.1
-  - railgun
+    - mysql-client@5.7:
+        or:        [mysql@5.7]
+        conflicts: [mysql-connector-c, mysql, mysql-client]
+  - ruby: 2.7.2
+  - isogun
   - bundler
 
 env:
   RAILGUN_HOST: identity-cache.railgun
   MYSQL_HOST: identity-cache.railgun
-  POSTGRES_HOST: identity-cache.railgun
   MEMCACHED_HOST: identity-cache.railgun
 
 commands:

data/gemfiles/Gemfile.latest-release

@@ -1,6 +1,13 @@
-source 'https://rubygems.org'
-gemspec path: '..'
+source "https://rubygems.org"
+gemspec path: ".."
 
-gem 'activerecord'
-gem 'activesupport'
-gem "mysql2", ">= 0.4.4"
+gem "rubocop", "~> 1.5"
+gem "rubocop-shopify", "~> 2.9.0", require: false
+
+gem "activerecord"
+gem "activesupport"
+gem "mysql2", "~> 0.5"
+gem "pg", "~> 1.1"
+gem "memcached_store"
+gem "dalli"
+gem "cityhash"

data/gemfiles/Gemfile.min-supported

@@ -0,0 +1,12 @@
+source "https://rubygems.org"
+gemspec path: ".."
+
+gem "ar_transaction_changes", "~> 1.1.0"
+
+gem "activerecord", "~> 5.2.0"
+gem "mysql2", "~> 0.4.4"
+gem "pg", "~> 0.18.0"
+gem "memcached", "~> 1.8.0"
+gem "memcached_store", "~> 1.0.0"
+gem "dalli", "~> 2.7.11"
+gem "cityhash", "~> 0.6.0"

data/gemfiles/Gemfile.rails-edge

@@ -1,6 +1,10 @@
-source 'https://rubygems.org'
-gemspec path: '..'
+source "https://rubygems.org"
+gemspec path: ".."
 
-gem 'activerecord', github: 'rails/rails'
-gem 'activesupport', github: 'rails/rails'
-gem "mysql2", ">= 0.4.4"
+gem "activerecord", github: "rails/rails", branch: "main"
+gem "activesupport", github: "rails/rails", branch: "main"
+gem "mysql2", "~> 0.5"
+gem "pg", "~> 1.1"
+gem "memcached_store"
+gem "dalli"
+gem "cityhash"

data/identity_cache.gemspec

@@ -1,6 +1,7 @@
 # -*- encoding: utf-8 -*-
 # frozen_string_literal: true
-require File.expand_path('../lib/identity_cache/version', __FILE__)
+
+require File.expand_path("../lib/identity_cache/version", __FILE__)
 
 Gem::Specification.new do |gem|
   gem.authors = [
@@ -15,40 +16,30 @@ Gem::Specification.new do |gem|
   gem.email         = ["gems@shopify.com"]
   gem.description   = "Opt-in read through Active Record caching."
   gem.summary       = "IdentityCache lets you specify how you want to cache your " \
-                      "model objects, at the model level, and adds a number of " \
-                      "convenience methods for accessing those objects through " \
-                      "the cache. Memcached is used as the backend cache store, " \
-                      "and the database is only hit when a copy of the object " \
-                      "cannot be found in Memcached."
+    "model objects, at the model level, and adds a number of " \
+    "convenience methods for accessing those objects through " \
+    "the cache. Memcached is used as the backend cache store, " \
+    "and the database is only hit when a copy of the object " \
+    "cannot be found in Memcached."
   gem.homepage      = "https://github.com/Shopify/identity_cache"
 
   gem.files         = Dir.chdir(File.expand_path(__dir__)) do
     %x(git ls-files -z).split("\x0").reject { |f| f.match(%r{^test/}) }
   end
   gem.executables   = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
-  gem.test_files    = gem.files.grep(%r{^test/})
   gem.name          = "identity_cache"
   gem.require_paths = ["lib"]
   gem.version       = IdentityCache::VERSION
 
-  gem.required_ruby_version = '>= 2.4.0'
+  gem.required_ruby_version = ">= 2.5.0"
 
-  gem.add_dependency('ar_transaction_changes', '~> 1.0')
-  gem.add_dependency('activerecord', '>= 5.2')
+  gem.metadata["allowed_push_host"] = "https://rubygems.org"
 
-  gem.add_development_dependency('memcached', '~> 1.8.0')
-  gem.add_development_dependency('memcached_store', '~> 1.0.0')
-  gem.add_development_dependency('rake')
-  gem.add_development_dependency('mocha', '0.14.0')
-  gem.add_development_dependency('spy')
-  gem.add_development_dependency('minitest', '>= 2.11.0')
+  gem.add_dependency("activerecord", ">= 5.2")
+  gem.add_dependency("ar_transaction_changes", "~> 1.1")
 
-  if RUBY_PLATFORM == 'java'
-    raise NotImplementedError
-  else
-    gem.add_development_dependency('cityhash', '0.6.0')
-    gem.add_development_dependency('mysql2')
-    gem.add_development_dependency('pg', '~> 0.18')
-    gem.add_development_dependency('stackprof')
-  end
+  gem.add_development_dependency("minitest", "~> 5.14")
+  gem.add_development_dependency("mocha", "~> 1.12")
+  gem.add_development_dependency("rake", "~> 13.0")
+  gem.add_development_dependency("spy", "~> 1.0")
 end