identity_cache 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9ae6ab233ca71a68a76c92e46a6819af91b02c39
-  data.tar.gz: 1bf83f15e3957a5b20133cdad5cc80d675496973
+  metadata.gz: abed676c785bc468fee7349b8e28af469499b78b
+  data.tar.gz: e64ed12cef1b57634416a2d4183313fae2a5f491
 SHA512:
-  metadata.gz: 45ad03a05a496eccb4327ae9ba775174cbf520a25c0087119fcde8de95ec7e77be79b0ab2dd65fcb99ad588af18d8b1992f126551e04daf58bca28d5a0f5c466
-  data.tar.gz: 6e9ecd4f00f97adf917e0ad354cb3cadba716b44dd75fd27d95c9437f564ea70af73312841bb89291b0a4beb5310d87538664b5930e2f572566013ac67b04e25
+  metadata.gz: cd1e569f94285089975e400da50e183731115c186b538ad822edf0bcb6bdf50c6b152a3b159d4196bb5749cd793f3745b19d744821e96479ba5106a1703d3785
+  data.tar.gz: 45358caea4c1d9ef27a682736cf180cbe982a9ce48946b842c6f788d0cb31c47658ed478f2c056e8e736b71e78dfa9af08abdbc5989e99ef12a96450a0197a3e

data/.ruby-version

@@ -1 +1 @@
-2.1.1
+2.2.2

data/.travis.yml

@@ -3,7 +3,8 @@ language: ruby
 rvm:
   - 1.9.3
   - 2.0.0
-  - 2.1.1
+  - 2.1
+  - 2.2
 
 gemfile:
   - Gemfile.rails32

data/CHANGELOG.md

@@ -1,6 +1,6 @@
 # IdentityCache changelog
 
-#### Unreleased
+#### 0.2.3
 
 - PostgreSQL support
 - Rails 4.2 compatibility

data/Gemfile.rails42

@@ -1,5 +1,5 @@
 source 'https://rubygems.org'
 gemspec
 
-gem 'activerecord', '~> 4.2.0.rc1'
-gem 'activesupport', '~> 4.2.0.rc1'
+gem 'activerecord', '~> 4.2.0'
+gem 'activesupport', '~> 4.2.0'

data/README.md

@@ -221,4 +221,4 @@ IdentityCache is also very much _opt-in_ by deliberate design. This means Identi
 
 - JRuby will not work with this current version, as we are using the memcached gem internally to interface with memcache.
 - See CHANGELOG.md for a list of changes to the library over time.
-- The librray is MIT licensed and we welcome contributions. See CONTRIBUTING.md for more information.
+- The library is MIT licensed and we welcome contributions. See CONTRIBUTING.md for more information.

data/lib/identity_cache/belongs_to_caching.rb

@@ -9,18 +9,22 @@ module IdentityCache
 
     module ClassMethods
       def cache_belongs_to(association, options = {})
-        self.cached_belongs_tos[association] = options
+        raise NotImplementedError if options[:embed]
 
-        options[:embed] ||= false
-        options[:cached_accessor_name]    ||= "fetch_#{association}"
-        options[:foreign_key]             ||= reflect_on_association(association).foreign_key
-        options[:association_class]       ||= reflect_on_association(association).klass
-        options[:prepopulate_method_name] ||= "prepopulate_fetched_#{association}"
-        if options[:embed]
-          raise NotImplementedError
-        else
-          build_normalized_belongs_to_cache(association, options)
+        unless association_reflection = reflect_on_association(association)
+          raise AssociationError, "Association named '#{association}' was not found on #{self.class}"
         end
+
+        options = {}
+        self.cached_belongs_tos[association] = options
+
+        options[:embed]                   = false
+        options[:cached_accessor_name]    = "fetch_#{association}"
+        options[:foreign_key]             = association_reflection.foreign_key
+        options[:association_class]       = association_reflection.klass
+        options[:prepopulate_method_name] = "prepopulate_fetched_#{association}"
+
+        build_normalized_belongs_to_cache(association, options)
       end
 
       def build_normalized_belongs_to_cache(association, options)

data/lib/identity_cache/cache_key_generation.rb

@@ -24,12 +24,15 @@ module IdentityCache
 
     module ClassMethods
       def rails_cache_key(id)
-        "#{rails_cache_key_prefix}#{id}"
+        "#{prefixed_rails_cache_key}#{id}"
       end
 
       def rails_cache_key_prefix
         @rails_cache_key_prefix ||= IdentityCache::CacheKeyGeneration.denormalized_schema_hash(self)
-        "#{rails_cache_key_namespace}blob:#{base_class.name}:#{@rails_cache_key_prefix}:"
+      end
+
+      def prefixed_rails_cache_key
+        "#{rails_cache_key_namespace}blob:#{base_class.name}:#{rails_cache_key_prefix}:"
       end
 
       def rails_cache_index_key_for_fields_and_values(fields, values)

data/lib/identity_cache/configuration_dsl.rb

@@ -94,10 +94,13 @@ module IdentityCache
       # * inverse_name: The name of the parent in the association if the name is
       #   not the lowercase pluralization of the parent object's class
       def cache_has_many(association, options = {})
+        options = options.slice(:embed, :inverse_name)
         options[:embed] = :ids unless options.has_key?(:embed)
         deprecate_embed_option(options, false, :ids)
         options[:inverse_name] ||= self.name.underscore.to_sym
-        raise InverseAssociationError unless self.reflect_on_association(association)
+        unless self.reflect_on_association(association)
+          raise AssociationError, "Association named '#{association}' was not found on #{self.class}"
+        end
         self.cached_has_manys[association] = options
 
         case options[:embed]
@@ -132,9 +135,12 @@ module IdentityCache
       #   necessary if the name is not the lowercase pluralization of the
       #   parent object's class)
       def cache_has_one(association, options = {})
+        options = options.slice(:embed, :inverse_name)
         options[:embed] = true unless options.has_key?(:embed)
         options[:inverse_name] ||= self.name.underscore.to_sym
-        raise InverseAssociationError unless self.reflect_on_association(association)
+        unless self.reflect_on_association(association)
+          raise AssociationError, "Association named '#{association}' was not found on #{self.class}"
+        end
         self.cached_has_ones[association] = options
 
         if options[:embed] == true
@@ -201,10 +207,10 @@ module IdentityCache
       end
 
       def build_recursive_association_cache(association, options) #:nodoc:
-        options[:association_class]      ||= reflect_on_association(association).klass
-        options[:cached_accessor_name]   ||= "fetch_#{association}"
-        options[:records_variable_name]  ||= "cached_#{association}"
-        options[:population_method_name] ||= "populate_#{association}_cache"
+        options[:association_class]      = reflect_on_association(association).klass
+        options[:cached_accessor_name]   = "fetch_#{association}"
+        options[:records_variable_name]  = "cached_#{association}"
+        options[:population_method_name] = "populate_#{association}_cache"
 
 
         unless instance_methods.include?(options[:cached_accessor_name].to_sym)
@@ -218,20 +224,21 @@ module IdentityCache
             end
           CODE
 
-          add_parent_expiry_hook(options.merge(:only_on_foreign_key_change => false))
+          options[:only_on_foreign_key_change] = false
+          add_parent_expiry_hook(options)
         end
       end
 
       def build_id_embedded_has_many_cache(association, options) #:nodoc:
         singular_association = association.to_s.singularize
-        options[:association_class]       ||= reflect_on_association(association).klass
-        options[:cached_accessor_name]    ||= "fetch_#{association}"
-        options[:ids_name]                ||= "#{singular_association}_ids"
-        options[:cached_ids_name]         ||= "fetch_#{options[:ids_name]}"
-        options[:ids_variable_name]       ||= "cached_#{options[:ids_name]}"
-        options[:records_variable_name]   ||= "cached_#{association}"
-        options[:population_method_name]  ||= "populate_#{association}_cache"
-        options[:prepopulate_method_name] ||= "prepopulate_fetched_#{association}"
+        options[:association_class]       = reflect_on_association(association).klass
+        options[:cached_accessor_name]    = "fetch_#{association}"
+        options[:ids_name]                = "#{singular_association}_ids"
+        options[:cached_ids_name]         = "fetch_#{options[:ids_name]}"
+        options[:ids_variable_name]       = "cached_#{options[:ids_name]}"
+        options[:records_variable_name]   = "cached_#{association}"
+        options[:population_method_name]  = "populate_#{association}_cache"
+        options[:prepopulate_method_name] = "prepopulate_fetched_#{association}"
 
         self.class_eval(<<-CODE, __FILE__, __LINE__ + 1)
           attr_reader :#{options[:ids_variable_name]}
@@ -260,7 +267,8 @@ module IdentityCache
           end
         CODE
 
-        add_parent_expiry_hook(options.merge(:only_on_foreign_key_change => true))
+        options[:only_on_foreign_key_change] = true
+        add_parent_expiry_hook(options)
       end
 
       def attribute_dynamic_fetcher(attribute, fields, values) #:nodoc:

data/lib/identity_cache/version.rb

@@ -1,4 +1,4 @@
 module IdentityCache
-  VERSION = "0.2.3"
+  VERSION = "0.2.4"
   CACHE_VERSION = 5
 end

data/lib/identity_cache.rb

@@ -21,6 +21,7 @@ module IdentityCache
   DELETED_TTL = 1000
 
   class AlreadyIncludedError < StandardError; end
+  class AssociationError < StandardError; end
   class InverseAssociationError < StandardError
     def initialize
       super "Inverse name for association could not be determined. Please use the :inverse_name option to specify the inverse association name for this cache."

data/test/normalized_has_many_test.rb

@@ -147,7 +147,8 @@ class NormalizedHasManyTest < IdentityCache::TestCase
 
   def test_saving_child_with_touch_true_on_parent_expires_parent
     IdentityCache.cache.expects(:delete).with(@record.primary_cache_index_key).once
-    @not_cached.save
+    @not_cached.name = 'Changed'
+    @not_cached.save!
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: identity_cache
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Camilo Lopez
@@ -13,30 +13,8 @@ authors:
 - Francis Bogsanyi
 autorequire: 
 bindir: bin
-cert_chain:
-- |
-  -----BEGIN CERTIFICATE-----
-  MIIDcDCCAligAwIBAgIBATANBgkqhkiG9w0BAQUFADA/MQ8wDQYDVQQDDAZhZG1p
-  bnMxFzAVBgoJkiaJk/IsZAEZFgdzaG9waWZ5MRMwEQYKCZImiZPyLGQBGRYDY29t
-  MB4XDTE0MDUxNTIwMzM0OFoXDTE1MDUxNTIwMzM0OFowPzEPMA0GA1UEAwwGYWRt
-  aW5zMRcwFQYKCZImiZPyLGQBGRYHc2hvcGlmeTETMBEGCgmSJomT8ixkARkWA2Nv
-  bTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAL0/81O3e1vh5smcwp2G
-  MpLQ6q0kejQLa65bPYPxdzWA1SYOKyGfw+yR9LdFzsuKpwWzKq6zX35lj1IckWS4
-  bNBEQzxmufUxU0XPM02haFB8fOfDJzdXsWte9Ge4IFwahwn68gpMqN+BvxL+KMYz
-  Iut9YmN44d4LZdsENEIO5vmybuG2vYDz7R56qB0PA+Q2P2CdhymsBad2DQs69FBo
-  uico9V6VMYYctL9lCYdzu9IXrOYNTt88suKIVzzAlHOKeN0Ng5qdztFoTR8sfxDr
-  Ydg3KHl5n47wlpgd8R0f/4b5gGxW+v9pyJCgQnLlRu7DedVSvv7+GMtj3g9r3nhJ
-  KqECAwEAAaN3MHUwCQYDVR0TBAIwADALBgNVHQ8EBAMCBLAwHQYDVR0OBBYEFI/o
-  maf34HXbUOQsdoLHacEKQgunMB0GA1UdEQQWMBSBEmFkbWluc0BzaG9waWZ5LmNv
-  bTAdBgNVHRIEFjAUgRJhZG1pbnNAc2hvcGlmeS5jb20wDQYJKoZIhvcNAQEFBQAD
-  ggEBADkK9aj5T0HPExsov4EoMWFnO+G7RQ28C30VAfKxnL2UxG6i4XMHVs6Xi94h
-  qXFw1ec9Y2eDUqaolT3bviOk9BB197+A8Vz/k7MC6ci2NE+yDDB7HAC8zU6LAx8Y
-  Iqvw7B/PSZ/pz4bUVFlTATif4mi1vO3lidRkdHRtM7UePSn2rUpOi0gtXBP3bLu5
-  YjHJN7wx5cugMEyroKITG5gL0Nxtu21qtOlHX4Hc4KdE2JqzCPOsS4zsZGhgwhPs
-  fl3hbtVFTqbOlwL9vy1fudXcolIE/ZTcxQ+er07ZFZdKCXayR9PPs64heamfn0fp
-  TConQSX2BnZdhIEYW+cKzEC/bLc=
-  -----END CERTIFICATE-----
-date: 2015-01-06 00:00:00.000000000 Z
+cert_chain: []
+date: 2015-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ar_transaction_changes
@@ -289,7 +267,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: IdentityCache lets you specify how you want to cache your model objects,

checksums.yaml.gz.sig

@@ -1,4 +0,0 @@
-�Es\�ϖD�&v��gSv�1LRO�T��������lR�5_\&'no��E`
-��;DLpd�վè��+gT^�
-fs���%8e�3����E���-��
-4[

data.tar.gz.sig

@@ -1,2 +0,0 @@
-\�� ��.C��gFJ��`vG971"א�����\ԑ���'�+/MWy�Cro�����C��BIH\�S�8�栔`<�1pd��l�W=G����"^`Id�����Q����{��a���W��Q���P�:��f����)f�y�ܺ��F����Ȏ����o�>�>=��XQ̱n�h{K�Z�8��Js^�Q�w�؆�9��’8X$�/I� �l$�J��>�Ȫ U-��WJ9�v�m@�/tf��)Uo�.
-YY��