identifiers 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 17d7278289ac40fc4fa68b488e85c98ada612f6f
-  data.tar.gz: e846cd17ac15a7cb87705c288eb8c41336721183
+  metadata.gz: ec8a0b18c19c41e22a23fe7232fba3d68f6284bc
+  data.tar.gz: 6aabefd1543b85621dcb2fd8ef7efac9c90663ce
 SHA512:
-  metadata.gz: 5a978d601dee61a25f5f66330e6e9bcd995fe1f217bdf43284350cc678574a1890a25ff289ad50ccebb25545da98acd459cd421e98e32d4e3c5266a41a84eb69
-  data.tar.gz: 30ef27cea3bc785f8f0ed841ac1f8cbfaa1e261b8a00afa9f0d942db0b8bc913f4e39f6ea91068f8eb7054a4cae1d04b17bd47956d3c7759d5ff9d5c2bed01b3
+  metadata.gz: f2adc7eb0afd80c19a11613d31ca6a9cdbb78fde6c2db5da5fc3e17c70f0c21bd898b642c8c8bb7bc870bd00dcaef0f108d96b9f86c68ada261dd64ac629a63d
+  data.tar.gz: f55f43f354984751504c3b9f91790b544a0c66396d6c189b750f835a7eb0c2bac3a71ff4ca20e0b6e49a6363c1303f13ab01bc3b908983c26da33aecabd5fbf7

data/CHANGELOG.md

@@ -2,9 +2,14 @@
 All notable changes to this project will be documented in this file. This
 project adheres to [Semantic Versioning](http://semver.org/).
 
+## [0.9.1] - 2017-08-01
+### Fixed
+- Don't extract duplicate ISBN-10s from within ISBN-13s
+
 ## [0.9.0] - 2017-07-31
 ### Added
 - Support extraction of multiple ISBNs separated by a single space
+- Support passing nil to any of the extract methods
 
 ## [0.8.1] - 2017-04-10
 ### Fixed
@@ -57,3 +62,4 @@ project adheres to [Semantic Versioning](http://semver.org/).
 [0.8.0]: https://github.com/altmetric/identifiers/releases/tag/v0.8.0
 [0.8.1]: https://github.com/altmetric/identifiers/releases/tag/v0.8.1
 [0.9.0]: https://github.com/altmetric/identifiers/releases/tag/v0.9.0
+[0.9.1]: https://github.com/altmetric/identifiers/releases/tag/v0.9.1

data/lib/identifiers/isbn.rb

@@ -12,6 +12,10 @@ module Identifiers
       \b
     /x
     ISBN_10_REGEXP = /
+      (?<!              # Don't match a hyphenated or spaced ISBN-13
+        97[89]
+        [\p{Pd}\p{Zs}]
+      )
       \b
       (?:
         \d              # Digit

data/spec/identifiers/isbn_spec.rb

@@ -86,4 +86,12 @@ RSpec.describe Identifiers::ISBN do
   it 'does not extract invalid 10-digit ISBNs' do
     expect(described_class.extract('3319217280')).to be_empty
   end
+
+  it 'does not extract ISBN-10s from hyphenated ISBN-13s' do
+    expect(described_class.extract('978-0-309-57079-4')).to contain_exactly('9780309570794')
+  end
+
+  it 'does not extract ISBN-10s from space-separated ISBN-13s' do
+    expect(described_class.extract('978 0 309 57079 4')).to contain_exactly('9780309570794')
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: identifiers
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - Jonathan Hernandez
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-07-31 00:00:00.000000000 Z
+date: 2017-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: urn