identifiers 0.12.0 → 0.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6ec6f86cbb54595ef76ab6615ba9e3a5f671478daebf31412f6b6820f1cb020d
-  data.tar.gz: 63881a8f3863926d66005133ba9fa0cdf471a7446c2dffa12534ac540911207e
+  metadata.gz: 423438daad2350706eced26425401a5d97ae715095b54853fe55ba4f8dbbaf2d
+  data.tar.gz: 2776accbdccfc17965dd69507a0b326b2a57e275811828b05e76b47c0f54bb28
 SHA512:
-  metadata.gz: 97b2352aa4a99ec8cf5158e1239f273e10f28321df11941445890549b827365e7a8ba1fb54d4a268bd146889f94aaa4fec0135ec1b67f779094557c6987bc466
-  data.tar.gz: f0e6a040a480bf9cf42900997415f8341fb7f68274434c936e725bafab484ce703fc6f0e21c5e317a85456c9fc0c2305e80ba9b1bae99cc7e6ba33fa40a890cc
+  metadata.gz: e319511db960df762b3a646239edf45ff683bef6227736c673072de6ef5d1649dd300232f93c0af0be1d7744308de4f07ebfd53582add6069c6b3f425249722b
+  data.tar.gz: 1ebd31499facbc5a51ec0dcf30fadb920e86ad6e53c20f4bb5dd66fa11c9f9cc7842a8b703348f13aac2675c0415c2c0f9464c42baafd055669c881342c33217

data/CHANGELOG.md

@@ -2,12 +2,17 @@
 All notable changes to this project will be documented in this file. This
 project adheres to [Semantic Versioning](http://semver.org/).
 
+## [0.12.1] - 2018-04-09
+### Fixed
+- Restored support for extracting hyphenated ISBN-10s with registration group
+  identifiers longer than one digit
+
 ## [0.12.0] - 2018-04-06
 ### Added
 - Added support for extracting more old Wiley DOIs
 
 ### Changed
-- Performance improvements when extracting DOIs with trailing punctuation.
+- Performance improvements when extracting DOIs with trailing punctuation
 
 ## [0.11.0] - 2018-03-12
 ### Fixed
@@ -61,7 +66,7 @@ project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [0.2.0] - 2016-11-01
 ### Changed
-- Strip leading 0s from Pubmed IDs. 0 is no longer a valid Pubmed ID.
+- Strip leading 0s from Pubmed IDs. 0 is no longer a valid Pubmed ID
 
 ## [0.1.0] - 2016-10-21
 ### Added
@@ -82,3 +87,4 @@ project adheres to [Semantic Versioning](http://semver.org/).
 [0.10.0]: https://github.com/altmetric/identifiers/releases/tag/v0.10.0
 [0.11.0]: https://github.com/altmetric/identifiers/releases/tag/v0.11.0
 [0.12.0]: https://github.com/altmetric/identifiers/releases/tag/v0.12.0
+[0.12.1]: https://github.com/altmetric/identifiers/releases/tag/v0.12.1

data/lib/identifiers/doi.rb

@@ -20,7 +20,7 @@ module Identifiers
           |
           [^[:space:]]+                         # Suffix...
           \([^[:space:])]+\)                    # Ending in balanced parentheses...
-          (?![^[:space:]\p{P}])                 # Not followed by more suffix or punctuation
+          (?![^[:space:]\p{P}])                 # Not followed by more suffix
           |
           [^[:space:]]+(?![[:space:]])\p{^P}    # Suffix ending in non-punctuation
         )

data/lib/identifiers/isbn.rb

@@ -20,12 +20,12 @@ module Identifiers
       )
       \b
       (
-        \d                # Digit
+        \d{1,5}           # Registration group identifier
         ([\p{Pd}\p{Zs}])? # Optional hyphenation
         (?:
           \d              # Digit
           \2?             # Optional hyphenation
-        ){8}
+        ){4,8}
         [\dX]             # Check digit
       )
       \b
@@ -85,7 +85,7 @@ module Identifiers
     end
 
     def self.valid_isbn_13?(isbn)
-      return false unless isbn =~ ISBN_13_REGEXP
+      return false unless String(isbn).length == 13 && isbn =~ ISBN_13_REGEXP
 
       result = digits_of(isbn).zip([1, 3].cycle).map { |digit, weight| digit * weight }.reduce(:+)
 
@@ -93,7 +93,7 @@ module Identifiers
     end
 
     def self.valid_isbn_10?(isbn)
-      return false unless isbn =~ ISBN_10_REGEXP
+      return false unless String(isbn).length == 10 && isbn =~ ISBN_10_REGEXP
 
       result = digits_of(isbn).with_index.map { |digit, weight| digit * weight.succ }.reduce(:+)
 

data/spec/identifiers/isbn_spec.rb

@@ -118,4 +118,9 @@ RSpec.describe Identifiers::ISBN do
   it 'does not extract ISBN-10s if they have less than four groups' do
     expect(described_class.extract('0-80506909-7')).to be_empty
   end
+
+  it 'extracts ISBN-10s with variable width registration group identifiers' do
+    expect(described_class.extract('99921-58-10-7 9971-5-0210-0 960-425-059-0 80-902734-1-6'))
+      .to contain_exactly('9789992158104', '9789971502102', '9789604250592', '9788090273412')
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: identifiers
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 0.12.1
 platform: ruby
 authors:
 - Jonathan Hernandez
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-04-06 00:00:00.000000000 Z
+date: 2018-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: urn