idempotency_lock 0.1.1 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3472cab3f3ed5118fb6b5843141d81c215efd5d0c7c7f1a12e88e3989a10315e
-  data.tar.gz: e070c49739921f73928eecc9ad94b97ce316c6cef1f4357ea109e211360c5ca5
+  metadata.gz: 4920afd8d5429063037ecb787cf54915a0837d01dcc0e347143117c92aa1e842
+  data.tar.gz: fb92062859dc7f2dad7ecc897c6f327ddf486376b1177f2adbee01b595853429
 SHA512:
-  metadata.gz: adf210196f47721787c1bc87e22de3c83ec787cf0b2f9c5b2a630e52aa610ee86c3e1124c19e2cea0401fbfc92a6ebcc795d94a735539eec55d57967e6ab70a1
-  data.tar.gz: b85bc4c3e9d4713d3e75bbe0032964d746e5eccc13b185937bfcf66617e8542c390414920e8478429812198f5680ef03ce28f07482c017b15e9c9a8a8053120e
+  metadata.gz: e81784700e7745eb981190b9aa53268c79f47ee1897ff20ea04669254e684abd1e012247d35de67b6af499539e4034651a9a28486e9c3494137e7749af22a80d
+  data.tar.gz: 32838477ada126fce6e6ff26f5a07e6b363d34a846314e46808917e90a934cb283a62d21bb0312c3a451cf2f3cff67e20dd31a5cd8f77f67a7df536fb2f92e5c

data/CHANGELOG.md

@@ -1,5 +1,23 @@
 ## [Unreleased]
 
+## [0.1.3] - 2025-12-06
+
+### Changed
+
+- Use `updated_at` instead of `expires_at` for optimistic locking (more reliable
+  since it's system-managed and always moves forward)
+
+## [0.1.2] - 2025-12-06
+
+### Fixed
+
+- Migration now works with MySQL (uses regular index instead of partial index,
+  which MySQL doesn't support)
+
+### Added
+
+- `Result#inspect` for easier debugging
+
 ## [0.1.1] - 2025-12-06
 
 ### Fixed

data/README.md

@@ -186,7 +186,7 @@ The gem creates an `idempotency_locks` table with:
 
 Indexes:
 - Unique index on `name` (provides atomicity)
-- Partial index on `expires_at` where not null (for efficient TTL queries)
+- Index on `expires_at` (partial index on PostgreSQL/SQLite, regular index on MySQL)
 
 **Note on name length:** Lock names are limited to 255 characters to ensure compatibility with database unique index limits. MySQL users with `utf8mb4` encoding may need to reduce this to 191 characters by modifying the migration before running it.
 

data/lib/generators/idempotency_lock/templates/create_idempotency_locks.rb.erb

@@ -13,7 +13,14 @@ class CreateIdempotencyLocks < ActiveRecord::Migration<%= migration_version %>
     end
 
     add_index :idempotency_locks, :name, unique: true
-    add_index :idempotency_locks, :expires_at, where: "expires_at IS NOT NULL"
+
+    # Partial indexes are more efficient but not supported by MySQL.
+    # Use a regular index for MySQL, partial index for PostgreSQL/SQLite.
+    if ActiveRecord::Base.connection.adapter_name.downcase.include?("mysql")
+      add_index :idempotency_locks, :expires_at
+    else
+      add_index :idempotency_locks, :expires_at, where: "expires_at IS NOT NULL"
+    end
   end
 end
 

data/lib/idempotency_lock/lock.rb

@@ -56,12 +56,12 @@ module IdempotencyLock
         return false if existing.nil?
         return false unless existing.expired?(now: now)
 
-        # Optimistic locking: use the observed expires_at in the WHERE clause.
+        # Optimistic locking: use the observed updated_at in the WHERE clause.
         # This prevents a race where two processes both see an expired lock and
         # both try to claim it. Only one UPDATE will match; the other returns 0.
-        # This is safer than `WHERE expires_at < now` which could allow a second
-        # process to steal a lock if the first used a short TTL.
-        updated = where(name: name, expires_at: existing.expires_at)
+        # We use updated_at rather than expires_at because it's system-managed
+        # and always moves forward, making it more reliable for concurrency control.
+        updated = where(name: name, updated_at: existing.updated_at)
                   .update_all(expires_at: expires_at, executed_at: now, updated_at: now)
 
         updated.positive?

data/lib/idempotency_lock/result.rb

@@ -40,5 +40,14 @@ module IdempotencyLock
     def success?
       @executed && !error?
     end
+
+    # @return [String] human-readable representation for debugging
+    def inspect
+      parts = ["executed=#{@executed}"]
+      parts << "skipped=#{@skipped}" if @skipped
+      parts << "value=#{@value.inspect}" if @value
+      parts << "error=#{@error.class}" if @error
+      "#<IdempotencyLock::Result #{parts.join(" ")}>"
+    end
   end
 end

data/lib/idempotency_lock/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IdempotencyLock
-  VERSION = "0.1.1"
+  VERSION = "0.1.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: idempotency_lock
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.3
 platform: ruby
 authors:
 - John Nagro