idempotency_lock 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2433a11192a9d10ad05520f94d7b60854531c2c23ee0e2c674318c34aa77739c
-  data.tar.gz: 6b7e54105e42bee7122d20670a9bfc18192b4d0846e58b131939cf46274fa98f
+  metadata.gz: 3472cab3f3ed5118fb6b5843141d81c215efd5d0c7c7f1a12e88e3989a10315e
+  data.tar.gz: e070c49739921f73928eecc9ad94b97ce316c6cef1f4357ea109e211360c5ca5
 SHA512:
-  metadata.gz: 102949944e74ef10b4f9ba6d3d62221abb307aaf79da156b6e25277eea4fd11032a435a1ea726044e228635c30e00511d7df46a10fe5f66621bf24dac901721b
-  data.tar.gz: 110b05bb0e03d952e5a44051dc4dfbb51c728e06f63e58aa46d2379482ab34ee261a39410fed5d90db4c0abe800948cfb509b4f4a17ec03d0a2ffb8b5e2513e0
+  metadata.gz: adf210196f47721787c1bc87e22de3c83ec787cf0b2f9c5b2a630e52aa610ee86c3e1124c19e2cea0401fbfc92a6ebcc795d94a735539eec55d57967e6ab70a1
+  data.tar.gz: b85bc4c3e9d4713d3e75bbe0032964d746e5eccc13b185937bfcf66617e8542c390414920e8478429812198f5680ef03ce28f07482c017b15e9c9a8a8053120e

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 ## [Unreleased]
 
+## [0.1.1] - 2025-12-06
+
+### Fixed
+
+- Use optimistic locking when claiming expired locks to prevent race conditions
+  where two processes with clock skew could both claim the same lock
+
+### Changed
+
+- `now` parameter is now injectable in `Lock.acquire`, `expired?`, and `valid_lock?` for testing
+
 ## [0.1.0] - 2025-12-06
 
 ### Added

data/lib/idempotency_lock/lock.rb

@@ -24,14 +24,14 @@ module IdempotencyLock
 
     # Check if this lock has expired
     # @return [Boolean]
-    def expired?
-      expires_at.present? && expires_at < Time.current
+    def expired?(now: Time.current)
+      expires_at.present? && expires_at < now
     end
 
     # Check if this lock is still valid (not expired)
     # @return [Boolean]
-    def valid_lock?
-      expires_at.nil? || expires_at >= Time.current
+    def valid_lock?(now: Time.current)
+      expires_at.nil? || expires_at >= now
     end
 
     class << self
@@ -40,7 +40,7 @@ module IdempotencyLock
       #
       # @param name [String] unique identifier for the operation
       # @param expires_at [Time, nil] when the lock should expire (nil = never)
-      # @param now [Time] current time reference
+      # @param now [Time] current time reference (injectable for testing)
       # @return [Boolean] true if lock was acquired
       def acquire(name, expires_at: nil, now: Time.current)
         # Try to insert first (most common case for new keys)
@@ -51,10 +51,17 @@ module IdempotencyLock
           # Lock exists, check if it's expired
         end
 
-        # Atomic update: claim the lock only if it's expired
-        # Returns number of rows updated (0 or 1)
-        updated = where(name: name)
-                  .where("expires_at IS NOT NULL AND expires_at < ?", now)
+        # Check if an existing lock is expired and can be claimed
+        existing = find_by(name: name)
+        return false if existing.nil?
+        return false unless existing.expired?(now: now)
+
+        # Optimistic locking: use the observed expires_at in the WHERE clause.
+        # This prevents a race where two processes both see an expired lock and
+        # both try to claim it. Only one UPDATE will match; the other returns 0.
+        # This is safer than `WHERE expires_at < now` which could allow a second
+        # process to steal a lock if the first used a short TTL.
+        updated = where(name: name, expires_at: existing.expires_at)
                   .update_all(expires_at: expires_at, executed_at: now, updated_at: now)
 
         updated.positive?

data/lib/idempotency_lock/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IdempotencyLock
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: idempotency_lock
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - John Nagro