idb 2.9.0 → 2.9.1

data/lib/gui/app_list_widget_item.rb

@@ -1,9 +1,5 @@
 module Idb
-
   class AppListWidgetItem < Qt::ListWidgetItem
     attr_accessor :app
-
-
   end
-
-end
+end

data/lib/gui/app_tab_widget.rb

@@ -4,46 +4,43 @@ module Idb
     signals "app_changed()"
     signals "binary_analyzed()"
 
-    def initialize *args
-      super *args
+    def initialize(*args)
+      super(*args)
 
       @layout = Qt::GridLayout.new self
       setLayout(@layout)
 
-
-
-      @layout.addWidget @select_app_button, 0,0
+      @layout.addWidget @select_app_button, 0, 0
 
       # Box for App details
       @app_details = AppDetailsGroupBox.new @central_widget
-      @app_details.connect(SIGNAL(:show_device_status)) {
+      @app_details.connect(SIGNAL(:show_device_status)) do
         @device_status = DeviceStatusDialog.new
         @device_status.exec
-      }
+      end
 
-
-      @layout.addWidget @app_details, 0,0,2,1
+      @layout.addWidget @app_details, 0, 0, 2, 1
 
       # Entitlements
       @app_entitlements = AppEntitlementsGroupBox.new @central_widget
-      @layout.addWidget @app_entitlements, 2,0, 1, 2
+      @layout.addWidget @app_entitlements, 2, 0, 1, 2
 
       # App Binary Details
       @app_binary = AppBinaryGroupBox.new @central_widget
-      @layout.addWidget @app_binary, 0,1
-      @app_binary.connect(SIGNAL('binary_analyzed()')) {
-        emit binary_analyzed()
-      }
-
-      @spacer_horizontal = Qt::SpacerItem.new 0,1, Qt::SizePolicy::Expanding, Qt::SizePolicy::Fixed
+      @layout.addWidget @app_binary, 0, 1
+      @app_binary.connect(SIGNAL('binary_analyzed()')) do
+        emit binary_analyzed
+      end
+
+      @spacer_horizontal = Qt::SpacerItem.new 0, 1,
+                                              Qt::SizePolicy::Expanding,
+                                              Qt::SizePolicy::Fixed
       @layout.addItem @spacer_horizontal, 0, 3
 
-      @spacer = Qt::SpacerItem.new 0,1, Qt::SizePolicy::Fixed, Qt::SizePolicy::Expanding
-      @spacer2 = Qt::SpacerItem.new 0,1, Qt::SizePolicy::Fixed, Qt::SizePolicy::Expanding
+      @spacer = Qt::SpacerItem.new 0, 1, Qt::SizePolicy::Fixed, Qt::SizePolicy::Expanding
+      @spacer2 = Qt::SpacerItem.new 0, 1, Qt::SizePolicy::Fixed, Qt::SizePolicy::Expanding
 
       @layout.addItem @spacer, 3, 0
-
-
     end
 
     def app_changed
@@ -51,8 +48,6 @@ module Idb
       @app_details.app_changed
       @app_entitlements.clear
       @app_entitlements.app_changed
-
     end
-
   end
 end

data/lib/gui/binary_strings_widget.rb

@@ -1,33 +1,25 @@
 module Idb
   class BinaryStringsWidget < Qt::Widget
-
-    def initialize *args
-      super *args
+    def initialize(*args)
+      super(*args)
       @layout = Qt::GridLayout.new
       setLayout(@layout)
 
       @details = Qt::PlainTextEdit.new
       @details.setReadOnly(true)
 
-
       @extract = Qt::PushButton.new "Extract Strings"
-      @extract.connect(SIGNAL :released) {
+      @extract.connect(SIGNAL(:released)) do
         @details.clear
         strings = $selected_app.strings
         @details.appendPlainText(strings)
-      }
-
-      @layout.addWidget @details, 0,0
-      @layout.addWidget @extract, 1,0
-
-
-
+      end
 
+      @layout.addWidget @details, 0, 0
+      @layout.addWidget @extract, 1, 0
     end
 
     def refresh
-
     end
-
   end
-end
+end

data/lib/gui/ca_manager_dialog.rb

@@ -1,17 +1,13 @@
 require_relative 'certificate_item'
 
 module Idb
-
   class CAManagerDialog < Qt::Dialog
-
-    def initialize *args
-      super *args
+    def initialize(*args)
+      super(*args)
       @layout = Qt::GridLayout.new
       setLayout(@layout)
       setWindowTitle("CA Certificate Management")
 
-
-
       @model = Qt::StandardItemModel.new
 
       @selection_model = Qt::ItemSelectionModel.new @model
@@ -22,50 +18,46 @@ module Idb
       @cert_tab.setSelectionModel(@selection_model)
 
       @cert_tab.setSelectionBehavior(Qt::AbstractItemView::SelectRows)
-      @cert_tab.setEditTriggers(Qt::AbstractItemView::NoEditTriggers	)
-
+      @cert_tab.setEditTriggers(Qt::AbstractItemView::NoEditTriggers)
 
-      @selection_model.connect(SIGNAL('selectionChanged(QItemSelection,QItemSelection)')) {|x,y|
-        if x.indexes.length == 0
+      @selection_model.connect(SIGNAL('selectionChanged(QItemSelection,QItemSelection)')) do |x, _|
+        if x.indexes.length.zero?
           @delete_button.setEnabled(false)
         else
           @delete_button.setEnabled(true)
           @selected_row = x.indexes[0].row
         end
-
-      }
-
+      end
 
       @refresh_button = Qt::PushButton.new "Refresh"
-      @refresh_button.connect(SIGNAL(:released)) {|x|
+      @refresh_button.connect(SIGNAL(:released)) do |_x|
         refresh_table
-      }
+      end
 
       @delete_button = Qt::PushButton.new "Delete"
       @delete_button.setEnabled(false)
-      @delete_button.connect(SIGNAL(:released)) {|x|
+      @delete_button.connect(SIGNAL(:released)) do |_x|
         item_containing_cert = @model.takeRow(@selected_row)[0]
-        if not item_containing_cert.nil?
+        unless item_containing_cert.nil?
           @if.remove_cert item_containing_cert.certificate
         end
         refresh_table
-      }
-
+      end
 
       @import_button = Qt::PushButton.new "Import..."
       @import_button.setToolTip("Import an existing certificate")
-      @import_button.connect(SIGNAL(:released)) { |x|
+      @import_button.connect(SIGNAL(:released)) do |_x|
         @file_dialog = Qt::FileDialog.new
         @file_dialog.setAcceptMode(Qt::FileDialog::AcceptOpen)
-        filters = Array.new
+        filters = []
         filters << "PEM Files (*.pem)"
         filters << "Any files (*)"
-        @file_dialog.setNameFilters(filters);
+        @file_dialog.setNameFilters(filters)
 
-        @file_dialog.connect(SIGNAL('fileSelected(QString)')) { |x|
+        @file_dialog.connect(SIGNAL('fileSelected(QString)')) do |x|
           begin
             @if.server_cert(x)
-          rescue Exception => e
+          rescue StandardError => e
             error = Qt::MessageBox.new self
             error.setInformativeText("Couldn't import certificate")
             error.setDetailedText(e.message)
@@ -73,33 +65,29 @@ module Idb
             error.exec
           end
           refresh_table
-        }
-
-
+        end
 
         @file_dialog.exec
-      }
+      end
 
       @close_button = Qt::PushButton.new "Close"
-      @close_button.connect(SIGNAL(:released)) {|x|
+      @close_button.connect(SIGNAL(:released)) do |_x|
         @if.stop_cert_server
-        reject()
-      }
+        reject
+      end
 
       @layout.addWidget @cert_tab, 0, 0, 4, 4
       @layout.addWidget @refresh_button, 0, 4
-      @layout.addWidget @delete_button, 1,4
-      @layout.addWidget @import_button, 2,4
-      @layout.addItem Qt::SpacerItem.new(0,1, Qt::SizePolicy::Fixed, Qt::SizePolicy::Expanding), 3, 4
+      @layout.addWidget @delete_button, 1, 4
+      @layout.addWidget @import_button, 2, 4
+      spacer_item = Qt::SpacerItem.new(0, 1, Qt::SizePolicy::Fixed, Qt::SizePolicy::Expanding)
+      @layout.addItem spacer_item, 3, 4
       @layout.addWidget @close_button, 4, 4
 
       @if = $device.ca_interface
       refresh_table
 
-
-
-      #setFixedHeight(sizeHint().height());
-      setMinimumSize(800,500)
+      setMinimumSize(800, 500)
     end
 
     def refresh_table
@@ -108,30 +96,20 @@ module Idb
       @model.setHorizontalHeaderItem(1, Qt::StandardItem.new("Expiry"))
       @model.setHorizontalHeaderItem(2, Qt::StandardItem.new("Issuer"))
 
-      @if.get_certs.each { |cert|
-        row = Array.new
-        item = CertificateItem.new(cert.subject.to_a.map { |x| "#{x[0]}: #{x[1]}"}.join("\n"))
+      @if.certs.each do |cert|
+        row = []
+        item = CertificateItem.new(cert.subject.to_a.map { |x| "#{x[0]}: #{x[1]}" }.join("\n"))
         item.certificate = cert
         row << item
         row << Qt::StandardItem.new(cert.not_after.to_s)
-        row << Qt::StandardItem.new(cert.issuer.to_a.map { |x| "#{x[0]}: #{x[1]}"}.join("\n"))
+        row << Qt::StandardItem.new(cert.issuer.to_a.map { |x| "#{x[0]}: #{x[1]}" }.join("\n"))
         @model.appendRow(row)
-      }
+      end
       @cert_tab.resizeColumnsToContents
       @cert_tab.resizeRowsToContents
 
-
       #     puts "#{i.to_s.ljust(2)} - Subject: #{cert.subject}"
       #     puts "     Details: #{cert.inspect}"
-
-
-
     end
-
-
-
-
-
   end
-
-end
+end

data/lib/gui/cache_db_widget.rb

@@ -1,33 +1,27 @@
 module Idb
   class CacheDbWidget < Qt::Widget
-
-    def initialize *args
-      super *args
+    def initialize(*args)
+      super(*args)
 
       @refresh = Qt::PushButton.new "Refresh"
-      @refresh.connect(SIGNAL :released) {
+      @refresh.connect(SIGNAL(:released)) do
         refresh
-      }
+      end
 
       @list = Qt::ListWidget.new self
-      @list.connect(SIGNAL('itemDoubleClicked(QListWidgetItem*)')) { |item|
-  #      x = ConsoleLauncher.new
-        #TODO: find sqlite binary
-        #x.run "/usr/bin/sqlite3 #{Dir.getwd}/#{$selected_app.cache_file item.full_path}"
-
+      @list.connect(SIGNAL('itemDoubleClicked(QListWidgetItem*)')) do |item|
         cache_name = $selected_app.cache_file item.full_path
         if cache_name.nil?
-          $log.error "File #{item.full_path} could not be downloaded. Either the file does not exist (e.g., dead symlink) or there is a permission problem."
+          $log.error "File #{item.full_path} could not be downloaded. Either" \
+                     "the file does not exist (e.g., dead symlink) or there " \
+                     "is a permission problem."
+        elsif RbConfig::CONFIG['host_os'] =~ /linux/
+          Process.spawn "'#{$settings['sqlite_editor']}' '#{cache_name}'"
         else
-          if RbConfig::CONFIG['host_os'] =~ /linux/
-            Process.spawn "'#{$settings['sqlite_editor']}' '#{cache_name}'"
-          else
-            Process.spawn "open -a '#{$settings['sqlite_editor']}' '#{cache_name}'"
-          end
+          Process.spawn "open -a '#{$settings['sqlite_editor']}' '#{cache_name}'"
         end
-
-      }
-     # "Launch app"
+      end
+      # "Launch app"
       @default_protection = DefaultProtectionClassGroupWidget.new self
       layout = Qt::VBoxLayout.new do |v|
         v.add_widget(@default_protection)
@@ -55,22 +49,23 @@ module Idb
       @list.setEnabled true
       @default_protection.update
       cache_dbs = $selected_app.find_cache_dbs
-      cache_dbs.each { |full_path|
+      cache_dbs.each do |full_path|
         item = PathListWidgetItem.new
         if $device.simulator?
-          item.setText full_path.sub($selected_app.app_dir,'')
+          item.setText full_path.sub($selected_app.app_dir, '')
         else
           pc = $device.protection_class full_path
           if full_path.start_with? $selected_app.app_dir
-            item.setText "[App Bundle]" + full_path.sub($selected_app.app_dir,'') + " => " + pc.strip
+            stripped_app_dir_path = full_path.sub($selected_app.app_dir, '')
+            item.setText "[App Bundle]" + stripped_app_dir_path + " => " + pc.strip
           elsif full_path.start_with? $selected_app.data_dir
-            item.setText "[Data Dir]" + full_path.sub($selected_app.data_dir,'') + " => " + pc.strip
+            stripped_data_dir_path = full_path.sub($selected_app.data_dir, '')
+            item.setText "[Data Dir]" + stripped_data_dir_path + " => " + pc.strip
           end
         end
         item.full_path = full_path
         @list.addItem item
-      }
+      end
     end
-
   end
-end
+end

data/lib/gui/certificate_item.rb

@@ -1,5 +1,5 @@
 module Idb
-  class CertificateItem  < Qt::StandardItem
+  class CertificateItem < Qt::StandardItem
     attr_accessor :certificate
   end
-end
+end

data/lib/gui/default_protection_class_group_widget.rb

@@ -1,18 +1,16 @@
 module Idb
-
   class DefaultProtectionClassGroupWidget < Qt::GroupBox
-
-    def initialize args
-      super *args
+    def initialize(args)
+      super(*args)
 
       setTitle  "Default Data Protection"
 
       @layout = Qt::GridLayout.new
-      label =  Qt::Label.new  "<b>Default Data Protection</b>", self, 0
-      @val =  Qt::Label.new  "No default set in the entitlements of this app.", self, 0
+      label = Qt::Label.new "<b>Default Data Protection</b>", self, 0
+      @val = Qt::Label.new "No default set in the entitlements of this app.", self, 0
       @layout.addWidget label, 0, 0
       @layout.addWidget @val, 0, 1
-      spacer_horizontal = Qt::SpacerItem.new 0,1, Qt::SizePolicy::Expanding, Qt::SizePolicy::Fixed
+      spacer_horizontal = Qt::SpacerItem.new 0, 1, Qt::SizePolicy::Expanding, Qt::SizePolicy::Fixed
       @layout.addItem spacer_horizontal, 0, 2
 
       setLayout @layout
@@ -22,15 +20,12 @@ module Idb
       if $device.ios_version < 8
         @val.setText "Only available for iOS 8+"
       else
-        $selected_app.services_map.entitlements_by_bundle_id($selected_app.bundle_id).each { |x|
+        $selected_app.services_map.entitlements_by_bundle_id($selected_app.bundle_id).each do |x|
           if x[0].to_s == "com.apple.developer.default-data-protection"
             @val.setText x[1].to_s
           end
-        }
+        end
       end
-
     end
-
   end
 end
-

data/lib/gui/device_info_group_box.rb

@@ -5,60 +5,63 @@ module Idb
     signals "disconnect()"
     signals "connect_clicked()"
 
-    def initialize *args
-      super *args
+    def initialize(*args)
+      super(*args)
 
       # details on selected app
       @layout = Qt::GridLayout.new
       setLayout(@layout)
       setTitle "Selected Device"
 
-      @device = Qt::Label.new  "<b><font color='red'>Please select a device from the 'Devices' menu or click 'Connect'.</font></b>", self, 0
-      @layout.addWidget @device, 0, 0, 2 ,1
+      device_label = "<b><font color='red'>Please select a device from the " \
+                     "'Devices' menu or click 'Connect'.</font></b>"
+      @device = Qt::Label.new device_label, self, 0
+      @layout.addWidget @device, 0, 0, 2, 1
       @connect = Qt::PushButton.new "Connect to USB/SSH device"
-      @connect.connect(SIGNAL(:released)) {
-        emit connect_clicked()
-      }
-      @layout.addWidget @connect, 0,1,2,1
+      @connect.connect(SIGNAL(:released)) do
+        emit connect_clicked
+      end
+      @layout.addWidget @connect, 0, 1, 2, 1
     end
 
     def update_device
       if $device.device?
         @connect.hide
-        uname = $device.ops.execute("/bin/uname -a")
-        ssh_connection_info = ""
         if $device.mode == "usb"
-          ssh_connection_info = " "
-          @device.setText "<b>USB device:</b> Manually connect via SSH as #{$settings.ssh_username}@localhost:#{$device.usb_ssh_port}"
+          usb_mode_text = "<b>USB device:</b> Manually connect via SSH as " \
+                          "#{$settings.ssh_username}@localhost:#{$device.usb_ssh_port}"
+          @device.setText usb_mode_text
         else
-          @device.setText "<b>SSH device:</b> ssh://#{$settings.ssh_username}:[redacted]@#{$settings.ssh_host}:#{$settings.ssh_port}"
+          ssh_mode_text = "<b>SSH device:</b> " \
+                          "ssh://#{$settings.ssh_username}:[redacted]@" \
+                          "#{$settings.ssh_host}:#{$settings.ssh_port}"
+          @device.setText ssh_mode_text
         end
 
         @status = Qt::PushButton.new "Status"
-        @status.connect(SIGNAL(:released)) {
+        @status.connect(SIGNAL(:released)) do
           @device_status = DeviceStatusDialog.new
           @device_status.exec
-        }
+        end
         @layout.addWidget @status, 0, 1
 
         @disconnect = Qt::PushButton.new "Disconnect"
-        @disconnect.connect(SIGNAL(:released)) {
+        @disconnect.connect(SIGNAL(:released)) do
           $device.close unless $device.nil?
           $device = nil
-          emit disconnect()
+          emit disconnect
           @disconnect.hide
           @connect.show
           @status.hide
-          @device.setText("<b><font color='red'>Please select a device from the 'Devices' menu.</font></b>")
-        }
+          device_selection_text = "<b><font color='red'>Please select a device " \
+                                  "from the 'Devices' menu.</font></b>"
+          @device.setText(device_selection_text)
+        end
         @layout.addWidget @disconnect, 1, 1
 
-
       else
         @device.setText "<b>Simulator:</b> #{$device.sim_dir}"
       end
     end
-
-
   end
-end
+end