id3tag 0.10.1 → 0.11.0

data/spec/lib/id3tag/frames/v2/genre_frame/genre_parser_24_spec.rb

@@ -1,26 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-
-describe ID3Tag::Frames::V2::GenreFrame::GenreParser24 do
-  describe '#genres' do
-
-    subject { described_class.new(genre_string).genres }
-
-    context "when version is 2.4" do
-      context "with remix and cover" do
-        let(:genre_string) { "RX\x00CR" }
-        it { is_expected.to eq(['Remix', 'Cover']) }
-      end
-      context "with refinement and number" do
-        let(:genre_string) { "ABC\x0017" }
-        it { is_expected.to eq(['ABC', 'Rock']) }
-      end
-      context "with one genre" do
-        let(:genre_string) { "17" }
-        it { is_expected.to eq(['Rock']) }
-      end
-    end
-
-  end
-end
-

data/spec/lib/id3tag/frames/v2/genre_frame/genre_parser_pre_24_spec.rb

@@ -1,48 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-
-describe ID3Tag::Frames::V2::GenreFrame::GenreParserPre24 do
-  describe '#genres' do
-
-    subject { described_class.new(genre_string).genres }
-
-    context "without refinements" do
-      context "with one genre" do
-        let(:genre_string) { '(17)' }
-        it { is_expected.to eq(['Rock']) }
-      end
-      context "with multiple genres" do
-        let(:genre_string) { '(17)(18)' }
-        it { is_expected.to eq(['Rock', 'Techno']) }
-      end
-      context "with remix and cover" do
-        let(:genre_string) { '(RX)(CR)' }
-        it { is_expected.to eq(['Remix', 'Cover']) }
-      end
-    end
-    context "with refinements" do
-      context "with one genre" do
-        let(:genre_string) { '(17)qwerty' }
-        it { is_expected.to eq(['qwerty']) }
-      end
-      context "with miltiple genres but only 1 refinement" do
-        let(:genre_string) { '(0)(16)(17)qwerty' }
-        it { is_expected.to eq(['Blues', 'Reggae', 'qwerty']) }
-      end
-      context "with multiple genres" do
-        let(:genre_string) { '(17)qwerty(18)abcdef' }
-        it { is_expected.to eq(['qwerty', 'abcdef']) }
-      end
-    end
-    context "with refinement containing '('" do
-      context "with one genre" do
-        let(:genre_string) { '(55)((I think...)' }
-        it { is_expected.to eq(['(I think...)']) }
-      end
-      context "with multiple genres" do
-        let(:genre_string) { '(55)((I think...)(17)' }
-        it { is_expected.to eq(['(I think...)', 'Rock']) }
-      end
-    end
-  end
-end

data/spec/lib/id3tag/frames/v2/genre_frame/genre_parser_spec.rb

@@ -1,13 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-
-describe ID3Tag::Frames::V2::GenreFrame::GenreParser do
-  let(:genre_string) { "17" }
-  subject { described_class.new(genre_string) }
-
-  describe '#genres' do
-    it "should raise not implemented error" do
-      expect { subject.genres }.to raise_error(/genres is not implemented/)
-    end
-  end
-end

data/spec/lib/id3tag/frames/v2/genre_frame_spec.rb

@@ -1,61 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-
-describe ID3Tag::Frames::V2::GenreFrame do
-  let(:id) { "TCON" }
-  let(:raw_content) { "\x03(17)" }
-  let(:flags) { nil }
-  let(:major_version_number) { 3 }
-  let(:frame) { described_class.new(id, raw_content, flags, major_version_number) }
-
-  describe '#id' do
-    subject { frame.id }
-    it { is_expected.to eq(:TCON) }
-  end
-
-  describe '#content' do
-    subject { frame.content }
-
-    context "when tag major version is pre 4" do
-      let(:major_version_number) { 3 }
-
-      context "when one genre" do
-        before do
-          allow_any_instance_of(ID3Tag::Frames::V2::GenreFrame::GenreParserPre24).to receive(:genres) { ['A'] }
-        end
-        it { is_expected.to eq('A') }
-      end
-      context "when two genres" do
-        before do
-          allow_any_instance_of(ID3Tag::Frames::V2::GenreFrame::GenreParserPre24).to receive(:genres) { ['A', 'B'] }
-        end
-
-        it { is_expected.to eq('A, B') }
-      end
-    end
-
-    context "when tag major version is 4" do
-      let(:major_version_number) { 4 }
-      before do
-        allow_any_instance_of(ID3Tag::Frames::V2::GenreFrame::GenreParser24).to receive(:genres) { ['B'] }
-      end
-      it { is_expected.to eq('B') }
-    end
-    context "when tag major version is 232" do
-      let(:major_version_number) { 232 }
-      it "should raise MissingGenreParser error" do
-        expect { subject }.to raise_error(ID3Tag::Frames::V2::GenreFrame::MissingGenreParser)
-      end
-    end
-  end
-
-  describe '#inspect' do
-    before do
-      allow(frame).to receive(:content) { 'Rock' }
-    end
-
-    it 'should be pretty inspectable' do
-      expect(frame.inspect).to eq('<ID3Tag::Frames::V2::GenreFrame TCON: Rock>')
-    end
-  end
-end

data/spec/lib/id3tag/frames/v2/picture_frame_spec.rb

@@ -1,127 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-
-describe ID3Tag::Frames::V2::PictureFrame do
-  let(:separator) { "\x00".force_encoding(target_encoding) }
-  let(:encoding) { encoding_byte.force_encoding(target_encoding) }
-  let(:flags) { nil }
-  let(:target_encoding) { Encoding::UTF_8 }
-  let(:encoding_byte) { "\x03" }
-  let(:description) { "picture description" }
-  let(:picture_type) { "\x03" } # cover_front
-  let(:frame) { described_class.new(id, raw_content, flags, major_version_number) }
-  let(:data) { "picture data" }
-
-  context "when PIC frame" do
-    let(:id) { "PIC" }
-    let(:major_version_number) { 2 }
-    let(:format) { "png" }
-    let(:raw_content) do
-      encoding_byte + format + picture_type + description + separator + data
-    end
-
-    describe '#id' do
-      subject { frame.id }
-      it { is_expected.to eq(:PIC) }
-    end
-
-    describe "mime_type" do
-      subject { frame.mime_type }
-      it { is_expected.to eq('image/png') }
-      context "when mime type is blank" do
-        let(:format) { "\x00\x00\x00" }
-        it { is_expected.to eq('image/') }
-      end
-    end
-
-    describe "#data" do
-      subject { frame.data }
-      it { is_expected.to eq("picture data") }
-    end
-
-    describe "#type" do
-      subject { frame.type }
-      it { is_expected.to eq(:cover_front) }
-    end
-
-    describe "#description" do
-      subject { frame.description }
-      it { is_expected.to eq("picture description") }
-    end
-
-    describe "#content" do
-      subject { frame.content }
-      it { is_expected.to eq("picture data") }
-    end
-  end
-
-  context "when APIC frame" do
-    let(:id) { "APIC" }
-    let(:major_version_number) { 3 }
-    let(:mime_type) { "image/png" }
-    let(:raw_content) do
-      # mime_type is iso 8859-1 so alawys terminated with \x00
-      encoding_byte + mime_type + "\x00" + picture_type + description + separator + data
-    end
-
-    describe '#id' do
-      subject { frame.id }
-      it { is_expected.to eq(:APIC) }
-    end
-
-    describe "#data" do
-      subject { frame.data }
-      it { is_expected.to eq("picture data") }
-    end
-
-    describe "#type" do
-      subject { frame.type }
-      it { is_expected.to eq(:cover_front) }
-    end
-
-    describe "#mime_type" do
-      subject { frame.mime_type }
-      it { is_expected.to eq("image/png") }
-      context "when mime type is omitted" do
-        let(:mime_type) { "\x00" }
-        subject { frame.mime_type }
-        it { is_expected.to eq("image/") }
-      end
-    end
-
-    describe "#description" do
-      subject { frame.description }
-      it { is_expected.to eq("picture description") }
-    end
-
-    describe "#content" do
-      subject { frame.content }
-      it { is_expected.to eq("picture data") }
-    end
-
-    context "when frame contains link not actual image data" do
-      let(:raw_content) { "\x02-->\x00\x08\u0000a\u0000b\u0000c" }
-      subject { frame }
-
-      describe '#link?' do
-        subject { super().link? }
-        it { is_expected.to eq(true) }
-      end
-
-      describe '#mime_type' do
-        subject { super().mime_type }
-        it { is_expected.to eq("-->") }
-      end
-
-      describe '#description' do
-        subject { super().description }
-        it { is_expected.to eq("abc") }
-      end
-
-      describe '#type' do
-        subject { super().type }
-        it { is_expected.to eq(:artist) }
-      end
-    end
-  end
-end

data/spec/lib/id3tag/frames/v2/text_frame_spec.rb

@@ -1,89 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-
-describe ID3Tag::Frames::V2::TextFrame do
-  let(:id) { "artist" }
-  let(:raw_content) { text.encode(target_encoding.to_s).prepend(encoding_byte.force_encoding(target_encoding)) }
-  let(:flags) { nil }
-  let(:major_version_number) { 4 }
-
-  let(:frame) { described_class.new(id, raw_content, flags, major_version_number) }
-  let(:target_encoding) { Encoding::UTF_8 }
-  let(:encoding_byte) { "\x03" }
-  let(:text) { "Glāzšķūņrūķīši" }
-
-  describe '#id' do
-    subject { frame.id }
-    it { is_expected.to eq(:artist) }
-  end
-
-  describe '#content' do
-    subject { frame.content }
-
-    context "when text's last char is null byte" do
-      let(:target_encoding) { Encoding::UTF_8 }
-      let(:encoding_byte) { "\x03" }
-      let(:text) { "Glāzšķūņrūķīši\x00" }
-      it { is_expected.to eq('Glāzšķūņrūķīši') }
-    end
-
-    context "when encoding byte is not present" do
-      let(:encoding_byte) { "" }
-      it { expect { subject }.to raise_error(ID3Tag::Frames::V2::TextFrame::UnsupportedTextEncoding) }
-    end
-
-    context "when encoding is ISO08859_1" do
-      let(:target_encoding) { Encoding::ISO8859_1 }
-      let(:encoding_byte) { "\x00" }
-      let(:text) { "some fancy artist" }
-      it { is_expected.to eq('some fancy artist') }
-    end
-
-    context "when encoding is UTF_16" do
-      let(:target_encoding) { Encoding::UTF_16 }
-      let(:encoding_byte) { "\x01" }
-      it { is_expected.to eq('Glāzšķūņrūķīši') }
-    end
-
-    context "when encoding is UTF_16BE" do
-      let(:target_encoding) { Encoding::UTF_16BE }
-      let(:encoding_byte) { "\x02" }
-      it { is_expected.to eq('Glāzšķūņrūķīši') }
-    end
-
-    context "when encoding is UTF_8" do
-      let(:target_encoding) { Encoding::UTF_8 }
-      let(:encoding_byte) { "\x03" }
-      it { is_expected.to eq('Glāzšķūņrūķīši') }
-    end
-
-    context "when UTF-16 and missing BOM" do
-      let(:target_encoding) { Encoding::UTF_8 }
-      let(:raw_content) { "\x01\x00\x00a\x00b\x00c" }
-      it "raises error Encoding::InvalidByteSequenceError" do
-        expect { subject }.to raise_error(Encoding::InvalidByteSequenceError)
-      end
-      context "when using global encode options" do
-        before(:each) do
-          ID3Tag.configuration do |c|
-            c.string_encode_options = { :invalid => :replace, :undef => :replace }
-          end
-        end
-        after(:each) do
-          ID3Tag.configuration do |c|
-            c.string_encode_options = {}
-          end
-        end
-        it "does not raise error" do
-          expect { subject }.not_to raise_error
-        end
-      end
-    end
-  end
-
-  describe '#inspect' do
-    it 'should be pretty inspectable' do
-      expect(frame.inspect).to eq('<ID3Tag::Frames::V2::TextFrame artist: Glāzšķūņrūķīši>')
-    end
-  end
-end

data/spec/lib/id3tag/frames/v2/unique_file_id_frame_spec.rb

@@ -1,31 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-
-describe ID3Tag::Frames::V2::UniqueFileIdFrame do
-  let(:id) { "UFID" }
-  let(:raw_content) { "ZXC\x00foobar" }
-  let(:flags) { nil }
-  let(:major_version_number) { 4 }
-  let(:frame) { described_class.new(id, raw_content, flags, major_version_number) }
-
-  describe '#id' do
-    subject { frame.id }
-    it { is_expected.to eq(:UFID) }
-  end
-
-  describe '#owner_identifier' do
-    subject { frame.owner_identifier }
-    it { is_expected.to eq('ZXC') }
-  end
-
-  describe '#content' do
-    subject { frame.content }
-    it { is_expected.to eq('foobar') }
-  end
-
-  describe '#inspect' do
-    it 'should be pretty inspectable' do
-      expect(frame.inspect).to eq('<ID3Tag::Frames::V2::UniqueFileIdFrame UFID: ZXC>')
-    end
-  end
-end

data/spec/lib/id3tag/frames/v2/user_text_frame_spec.rb

@@ -1,34 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-
-describe ID3Tag::Frames::V2::UserTextFrame do
-  let(:id) { "TXX" }
-  let(:raw_content) { text.encode(target_encoding).prepend(encoding_byte.force_encoding(target_encoding)) }
-  let(:flags) { nil }
-  let(:major_version_number) { 4 }
-
-  let(:target_encoding) { Encoding::UTF_8 }
-  let(:encoding_byte) { "\x03" }
-  let(:text) { "SUPER_FRAME\x00Glāzšķūņrūķīši" }
-  subject { described_class.new(id, raw_content, flags, major_version_number) }
-
-  describe '#id' do
-    subject { super().id }
-    it { is_expected.to eq(:TXX) }
-  end
-
-  describe '#content' do
-    subject { super().content }
-    it { is_expected.to eq('Glāzšķūņrūķīši') }
-  end
-
-  describe '#description' do
-    subject { super().description }
-    it { is_expected.to eq('SUPER_FRAME') }
-  end
-
-  describe '#inspect' do
-    subject { super().inspect }
-    it { is_expected.to eq('<ID3Tag::Frames::V2::UserTextFrame TXX: Glāzšķūņrūķīši>') }
-  end
-end

data/spec/lib/id3tag/id3_v1_frame_parser_spec.rb

@@ -1,71 +0,0 @@
-require "spec_helper"
-describe ID3Tag::ID3V1FrameParser do
-  let(:mp3_with_v1_0_tag) { mp3_fixture('id3v1_without_track_nr.mp3') }
-  let(:mp3_with_v1_1_tag) { mp3_fixture('id3v1_with_track_nr.mp3') }
-  let(:frame_bytes_v1_0) { File.read(mp3_with_v1_0_tag, 125, 579) }
-  let(:frame_bytes_v1_1) { File.read(mp3_with_v1_1_tag, 125, 579) }
-  describe "#frames" do
-    subject { described_class.new(frame_bytes_v1_0).frames }
-
-    describe "common frames between v1.0 and v.1.1" do
-
-      it "should contain title frame" do
-        frame = subject.select { |frame| frame.id == :title }.first
-        expect(frame.content).to eq("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaA")
-      end
-
-      it "should contain artist frame" do
-        frame = subject.select { |frame| frame.id == :artist }.first
-        expect(frame.content).to eq("bbbbbbbbbbbbbbbbbbbbbbbbbbbbbB")
-      end
-
-      it "should contain album frame" do
-        frame = subject.select { |frame| frame.id == :album }.first
-        expect(frame.content).to eq("cccccccccccccccccccccccccccccC")
-      end
-
-      it "should contain year frame" do
-        frame = subject.select { |frame| frame.id == :year }.first
-        expect(frame.content).to eq("2003")
-      end
-    end
-
-    describe "frames with differences in v1.0 and v1.1" do
-      context "when reading v1.0 tag" do
-        it "should contain comments frame" do
-          frame = subject.select { |frame| frame.id == :comments }.first
-          expect(frame.content).to eq("dddddddddddddddddddddddddddddD")
-        end
-
-        it "should contain genre frame" do
-          frame = subject.select { |frame| frame.id == :genre }.first
-          expect(frame.content).to eq("Blues")
-        end
-
-        it "should not contain track nr frame" do
-          expect(subject.select { |frame| frame.id == :track_nr }.first).to be_nil
-        end
-      end
-      context "when reading v1.1 tag" do
-        subject { described_class.new(frame_bytes_v1_1).frames }
-        it "should contain comments frame" do
-          frame = subject.select { |frame| frame.id == :comments }.first
-          expect(frame.content).to eq("dddddddddddddddddddddddddddD")
-        end
-
-        it "should contain track nr frame" do
-          frame = subject.select { |frame| frame.id == :track_nr }.first
-          expect(frame.content).to eq("1")
-        end
-      end
-    end
-  end
-
-  describe "Test with real-world tag" do
-    let(:tag_body) { File.read mp3_fixture("pov_20131018-2100a.mp3.v1_tag_body") }
-    subject { described_class.new(tag_body) }
-    it "have title" do
-      expect(subject.frames.find { |f| f.id == :title }.content).to eq("pov_20131018-2100a.mp3")
-    end
-  end
-end