id3tag 0.0.0 → 0.1.0

data/spec/lib/id3tag/id3_v1_frame_parser_spec.rb

@@ -0,0 +1,67 @@
+require "spec_helper"
+describe ID3Tag::ID3V1FrameParser do
+  let(:mp3_with_v1_0_tag) { mp3_fixture('id3v1_without_track_nr.mp3') }
+  let(:mp3_with_v1_1_tag) { mp3_fixture('id3v1_with_track_nr.mp3') }
+  let(:frame_bytes_v1_0) { File.read(mp3_with_v1_0_tag, 125, 579) }
+  let(:frame_bytes_v1_1) { File.read(mp3_with_v1_1_tag, 125, 579) }
+  describe "#frames" do
+    subject { described_class.new(frame_bytes_v1_0).frames }
+
+    it "should return array or frames" do
+      subject.should be_kind_of(Set)
+    end
+
+    describe "common frames between v1.0 and v.1.1" do
+
+      it "should contain title frame" do
+        frame = subject.select { |frame| frame.id == :title }.first
+        frame.content.should == "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaA"
+      end
+
+      it "should contain artist frame" do
+        frame = subject.select { |frame| frame.id == :artist }.first
+        frame.content.should == "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbB"
+      end
+
+      it "should contain album frame" do
+        frame = subject.select { |frame| frame.id == :album }.first
+        frame.content.should == "cccccccccccccccccccccccccccccC"
+      end
+
+      it "should contain year frame" do
+        frame = subject.select { |frame| frame.id == :year }.first
+        frame.content.should == "2003"
+      end
+    end
+
+    describe "frames with differences in v1.0 and v1.1" do
+      context "when reading v1.0 tag" do
+        it "should contain comments frame" do
+          frame = subject.select { |frame| frame.id == :comments }.first
+          frame.content.should == "dddddddddddddddddddddddddddddD"
+        end
+
+        it "should contain genre frame" do
+          frame = subject.select { |frame| frame.id == :genre }.first
+          frame.content.should == "Blues"
+        end
+
+        it "should not contain track nr frame" do
+          subject.select { |frame| frame.id == :track_nr }.first.should be_nil
+        end
+      end
+      context "when reading v1.1 tag" do
+        subject { described_class.new(frame_bytes_v1_1).frames }
+        it "should contain comments frame" do
+          frame = subject.select { |frame| frame.id == :comments }.first
+          frame.content.should == "dddddddddddddddddddddddddddD"
+        end
+
+        it "should contain track nr frame" do
+          frame = subject.select { |frame| frame.id == :track_nr }.first
+          frame.content.should == "1"
+        end
+      end
+    end
+  end
+end

data/spec/lib/id3tag/id3_v2_frame_parser_spec.rb

@@ -0,0 +1,18 @@
+require "spec_helper"
+describe ID3Tag::ID3V2FrameParser do
+  let(:mp3_with_v2_3_tag) { mp3_fixture('id3v2.mp3') }
+  let(:frame_bytes) { File.read(mp3_with_v2_3_tag, 246, 10) }
+  let(:tag_major_version) { 3 }
+  describe "#frames" do
+    subject { described_class.new(frame_bytes, tag_major_version).frames }
+    it "should have frame TIT2" do
+      subject.select { |x| x.id == :TIT2 }.count.should == 1
+    end
+
+    describe "text frames" do
+      it "should parse text frames and initialize as TextFrame objects" do
+        subject.select { |x| x.id == :TIT2 }.first.should be_kind_of(ID3Tag::Frames::V2::TextFrame)
+      end
+    end
+  end
+end

data/spec/lib/id3tag/id3_v2_tag_header_spec.rb

@@ -0,0 +1,60 @@
+require "spec_helper"
+
+describe ID3Tag::ID3v2TagHeader do
+  subject { described_class.new(header_data) }
+  
+  describe "#major_version_number" do
+    context "when first bit represent 3" do
+      let(:header_data) { "ID3\03\00..." }
+      its(:major_version_number) { should == 3 }
+    end
+  end
+
+  describe "#minor_version_number" do
+    context "when 2nd bit represent 2" do
+      let(:header_data) { "ID3\03\02..." }
+      its(:minor_version_number) { should == 2 }
+    end
+  end
+
+  describe "#version_number" do
+    let(:header_data) { "ID3\02\03..." }
+    its(:version_number) { should == "2.3" }
+  end
+
+  describe "header flags" do
+    context "when flags bite is 0b10000000" do
+      let(:header_data) { "ID3\03\00#{0b10000000.chr}" }
+      its(:unsynchronisation?) { should be_true }
+      its(:extended_header?) { should be_false }
+      its(:experimental?) { should be_false }
+      its(:footer_present?) { should be_false }
+    end
+    context "when flags bite is 0b01000000" do
+      let(:header_data) { "ID3\03\00#{0b01000000.chr}" }
+      its(:unsynchronisation?) { should be_false }
+      its(:extended_header?) { should be_true }
+      its(:experimental?) { should be_false }
+      its(:footer_present?) { should be_false }
+    end
+    context "when flags bite is 0b00100000" do
+      let(:header_data) { "ID3\03\00#{0b00100000.chr}" }
+      its(:unsynchronisation?) { should be_false }
+      its(:extended_header?) { should be_false }
+      its(:experimental?) { should be_true }
+      its(:footer_present?) { should be_false }
+    end
+    context "when flags bite is 0b00010000" do
+      let(:header_data) { "ID3\03\00#{0b00010000.chr}" }
+      its(:unsynchronisation?) { should be_false }
+      its(:extended_header?) { should be_false }
+      its(:experimental?) { should be_false }
+      its(:footer_present?) { should be_true }
+    end
+  end
+
+  describe "#tag_size" do
+    let(:header_data) { "ID3abc\x00\x00\x01\x7F" }
+    its(:tag_size) { should == 255 }
+  end
+end

data/spec/lib/id3tag/id3tag_spec.rb

@@ -0,0 +1,17 @@
+require "spec_helper"
+
+describe ID3Tag do
+  let(:file) { mp3_fixture('id3v2.mp3') }
+  describe "#read" do
+    it "reads file tag" do
+      ID3Tag.read(file).should be_instance_of(ID3Tag::Tag)
+    end
+
+    it "accepts block" do
+      expect do |b|
+        ID3Tag.read(file, &b)
+      end.to yield_control
+    end
+  end
+end
+

data/spec/lib/id3tag/number_util_spec.rb

@@ -0,0 +1,24 @@
+require "spec_helper"
+describe ID3Tag::NumberUtil do
+  describe "#convert_string_to_32bit_integer" do
+    context "when string with 4 bytes given" do
+      it "should return integer" do
+        described_class.convert_string_to_32bit_integer("abcd").should == 1633837924
+      end
+    end
+
+    context "when string with less than 4 bytes given" do
+      it "should raise Argument error" do
+        expect do
+          described_class.convert_string_to_32bit_integer("ab")
+        end.to raise_error(ArgumentError)
+      end
+    end
+  end
+
+  describe "#convert_32bit_integer_to_string" do
+    it "should return 4 byte string" do
+      described_class.convert_32bit_integer_to_string(1633837924).should == "abcd"
+    end
+  end
+end

data/spec/lib/id3tag/string_util_spec.rb

@@ -0,0 +1,21 @@
+require "spec_helper"
+
+describe ID3Tag::StringUtil do
+  describe "#blank?" do
+    subject { described_class.blank?(test_string) }
+    context "when test string is like ''" do
+      let(:test_string) { "" }
+      it { should be_true }
+    end
+
+    context "when test string is like '   '" do
+      let(:test_string) { "    " }
+      it { should be_true }
+    end
+
+    context "when test string is like 'foo'" do
+      let(:test_string) { "foo" }
+      it { should be_false }
+    end
+  end
+end

data/spec/lib/id3tag/synchsafe_integer_spec.rb

@@ -0,0 +1,14 @@
+require "spec_helper"
+describe ID3Tag::SynchsafeInteger do
+  it "encodes regular integers" do
+    described_class.encode(255).should eq(383)
+    described_class.encode(5).should eq(5)
+    described_class.encode(128).should eq(256)
+  end
+
+  it "decodes synchsafe integers" do
+    described_class.decode(383).should eq(255)
+    described_class.decode(5).should eq(5)
+    described_class.decode(256).should eq(128)
+  end
+end

data/spec/lib/id3tag/tag_spec.rb

@@ -0,0 +1,84 @@
+require "spec_helper"
+
+describe ID3Tag::Tag do
+  let(:mp3_with_v1_tag) { mp3_fixture('id3v1_without_track_nr.mp3') }
+  let(:mp3_with_v1_1_tag) { mp3_fixture('id3v1_with_track_nr.mp3') }
+  context "when reading file with v1.x tag" do
+    subject { described_class.new(mp3_with_v1_tag)}
+    describe "#frames" do
+      it "reads frames from source" do
+        subject.frames.size.should > 0
+      end
+    end
+
+    describe "Class methods" do
+      describe "#read" do
+        it "should initialize new instance of tag object" do
+          described_class.read(mp3_with_v1_tag).should be_instance_of(described_class)
+        end
+      end
+    end
+
+    describe "#get_frame" do
+      it "returns string with frames content" do
+        subject.get_frame(:title).should be_kind_of(ID3Tag::Frames::V1::TextFrame)
+        subject.get_frame(:title).id.should == :title
+      end
+
+      it "raises MultipleFrameError when tag has multiple tags with the same id" do
+        subject.stub(:frames) { [ID3Tag::Frames::V1::TextFrame.new(:TIT2, "some title"), ID3Tag::Frames::V1::TextFrame.new(:TIT2, "some other title")] }
+        expect { subject.get_frame(:TIT2) }.to raise_error(ID3Tag::Tag::MultipleFrameError)
+      end
+    end
+
+    describe "#get_frames" do
+      it "returns string with frames content" do
+        subject.get_frames(:title).should be_kind_of(Array)
+        subject.get_frames(:title).count.should == 1
+      end
+    end
+
+    describe "#frames" do
+      context "when file has v2.x tag version" do
+        before do
+          ID3Tag::AudioFile.any_instance.stub(:v1_tag_present?) { true }
+          ID3Tag::AudioFile.any_instance.stub(:v2_tag_present?) { true }
+          ID3Tag::ID3V2FrameParser.any_instance.stub(:frames) { [1,2,3] }
+        end
+        it "should return frames from ID3V2FrameParser class" do
+          subject.frames.should == [1,2,3]
+        end
+      end
+      context "when file has v2.x tag version" do
+        before do
+          ID3Tag::AudioFile.any_instance.stub(:v1_tag_present?) { true }
+          ID3Tag::AudioFile.any_instance.stub(:v2_tag_present?) { false }
+          ID3Tag::ID3V1FrameParser.any_instance.stub(:frames) { [1,2,3] }
+        end
+        it "should return frames from ID3V1FrameParser class" do
+          subject.frames.should == [1,2,3]
+        end
+      end
+    end
+
+    describe "#frame_ids" do
+      before do
+        subject.stub(:frames) { [ID3Tag::Frames::V1::TextFrame.new(:TIT2, "some title")] }
+      end
+      it "returns its of all frames" do
+        subject.frame_ids.should == [:TIT2]
+      end
+    end
+  end
+
+  describe "Easy access methods to text frames" do
+    subject { described_class.new(mp3_with_v1_1_tag)}
+    its(:title) { should == "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaA" }
+    its(:artist) { should == "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbB" }
+    its(:album) { should == "cccccccccccccccccccccccccccccC" }
+    its(:comments) { should == "dddddddddddddddddddddddddddD" }
+    its(:genre) { should == "Blues" }
+    its(:year) { should == "2003" }
+    its(:track_nr) { should == "1" }
+  end
+end

data/spec/spec_helper.rb

@@ -1,3 +1,11 @@
+if ENV['CI']
+  require 'coveralls'
+  Coveralls.wear!
+else
+  require 'simplecov'
+  SimpleCov.start
+end
+
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 require 'rspec'
@@ -5,7 +13,7 @@ require 'id3tag'
 
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
 RSpec.configure do |config|
   

data/spec/support/mp3_fixtures.rb

@@ -0,0 +1,4 @@
+def mp3_fixture(filename)
+  fixtures_dir = File.expand_path('../../fixtures', __FILE__)
+  File.open(File.join(fixtures_dir, filename))
+end

metadata

@@ -1,36 +1,60 @@
 --- !ruby/object:Gem::Specification
 name: id3tag
 version: !ruby/object:Gem::Version
-  version: 0.0.0
-  prerelease: 
+  version: 0.1.0
 platform: ruby
 authors:
 - Krists Ozols
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-25 00:00:00.000000000 Z
+date: 2013-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: debugger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: jeweler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.8.0
+        version: 1.8.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.8.0
+        version: 1.8.4
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -38,47 +62,41 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '3.12'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.1.5
+        version: 2.13.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.1.5
+        version: 2.13.0
 - !ruby/object:Gem::Dependency
-  name: jeweler
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.8.4
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.8.4
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -86,57 +104,103 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-description: Native Ruby ID3 tag reader/writer.
+description: Native Ruby ID3 tag reader that aims for 100% covarage of ID3v2.x and
+  ID3v1.x standards
 email: krists@iesals.lv
 executables: []
 extensions: []
 extra_rdoc_files:
 - LICENSE.txt
-- README.rdoc
+- README.md
 files:
 - .document
 - .rspec
+- .travis.yml
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
-- README.rdoc
+- README.md
 - Rakefile
 - VERSION
 - id3tag.gemspec
 - lib/id3tag.rb
-- spec/id3tag_spec.rb
+- lib/id3tag/audio_file.rb
+- lib/id3tag/frame_id_advisor.rb
+- lib/id3tag/frames/util/genre_names.rb
+- lib/id3tag/frames/v1/comments_frame.rb
+- lib/id3tag/frames/v1/genre_frame.rb
+- lib/id3tag/frames/v1/text_frame.rb
+- lib/id3tag/frames/v1/track_nr_frame.rb
+- lib/id3tag/frames/v2/basic_frame.rb
+- lib/id3tag/frames/v2/comments_frame.rb
+- lib/id3tag/frames/v2/frame_fabricator.rb
+- lib/id3tag/frames/v2/genre_frame.rb
+- lib/id3tag/frames/v2/genre_frame/genre_parser.rb
+- lib/id3tag/frames/v2/genre_frame/genre_parser_24.rb
+- lib/id3tag/frames/v2/genre_frame/genre_parser_pre_24.rb
+- lib/id3tag/frames/v2/text_frame.rb
+- lib/id3tag/frames/v2/unique_file_id_frame.rb
+- lib/id3tag/id3_v1_frame_parser.rb
+- lib/id3tag/id3_v2_frame_parser.rb
+- lib/id3tag/id3_v2_tag_header.rb
+- lib/id3tag/number_util.rb
+- lib/id3tag/string_util.rb
+- lib/id3tag/synchsafe_integer.rb
+- lib/id3tag/tag.rb
+- spec/fixtures/id3v1_and_v2.mp3
+- spec/fixtures/id3v1_with_track_nr.mp3
+- spec/fixtures/id3v1_without_track_nr.mp3
+- spec/fixtures/id3v2.mp3
+- spec/lib/id3tag/audio_file_spec.rb
+- spec/lib/id3tag/frames/util/genre_name_by_id_finder_spec.rb
+- spec/lib/id3tag/frames/v1/comments_frame_spec.rb
+- spec/lib/id3tag/frames/v1/genre_frame_spec.rb
+- spec/lib/id3tag/frames/v1/text_frame_spec.rb
+- spec/lib/id3tag/frames/v1/track_nr_frame_spec.rb
+- spec/lib/id3tag/frames/v2/basic_frame_spec.rb
+- spec/lib/id3tag/frames/v2/comments_frame_spec.rb
+- spec/lib/id3tag/frames/v2/genre_frame/genre_parser_24_spec.rb
+- spec/lib/id3tag/frames/v2/genre_frame/genre_parser_pre_24_spec.rb
+- spec/lib/id3tag/frames/v2/genre_frame_spec.rb
+- spec/lib/id3tag/frames/v2/text_frame_spec.rb
+- spec/lib/id3tag/frames/v2/unique_file_id_frame_spec.rb
+- spec/lib/id3tag/id3_v1_frame_parser_spec.rb
+- spec/lib/id3tag/id3_v2_frame_parser_spec.rb
+- spec/lib/id3tag/id3_v2_tag_header_spec.rb
+- spec/lib/id3tag/id3tag_spec.rb
+- spec/lib/id3tag/number_util_spec.rb
+- spec/lib/id3tag/string_util_spec.rb
+- spec/lib/id3tag/synchsafe_integer_spec.rb
+- spec/lib/id3tag/tag_spec.rb
 - spec/spec_helper.rb
+- spec/support/mp3_fixtures.rb
 homepage: http://github.com/krists/id3tag
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
-      version: '0'
-      segments:
-      - 0
-      hash: -665629855
+      version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
-summary: Native Ruby ID3 tag reader/writer.
+specification_version: 4
+summary: Native Ruby ID3 tag reader that aims for 100% covarage of ID3v2.x and ID3v1.x
+  standards
 test_files: []