icu_tournament 1.2.8 → 1.3.1

data/spec/tournament_krause_spec.rb

@@ -8,7 +8,7 @@ module ICU
         p = @t.player(num)
         p.first_name.should == first
         p.last_name.should  == last
-        [:gender, :title, :rating, :fed, :id, :fide, :dob, :rank].each do |key|
+        [:gender, :title, :rating, :fide_rating, :fed, :id, :fide, :dob, :rank].each do |key|
           p.send(key).should == other[key] if other.has_key?(key)
         end
       end
@@ -43,7 +43,7 @@ module ICU
 001    3 m  g Bologan,Viktor                    2663 MDA    13900048 1971.01.01  0.0    3               1 b 0     2 w 0
 KRAUSE
           @p = ICU::Tournament::Krause.new
-          @t = @p.parse!(krause)
+          @t = @p.parse!(krause, :fide => true)
         end
 
         it "should have a name, city and federation" do
@@ -71,9 +71,9 @@ KRAUSE
 
         it "should have players and their details" do
           @t.should have(3).players
-          check_player(1, 'Gearoidin', 'Ui Laighleis', :gender => 'F', :rating => 1985, :fed => 'IRL', :id =>  2501171, :dob => '1964-06-10', :rank => 2)
-          check_player(2, 'Mark', 'Orr',               :gender => 'M', :rating => 2258, :fed => 'IRL', :id =>  2500035, :dob => '1955-11-09', :rank => 1, :title => 'IM')
-          check_player(3, 'Viktor', 'Bologan',         :gender => 'M', :rating => 2663, :fed => 'MDA', :id => 13900048, :dob => '1971-01-01', :rank => 3, :title => 'GM')
+          check_player(1, 'Gearoidin', 'Ui Laighleis', :gender => 'F', :fide_rating => 1985, :fed => 'IRL', :fide =>  2501171, :dob => '1964-06-10', :rank => 2)
+          check_player(2, 'Mark', 'Orr',               :gender => 'M', :fide_rating => 2258, :fed => 'IRL', :fide =>  2500035, :dob => '1955-11-09', :rank => 1, :title => 'IM')
+          check_player(3, 'Viktor', 'Bologan',         :gender => 'M', :fide_rating => 2663, :fed => 'MDA', :fide => 13900048, :dob => '1971-01-01', :rank => 3, :title => 'GM')
         end
 
         it "should have correct results for each player" do
@@ -202,6 +202,12 @@ KRAUSE
           t.serialize('Krause').should == @krause
         end
 
+        it "should serialize only if :fide option is used correctly" do
+          t = @p.parse!(@krause, :fide => true)
+          t.serialize('Krause', :fide => true).should == @krause
+          t.serialize('Krause').should_not == @krause
+        end
+
         it "should not serialize coorectly if mixed ID types are used" do
           t = @p.parse!(@krause, :fide => true)
           t.serialize('Krause').should_not == @krause
@@ -233,7 +239,7 @@ KRAUSE
           @t.player(3).rank.should == 3
         end
       end
-      
+
       context "local or FIDE IDs" do
         before(:each) do
           @krause = <<KRAUSE
@@ -266,7 +272,7 @@ KRAUSE
           @krause = <<KRAUSE
 012 Las Vegas National Open
 042 2008-06-07
-001   10 w    Ui Laighleis,Gearoidin            1985 IRL                         1.0         20 b 0    30 w 1          
+001   10 w    Ui Laighleis,Gearoidin            1985 IRL                         1.0         20 b 0    30 w 1
 001   20 m  m Orr,Mark                          2258 IRL                         2.0         10 w 1              30 b 1
 001   30 m  g Bologan,Viktor                    2663 MDA                         0.0                   10 b 0    20 w 0
 KRAUSE
@@ -307,7 +313,7 @@ KRAUSE
           @output = @p.serialize(@t)
         end
 
-        it "should serialise manually build tournaments" do
+        it "should serialise" do
           @output.should == @krause
         end
       end
@@ -346,27 +352,27 @@ KRAUSE
 
         it "removing the line on which the tournament name is specified should cause an error" do
           @k.sub!('012 Gonzaga Classic', '')
-          lambda { t = @p.parse!(@k) }.should raise_error(/name missing/)
+          lambda { @p.parse!(@k) }.should raise_error(/name missing/)
         end
 
         it "blanking the tournament name should cause an error" do
           @k.sub!('Gonzaga Classic', '')
-          lambda { t = @p.parse!(@k) }.should raise_error(/name missing/)
+          lambda { @p.parse!(@k) }.should raise_error(/name missing/)
         end
 
         it "blanking the start date should cause an error" do
           @k.sub!('2008-02-01', '2008-02-04')
-          lambda { t = @p.parse!(@k) }.should raise_error(/start.*after.*end/)
+          lambda { @p.parse!(@k) }.should raise_error(/start.*after.*end/)
         end
 
         it "the start cannot be later than the end date" do
           @k.sub!('2008-02-01', '')
-          lambda { t = @p.parse!(@k) }.should raise_error(/start date missing/)
+          lambda { @p.parse!(@k) }.should raise_error(/start date missing/)
         end
 
         it "creating a duplicate player number should cause an error" do
           @k.sub!('  2  ', '  1  ')
-          lambda { t = @p.parse!(@k) }.should raise_error(/player number/)
+          lambda { @p.parse!(@k) }.should raise_error(/player number/)
         end
 
         it "creating a duplicate rank number should not cause an error becuse the tournament will be reranked" do
@@ -377,35 +383,35 @@ KRAUSE
 
         it "referring to a non-existant player number should cause an error" do
            @k.sub!(' 3 b 1', '33 b 1')
-           lambda { t = @p.parse!(@k) }.should raise_error(/opponent number/)
+           lambda { @p.parse!(@k) }.should raise_error(/opponent number/)
         end
 
         it "inconsistent colours should cause an error" do
            @k.sub!('3 b 1', '3 w 1')
-           lambda { t = @p.parse!(@k) }.should raise_error(/result/)
+           lambda { @p.parse!(@k) }.should raise_error(/result/)
         end
 
         it "inconsistent scores should cause an error" do
            @k.sub!('3 b 1', '3 b =')
-           lambda { t = @p.parse!(@k) }.should raise_error(/result/)
+           lambda { @p.parse!(@k) }.should raise_error(/result/)
         end
 
         it "inconsistent totals should cause an error" do
            @k.sub!('4.0', '4.5')
-           lambda { t = @p.parse!(@k) }.should raise_error(/total/)
+           lambda { @p.parse!(@k) }.should raise_error(/total/)
         end
 
         it "invalid federations should cause an error" do
            @k.sub!('SCO', 'XYZ')
-           lambda { t = @p.parse!(@k) }.should raise_error(/federation/)
+           lambda { @p.parse!(@k) }.should raise_error(/federation/)
         end
 
         it "removing any player that somebody else has played should cause an error" do
            @k.sub!(/^001   12.*$/, '')
-           lambda { t = @p.parse!(@k) }.should raise_error(/opponent/)
+           lambda { @p.parse!(@k) }.should raise_error(/opponent/)
         end
       end
-      
+
       context "encoding" do
         before(:all) do
           @utf8 = <<KRAUSE

data/spec/tournament_sp_spec.rb

@@ -4,14 +4,14 @@ SAMPLES = File.dirname(__FILE__) + '/samples/sp/'
 
 module ICU
   class Tournament
-    def signature
+    def sp_signature
       [name, arbiter, rounds, start, players.size].join("|")
     end
   end
   class Player
-    def signature
+    def sp_signature
       [
-        name, id, fide, rating, points, rank,
+        name, id, fide, rating, fide_rating, points, rank,
         results.map{ |r| r.round }.join(''),
         results.map{ |r| r.score }.join(''),
         results.map{ |r| r.colour || "-" }.join(''),
@@ -34,14 +34,14 @@ module ICU
 
         it "should parse and have the right basic details" do
           @p.error.should be_nil
-          @t.signature.should == "Gonzaga Chess Classic 2010 Challengers Section|Herbert Scarry|6|2010-01-29|56"
+          @t.sp_signature.should == "Gonzaga Chess Classic 2010 Challengers Section|Herbert Scarry|6|2010-01-29|56"
         end
 
         it "should have correct details for selected players" do
-          @t.player(2).signature.should  == "Mullooly, Neil M.|6438||1083|6.0|1|123456|WWWWWW|WBWBWB|TTTTTT" # winner
-          @t.player(4).signature.should  == "Gallagher, Mark|12138||1036|4.0|9|123456|WLWWWL|WBWBWB|FTTTTT"  # had one bye
-          @t.player(45).signature.should == "Catre, Loredan|||507|3.5|18|123456|WDLWLW|BWBWBW|FTTTFT"        # had two byes
-          @t.player(56).signature.should == "McDonnell, Cathal|||498|0.0|54|1|L|-|F"                         # last
+          @t.player(2).sp_signature.should  == "Mullooly, Neil M.|6438||1083||6.0|1|123456|WWWWWW|WBWBWB|TTTTTT" # winner
+          @t.player(4).sp_signature.should  == "Gallagher, Mark|12138||1036||4.0|9|123456|WLWWWL|WBWBWB|FTTTTT"  # had one bye
+          @t.player(45).sp_signature.should == "Catre, Loredan|||507||3.5|18|123456|WDLWLW|BWBWBW|FTTTFT"        # had two byes
+          @t.player(56).sp_signature.should == "McDonnell, Cathal|||498||0.0|54|1|L|-|F"                          # last
         end
 
         it "should have consistent ranks" do
@@ -53,7 +53,7 @@ module ICU
         end
 
         it "should serialize to the text export format" do
-          @t.serialize('SwissPerfect').should == @s
+          @t.serialize('SPExport').should == @s
         end
       end
 
@@ -66,14 +66,14 @@ module ICU
 
         it "should parse and have the right basic details" do
           @p.error.should be_nil
-          @t.signature.should == "U - 19 All Ireland||3|2010-04-11|4"
+          @t.sp_signature.should == "U - 19 All Ireland||3|2010-04-11|4"
         end
 
         it "should have correct details for selected players" do
-          @t.player(1).signature.should == "Griffiths, Ryan-Rhys|6897||2225|3.0|1|123|WWW|WWB|TTT"
-          @t.player(2).signature.should == "Flynn, Jamie|5226||1633|2.0|2|123|WLW|WBW|TTT"
-          @t.player(3).signature.should == "Hulleman, Leon|6409||1466|1.0|3|123|LWL|BBW|TTT"
-          @t.player(4).signature.should == "Dunne, Thomas|10914|||0.0|4|123|LLL|BWB|TTT"
+          @t.player(1).sp_signature.should == "Griffiths, Ryan-Rhys|6897||2225||3.0|1|123|WWW|WWB|TTT"
+          @t.player(2).sp_signature.should == "Flynn, Jamie|5226||1633||2.0|2|123|WLW|WBW|TTT"
+          @t.player(3).sp_signature.should == "Hulleman, Leon|6409||1466||1.0|3|123|LWL|BBW|TTT"
+          @t.player(4).sp_signature.should == "Dunne, Thomas|10914||||0.0|4|123|LLL|BWB|TTT"
         end
 
         it "should have consistent ranks" do
@@ -85,7 +85,7 @@ module ICU
         end
 
         it "should serialize to the text export format" do
-          @t.rerank.renumber.serialize('SwissPerfect').should == @s
+          @t.rerank.renumber.serialize('SPExport').should == @s
         end
       end
 
@@ -97,16 +97,16 @@ module ICU
 
         it "should parse and have the right basic details" do
           @p.error.should be_nil
-          @t.signature.should == "Limerick Club Championship 2009||7|2009-09-15|19"
+          @t.sp_signature.should == "Limerick Club Championship 2009||7|2009-09-15|19"
         end
 
         it "should have correct details for selected players" do
-          @t.player(15).signature.should == "Talazec, Laurent|10692||1570|5.5|1|1234567|WWWDDDW|WWBWBWB|FTTTTTT"  # winner
-          @t.player(6).signature.should  == "Foenander, Phillip|7168||1434|4.0|7|1234567|WLWLLWW|BWBWBWB|TTFFTTT" # had some byes
-          @t.player(19).signature.should == "Wall, Robert||||3.0|14|34567|WWLWL|WWBBW|FTTTT"                       # didn't play 1st 2 rounds
-          @t.player(17).signature.should == "Freeman, Conor||||2.0|16|1234567|DDLWLLL|--BWBWB|FFTTTTT"             # had byes and bonus (in BONUS)
-          @t.player(18).signature.should == "Freeman, Ruiri||||2.0|17|1234567|DDLLLLW|--WBBWB|FFTTTTF"             # had byes and bonus (in BONUS)
-          @t.player(16).signature.should == "O'Connor, David||||1.0|19|123|WLL|WBW|FTF"                            # last
+          @t.player(15).sp_signature.should == "Talazec, Laurent|10692||1570||5.5|1|1234567|WWWDDDW|WWBWBWB|FTTTTTT"  # winner
+          @t.player(6).sp_signature.should  == "Foenander, Phillip|7168||1434||4.0|7|1234567|WLWLLWW|BWBWBWB|TTFFTTT" # had some byes
+          @t.player(19).sp_signature.should == "Wall, Robert|||||3.0|14|34567|WWLWL|WWBBW|FTTTT"                      # didn't play 1st 2 rounds
+          @t.player(17).sp_signature.should == "Freeman, Conor|||||2.0|16|1234567|DDLWLLL|--BWBWB|FFTTTTT"            # had byes and bonus (in BONUS)
+          @t.player(18).sp_signature.should == "Freeman, Ruiri|||||2.0|17|1234567|DDLLLLW|--WBBWB|FFTTTTF"            # had byes and bonus (in BONUS)
+          @t.player(16).sp_signature.should == "O'Connor, David|||||1.0|19|123|WLL|WBW|FTF"                           # last
         end
 
         it "should have consistent ranks" do
@@ -126,14 +126,14 @@ module ICU
 
         it "should parse and have the right basic details" do
           @p.error.should be_nil
-          @t.signature.should == "U16 Inter Provincials 2010|David B Murray|3|2010-02-02|18"
+          @t.sp_signature.should == "U16 Inter Provincials 2010|David B Murray|3|2010-02-02|18"
         end
 
         it "should have correct details for selected players" do
-          @t.player(15).signature.should == "Gupta, Radhika|||1247|3.0|1|123|WWW|BBW|TTT"            # won all his games
-          @t.player(18).signature.should == "Hurley, Thomas|6292||820|1.0|14|1|W|B|F"                 # scored just 1 from a bye in R1
-          @t.player(8).signature.should  == "Berney, Mark|10328||1948|2.0|3|23|WW|BW|TT"             # didn't play in round 1
-          @t.player(10).signature.should == "O'Donnell, Conor E.|10792||1073|2.0|10|123|LWW|WBW|TFT"  # got just 1 point for a bye
+          @t.player(15).sp_signature.should == "Gupta, Radhika|||1247||3.0|1|123|WWW|BBW|TTT"            # won all his games
+          @t.player(18).sp_signature.should == "Hurley, Thomas|6292||820||1.0|14|1|W|B|F"                # scored just 1 from a bye in R1
+          @t.player(8).sp_signature.should  == "Berney, Mark|10328||1948||2.0|3|23|WW|BW|TT"             # didn't play in round 1
+          @t.player(10).sp_signature.should == "O'Donnell, Conor E.|10792||1073||2.0|10|123|LWW|WBW|TFT" # got just 1 point for a bye
         end
 
         it "should have consistent ranks" do
@@ -153,15 +153,15 @@ module ICU
 
         it "should parse and have the right basic details" do
           @p.error.should be_nil
-          @t.signature.should == "Mulcahy Cup 2010|Stephen Short|6|2010-01-15|50"
+          @t.sp_signature.should == "Mulcahy Cup 2010|Stephen Short|6|2010-01-15|50"
         end
 
         it "should have correct details for selection of players who got bonuses (in MEMO)" do
-          @t.player(23).signature.should == "Long, Killian|10293|2|1506|2.5|33|123456|WDLLWL|WWBWBB|TFTTTT"
-          @t.player(26).signature.should == "Bradley, Michael|6756|27|1413|3.0|26|123456|DDLWWL|BWWBWW|TFTTTT"
-          @t.player(15).signature.should == "Twomey, Pat|1637|22|1656|4.5|7|123456|WDLWWW|WWWBWB|FFTTTT"
-          @t.player(46).signature.should == "O'Riordan, Pat|10696||900|2.0|42|123456|LDDLDD|BWBWWB|TTTTFT"
-          @t.player(38).signature.should == "Gill, Craig I.|10637|28|1081|2.0|43|123456|LLWDDL|BWBWWB|TTTTFT"
+          @t.player(23).sp_signature.should == "Long, Killian|10293|2|1506||2.5|33|123456|WDLLWL|WWBWBB|TFTTTT"
+          @t.player(26).sp_signature.should == "Bradley, Michael|6756|27|1413||3.0|26|123456|DDLWWL|BWWBWW|TFTTTT"
+          @t.player(15).sp_signature.should == "Twomey, Pat|1637|22|1656||4.5|7|123456|WDLWWW|WWWBWB|FFTTTT"
+          @t.player(46).sp_signature.should == "O'Riordan, Pat|10696||900||2.0|42|123456|LDDLDD|BWBWWB|TTTTFT"
+          @t.player(38).sp_signature.should == "Gill, Craig I.|10637|28|1081||2.0|43|123456|LLWDDL|BWBWWB|TTTTFT"
         end
 
         it "should have consistent ranks" do
@@ -177,22 +177,14 @@ module ICU
 
         it "should parse and have the right basic details" do
           @p.error.should be_nil
-          @t.signature.should == "National Club Championship 2010|Gerry Graham|4|2010-05-08|77"
+          @t.sp_signature.should == "National Club Championship 2010|Gerry Graham|4|2010-05-08|77"
         end
 
         it "should have correct details for selection of players, including ICU IDs" do
-          @t.player(2).signature.should  == "Szabo, Gergely|12379|1205064|2530|4.0|4|1234|WWWW|WBWB|TTTT"
-          @t.player(5).signature.should  == "Daly, Colm|295|2500434|2314|3.5|7|1234|WWWD|WBWB|TTTT"
-          @t.player(8).signature.should  == "Vega, Marcos Llaneza||2253585|2475|3.0|16|1234|DDWW|BWBW|TTTT"
-          @t.player(67).signature.should == "Lee, Shane|780||1633|1.0|52|134|DLD|WWW|TTT"
-        end
-
-        it "should have correct details for selection of players, including international ratings when so configured" do
-          @t = @p.parse_file(SAMPLES + 'ncc', :start => "2010-05-08", :rating => :intl)
-          @t.player(2).signature.should  == "Szabo, Gergely|12379|1205064||4.0|4|1234|WWWW|WBWB|TTTT"
-          @t.player(5).signature.should  == "Daly, Colm|295|2500434||3.5|7|1234|WWWD|WBWB|TTTT"
-          @t.player(8).signature.should  == "Vega, Marcos Llaneza||2253585||3.0|16|1234|DDWW|BWBW|TTTT"
-          @t.player(67).signature.should == "Lee, Shane|780|||1.0|52|134|DLD|WWW|TTT"
+          @t.player(2).sp_signature.should  == "Szabo, Gergely|12379|1205064||2530|4.0|4|1234|WWWW|WBWB|TTTT"
+          @t.player(5).sp_signature.should  == "Daly, Colm|295|2500434|2314||3.5|7|1234|WWWD|WBWB|TTTT"
+          @t.player(8).sp_signature.should  == "Vega, Marcos Llaneza||2253585|2475||3.0|16|1234|DDWW|BWBW|TTTT"
+          @t.player(67).sp_signature.should == "Lee, Shane|780||1633||1.0|52|134|DLD|WWW|TTT"
         end
       end
 
@@ -279,14 +271,14 @@ module ICU
 
         it "should parse and have the right basic details" do
           @p.error.should be_nil
-          @t.signature.should == "National Club Championship 2010|Gerry Graham|4|2010-05-08|77"
+          @t.sp_signature.should == "National Club Championship 2010|Gerry Graham|4|2010-05-08|77"
         end
 
         it "should have correct details for selection of players, including ICU IDs" do
-          @t.player(2).signature.should  == "Szabo, Gergely|12379|1205064|2530|4.0|4|1234|WWWW|WBWB|TTTT"
-          @t.player(5).signature.should  == "Daly, Colm|295|2500434|2314|3.5|7|1234|WWWD|WBWB|TTTT"
-          @t.player(8).signature.should  == "Vega, Marcos Llaneza||2253585|2475|3.0|16|1234|DDWW|BWBW|TTTT"
-          @t.player(67).signature.should == "Lee, Shane|780||1633|1.0|52|134|DLD|WWW|TTT"
+          @t.player(2).sp_signature.should  == "Szabo, Gergely|12379|1205064||2530|4.0|4|1234|WWWW|WBWB|TTTT"
+          @t.player(5).sp_signature.should  == "Daly, Colm|295|2500434|2314||3.5|7|1234|WWWD|WBWB|TTTT"
+          @t.player(8).sp_signature.should  == "Vega, Marcos Llaneza||2253585|2475||3.0|16|1234|DDWW|BWBW|TTTT"
+          @t.player(67).sp_signature.should == "Lee, Shane|780||1633||1.0|52|134|DLD|WWW|TTT"
         end
       end
 
@@ -311,9 +303,9 @@ module ICU
 
         it "should parse and the name should be in UTF-8" do
           lambda { @t = @p.parse_file!(SAMPLES + 'munster_u10_2011.zip', :start => "2011-01-20") }.should_not raise_error
-          @t.player(1).signature.should  == "Kennedy, Stephen|||849|2.0|6|12345|WLWLL|BWBWB|TTTTT"
-          @t.player(4).signature.should  == "Sheehan, Ciarán||||3.0|5|12345|LWWLW|WBWBW|TTTTF"
-          @t.player(10).signature.should  == "Sheehan, Adam||||2.0|7|12345|WLLWL|WBWWB|TTTFT"
+          @t.player(1).sp_signature.should  == "Kennedy, Stephen|||849||2.0|6|12345|WLWLL|BWBWB|TTTTT"
+          @t.player(4).sp_signature.should  == "Sheehan, Ciarán|||||3.0|5|12345|LWWLW|WBWBW|TTTTF"
+          @t.player(10).sp_signature.should  == "Sheehan, Adam|||||2.0|7|12345|WLLWL|WBWWB|TTTFT"
         end
       end
 

data/spec/tournament_spx_spec.rb

@@ -0,0 +1,379 @@
+# encoding: UTF-8
+require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+
+module ICU
+  class Tournament
+    def spx_signature
+      [name, rounds, start, players.size].join("|")
+    end
+  end
+  class Player
+    def spx_signature
+      [
+        name, id, points,
+        results.map{ |r| r.round }.join(''),
+        results.map{ |r| r.score }.join(''),
+        results.map{ |r| r.colour || "-" }.join(''),
+        results.map{ |r| r.rateable ? 'T' : 'F' }.join(''),
+      ].join("|")
+    end
+    def spx_signature2
+      [
+        results.map{ |r| r.round }.join(''),
+        results.map{ |r| r.score }.join(''),
+        results.map{ |r| r.rateable ? 'T' : 'F' }.join(''),
+      ].join("|")
+    end
+  end
+end
+
+module ICU
+  class Tournament
+    describe SPExport do
+      def samples
+        File.dirname(__FILE__) + '/samples/spx/'
+      end
+
+      context "documentation example" do
+        before(:each) do
+          @x = <<EXPORT
+No	Name          	Feder	Intl Id	Loc Id	Rtg 	Loc 	Title	Total	1  	2  	3
+
+1 	Duck, Daffy   	IRL  	       	12345 	    	2200	im   	2    	0:D	3:W	2:D
+2 	Mouse, Minerva	     	1234568	      	1900	    	     	1.5  	3:D	0:D	1:D
+3 	Mouse, Mickey 	USA  	1234567	      	    	    	gm   	1    	2:D	1:L	0:D
+EXPORT
+          @p = ICU::Tournament::SPExport.new
+          @opt = { :name => "Mickey Mouse Masters", :start => "2012-01-01" }
+          @t = ICU::Tournament::SPExport.new.parse(@x, @opt)
+        end
+
+        it "should parse without exception" do
+          lambda { @p.parse!(@x, @opt) }.should_not raise_error
+        end
+
+        it "should parse without error" do
+          @p.parse(@x, @opt)
+          @p.error.should be_nil
+        end
+
+        it "players should have all the right names and numbers" do
+          @t.player(1).name.should == "Duck, Daffy"
+          @t.player(2).name.should == "Mouse, Minerva"
+          @t.player(3).name.should == "Mouse, Mickey"
+        end
+
+        it "players should have correct ICU IDs" do
+          @t.player(1).id.should == 12345
+          @t.player(2).id.should be_nil
+          @t.player(3).id.should be_nil
+        end
+
+        it "players should have correct FIDE IDs" do
+          @t.player(1).fide.should be_nil
+          @t.player(2).fide.should == 1234568
+          @t.player(3).fide.should == 1234567
+        end
+
+        it "players should have correct ICU ratings" do
+          @t.player(1).rating.should == 2200
+          @t.player(2).rating.should be_nil
+          @t.player(3).rating.should be_nil
+        end
+
+        it "players should have correct FIDE ratings" do
+          @t.player(1).fide_rating.should be_nil
+          @t.player(2).fide_rating.should == 1900
+          @t.player(3).fide_rating.should be_nil
+        end
+
+        it "players should have correct titles" do
+          @t.player(1).title.should == "IM"
+          @t.player(2).title.should be_nil
+          @t.player(3).title.should == "GM"
+        end
+
+        it "players should have correct federations" do
+          @t.player(1).fed.should == "IRL"
+          @t.player(2).fed.should be_nil
+          @t.player(3).fed.should == "USA"
+        end
+
+        it "players should have correct scores" do
+          @t.player(1).points.should == 2.0
+          @t.player(2).points.should == 1.5
+          @t.player(3).points.should == 1.0
+        end
+
+        it "players should have correct ranks" do
+          @t.player(1).rank.should == 1
+          @t.player(2).rank.should == 2
+          @t.player(3).rank.should == 3
+        end
+
+        it "players should have correct results" do
+          @t.player(1).spx_signature2.should == '123|DWD|FTT'
+          @t.player(2).spx_signature2.should == '123|DDD|TFT'
+          @t.player(3).spx_signature2.should == '123|DLD|TTF'
+        end
+      end
+
+      context "serialisation" do
+        before(:each) do
+          name = "Bangor Masters"
+          start = "2009-11-09"
+          @t = ICU::Tournament.new(name, start)
+          @t.add_player(ICU::Player.new('Bobby', 'Fischer', 10))
+          @t.add_player(ICU::Player.new('Garry', 'Kasparov', 20))
+          @t.add_player(ICU::Player.new('Mark', 'Orr', 30, :id => 1350, :fide => 2500035, :fed => 'IRL', :rating => 2200, :fide_rating => 2250))
+          @t.add_result(ICU::Result.new(1, 10, 'D', :opponent => 30))
+          @t.add_result(ICU::Result.new(2, 20, 'W', :opponent => 30))
+          @t.add_result(ICU::Result.new(3, 20, 'L', :opponent => 10))
+          @p = ICU::Tournament::SPExport.new
+          @x = @t.serialize('SPExport')
+          @r = @p.parse(@x, :name => name, :start => start)
+        end
+
+        it "should round trip" do
+          @p.error.should be_nil
+          @r.spx_signature.should == "Bangor Masters|3|2009-11-09|3"
+          @r.player(1).spx_signature.should == "Fischer, Bobby||1.5|123|DLW|---|TFT"
+          @r.player(2).spx_signature.should == "Kasparov, Garry||1.0|123|LWL|---|FTT"
+          @r.player(3).spx_signature.should == "Orr, Mark|1350|0.5|123|DLL|---|TTF"
+        end
+
+        it "should have default columns" do
+          @x.should match(/^No\s*Name\s*Loc Id\s*Total\s*1\s*2\s*3\s*/)
+          @x.should match(/1\s*Fischer,\s*Bobby\s*1\.5\s*3:D\s*0?:L?\s*2:W\s*/)
+        end
+
+        it "can have custom columns" do
+          @x = @t.serialize('SPExport', :columns => [])
+          @x.should match(/^No\s*Name\s*1\s*2\s*3\s*/)
+          @x = @t.serialize('SPExport', :columns => [:points])
+          @x.should match(/^No\s*Name\s*Total\s*1\s*2\s*3\s*/)
+          @x = @t.serialize('SPExport', :columns => [:points, :id])
+          @x.should match(/^No\s*Name\s*Loc Id\s*Total\s*1\s*2\s*3\s*/)
+          @x = @t.serialize('SPExport', :columns => [:points, :id, :fed])
+          @x.should match(/^No\s*Name\s*Feder\s*Loc Id\s*Total\s*1\s*2\s*3\s*/)
+          @x = @t.serialize('SPExport', :columns => [:points, :id, :fed, :fed, :rubbish, :fide])
+          @x.should match(/^No\s*Name\s*Feder\s*Intl Id\s*Loc Id\s*Total\s*1\s*2\s*3\s*/)
+          @x = @t.serialize('SPExport', :columns => [:fed, :fide, :points, :id, :rating])
+          @x.should match(/^No\s*Name\s*Feder\s*Intl Id\s*Loc Id\s*Loc\s*Total\s*1\s*2\s*3\s*/)
+          @x = @t.serialize('SPExport', :columns => [:fed, :fide, :fide_rating, :points, :id, :rating])
+          @x.should match(/^No\s*Name\s*Feder\s*Intl Id\s*Loc Id\s*Rtg\s*Loc\s*Total\s*1\s*2\s*3\s*/)
+          @x.should match(/3\s*Orr,\s*Mark\s*IRL\s*2500035\s*1350\s*2250\s*2200\s*0.5\s*1:D\s*2:L\s*:\s*/)
+        end
+      end
+
+      context "invisible bonuses" do
+        before(:each) do
+          @x = <<EXPORT
+No	Name          	Total	1  	2  	3
+
+1 	Daffy Duck    	2.0  	0: 	3:W	2:D
+2 	Mouse, Minerva	1.5  	3:D	0: 	1:D
+3 	Mouse, Mickey 	1.0  	2:D	1:L	0:D
+EXPORT
+          @p = ICU::Tournament::SPExport.new
+          @t = @p.parse!(@x, :name => "Mickey Mouse Masters", :start => "2012-01-01")
+        end
+
+        it "players should have correct results" do
+          @t.player(1).spx_signature2.should == '123|DWD|FTT'
+          @t.player(2).spx_signature2.should == '123|DDD|TFT'
+          @t.player(3).spx_signature2.should == '123|DLD|TTF'
+        end
+      end
+
+      context "invisible bonuses extreme example" do
+        before(:each) do
+          @x = <<EXPORT
+No	Name          	Total	1  	2  	3
+
+1 	Daffy Duck    	2.5  	 : 	 : 	 :
+2 	Mouse, Minerva	2.0  	 : 	 : 	 :
+3 	Mouse, Mickey 	1.0  	 : 	 : 	 :
+EXPORT
+          @p = ICU::Tournament::SPExport.new
+          @t = @p.parse!(@x, :name => "Mickey Mouse Masters", :start => "2012-01-01")
+        end
+
+        it "players should have correct results" do
+          @t.player(1).spx_signature2.should == '123|WWD|FFF'
+          @t.player(2).spx_signature2.should == '123|WDD|FFF'
+          @t.player(3).spx_signature2.should == '123|DDL|FFF'
+        end
+      end
+
+      context "odds and ends" do
+        before(:each) do
+          @x = <<EXPORT
+No	Name          	Total	1  	2  	3
+
+1 	Daffy Duck    	2.0  	0:=	3:+	2:d
+2 	Mouse, Minerva	1.0  	3:=	 : 	1:D
+3 	Mouse, Mickey 	1.0  	2:=	1:-	0:D
+EXPORT
+          @p = ICU::Tournament::SPExport.new
+          @t = @p.parse!(@x, :name => "Mickey Mouse Masters", :start => "2012-01-01")
+        end
+
+        it "players should have all the right names and numbers" do
+          @t.player(1).name.should == "Duck, Daffy"
+          @t.player(2).name.should == "Mouse, Minerva"
+          @t.player(3).name.should == "Mouse, Mickey"
+        end
+
+        it "players should have correct results" do
+          @t.player(1).spx_signature2.should == '123|DWD|FFT'
+          @t.player(2).spx_signature2.should == '123|DLD|FFT'
+          @t.player(3).spx_signature2.should == '123|DLD|FFF'
+        end
+
+        it "players should have correct ranks given default name tie-break" do
+          @t.player(1).rank.should == 1
+          @t.player(2).rank.should == 3
+          @t.player(3).rank.should == 2
+        end
+      end
+
+      context "strings and encoding" do
+        before(:each) do
+          @p = ICU::Tournament::SPExport.new
+          @x = <<EXPORT
+No	Name          	Total	1  	2
+
+1 	Dück, Dâffy   	1.5  	2:W	2:D
+2 	Möuse, Mickéy 	0.5  	1:L	1:D
+EXPORT
+          @opt = { :name => "Test", :start => "2011-02-05" }
+        end
+
+        it "UTF-8" do
+          t = @p.parse(@x, @opt)
+          @p.error.should be_nil
+          t.player(1).name.should == "Dück, Dâffy"
+          t.player(2).name.should == "Möuse, Mickéy"
+        end
+
+        it "Latin-1" do
+          t = @p.parse(@x.encode("ISO-8859-1"), @opt)
+          @p.error.should be_nil
+          t.player(1).name.should == "Dück, Dâffy"
+          t.player(2).name.should == "Möuse, Mickéy"
+        end
+      end
+
+      context "errors" do
+        before(:each) do
+          @p = ICU::Tournament::SPExport.new
+          @opt = { :name => "Test", :start => "2011-02-05" }
+        end
+
+        it "correct example" do
+          data = <<EXPORT
+No	Name          	Total	1  	2
+
+1 	Duck, Daffy   	1.5  	2:W	2:D
+2 	Mouse, Mickey 	0.5  	1:L	1:D
+EXPORT
+          lambda { @p.parse!(data, @opt) }.should_not raise_error
+        end
+
+        it "no header" do
+          data = <<EXPORT
+1 	Duck, Daffy   	1.5  	2:W	2:D
+2 	Mouse, Mickey 	0.5  	1:L	1:L
+EXPORT
+          lambda { @p.parse!(data, @opt) }.should raise_error(/header/)
+        end
+
+        it "invalid header" do
+          data = <<EXPORT
+Xx	Name          	Total	1  	2
+
+1 	Duck, Daffy   	1.5  	2:W	2:D
+2 	Mouse, Mickey 	0.5  	1:L	1:D
+EXPORT
+          lambda { @p.parse!(data, @opt) }.should raise_error(/header/)
+        end
+
+        it "missing round 1" do
+          data = <<EXPORT
+No	Name          	Total	2  	3
+
+1 	Duck, Daffy   	1.5  	2:W	2:D
+2 	Mouse, Mickey 	0.0  	1:L	1:L
+EXPORT
+          lambda { @p.parse!(data, @opt) }.should raise_error(/round 1/)
+        end
+
+        it "missing round 2" do
+          data = <<EXPORT
+No	Name          	Total	1  	3
+
+1 	Duck, Daffy   	1.5  	2:W	2:D
+2 	Mouse, Mickey 	0.0  	1:L	1:L
+EXPORT
+          lambda { @p.parse!(data, @opt) }.should raise_error(/round 2/)
+        end
+
+        it "incorrect total" do
+          data = <<EXPORT
+No	Name          	Total	1  	2
+
+1 	Duck, Daffy   	1.5  	2:W	2:D
+2 	Mouse, Mickey 	1.0  	1:L	1:D
+EXPORT
+          lambda { @p.parse!(data, @opt) }.should raise_error(/total/)
+        end
+
+
+        it "mismatched results" do
+          data = <<EXPORT
+No	Name          	Total	1  	2
+
+1 	Duck, Daffy   	1.5  	2:W	2:D
+2 	Mouse, Mickey 	0.0  	1:L	1:L
+EXPORT
+          lambda { @p.parse!(data, @opt) }.should raise_error(/result/)
+        end
+
+        it "invalid attribute, title for example)" do
+          data = <<EXPORT
+No	Name          	Title	Total	1  	2
+
+1 	Duck, Daffy   	mg   	1.5  	2:W	2:D
+2 	Mouse, Mickey 	     	0.5  	1:L	1:D
+EXPORT
+          lambda { @p.parse!(data, @opt) }.should raise_error(/title/)
+        end
+      end
+
+      context "Gonzaga Challengers 2010 file" do
+        before(:each) do
+          @p = ICU::Tournament::SPExport.new
+          @t = @p.parse_file(samples + 'gonzaga_challengers_2010.txt', :name => "Gonzaga Chess Classic 2010 Challengers Section", :start => "2010-01-29")
+          @s = open(samples + 'gonzaga_challengers_2010.txt') { |f| f.read }
+        end
+
+        it "should parse and have the right basic details" do
+          @p.error.should be_nil
+          @t.spx_signature.should == "Gonzaga Chess Classic 2010 Challengers Section|6|2010-01-29|56"
+        end
+
+        it "should have correct details for selected players" do
+          @t.player(2).spx_signature.should  == "Mullooly, Neil M.|6438|6.0|123456|WWWWWW|------|TTTTTT" # winner
+          @t.player(4).spx_signature.should  == "Gallagher, Mark|12138|4.0|123456|WLWWWL|------|FTTTTT"  # had one bye
+          @t.player(45).spx_signature.should == "Catre, Loredan||3.5|123456|WDLWLW|------|FTTTFT"        # had two byes
+          @t.player(56).spx_signature.should == "McDonnell, Cathal||0.0|123456|LLLLLL|------|FFFFFF"     # last, all defaults
+        end
+
+        it "should have consistent ranks" do
+          @t.players.map{ |p| p.rank }.sort.join('').should == (1..@t.players.size).to_a.join('')
+        end
+      end
+    end
+  end
+end