ico-validator 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 36c0f4c596aaf1ecaeecad864c17577ee5bcb604
-  data.tar.gz: bc26e9492611e8185559900a8cc753ce560fc6a7
+  metadata.gz: 5ead1e5ad457e39c8f075ae5517185fda8bf6601
+  data.tar.gz: 8e5050a516d388ebf8ff8b5ff571bc23ea2dd26a
 SHA512:
-  metadata.gz: af15cfac13cbd03c1effaa3e57e78f8c8f8ba21aa444d0baf7ef54ae38188992f0aa6fd85740818f3bc26e0e5601a1686443af9507c9bf86ca8c335a293c6174
-  data.tar.gz: a69703830b510511847d69872394ad57fa70df20c02839238ce2f8702a8251b9ed96bf79f5207c23fd16c56b5ae5b058f73237dc7e20dee3234b755ed1e2bea0
+  metadata.gz: d96806fd286e25538b8201b173936139ab50c353709abf0326a67518f058d75c27d24de2e2012906ec06b10bc3c00b88c02fc85237acb4f465352dc7514994b8
+  data.tar.gz: d6929d6f7d1e3f6f1076d31c7e4dc8915718b20ce57fa0407641183aeafe31b3f2de181b0872be52396fc1522307c13948e8015e5b667078386ae35ac73cedbc

data/Gemfile

@@ -1,9 +1,4 @@
 source 'https://rubygems.org'
 
-group :test, :development do
-  gem 'rails'
-  gem 'jasmine'
-end
-
 # Specify your gem's dependencies in ico_validator.gemspec
 gemspec

data/README.md

@@ -8,33 +8,55 @@ ico-validator
 
 
 
-Rails validator for format of [Czech company identification number - ICO](http://cs.wikipedia.org/wiki/Identifika%C4%8Dn%C3%AD_%C4%8D%C3%ADslo_osoby)
+Ruby validator for format of [Czech company identification number - ICO](http://cs.wikipedia.org/wiki/Identifika%C4%8Dn%C3%AD_%C4%8D%C3%ADslo_osoby)
+
+**Contains:**
+
+1. Standalone ruby validator
+2. Rails ActiveModel::EachValidator
+3. JS validator
+
+**What is validated:**
+
+1. ICO length - must be exactly 8 characters
+2. ICO must contain only numbers
+3. ICO number must satisfy [last digit control formula ](http://www.cssz.cz/cz/e-podani/pro-vyvojare/definice-druhu-e-podani/p-o/logicke-testy-datove-vety.htm)
 
 ## Usage
-ICO validator is implemented as ActiveModel::EachValidator so for validation just add `ico: true` parameter to your attribute validation. If validation doesn't pass it adds `:invalid_format` error on validated attribute.
+### Ruby validator
+Ruby validator is one simple module with only one public method `IcoValidation.valid_ico?` which returns true or false.
 
-### Full Example
 ```ruby
-attr_accessor :ico
-validates :ico,
-  ico: true
+require 'ico_validator'
+
+IcoValidation.valid_ico?('12345678') # invalid ico
+=> false
+
+IcoValidation.valid_ico?('27169278')
+=> true
 
 ```
 
+### Rails validator
+Rails validator is implemented as [ActiveModel::EachValidator](http://api.rubyonrails.org/classes/ActiveModel/Validator.html). So it's easy to use within your AR models:
+
+```ruby
+class Company < ActiveRecord::Base
+  validates :ico, ico: true
+end
+```
+If validation doesn't pass it adds `:invalid_format` error on validated attribute.
+
 ### JS validation
+ico-validator is Rails engine, so if you want to validate ico with javascript just add following to application.js
 ```js
-application.js
 //= require ico-validator
 ```
-```ruby
+
+And then on any field you want to be validated with JS:
+```erb
 <%= form_for(...) do |f| %>
   <%= f.text_field :ico, class: 'ico-validate' %>
 <% end %>
 ```
-
-### What is validated
-
-* ICO length - must be exactly 8 characters
-* ICO must contain only numbers
-* ICO number must satisfy [last digit control formula ](http://www.cssz.cz/cz/e-podani/pro-vyvojare/definice-druhu-e-podani/p-o/logicke-testy-datove-vety.htm)
-
+jQuery will bind validations there.

data/app/assets/javascripts/ico-validator.js

@@ -1,11 +1,29 @@
-var ico_validator = {
-  valid_ico: function(value) {
-    return value.length === 8 && value.match(/^\d+$/) && ico_validator.last_number_valid(value);
+var icoValidator = {
+  validIco: function(value) {
+    var $newValue,
+        $remainingDigits,
+        i,
+        j;
+
+    if (value.length === 8) {
+      return value.match(/^\d+$/) && icoValidator.lastNumberValid(value);
+    } else {
+      $remainingDigits = 8 - value.length;
+      $newValue = value;
+      i = 0;
+      j = $remainingDigits;
+      while (i < j) {
+        $newValue = '0' + $newValue;
+        i++;
+      }
+
+      return $newValue.length === 8 && $newValue.match(/^\d+$/) && icoValidator.lastNumberValid($newValue);
+    }
   },
-  last_number_valid: function(value) {
-    return parseInt(value[7], 10) === ico_validator.calculate_valid_last_number(value);
+  lastNumberValid: function(value) {
+    return parseInt(value[value.length - 1], 10) === icoValidator.calculateValidLastNumber(value);
   },
-  calculate_valid_last_number: function(value) {
+  calculateValidLastNumber: function(value) {
     var sum = 0;
     for( var i = 0; i <= 6; i++ ) {
       sum += value[i] * (8 - i);
@@ -26,7 +44,7 @@ jQuery( function($) {
 
   function validate(el) {
     var value = $(el).val();
-    if( value.length <= 0 || ico_validator.valid_ico(value) ) {
+    if( value.length <= 0 || icoValidator.validIco(value) ) {
       $(el).parent().removeClass('field_with_errors').removeClass('error');
     } else {
       $(el).parent().addClass('field_with_errors').addClass('error');

data/circle.yml

@@ -0,0 +1,3 @@
+machine:
+  ruby:
+    version: 2.1.7

data/ico-validator.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'ico-validator'
-  spec.version       = '0.4.0'
+  spec.version       = '0.5.0'
   spec.authors       = ['Premysl Donat']
   spec.email         = ['donat@uol.cz']
   spec.summary       = %q{Rails validator for validating format of czech identification number = IC}
@@ -23,4 +23,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'codeclimate-test-reporter'
+  spec.add_development_dependency 'rails', '~> 4.1'
+  spec.add_development_dependency 'jasmine'
 end

data/spec/javascripts/validator_spec.js

@@ -1,18 +1,21 @@
-describe("ICO validator", function() {
-  var ico_list, i;
-  ico_list = ['61499609', '25275500', '29233011'];
-  for( i in ico_list ) if( ico_list.hasOwnProperty(i) ) {
-    ico_valid = ico_list[i];
-    it("ICO " + ico_valid + " is valid", function() {
-      expect(ico_validator.valid_ico(ico_valid)).toBeTruthy();
-    });
+describe('ICO validator', function() {
+  var icoList, i;
+  icoList = ['61499609', '25275500', '29233011'];
+  for( i in icoList ) {
+    if( icoList.hasOwnProperty(i) ) {
+      var icoValid = icoList[i];
+      it('ICO ' + icoValid + ' is valid', function() {
+        expect(icoValidator.validIco(icoValid)).toBeTruthy();
+      });
+    }
   }
-  ico_list = [null, '', '1', 123, '1111111X', '00000000', '614996097', '123456789'];
-  for( i in ico_list ) if( ico_list.hasOwnProperty(i) ) {
-    ico_invalid = ico_list[i];
-    it("ICO is invalid with value " + ico_invalid, function() {
-      expect(ico_validator.valid_ico(ico_invalid)).toBeFalsy();
-    });
+  icoList = [null, '', '1', 123, '1111111X', '00000000', '614996097', '123456789'];
+  for( i in icoList ) {
+    if( icoList.hasOwnProperty(i) ) {
+      var icoInvalid = icoList[i];
+      it('ICO is invalid with value ' + icoInvalid, function() {
+        expect(icoValidator.validIco(icoInvalid)).toBeFalsy();
+      });
+    }
   }
 });
-

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ico-validator
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Premysl Donat
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-22 00:00:00.000000000 Z
+date: 2016-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -80,6 +80,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.1'
+- !ruby/object:Gem::Dependency
+  name: jasmine
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Rails validator for validating format of czech identification number
   = IC
 email:
@@ -90,13 +118,13 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".hound.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
 - app/assets/javascripts/ico-validator.js
+- circle.yml
 - ico-validator.gemspec
 - lib/ico-validator.rb
 - lib/ico-validator/engine.rb
@@ -130,7 +158,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Rails validator for validating format of czech identification number = IC
@@ -141,4 +169,3 @@ test_files:
 - spec/javascripts/support/jasmine_helper.rb
 - spec/javascripts/validator_spec.js
 - spec/spec_helper.rb
-has_rdoc: 

data/.travis.yml

@@ -1,12 +0,0 @@
-language: ruby
-rvm:
-  - 2.2.1
-  - 2.2.0
-  - 2.1.1
-  - 2.0.0
-script:
-  - bundle exec rspec
-  - bundle exec rake jasmine:ci
-addons:
-  code_climate:
-    repo_token: eebc129fa878929ebbf8f1097a518df71c73bf316dc0ae59eec048f4e3d4fdd6