icinga2 0.7.0.1 → 0.8.1.2

data/lib/icinga2/notifications.rb

@@ -17,6 +17,9 @@ module Icinga2
     #
     def enable_host_notification( host )
 
+      raise ArgumentError.new('only String are allowed') unless( host.is_a?(String) )
+      raise ArgumentError.new('missing host') if( host.size.zero? )
+
       host_notification( name: host, enable_notifications: true )
     end
 
@@ -31,6 +34,9 @@ module Icinga2
     #
     def disable_host_notification( host )
 
+      raise ArgumentError.new('only String are allowed') unless( host.is_a?(String) )
+      raise ArgumentError.new('missing host') if( host.size.zero? )
+
       host_notification( name: host, enable_notifications: false )
     end
 
@@ -45,13 +51,8 @@ module Icinga2
     #
     def enable_service_notification( host )
 
-      if( host.nil? )
-
-        return {
-          status: 404,
-          message: 'missing host name'
-        }
-      end
+      raise ArgumentError.new('only String are allowed') unless( host.is_a?(String) )
+      raise ArgumentError.new('missing host') if( host.size.zero? )
 
       service_notification( name: host, enable_notifications: true )
     end
@@ -67,12 +68,8 @@ module Icinga2
     #
     def disable_service_notification( host )
 
-      if( host.nil? )
-        return {
-          status: 404,
-          message: 'missing host name'
-        }
-      end
+      raise ArgumentError.new('only String are allowed') unless( host.is_a?(String) )
+      raise ArgumentError.new('missing host') if( host.size.zero? )
 
       service_notification( name: host, enable_notifications: false )
     end
@@ -88,24 +85,16 @@ module Icinga2
     #
     # @return [Hash]
     #
-    def enable_hostgroup_notification( params = {} )
+    def enable_hostgroup_notification( params )
 
-      host = params.dig(:host)
-      host_group = params.dig(:host_group)
+      raise ArgumentError.new('only Hash are allowed') unless( params.is_a?(Hash) )
+      raise ArgumentError.new('missing params') if( params.size.zero? )
 
-      if( host.nil? )
-        return {
-          status: 404,
-          message: 'missing host name'
-        }
-      end
+      host       = params.dig(:host)
+      host_group = params.dig(:host_group)
 
-      if( host_group.nil? )
-        return {
-          status: 404,
-          message: 'missing host_group name'
-        }
-      end
+      raise ArgumentError.new('Missing host') if( host.nil? )
+      raise ArgumentError.new('Missing host_group') if( host_group.nil? )
 
       hostgroup_notification( host: host, host_group: host_group, enable_notifications: true )
     end
@@ -121,49 +110,41 @@ module Icinga2
     #
     # @return [Hash]
     #
-    def disable_hostgroup_notification( params = {} )
+    def disable_hostgroup_notification( params )
 
-      host = params.dig(:host)
-      host_group = params.dig(:host_group)
+      raise ArgumentError.new('only Hash are allowed') unless( params.is_a?(Hash) )
+      raise ArgumentError.new('missing params') if( params.size.zero? )
 
-      if( host.nil? )
-        return {
-          status: 404,
-          message: 'missing host name'
-        }
-      end
+      host       = params.dig(:host)
+      host_group = params.dig(:host_group)
 
-      if( host_group.nil? )
-        return {
-          status: 404,
-          message: 'missing host_group name'
-        }
-      end
+      raise ArgumentError.new('Missing host') if( host.nil? )
+      raise ArgumentError.new('Missing host_group') if( host_group.nil? )
 
       hostgroup_notification( host: host, host_group: host_group, enable_notifications: false )
     end
 
     # return all notifications
     #
-    # @param [Hash] params
-    # @option params [String] name
     #
-    # @return [Hash]
+    # @return [Array]
     #
-    def notifications( params = {} )
-
-      name = params.dig(:name)
+    def notifications
 
-      Network.get(         host: name,
-        url: format( '%s/v1/objects/notifications/%s', @icinga_api_url_base, name ),
+      data = Network.api_data(
+        url: format( '%s/objects/notifications', @icinga_api_url_base ),
         headers: @headers,
-        options: @options )
+        options: @options
+      )
 
-    end
+      return data.dig('results') if( data.dig(:status).nil? )
 
+      nil
+    end
 
+    protected
     # function for host notifications
-    # @private
+    # @api protected
     #
     # @param [Hash] params
     # @option params [String] name
@@ -171,7 +152,6 @@ module Icinga2
     #
     # @return [Hash]
     #
-    private
     def host_notification( params = {} )
 
       name          = params.dig(:name)
@@ -183,16 +163,16 @@ module Icinga2
         }
       }
 
-      Network.post(         host: name,
-        url: format( '%s/v1/objects/hosts/%s', @icinga_api_url_base, name ),
+      Network.post(
+        url: format( '%s/objects/hosts/%s', @icinga_api_url_base, name ),
         headers: @headers,
         options: @options,
-        payload: payload )
-
+        payload: payload
+      )
     end
 
     # function for hostgroup notifications
-    # @private
+    # @api protected
     #
     # @param [Hash] params
     # @option params [String] host_group
@@ -200,10 +180,8 @@ module Icinga2
     #
     # @return [Hash]
     #
-    private
     def hostgroup_notification( params = {} )
 
-      host          = params.dig(:host)
       group         = params.dig(:host_group)
       notifications = params.dig(:enable_notifications) || false
 
@@ -214,16 +192,16 @@ module Icinga2
         }
       }
 
-      Network.post(         host: host,
-        url: format( '%s/v1/objects/services', @icinga_api_url_base ),
+      Network.post(
+        url: format( '%s/objects/services', @icinga_api_url_base ),
         headers: @headers,
         options: @options,
-        payload: payload )
-
+        payload: payload
+      )
     end
 
     # function for service notifications
-    # @private
+    # @api protected
     #
     # @param [Hash] params
     # @option params [String] name
@@ -231,7 +209,6 @@ module Icinga2
     #
     # @return [Hash]
     #
-    private
     def service_notification( params = {} )
 
       name          = params.dig(:name)
@@ -244,12 +221,12 @@ module Icinga2
         }
       }
 
-      Network.post(         host: name,
-        url: format( '%s/v1/objects/services', @icinga_api_url_base ),
+      Network.post(
+        url: format( '%s/objects/services', @icinga_api_url_base ),
         headers: @headers,
         options: @options,
-        payload: payload )
-
+        payload: payload
+      )
     end
 
   end

data/lib/icinga2/servicegroups.rb

@@ -9,104 +9,116 @@ module Icinga2
     # add a servicegroup
     #
     # @param [Hash] params
-    # @option params [String] :name servicegroup to create
+    # @option params [String] :service_group servicegroup to create
     # @option params [String] :display_name the displayed name
     #
     # @example
-    #   @icinga.add_servicegroup(name: 'foo', display_name: 'FOO')
+    #   @icinga.add_servicegroup(service_group: 'foo', display_name: 'FOO')
     #
     # @return [Hash] result
     #
-    def add_servicegroup( params = {} )
+    def add_servicegroup( params )
 
-      name = params.dig(:name)
+      raise ArgumentError.new('only Hash are allowed') unless( params.is_a?(Hash) )
+      raise ArgumentError.new('missing params') if( params.size.zero? )
+
+      service_group = params.dig(:service_group)
       display_name = params.dig(:display_name)
 
-      if( name.nil? )
-        return {
-          status: 404,
-          message: 'missing servicegroup name'
-        }
-      end
+      raise ArgumentError.new('Missing service_group') if( service_group.nil? )
+      raise ArgumentError.new('Missing display_name') if( display_name.nil? )
 
       payload = { 'attrs' => { 'display_name' => display_name } }
 
-      Network.put(         host: name,
-        url: format( '%s/v1/objects/servicegroups/%s', @icinga_api_url_base, name ),
+      Network.put(
+        url: format( '%s/objects/servicegroups/%s', @icinga_api_url_base, service_group ),
         headers: @headers,
         options: @options,
-        payload: payload )
-
+        payload: payload
+      )
     end
 
     # delete a servicegroup
     #
     # @param [Hash] params
-    # @option params [String] :name servicegroup to delete
+    # @option params [String] :service_group servicegroup to delete
     #
     # @example
-    #   @icinga.delete_servicegroup(name: 'foo')
+    #   @icinga.delete_servicegroup(service_group: 'foo')
     #
-    # @return [Hash] result
+    # @return [Array] result
     #
-    def delete_servicegroup( params = {} )
+    def delete_servicegroup( params )
 
-      name = params.dig(:name)
+      raise ArgumentError.new('only Hash are allowed') unless( params.is_a?(Hash) )
+      raise ArgumentError.new('missing params') if( params.size.zero? )
 
-      if( name.nil? )
-        return {
-          status: 404,
-          message: 'missing servicegroup name'
-        }
-      end
+      service_group = params.dig(:service_group)
 
-      Network.delete(         host: name,
-        url: format( '%s/v1/objects/servicegroups/%s?cascade=1', @icinga_api_url_base, name ),
-        headers: @headers,
-        options: @options )
+      raise ArgumentError.new('Missing service_group') if( service_group.nil? )
 
+      Network.delete(
+        url: format( '%s/objects/servicegroups/%s?cascade=1', @icinga_api_url_base, service_group ),
+        headers: @headers,
+        options: @options
+      )
     end
 
     # returns all servicegroups
     #
     # @param [Hash] params
-    # @option params [String] :name ('') optional for a single servicegroup
+    # @option params [String] :service_group ('') optional for a single servicegroup
     #
     # @example to get all users
     #    @icinga.servicegroups
     #
     # @example to get one user
-    #    @icinga.servicegroups(name: 'disk')
+    #    @icinga.servicegroups(service_group: 'disk')
     #
-    # @return [Hash] returns a hash with all servicegroups
+    # @return [Array] returns a hash with all servicegroups
     #
     def servicegroups( params = {} )
 
-      name = params.dig(:name)
+      service_group = params.dig(:service_group)
 
-      Network.get(         host: name,
-        url: format( '%s/v1/objects/servicegroups/%s', @icinga_api_url_base, name ),
+      url =
+      if( service_group.nil? )
+        format( '%s/objects/servicegroups'   , @icinga_api_url_base )
+      else
+        format( '%s/objects/servicegroups/%s', @icinga_api_url_base, service_group )
+      end
+
+      data = Network.api_data(
+        url: url,
         headers: @headers,
-        options: @options )
+        options: @options
+      )
+
+      return data.dig('results') if( data.dig(:status).nil? )
 
+      nil
     end
 
-    # returns true if the servicegroup exists
+    # checks if the servicegroup exists
     #
-    # @param [String] name the name of the servicegroups
+    # @param [String] service_group the name of the servicegroup
     #
     # @example
     #    @icinga.exists_servicegroup?('disk')
     #
     # @return [Bool] returns true if the servicegroup exists
     #
-    def exists_servicegroup?( name )
-      result = servicegroups( name: name )
+    def exists_servicegroup?( service_group )
+
+      raise ArgumentError.new('only String are allowed') unless( service_group.is_a?(String) )
+      raise ArgumentError.new('Missing service_group') if( service_group.size.zero? )
+
+
+      result = servicegroups( service_group: service_group )
       result = JSON.parse( result ) if  result.is_a?( String )
 
-      status = result.dig(:status)
+      return true if  !result.nil? && result.is_a?(Array)
 
-      return true if  !status.nil? && status == 200
       false
     end
 

data/lib/icinga2/services.rb

@@ -8,19 +8,31 @@ module Icinga2
 
     # add services
     #
-    # @param [String] host
-    # @param [Hash] services
+    # @param [Hash] params
+    # @option params [String] :host
+    # @option params [String] :services
     #
+    # @todo
+    #  this function is not operable
+    #  need help, time or beer
     #
     # @return [Hash]
     #
-    def add_services( host, services = {} )
+    def add_services( params = {} )
+
+      raise ArgumentError.new('only Hash are allowed') unless( params.is_a?(Hash) )
+
+      # TODO
+      puts 'add_services() ToDo'
+
+      host_name = params.dig(:host)
+      services  = params.dig(:services)
 
       services.each do |s,v|
 
         payload = {
           'templates' => [ 'generic-service' ],
-          'attrs'     => update_host( v, host )
+          'attrs'     => update_host( v, host_name )
         }
 
         logger.debug( s )
@@ -28,14 +40,12 @@ module Icinga2
 
         logger.debug( JSON.pretty_generate( payload ) )
 
-        Network.put(           host: host,
-          url: format( '%s/v1/objects/services/%s!%s', @icinga_api_url_base, host, s ),
+        Network.put(
+          url: format( '%s/objects/services/%s!%s', @icinga_api_url_base, host_name, s ),
           headers: @headers,
           options: @options,
-          payload: payload)
-
-        logger.debug( result )
-
+          payload: payload
+        )
       end
 
     end
@@ -45,16 +55,23 @@ module Icinga2
     # @param [Hash] params
     #
     # @todo
-    #  this function are not operable
+    #  this function is not operable
     #  need help, time or beer
     #
     # @return [Nil]
     #
     def unhandled_services( params = {} )
 
+      raise ArgumentError.new('only Hash are allowed') unless( params.is_a?(Hash) )
+
+      # TODO
+      puts 'unhandled_services() ToDo'
+
       # taken from https://blog.netways.de/2016/11/18/icinga-2-api-cheat-sheet/
       # 5) Anzeige aller Services die unhandled sind und weder in Downtime, noch acknowledged sind
-      # /usr/bin/curl -k -s -u 'root:icinga' -H 'X-HTTP-Method-Override: GET' -X POST 'https://127.0.0.1:5665/v1/objects/services' -d '{ "attrs": [ "__name", "state", "downtime_depth", "acknowledgement" ], "filter": "service.state != ServiceOK && service.downtime_depth == 0.0 && service.acknowledgement == 0.0" }''' | jq
+      # /usr/bin/curl -k -s -u 'root:icinga' -H 'X-HTTP-Method-Override: GET' -X POST
+      # 'https://127.0.0.1:5665/objects/services' #
+      # -d '{ "attrs": [ "__name", "state", "downtime_depth", "acknowledgement" ], "filter": "service.state != ServiceOK && service.downtime_depth == 0.0 && service.acknowledgement == 0.0" }''' | jq
 
     end
 
@@ -74,21 +91,27 @@ module Icinga2
     #
     def services( params = {} )
 
-      name    = params.dig(:host)
-      service = params.dig(:service)
+      raise ArgumentError.new('only Hash are allowed') unless( params.is_a?(Hash) )
+
+      host_name = params.dig(:host)
+      service   = params.dig(:service)
 
       url =
       if( service.nil? )
-        format( '%s/v1/objects/services/%s', @icinga_api_url_base, name )
+        format( '%s/objects/services/%s', @icinga_api_url_base, host_name )
       else
-        format( '%s/v1/objects/services/%s!%s', @icinga_api_url_base, name, service )
+        format( '%s/objects/services/%s!%s', @icinga_api_url_base, host_name, service )
       end
 
-      Network.get(         host: name,
+      data = Network.api_data(
         url: url,
         headers: @headers,
-        options: @options )
+        options: @options
+      )
+
+      return data.dig('results') if( data.dig(:status).nil? )
 
+      nil
     end
 
     # returns true if the service exists
@@ -102,23 +125,22 @@ module Icinga2
     #
     # @return [Bool]
     #
-    def exists_service?( params = {} )
+    def exists_service?( params )
+
+      raise ArgumentError.new('only Hash are allowed') unless( params.is_a?(Hash) )
+      raise ArgumentError.new('missing params') if( params.size.zero? )
 
       host    = params.dig(:host)
       service = params.dig(:service)
 
-      if( host.nil? )
-        return {
-          status: 404,
-          message: 'missing host name'
-        }
-      end
+      raise ArgumentError.new('Missing host') if( host.nil? )
+      raise ArgumentError.new('Missing service') if( service.nil? )
 
       result = services( host: host, service: service )
       result = JSON.parse( result ) if  result.is_a?( String )
-      status = result.dig(:status)
 
-      return true if  !status.nil? && status == 200
+      return true if  !result.nil? && result.is_a?(Array)
+
       false
     end
 
@@ -135,7 +157,7 @@ module Icinga2
     # @example
     #    @icinga.service_objects(attrs: ['name', 'state'], joins: ['host.name','host.state'])
     #
-    # @return [Hash]
+    # @return [Array]
     #
     def service_objects( params = {} )
 
@@ -152,47 +174,92 @@ module Icinga2
         joins = ['host.name', 'host.state', 'host.acknowledgement', 'host.downtime_depth', 'host.last_check']
       end
 
-      payload['attrs'] = attrs unless  attrs.nil?
-      payload['filter'] = filter unless  filter.nil?
-      payload['joins'] = joins unless  joins.nil?
+      payload['attrs']  = attrs unless  attrs.nil?
+      payload['filter'] = filter unless filter.nil?
+      payload['joins']  = joins unless  joins.nil?
 
-      Network.get(         host: nil,
-        url: format( '%s/v1/objects/services', @icinga_api_url_base ),
+      data = Network.api_data(
+        url: format( '%s/objects/services', @icinga_api_url_base ),
         headers: @headers,
         options: @options,
-        payload: payload )
+        payload: payload
+      )
+
+      status  = data.dig(:status)
+
+      if( status.nil? )
+
+        results = data.dig('results')
+
+        unless( results.nil? )
+
+          all_services = results.clone
+
+          unless( all_services.nil? )
 
+            @services_all              = all_services.size
+            @services_problems         = count_problems(results)
+            @services_handled_warning  = count_problems(results, Icinga2::SERVICE_STATE_WARNING)
+            @services_handled_critical = count_problems(results, Icinga2::SERVICE_STATE_CRITICAL)
+            @services_handled_unknown  = count_problems(results, Icinga2::SERVICE_STATE_UNKNOWN)
+          end
+        end
+      end
+
+      results
+    end
+
+    # returns adjusted service state
+    #
+    # @example
+    #    @icinga.cib_data
+    #    @icinga.service_objects
+    #    warning, critical, unknown = @icinga.services_adjusted.values
+    #
+    #    s = @icinga.services_adjusted
+    #    unknown = s.dig(:unknown)
+    #
+    # @return [Hash]
+    #    * warning
+    #    * critical
+    #    * unknown
+    #
+    def services_adjusted
+
+      service_warning          = @services_warning.nil?          ? 0 : @services_warning
+      service_critical         = @services_critical.nil?         ? 0 : @services_critical
+      service_unknown          = @services_unknown.nil?          ? 0 : @services_unknown
+      service_handled_warning  = @services_handled_warning.nil?  ? 0 : @services_handled_warning
+      service_handled_critical = @services_handled_critical.nil? ? 0 : @services_handled_critical
+      service_handled_unknown  = @services_handled_unknown.nil?  ? 0 : @services_handled_unknown
+
+      # calculate service problems adjusted by handled problems
+      service_adjusted_warning  = service_warning  - service_handled_warning
+      service_adjusted_critical = service_critical - service_handled_critical
+      service_adjusted_unknown  = service_unknown  - service_handled_unknown
+
+      {
+        warning: service_adjusted_warning.to_i,
+        critical: service_adjusted_critical.to_i,
+        unknown: service_adjusted_unknown.to_i
+      }
     end
 
     # return count of services with problems
     #
     # @example
-    #    @icinga.service_problems
+    #    @icinga.count_services_with_problems
     #
     # @return [Integer]
     #
-    def service_problems
-
-      data     = service_objects
-      problems = 0
-
-      data = JSON.parse(data) if  data.is_a?(String)
-      nodes = data.dig(:nodes)
+    def count_services_with_problems
 
-      unless( nodes.nil? )
+      service_data = service_objects
+      service_data = JSON.parse(service_data) if service_data.is_a?(String)
 
-        nodes.each do |n|
-          attrs           = n.last.dig('attrs')
-          state           = attrs.dig('state')           || 0
-          downtime_depth  = attrs.dig('downtime_depth')  || 0
-          acknowledgement = attrs.dig('acknowledgement') || 0
+      f = service_data.select { |t| t.dig('attrs','state') != 0 && t.dig('attrs','downtime_depth').zero? && t.dig('attrs','acknowledgement').zero? }
 
-          if( state != 0 && downtime_depth.zero? && acknowledgement.zero? )
-            problems += 1
-          end
-        end
-      end
-      problems
+      f.size
     end
 
     # return a list of services with problems
@@ -200,42 +267,45 @@ module Icinga2
     # @param [Integer] max_items numbers of list entries
     #
     # @example
-    #    @icinga.problem_services
+    #    problems, problems_and_severity = @icinga.list_services_with_problems.values
+    #
+    #    l = @icinga.list_services_with_problems
+    #    problems_and_severity = l.dig(:services_with_problems_and_severity)
     #
     # @return [Hash]
+    #    * Array (services_with_problems)
+    #    * Hash  (services_with_problems_and_severity)
     #
-    def problem_services( max_items = 5 )
+    def list_services_with_problems( max_items = 5 )
 
-      service_problems = {}
-      service_problems_severity = {}
+      services_with_problems = {}
+      services_with_problems_and_severity = {}
 
       # only fetch the minimal attribute set required for severity calculation
       services_data = service_objects
-
-      if( services_data.is_a?(String) )
-        services_data = JSON.parse( services_data )
-      end
-
-      services_data = services_data.dig(:nodes)
+      services_data = JSON.parse( services_data ) if services_data.is_a?(String)
 
       unless( services_data.nil? )
 
-        services_data.each do |_service,v|
+        services_data.each do |s,_v|
 
-          name  = v.dig('name')
-          state = v.dig('attrs','state')
+          name  = s.dig('name')
+          state = s.dig('attrs','state')
           next if  state.zero?
 
-          service_problems[name] = service_severity(v)
+          services_with_problems[name] = service_severity(s)
         end
 
-        if( service_problems.count != 0 )
-          service_problems.sort.reverse!
-          service_problems = service_problems.keys[1..max_items].each { |k,_v| service_problems_severity[k] = service_problems[k] }
+        if( services_with_problems.count != 0 )
+          services_with_problems.sort.reverse!
+          services_with_problems = services_with_problems.keys[1..max_items].each { |k,_v| services_with_problems_and_severity[k] = services_with_problems[k] }
         end
       end
 
-      [service_problems, service_problems_severity]
+      {
+        services_with_problems: services_with_problems,
+        services_with_problems_and_severity: services_with_problems_and_severity
+      }
     end
 
     # update host
@@ -268,23 +338,83 @@ module Icinga2
       hash
     end
 
+    # returns a counter of all services
+    #
+    # @example
+    #    @icinga.cib_data
+    #    @icinga.service_objects
+    #    @icinga.services_all
+    #
+    # @return [Integer]
+    #
+    def services_all
+      @services_all
+    end
+
+    # returns data with service problems they be handled (acknowledged or in downtime)
+    #
+    # @example
+    #    @icinga.cib_data
+    #    @icinga.service_objects
+    #    all, critical, warning, unknown = @icinga.service_problems_handled.values
+    #
+    #    p = @icinga.service_problems_handled
+    #    warning = p.dig(:warning)
+    #
+    # @return [Hash]
+    #    * all
+    #    * critical
+    #    * warning
+    #    * unknown
+    #
+    def service_problems_handled
+
+      problems_all      = @services_handled.nil?          ? 0 : @services_handled
+      problems_critical = @services_handled_critical.nil? ? 0 : @services_handled_critical
+      problems_warning  = @services_handled_warning.nil?  ? 0 : @services_handled_warning
+      problems_unknown  = @services_handled_unknown.nil?  ? 0 : @services_handled_unknown
+
+      {
+        all: problems_all.to_i,
+        critical: problems_critical.to_i,
+        warning: problems_warning.to_i,
+        unknown: problems_unknown.to_i
+      }
+
+#      [problems_all,problems_critical,problems_warning,problems_unknown]
+    end
+
+    protected
     # calculate a service severity
     #
     # stolen from Icinga Web 2
     # ./modules/monitoring/library/Monitoring/Backend/Ido/Query/ServicestatusQuery.php
     #
-    # @param [Hash] service
+    # @param [Hash] params
+    # @option params [hash] attrs ()
+    #   * state [Float]
+    #   * acknowledgement [Float] (default: 0)
+    #   * downtime_depth [Float] (default: 0)
     #
-    # @private
+    # @api protected
     #
-    # @return [Hash]
+    # @example
+    #   service_severity( {'attrs' => { 'state' => 0.0, 'acknowledgement' => 0.0, 'downtime_depth' => 0.0 } } )
     #
-    def service_severity(service)
+    # @return [Integer]
+    #
+    def service_severity( params )
+
+      raise ArgumentError.new('only Hash are allowed') unless( params.is_a?(Hash) )
+      raise ArgumentError.new('missing params') if( params.size.zero? )
+
+      state           = params.dig('attrs','state')
+      acknowledgement = params.dig('attrs','acknowledgement') || 0
+      downtime_depth  = params.dig('attrs','downtime_depth')  || 0
 
-      attrs           = service.dig('attrs')
-      state           = attrs.dig('state')
-      acknowledgement = attrs.dig('acknowledgement') || 0
-      downtime_depth  = attrs.dig('downtime_depth')  || 0
+      raise ArgumentError.new('only Float for state are allowed') unless( state.is_a?(Float) )
+      raise ArgumentError.new('only Float for acknowledgement are allowed') unless( acknowledgement.is_a?(Float) )
+      raise ArgumentError.new('only Float for downtime_depth are allowed') unless( downtime_depth.is_a?(Float) )
 
       severity = 0
 
@@ -297,7 +427,7 @@ module Icinga2
           4
         end
 
-      severity += 16 if object_has_been_checked?(service)
+      severity += 16 if object_has_been_checked?(params)
 
       unless state.zero?
 
@@ -311,7 +441,7 @@ module Icinga2
           end
 
         # requires joins
-        host_attrs = service.dig('joins','host')
+        host_attrs = params.dig('joins','host')
         host_state           = host_attrs.dig('state')
         host_acknowledgement = host_attrs.dig('acknowledgement')
         host_downtime_depth  = host_attrs.dig('downtime_depth')