ice_nine 0.3.0 → 0.4.0

data/Gemfile

@@ -10,7 +10,7 @@ group :metrics do
   gem 'flay',            '~> 1.4.3'
   gem 'flog',            '~> 2.5.3'
   gem 'map',             '~> 5.4.0'
-  gem 'reek',            '~> 1.2.8', :git => 'git://github.com/dkubb/reek.git'
+  gem 'reek',            '~> 1.2.8', :github => 'dkubb/reek'
   gem 'roodi',           '~> 2.1.0'
   gem 'tailor',          '~> 0.1.5'
   gem 'yardstick',       '~> 0.4.0'

data/config/site.reek

@@ -11,7 +11,7 @@ LargeClass:
   max_methods: 1
   exclude: []
   enabled: true
-  max_instance_variables: 0
+  max_instance_variables: 1
 UncommunicativeMethodName:
   accept: []
   exclude: []

data/lib/ice_nine.rb

@@ -37,6 +37,7 @@ module IceNine
   #
   # @api public
   def self.deep_freeze(object)
+    return object if object.frozen?
     RecursionGuard.guard(object.object_id) do
       Freezer[object.class].deep_freeze(object)
     end

data/lib/ice_nine/freezer.rb

@@ -8,6 +8,14 @@ module IceNine
     # Configure const_get and const_defined? to not search ancestors
     SKIP_ANCESTORS = (RUBY_VERSION < '1.9' ? [] : [false]).freeze
 
+    # Cache the Freezer classes returned for each type
+    @freezer_cache = Hash.new do |cache, mod|
+      mod.ancestors.each do |ancestor|
+        freezer = find(ancestor.name.to_s)
+        break cache[mod] = freezer if freezer
+      end
+    end
+
     # Look up the Freezer descendant by object type
     #
     # @example
@@ -19,10 +27,7 @@ module IceNine
     #
     # @api public
     def self.[](mod)
-      mod.ancestors.each do |ancestor|
-        freezer = find(ancestor.name.to_s)
-        return freezer if freezer
-      end
+      @freezer_cache[mod]
     end
 
     # Find a Freezer descendant by name

data/lib/ice_nine/version.rb

@@ -3,6 +3,6 @@
 module IceNine
 
   # Current gem version
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 
 end # module IceNine

data/spec/unit/ice_nine/class_methods/deep_freeze_spec.rb

@@ -13,15 +13,35 @@ describe IceNine, '.deep_freeze' do
     value.instance_eval { @a = '1' }
   end
 
-  it 'returns the object' do
-    should be(value)
-  end
+  context 'when the object is not frozen' do
+    it 'returns the object' do
+      should be(value)
+    end
+
+    it 'freezes the object' do
+      expect { subject }.should change(value, :frozen?).from(false).to(true)
+    end
 
-  it 'freezes the object' do
-    expect { subject }.should change(value, :frozen?).from(false).to(true)
+    it 'freezes the instance variables in the Object' do
+      subject.instance_variable_get(:@a).should be_frozen
+    end
   end
 
-  it 'freezes the instance variables in the Object' do
-    subject.instance_variable_get(:@a).should be_frozen
+  context 'when the object is frozen' do
+    before do
+      value.freeze
+    end
+
+    it 'returns the object' do
+      should be(value)
+    end
+
+    it 'does not freeze the object' do
+      expect { subject }.should_not change(value, :frozen?).from(true)
+    end
+
+    it 'does not freeze the instance variables in the Object' do
+      subject.instance_variable_get(:@a).should_not be_frozen
+    end
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: ice_nine
 version: !ruby/object:Gem::Version 
-  hash: 19
+  hash: 15
   prerelease: 
   segments: 
   - 0
-  - 3
+  - 4
   - 0
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors: 
 - Dan Kubb
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-03-29 00:00:00 Z
+date: 2012-04-01 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rake