icanhazpdf 0.0.4.1 → 0.0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1d55a40bcefdecf4596c1f85eae4f36e3f649d3d
-  data.tar.gz: 5bdbcccf09813d2fc47e8abfcb7fede9b1170695
+  metadata.gz: 29d92c7f6514403cf7f58a68e1a41f6782da51a5
+  data.tar.gz: 644f4818c62cf2cbd40b74f2f06bcd03ea68a5d2
 SHA512:
-  metadata.gz: 656a9f9e8f9271bcb20be75c1ad7700d0db9963329716b543a6344dbfa47558b5cb68e323adf32caed751c5694e9480f6ba37ea85e6b313bfc2f8ce5ef45684c
-  data.tar.gz: 2b064d01fd2a1d2c7fd2cb0a9edf53ab77fa975cfe38027dcddafc419a9867886c9a2d689b2de32846b3c6f8851d668dfdf3eb76a0cfa06c8ec02aa042db22d2
+  metadata.gz: 2fb4be6777b2a15d9bbedc61142e316fa3bb361b10e31438bf7fa825da838c16c15d0547468ed06ef07dc835bffced5b00115d624cb92b07a98f5ca3d6bc6441
+  data.tar.gz: b8c7b365ef97751200cf79b36d21e086b88c17adb700ca4eaa627630a4db9b8f7fc9259c5f9e65cbef0ea6c089c9d4db00f98c8cbdf80a3defe2214569ce4592

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    icanhazpdf (0.0.4)
+    icanhazpdf (0.0.4.1)
       activesupport (~> 4.0)
       httparty (~> 0.13)
 

data/README.md

@@ -5,7 +5,17 @@ Makes using the icanhazpdf service in a Rails app simples
 
 Add this line to your application's Gemfile:
 
-    gem 'icanhazpdf', '~> 0.0.3'
+    gem 'icanhazpdf', '~> 0.0.4'
+
+## Rails configuration
+
+You can configure some aspects of the client in your rails environment config
+
+    config.icanhazpdf_api_key = 'this needs to be configured to your api key'
+    config.icanhazpdf_url = 'http://use.this.to.override.the.service/endpoint'
+
+if you dont override the service (and why would you?) it will hit the default
+icanhazpdf service
 
 ## Client
 
@@ -40,6 +50,7 @@ To render a pdf using a previous response from the Client use:
     class MyController < ApplicationController
       include Icanhazpdf::Controller::Renderer
 
+
       def my_action
         pdf_response = Icanhazpdf::Client.new.pdf_from_url my_resource_url(resource)
 
@@ -49,6 +60,14 @@ To render a pdf using a previous response from the Client use:
       end
     end
 
+## PDF Engine
+
+By default ICanHazPdf uses phantomjs to generate pdfs. You can also now choose to
+use wkhtmltopdf. To enable this you need to pass this option into the client or controller
+request. e.g.
+
+    pdf_response = Icanhazpdf::Client.new.pdf_from_url my_resource_url(resource), true
+
 ## Authentication
 
 Checks the current request being made is coming from the icanhazpdf service and

data/lib/icanhazpdf/client.rb

@@ -27,7 +27,7 @@ module Icanhazpdf
       rescue
         service_url = Icanhazpdf::Client.default_service_url
       end
-      encoded_url = "#{service_url}?url=#{URI.encode(uri.to_s).gsub(':', '%3A').gsub('/', '%2F').gsub('?', '%3F').gsub('=', '%3D')}"
+      encoded_url = "#{service_url}?url=#{URI.encode(uri.to_s).gsub(':', '%3A').gsub('/', '%2F').gsub('?', '%3F').gsub('=', '%3D').gsub('&', '%26')}"
       encoded_url += "&use_wkhtmltopdf=true" if use_wkhtmltopdf
       HTTParty.get(encoded_url, :timeout => 10000)
     end

data/lib/icanhazpdf/version.rb

@@ -1,3 +1,3 @@
 module Icanhazpdf
-  VERSION = "0.0.4.1"
+  VERSION = "0.0.4.2"
 end

data/spec/lib/icanhazpdf/client_spec.rb

@@ -3,7 +3,7 @@ require 'httparty'
 
 describe 'Icanhazpdf::Client' do
 
-  let(:a_url) { "http://a.url.to/generate_a_pdf_from?with=querystring" }
+  let(:a_url) { "http://a.url.to/generate_a_pdf_from?with=querystring&language=english" }
   subject { Icanhazpdf::Client.new }
 
   describe 'generating a pdf from' do
@@ -33,7 +33,7 @@ describe 'Icanhazpdf::Client' do
       end
 
       it 'url encodes the address of the page to create a pdf from' do
-        expect(HTTParty).to receive(:get).with(include("http%3A%2F%2Fa.url.to%2Fgenerate_a_pdf_from%3Fwith%3Dquerystring"), be_an(Hash))
+        expect(HTTParty).to receive(:get).with(include("http%3A%2F%2Fa.url.to%2Fgenerate_a_pdf_from%3Fwith%3Dquerystring%26language%3Denglish"), be_an(Hash))
         @result = subject.pdf_from_url a_url
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: icanhazpdf
 version: !ruby/object:Gem::Version
-  version: 0.0.4.1
+  version: 0.0.4.2
 platform: ruby
 authors:
 - Nic Pillinger
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-07 00:00:00.000000000 Z
+date: 2014-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler