icalendar 2.12.2 → 2.12.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ad06e861392ab70f0e800ac4f2a6b81f019aaf3548a35e513f02bcc975968b86
-  data.tar.gz: 16562bdeae817fc8afd4e0b6de7090a42c0b095cb56640d5b9183cfb3a07bb74
+  metadata.gz: 6a9a656fd81bc80eb43cf61e14d95a3b582f66bae80417da16a7e5d621910581
+  data.tar.gz: df88f0f0a1619dbdcba157316aba616019d146fe74e46aba6d7603dc30b40c26
 SHA512:
-  metadata.gz: 927cd1536b413039b75f4c2a100ca169bb17897c10754b4806762d341aaa4b7800fc93e7bc81566681a678a853fefc0d54fad5fdd0316c10f0245f91864d2faf
-  data.tar.gz: 5d9c09347062a5dd73ad23cd75905c5508b8a72ce0447241ee282fa6bbcc7d259e4a26309fc90af718f14f14b18ca78403bc849898b42147c5368ae6edb21d13
+  metadata.gz: a0ad4eb07a4123fba9260916530046bd008a9f076a26a276f09a31cce789aa0801a38fff3d553b7b11fcb3de072c72aff758921ad601d7e643b808495425b0df
+  data.tar.gz: 06bab135b068613fdf8c4d10554a327a35b2072eb5e37c5e7bc7509b8e62b05e596153cfa8985065b2739e99eb7bc90dd8282c173972929900aa763d58e218b1

data/.github/workflows/main.yml

@@ -22,9 +22,10 @@ jobs:
           - 3.2
           - 3.3
           - 3.4
+          - "4.0"
 
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 ## Unreleased
 
+## 2.12.4 - 2026-07-31
+- TEXT unescape fix - Vincent Gao
+
+## 2.12.3 - 2026-05-13
+- Memory use optimization - Jared Menard
+- Run CI against Ruby 4.0 - Artem Chubchenko
+
 ## 2.12.2 - 2026-03-21
 - Fix a potential property injection issue through escaping control characters in URI values - Wes Ring
 

data/benchmarks/memory_per_event_ical.rb

@@ -0,0 +1,27 @@
+require 'memory_profiler'
+require 'icalendar'
+
+# Profiles the per-event calendar wrapping pattern:
+#   cal = Icalendar::Calendar.new
+#   ical_event.parent&.timezones&.each { |tz| cal.add_timezone tz }
+#   cal.add_event(ical_event)
+#   cal.to_ical
+
+cal_string = File.read(File.join(__dir__, '..', 'spec/fixtures/timezone.ics'))
+source_calendar = Icalendar::Calendar.parse(cal_string).first
+events = source_calendar.events
+
+ITERATIONS = 1000
+
+report = MemoryProfiler.report do
+  ITERATIONS.times do
+    events.each do |ical_event|
+      cal = Icalendar::Calendar.new
+      ical_event.parent&.timezones&.each { |tz| cal.add_timezone tz }
+      cal.add_event(ical_event)
+      cal.to_ical
+    end
+  end
+end
+
+report.pretty_print(scale_bytes: true, top: 20)

data/icalendar.gemspec

@@ -37,7 +37,7 @@ ActiveSupport is required for TimeWithZone support, but not required for general
   s.add_dependency 'ostruct'
 
   s.add_development_dependency 'rake', '~> 13.0'
-  s.add_development_dependency 'bundler', '~> 2.0'
+  s.add_development_dependency 'bundler'
 
   # test with all groups of tzinfo dependencies
   # tzinfo 2.x

data/lib/icalendar/has_properties.rb

@@ -172,13 +172,11 @@ module Icalendar
     private
 
     def map_property_value(value, klass, multi_valued, new_property)
-      params = {}
-      if new_property
-        params.merge!('VALUE': klass.value_type)
-      end
-      if value.nil? || value.is_a?(Icalendar::Value)
-        value
-      elsif value.is_a? ::Array
+      return value if value.nil? || value.is_a?(Icalendar::Value)
+      
+      params = new_property ? {'VALUE': klass.value_type} : {}
+        
+      if value.is_a? ::Array
         Icalendar::Values::Helpers::Array.new value, klass, params, {delimiter: (multi_valued ? ',' : ';')}
       else
         klass.new value, params

data/lib/icalendar/values/text.rb

@@ -3,11 +3,11 @@
 module Icalendar
   module Values
     class Text < Value
+      UNESCAPE_GSUB_REGEX = /\\([\\,;nN])/.freeze
+
       def initialize(value, *args)
-        value = value.gsub('\n', "\n")
-        value.gsub!('\,', ',')
-        value.gsub!('\;', ';')
-        value.gsub!('\\\\') { '\\' }
+        # One left-to-right pass keeps unescape the exact inverse of value_ical; \n and \N are newline.
+        value = value.gsub(UNESCAPE_GSUB_REGEX) { |_| %w[n N].include?($1) ? "\n" : $1 }
         super value, *args
       end
 

data/lib/icalendar/version.rb

@@ -2,6 +2,6 @@
 
 module Icalendar
 
-  VERSION = '2.12.2'
+  VERSION = '2.12.4'
 
 end

data/spec/values/text_spec.rb

@@ -30,6 +30,39 @@ describe Icalendar::Values::Text do
     end
   end
 
+  describe 'unescape is the exact inverse of value_ical' do
+    bs = "\\"
+    {
+      'a literal backslash before n (windows path)' => ["C:#{bs}#{bs}next", "C:#{bs}next"],
+      'a UNC path with several backslashes'         => ["#{bs * 4}srv#{bs * 2}sh", "#{bs * 2}srv#{bs}sh"],
+      'an escaped backslash alone'                  => ["a#{bs}#{bs}b", "a#{bs}b"],
+      'an escaped comma'                            => ["a#{bs},b", 'a,b'],
+      'an escaped semicolon'                        => ["a#{bs};b", 'a;b'],
+      'a lowercase newline escape'                  => ["a#{bs}nb", "a\nb"],
+      'plain text without backslashes'              => ['plain summary text', 'plain summary text'],
+    }.each do |desc, (onwire, content)|
+      context "given #{desc}" do
+        subject { described_class.new onwire.dup }
+
+        it 'decodes to the original content' do
+          expect(subject.value).to eq content
+        end
+
+        it 'round-trips back to the on-wire form' do
+          expect(subject.value_ical).to eq onwire
+        end
+      end
+    end
+
+    it 'decodes a capital-N newline escape (RFC 5545 3.3.11)' do
+      expect(described_class.new("a#{bs}Nb").value).to eq "a\nb"
+    end
+
+    it 'leaves a backslash before a non-escape char untouched' do
+      expect(described_class.new("a#{bs}:b").value).to eq "a#{bs}:b"
+    end
+  end
+
   describe 'escapes parameter text properly' do
     subject { described_class.new escaped, {'param' => param_value} }
     context 'single value, no special characters' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: icalendar
 version: !ruby/object:Gem::Version
-  version: 2.12.2
+  version: 2.12.4
 platform: ruby
 authors:
 - Ryan Ahearn
@@ -83,16 +83,16 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -209,6 +209,7 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- benchmarks/memory_per_event_ical.rb
 - icalendar.gemspec
 - lib/icalendar.rb
 - lib/icalendar/alarm.rb
@@ -319,7 +320,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.6
 specification_version: 4
 summary: A ruby implementation of the iCalendar specification (RFC-5545).
 test_files: