icalendar 2.11.1 → 2.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d203d559d0522f82ba0036892eb054a5be722cd6e19af063a85563c9b8357d3b
-  data.tar.gz: 711e78355b4f08581ce8fc6d69d81ac0851e55c50f2931e56bf38344f594c3c8
+  metadata.gz: 9aaf6132f4baffabc0b6a45fb4a1a5049e58b4ca264eddaac67648575e6702c6
+  data.tar.gz: ac0ee8ac873a3a9d97ad8914aa6f2bf3edb545f1d58d0d152988850cce9fca07
 SHA512:
-  metadata.gz: 30825c56f9cabbc358966a315f1678b785013cb3316eaec30c5f91f512746ca7bbdc6384c322d404b67f1d8bcf60b1e9a85ad2b3b9d5b0399c64cc2c4695b718
-  data.tar.gz: 2776f4a9dfb99205c392f1f13d12d281dea120d9626b94341d520c297417f32ca1f5b9a1378ec4edea8e63d2ccfaaf16945cc4cc52bb0901bd869da0f2121e5a
+  metadata.gz: a330a0e6568705cc448eef9090d54c72b59fc78fec537ca715523689b5954875c76e0a16957ec344bce71fcb4b8f1f9e62af7c57591eef49d4682acee431a3e1
+  data.tar.gz: 2f49d14ad8759d16324a04f1472eee65e05fc5a1a9167ab5a93da5e2cdddab11cd8a61bad95718533747f10f7f8bf4b7a664e67e8b743d0cf490a1657f55dcdd

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 ## Unreleased
 
+## 2.12.0 - 2025-09-26
+- Support timezone lookup by Windows names - Ronak Gothi
+
+## 2.11.2 - 2025-06-21
+- Deal with more bad value parameter values by falling back to the property default type
+
 ## 2.11.1 - 2025-06-06
  - Gracefully deal with malformed ics files that use spaces in the value parameter instead of hyphens
 

data/lib/icalendar/offset/windows_to_iana.rb

@@ -0,0 +1,144 @@
+# frozen_string_literal: true
+
+# This module contains mappings from Windows timezone identifiers to Olson timezone identifiers.
+#
+# The data is taken from the unicode consortium [0], the proposal and rationale
+# for this mapping is also available at the unicode consortium [1].
+#
+# [0] https://www.unicode.org/cldr/cldr-aux/charts/29/supplemental/zone_tzid.html
+# [1] https://cldr.unicode.org/development/development-process/design-proposals/extended-windows-olson-zid-mapping
+
+module Icalendar
+  class Offset
+    class WindowsToIana < Offset
+      WINDOWS_TO_IANA = {
+        'AUS Central Standard Time' => 'Australia/Darwin',
+        'AUS Eastern Standard Time' => 'Australia/Sydney',
+        'Afghanistan Standard Time' => 'Asia/Kabul',
+        'Alaskan Standard Time' => 'America/Anchorage',
+        'Arab Standard Time' => 'Asia/Riyadh',
+        'Arabian Standard Time' => 'Asia/Dubai',
+        'Arabic Standard Time' => 'Asia/Baghdad',
+        'Argentina Standard Time' => 'America/Argentina/Buenos_Aires',
+        'Atlantic Standard Time' => 'America/Halifax',
+        'Azerbaijan Standard Time' => 'Asia/Baku',
+        'Azores Standard Time' => 'Atlantic/Azores',
+        'Bahia Standard Time' => 'America/Bahia',
+        'Bangladesh Standard Time' => 'Asia/Dhaka',
+        'Belarus Standard Time' => 'Europe/Minsk',
+        'Canada Central Standard Time' => 'America/Regina',
+        'Cape Verde Standard Time' => 'Atlantic/Cape_Verde',
+        'Caucasus Standard Time' => 'Asia/Yerevan',
+        'Cen. Australia Standard Time' => 'Australia/Adelaide',
+        'Central America Standard Time' => 'America/Guatemala',
+        'Central Asia Standard Time' => 'Asia/Almaty',
+        'Central Brazilian Standard Time' => 'America/Cuiaba',
+        'Central Europe Standard Time' => 'Europe/Budapest',
+        'Central European Standard Time' => 'Europe/Warsaw',
+        'Central Pacific Standard Time' => 'Pacific/Guadalcanal',
+        'Central Standard Time' => 'America/Chicago',
+        'Central Standard Time (Mexico)' => 'America/Mexico_City',
+        'China Standard Time' => 'Asia/Shanghai',
+        'Dateline Standard Time' => 'Etc/GMT+12',
+        'E. Africa Standard Time' => 'Africa/Nairobi',
+        'E. Australia Standard Time' => 'Australia/Brisbane',
+        'E. Europe Standard Time' => 'Europe/Chisinau',
+        'E. South America Standard Time' => 'America/Sao_Paulo',
+        'Eastern Standard Time' => 'America/New_York',
+        'Eastern Standard Time (Mexico)' => 'America/Cancun',
+        'Egypt Standard Time' => 'Africa/Cairo',
+        'Ekaterinburg Standard Time' => 'Asia/Yekaterinburg',
+        'FLE Standard Time' => 'Europe/Kyiv',
+        'Fiji Standard Time' => 'Pacific/Fiji',
+        'GMT Standard Time' => 'Europe/London',
+        'GTB Standard Time' => 'Europe/Bucharest',
+        'Georgian Standard Time' => 'Asia/Tbilisi',
+        'Greenland Standard Time' => 'America/Nuuk',
+        'Greenwich Standard Time' => 'Atlantic/Reykjavik',
+        'Hawaiian Standard Time' => 'Pacific/Honolulu',
+        'India Standard Time' => 'Asia/Kolkata',
+        'Iran Standard Time' => 'Asia/Tehran',
+        'Israel Standard Time' => 'Asia/Jerusalem',
+        'Jordan Standard Time' => 'Asia/Amman',
+        'Kaliningrad Standard Time' => 'Europe/Kaliningrad',
+        'Korea Standard Time' => 'Asia/Seoul',
+        'Libya Standard Time' => 'Africa/Tripoli',
+        'Line Islands Standard Time' => 'Pacific/Kiritimati',
+        'Magadan Standard Time' => 'Asia/Magadan',
+        'Mauritius Standard Time' => 'Indian/Mauritius',
+        'Middle East Standard Time' => 'Asia/Beirut',
+        'Montevideo Standard Time' => 'America/Montevideo',
+        'Morocco Standard Time' => 'Africa/Casablanca',
+        'Mountain Standard Time' => 'America/Denver',
+        'Mountain Standard Time (Mexico)' => 'America/Chihuahua',
+        'Myanmar Standard Time' => 'Asia/Yangon',
+        'N. Central Asia Standard Time' => 'Asia/Novosibirsk',
+        'Namibia Standard Time' => 'Africa/Windhoek',
+        'Nepal Standard Time' => 'Asia/Kathmandu',
+        'New Zealand Standard Time' => 'Pacific/Auckland',
+        'Newfoundland Standard Time' => 'America/St_Johns',
+        'North Asia East Standard Time' => 'Asia/Irkutsk',
+        'North Asia Standard Time' => 'Asia/Krasnoyarsk',
+        'North Korea Standard Time' => 'Asia/Pyongyang',
+        'Pacific SA Standard Time' => 'America/Santiago',
+        'Pacific Standard Time' => 'America/Los_Angeles',
+        'Pakistan Standard Time' => 'Asia/Karachi',
+        'Paraguay Standard Time' => 'America/Asuncion',
+        'Romance Standard Time' => 'Europe/Paris',
+        'Russia Time Zone 10' => 'Asia/Srednekolymsk',
+        'Russia Time Zone 11' => 'Asia/Kamchatka',
+        'Russia Time Zone 3' => 'Europe/Samara',
+        'Russian Standard Time' => 'Europe/Moscow',
+        'SA Eastern Standard Time' => 'America/Cayenne',
+        'SA Pacific Standard Time' => 'America/Bogota',
+        'SA Western Standard Time' => 'America/La_Paz',
+        'SE Asia Standard Time' => 'Asia/Bangkok',
+        'Samoa Standard Time' => 'Pacific/Apia',
+        'Singapore Standard Time' => 'Asia/Singapore',
+        'South Africa Standard Time' => 'Africa/Johannesburg',
+        'Sri Lanka Standard Time' => 'Asia/Colombo',
+        'Syria Standard Time' => 'Asia/Damascus',
+        'Taipei Standard Time' => 'Asia/Taipei',
+        'Tasmania Standard Time' => 'Australia/Hobart',
+        'Tokyo Standard Time' => 'Asia/Tokyo',
+        'Tonga Standard Time' => 'Pacific/Tongatapu',
+        'Turkey Standard Time' => 'Europe/Istanbul',
+        'US Eastern Standard Time' => 'America/Indiana/Indianapolis',
+        'US Mountain Standard Time' => 'America/Phoenix',
+        'UTC' => 'Etc/GMT',
+        'UTC+12' => 'Etc/GMT-12',
+        'UTC-02' => 'Etc/GMT+2',
+        'UTC-11' => 'Etc/GMT+11',
+        'Ulaanbaatar Standard Time' => 'Asia/Ulaanbaatar',
+        'Venezuela Standard Time' => 'America/Caracas',
+        'Vladivostok Standard Time' => 'Asia/Vladivostok',
+        'W. Australia Standard Time' => 'Australia/Perth',
+        'W. Central Africa Standard Time' => 'Africa/Lagos',
+        'W. Europe Standard Time' => 'Europe/Berlin',
+        'West Asia Standard Time' => 'Asia/Tashkent',
+        'West Pacific Standard Time' => 'Pacific/Port_Moresby',
+        'Yakutsk Standard Time' => 'Asia/Yakutsk'
+      }.freeze
+
+      def valid?
+        support_classes_defined? && tz
+      end
+
+      def normalized_value
+        Icalendar.logger.debug("Plan a - parsing #{value}/#{tzid} as ActiveSupport::TimeWithZone")
+        # plan a - use ActiveSupport::TimeWithZone
+        Icalendar::Values::Helpers::ActiveSupportTimeWithZoneAdapter.new(nil, tz, value)
+      end
+
+      def normalized_tzid
+        [WINDOWS_TO_IANA[tzid]].compact
+      end
+
+      private
+
+      def tz
+        @tz ||= ActiveSupport::TimeZone[normalized_tzid.first || '']
+      end
+    end
+  end
+end

data/lib/icalendar/offset.rb

@@ -10,6 +10,7 @@ module Icalendar
       [
         Icalendar::Offset::ActiveSupportExact,
         Icalendar::Offset::TimeZoneStore,
+        Icalendar::Offset::WindowsToIana,
         Icalendar::Offset::ActiveSupportPartial,
         Icalendar::Offset::Null
       ].lazy.map { |klass| klass.new(tzid, value, timezone_store) }.detect(&:valid?)
@@ -36,7 +37,8 @@ module Icalendar
   end
 end
 
-require_relative "offset/active_support_exact"
-require_relative "offset/active_support_partial"
-require_relative "offset/null"
-require_relative "offset/time_zone_store"
+require_relative 'offset/active_support_exact'
+require_relative 'offset/active_support_partial'
+require_relative 'offset/null'
+require_relative 'offset/time_zone_store'
+require_relative 'offset/windows_to_iana'

data/lib/icalendar/parser.rb

@@ -113,7 +113,12 @@ module Icalendar
         klass_name = fields[:params].delete('value').first
         unless klass_name.upcase == klass.value_type
           klass_name = "Icalendar::Values::#{klass_name.downcase.gsub(GET_WRAPPER_CLASS_GSUB_REGEX) { |m| m[-1].upcase }}"
-          klass = Object.const_get klass_name if Object.const_defined?(klass_name)
+          begin
+            klass = Object.const_get klass_name if Object.const_defined?(klass_name)
+          rescue NameError => e
+            Icalendar.logger.error "NameError trying to find value type for #{component.name} | #{fields[:name]}: #{e.message}"
+            raise e if strict?
+          end
         end
       end
       klass

data/lib/icalendar/version.rb

@@ -2,6 +2,6 @@
 
 module Icalendar
 
-  VERSION = '2.11.1'
+  VERSION = '2.12.0'
 
 end

data/spec/fixtures/single_event_bad_location.ics

@@ -0,0 +1,23 @@
+BEGIN:VCALENDAR
+VERSION:2.0
+PRODID:bsprodidfortestabc123
+CALSCALE:GREGORIAN
+BEGIN:VEVENT
+DTSTAMP:20050118T211523Z
+UID:bsuidfortestabc123
+DTSTART;TZID=US-Mountain:20050120T170000
+DTEND;TZID=US-Mountain:20050120T184500
+CLASS:PRIVATE
+GEO:37.386013;-122.0829322
+ORGANIZER;CN="Joe Bob: Magician":mailto:joebob@random.net
+LOCATION;VALUE=1000 MAIN ST EXAMPLE, STATE 12345:1000 Main St Example\, State 12345
+PRIORITY:2
+SUMMARY:This is a really long summary to test the method of unfolding lines
+ \, so I'm just going to make it a whole bunch of lines. With a twist: a "
+ ö" takes up multiple bytes\, and should be wrapped to the next line.
+ATTACH:http://bush.sucks.org/impeach/him.rhtml
+ATTACH:http://corporations-dominate.existence.net/why.rhtml
+RDATE;TZID=US-Mountain:20050121T170000,20050122T170000
+X-TEST-COMPONENT;QTEST="Hello, World":Shouldn't double double quotes
+END:VEVENT
+END:VCALENDAR

data/spec/parser_spec.rb

@@ -116,4 +116,14 @@ describe Icalendar::Parser do
       expect(event.dtstart).to be_kind_of Icalendar::Values::Date
     end
   end
+
+  describe 'completely bad location value' do
+    let(:fn) { 'single_event_bad_location.ics' }
+
+    it 'falls back to string type for location' do
+      event = subject.parse.first.events.first
+      expect(event.location).to be_kind_of Icalendar::Values::Text
+      expect(event.location.value).to eq "1000 Main St Example, State 12345"
+    end
+  end
 end

data/spec/values/date_time_spec.rb

@@ -17,7 +17,7 @@ describe Icalendar::Values::DateTime do
         expect(subject.value_ical).to eq value
       end
 
-      context 'local time' do
+      context 'tzid in IANA format' do
         let(:value) { '20140209T160652' }
         let(:params) { {'tzid' => 'America/Denver'} }
 
@@ -28,14 +28,15 @@ describe Icalendar::Values::DateTime do
         end
       end
 
-      context 'nonstandard format tzid local time' do
+      context 'tzid with partial match' do
         let(:value) { '20230901T230404' }
-        let(:params) { {'tzid' => 'Singapore Standard Time'} }
+        let(:params) { { 'tzid' => 'Singapore Time' } }
 
         it 'parses the value as local time' do
           expect(subject.value.hour).to eq 23
-          expect(subject.value.utc_offset).to eq 28800
+          expect(subject.value.utc_offset).to eq 28_800
           expect(subject.value.utc.hour).to eq 15
+          expect(subject.value.utc.minute).to eq 04
         end
 
         it 'updates the tzid' do
@@ -43,8 +44,24 @@ describe Icalendar::Values::DateTime do
           expect(subject.ical_params['tzid']).to eq ['Asia/Singapore']
         end
       end
-    end
 
+      context 'tzid in windows format' do
+        let(:value) { '20230901T230404' }
+        let(:params) { { 'tzid' => 'India Standard Time' } }
+
+        it 'parses the value as local time' do
+          expect(subject.value.hour).to eq 23
+          expect(subject.value.utc_offset).to eq 19_800
+          expect(subject.value.utc.hour).to eq 17
+          expect(subject.value.utc.minute).to eq 34
+        end
+
+        it 'updates the tzid' do
+          # use an array because that's how output from the parser will end up
+          expect(subject.ical_params['tzid']).to eq ['Asia/Kolkata']
+        end
+      end
+    end
   else
 
     context 'without ActiveSupport' do
@@ -63,10 +80,8 @@ describe Icalendar::Values::DateTime do
         end
       end
     end
-
   end
 
-
   context 'common tests' do
     it 'does not add any tzid parameter to output' do
       expect(subject.to_ical described_class).to eq ":#{value}"

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: icalendar
 version: !ruby/object:Gem::Version
-  version: 2.11.1
+  version: 2.12.0
 platform: ruby
 authors:
 - Ryan Ahearn
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-06-06 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: base64
@@ -228,6 +227,7 @@ files:
 - lib/icalendar/offset/active_support_partial.rb
 - lib/icalendar/offset/null.rb
 - lib/icalendar/offset/time_zone_store.rb
+- lib/icalendar/offset/windows_to_iana.rb
 - lib/icalendar/parser.rb
 - lib/icalendar/timezone.rb
 - lib/icalendar/timezone_store.rb
@@ -267,6 +267,7 @@ files:
 - spec/fixtures/single_event.ics
 - spec/fixtures/single_event_bad_dtstart.ics
 - spec/fixtures/single_event_bad_line.ics
+- spec/fixtures/single_event_bad_location.ics
 - spec/fixtures/single_event_bad_organizer.ics
 - spec/fixtures/single_event_organizer_parsed.ics
 - spec/fixtures/timezone.ics
@@ -316,8 +317,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.27
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: A ruby implementation of the iCalendar specification (RFC-5545).
 test_files:
@@ -335,6 +335,7 @@ test_files:
 - spec/fixtures/single_event.ics
 - spec/fixtures/single_event_bad_dtstart.ics
 - spec/fixtures/single_event_bad_line.ics
+- spec/fixtures/single_event_bad_location.ics
 - spec/fixtures/single_event_bad_organizer.ics
 - spec/fixtures/single_event_organizer_parsed.ics
 - spec/fixtures/timezone.ics