icalendar 2.11.0 → 2.11.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8a3ae780c56015cbd4ff657ce042c086038f2f922069fa40eaaeaeedd3b7144c
-  data.tar.gz: 88d669f06da7a9b91c3c8a92dd08e11e70b8712a2c4b05a752427abc1ed56435
+  metadata.gz: 0d1b88e3b63c6a6c5865093d45c296bfc4f0d807922b79bbd071355f5bdf72a2
+  data.tar.gz: 2b0e5e61d9dbab1ec76aab2a97bf3055da0ee42bfcb294867e1cba5d60841d17
 SHA512:
-  metadata.gz: 250a5156dbb7f7ec7cd7f9fddd51982676d81b5a41ae2815c85b41f3f114e3b3c812c07794463d3563f85a93d8097075a19bb7d37b2ca4694682cc8804ff9be7
-  data.tar.gz: 11c71867043fd1fd94cc6199e470b9ff4ce55c7c5e2455d0435b46676b4017743cec130de8f5383faf66eee4e28a400b6b807bf76eb1c781fd47604b7276a4c5
+  metadata.gz: 070602bed48d0b45c04dc6801944b0f2d8916a67ecc39194ff93a5bc6619aca5eafad06843cb39df72910f9babbe010310dcada5bce1a27d046297586a0d1042
+  data.tar.gz: f4e43c98d659fa97b4cffadb0c79ba34ef0ba077d181272747eaf0065301d1b540a3fa5169dcd8d1701a60076f1f748ec8d28a44d1aefaf179197437ecab2958

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 ## Unreleased
 
+## 2.11.2 - 2025-06-21
+- Deal with more bad value parameter values by falling back to the property default type
+
+## 2.11.1 - 2025-06-06
+ - Gracefully deal with malformed ics files that use spaces in the value parameter instead of hyphens
+
 ## 2.11.0 - 2025-04-12
  - Require gems for ruby 3.4 that used to be in stdlib - Go Sueyoshi
  - Refactor how timezone offsets are calculated - Pat Allan

data/lib/icalendar/parser.rb

@@ -105,7 +105,7 @@ module Icalendar
         ((multi_property && value =~ WRAP_IN_ARRAY_REGEX_1) || value =~ WRAP_IN_ARRAY_REGEX_2)
     end
 
-    GET_WRAPPER_CLASS_GSUB_REGEX = /(?:\A|-)(.)/.freeze
+    GET_WRAPPER_CLASS_GSUB_REGEX = /(?:\A|-|\s+)(.)/.freeze
 
     def get_wrapper_class(component, fields)
       klass = component.class.default_property_types[fields[:name]]
@@ -113,7 +113,12 @@ module Icalendar
         klass_name = fields[:params].delete('value').first
         unless klass_name.upcase == klass.value_type
           klass_name = "Icalendar::Values::#{klass_name.downcase.gsub(GET_WRAPPER_CLASS_GSUB_REGEX) { |m| m[-1].upcase }}"
-          klass = Object.const_get klass_name if Object.const_defined?(klass_name)
+          begin
+            klass = Object.const_get klass_name if Object.const_defined?(klass_name)
+          rescue NameError => e
+            Icalendar.logger.error "NameError trying to find value type for #{component.name} | #{fields[:name]}: #{e.message}"
+            raise e if strict?
+          end
         end
       end
       klass

data/lib/icalendar/version.rb

@@ -2,6 +2,6 @@
 
 module Icalendar
 
-  VERSION = '2.11.0'
+  VERSION = '2.11.2'
 
 end

data/spec/fixtures/single_event_bad_location.ics

@@ -0,0 +1,23 @@
+BEGIN:VCALENDAR
+VERSION:2.0
+PRODID:bsprodidfortestabc123
+CALSCALE:GREGORIAN
+BEGIN:VEVENT
+DTSTAMP:20050118T211523Z
+UID:bsuidfortestabc123
+DTSTART;TZID=US-Mountain:20050120T170000
+DTEND;TZID=US-Mountain:20050120T184500
+CLASS:PRIVATE
+GEO:37.386013;-122.0829322
+ORGANIZER;CN="Joe Bob: Magician":mailto:joebob@random.net
+LOCATION;VALUE=1000 MAIN ST EXAMPLE, STATE 12345:1000 Main St Example\, State 12345
+PRIORITY:2
+SUMMARY:This is a really long summary to test the method of unfolding lines
+ \, so I'm just going to make it a whole bunch of lines. With a twist: a "
+ ö" takes up multiple bytes\, and should be wrapped to the next line.
+ATTACH:http://bush.sucks.org/impeach/him.rhtml
+ATTACH:http://corporations-dominate.existence.net/why.rhtml
+RDATE;TZID=US-Mountain:20050121T170000,20050122T170000
+X-TEST-COMPONENT;QTEST="Hello, World":Shouldn't double double quotes
+END:VEVENT
+END:VCALENDAR

data/spec/fixtures/two_time_events.ics

@@ -38,7 +38,7 @@ SEQUENCE:13
 BEGIN:VALARM
 X-WR-ALARMUID:6F54CD66-F2A9-491D-8892-7E3209F6A2E4
 UID:6F54CD66-F2A9-491D-8892-7E3209F6A2E4
-TRIGGER;VALUE=DATE-TIME:19760401T005545Z
+TRIGGER;VALUE=DATE TIME:19760401T005545Z
 ACTION:NONE
 END:VALARM
 END:VEVENT

data/spec/parser_spec.rb

@@ -116,4 +116,14 @@ describe Icalendar::Parser do
       expect(event.dtstart).to be_kind_of Icalendar::Values::Date
     end
   end
+
+  describe 'completely bad location value' do
+    let(:fn) { 'single_event_bad_location.ics' }
+
+    it 'falls back to string type for location' do
+      event = subject.parse.first.events.first
+      expect(event.location).to be_kind_of Icalendar::Values::Text
+      expect(event.location.value).to eq "1000 Main St Example, State 12345"
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: icalendar
 version: !ruby/object:Gem::Version
-  version: 2.11.0
+  version: 2.11.2
 platform: ruby
 authors:
 - Ryan Ahearn
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-04-12 00:00:00.000000000 Z
+date: 2025-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: base64
@@ -267,6 +267,7 @@ files:
 - spec/fixtures/single_event.ics
 - spec/fixtures/single_event_bad_dtstart.ics
 - spec/fixtures/single_event_bad_line.ics
+- spec/fixtures/single_event_bad_location.ics
 - spec/fixtures/single_event_bad_organizer.ics
 - spec/fixtures/single_event_organizer_parsed.ics
 - spec/fixtures/timezone.ics
@@ -335,6 +336,7 @@ test_files:
 - spec/fixtures/single_event.ics
 - spec/fixtures/single_event_bad_dtstart.ics
 - spec/fixtures/single_event_bad_line.ics
+- spec/fixtures/single_event_bad_location.ics
 - spec/fixtures/single_event_bad_organizer.ics
 - spec/fixtures/single_event_organizer_parsed.ics
 - spec/fixtures/timezone.ics