icalendar 2.10.0 → 2.10.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4a4c654b36ffe5a09f521ad3c012686f12e582ba5d380242c646334f47153360
-  data.tar.gz: 184399a11e6e8a39b18ceeef59de8a9b9f7cd581f0c7169cce5c7dca63575e3b
+  metadata.gz: 25be453368a5f3878e1914626da23ed5116c8e7835f60bf67c2cf0d87f6766dc
+  data.tar.gz: 00163247da24fc8057dcd4e1955f72a709ad3fd668526e35af17004232d4b173
 SHA512:
-  metadata.gz: 61837b5d19193d80d72f37edff89290fc2e5ffa0c6b9ee500036de58b0fbd9aacb5e0e9bc9f1a0a4e1ce7a3ad494ed0147e87bf697b54523d8b799e9eaa275fa
-  data.tar.gz: 00d54cc0ab4b7fc6acf616a537b426d110ddbe65dda1d6ab8ec938ba2df64e87def99023916c6193ab25d1885a2a60e8a1706617ed5a6e0adb5cb34671dae1ec
+  metadata.gz: d812eaf1f48875019ce982e7c6fc9ce900a1dccd315ae072867d62407ff8a13fbb0b2dae9e7c0c9b83870e1630fc5c63c09a4d0812eb539f7c8ffb799d5656b1
+  data.tar.gz: dcadb2f20833a329b0e4b3845ec2cf41c5b415f739cb34489f8987837892280b888f328dc3e07c6c2aeff6bc5cf5b1db24a9e061993b2868a51cf89444e037e2

data/.github/workflows/main.yml

@@ -15,11 +15,12 @@ jobs:
     runs-on: ubuntu-latest
 
     strategy:
+      fail-fast: false
       matrix:
         ruby:
-          - 3.0.6
-          - 3.1.4
-          - 3.2.2
+          - 3.1.6
+          - 3.2.4
+          - 3.3.4
 
     steps:
     - uses: actions/checkout@v4

data/CHANGELOG.md

@@ -0,0 +1,206 @@
+## Unreleased
+
+## 2.10.2 - 2024-07-21
+ - Raise Icalendar::Parser::ParseError on bad .ics file input instead of RuntimeError - Micah Geisel
+ - Remove Ruby 3.0 from the test matrix - still should work for now with ice_cube < 0.17.0
+ - Add Ruby 3.3 to the test matrix
+ - Move from old History.txt file to modern CHANGELOG.md - Guillaume Briday
+
+## 2.10.1 - 2023-12-01
+ - Parsing now handles VTIMEZONE blocks defined after their TZID is used in events and other components
+
+## 2.10.0 - 2023-11-01
+ - Add changelog metadata to gemspec - Juri Hahn
+ - Attempt to rescue timezone info when given a nonstandard tzid with no VTIMEZONE
+ - Move Values classes that shouldn't be directly used into Helpers module
+
+## 2.9.0 - 2023-08-11
+ - Always include the VALUE of Event URLs for improved compatibility - Sean Kelley
+ - Improved parse performance - Thomas Cannon
+ - Add helper methods for other Calendar method verbs
+ - bugfix: Require stringio before use in Parser - vwyu
+
+## 2.8.0 - 2022-07-10
+ - Fix compatibility with ActiveSupport 7 - Pat Allan
+ - Set default action of "DISPLAY" on alarms - Rikson
+ - Add license information to gemspec - Robert Reiz
+ - Support RFC7986 properties - Daniele Frisanco
+
+## 2.7.1 - 2021-03-14
+ - Recover from bad line-wrapping code that splits in the middle of Unicode code points
+ - Add a verbose option to the Parser to quiet some of the chattier log entries
+
+## 2.7.0 - 2020-09-12
+ - Handle custom component names, with and without X- prefix
+ - Fix Component lookup to avoid namespace collisions
+
+## 2.6.1 - 2019-12-07
+ - Improve performance when generating large ICS files - Alex Balhatchet
+
+## 2.6.0 - 2019-11-26
+ - Improve performance for calculating timezone offsets - Justin Howard
+ - Make it possible to de/serialize with Marshal - Pawel Niewiadomski
+ - Avoid FrozenError when running with frozen_string_literal
+ - Update minimum Ruby version to supported versions
+
+## 2.5.3 - 2019-03-04
+ - Improve parsing performance - nehresma
+ - Support tzinfo 2.0 - Misty De Meo
+
+## 2.5.2 - 2018-12-08
+ - Remove usage of the global TimezoneStore instance, in favor of a local variable in the parser
+ - Deprecate TimezoneStore class methods
+
+## 2.5.1 - 2018-10-30
+ - Fix usage without ActiveSupport installed.
+
+## 2.5.0 - 2018-09-10
+ - Set timezone information from VTIMEZONE components in cases that ActiveSupport can't figure it out (or isn't installed)
+ - Prevent rewinding the Parser IO input during parsing - Niels Laukens
+ - Update tested/supported ruby versions & documentation updates.
+
+## 2.4.1 - 2016-09-03
+ - Fix parsing multiple calendars or components in same file - Patrick Schnetger
+ - Fix multi-byte folding bug - Niels Laukens
+ - Fix typos across the code - Martin Edenhofer & yuuji.yaginuma
+
+## 2.4.0 - 2016-07-04
+ - Enable parsing individual ICalendar components - Patrick Schnetger
+ - many bug fixes. Thanks to Quan Sun, Garry Shutler, Ryan Bigg, Patrick Schnetger and others
+ - README/documentation updates. Thanks to JonMidhir and Hendrik Sollich
+
+## 2.3.0 - 2015-04-26
+ - fix value parameter for properties with multiple values
+ - fix error when assigning Icalendar::Values::Array to a component
+ - Fall back to Icalendar::Values::Date if Icalendar::Values::DateTime is not given a properly formatted value
+ - Downcase the keys in ical_params to ensure we aren't assigning both tzid and TZID
+
+## 2.2.2 - 2014-12-27
+ - add a `has_#{component}?` method for testing if component exists - John Hope
+ - add documentation & tests for organizer attribute - Ben Walding
+
+## 2.2.1 - 2014-12-03
+ - Prevent crashes when using ActiveSupport::TimeWithZone in multi-property DateTime fields - Danny (tdg5)
+ - Ensure TimeWithZone is loaded before using, not just ActiveSupport - Jeremy Evans
+ - Improve error message on unparseable DateTimes - Garry Shutler
+
+## 2.2.0 - 2014-09-23
+ - Default to non-strict parsing
+ - Enable sorting events by dtstart - Mark Rickert
+ - Better tolerate malformed lines in parser - Garry Shutler
+ - Deduplicate timezone code - Jan Vlnas
+ - Eliminate warnings - rochefort
+
+## 2.1.2 - 2014-09-10
+ - Fix timezone abbreviation generation - Jan Vlnas
+ - Fix timezone repeat rules for end of month
+
+## 2.1.1 - 2014-07-23
+ - Quiet TimeWithZone support logging
+ - Use SecureRandom.uuid - antoinelyset
+
+## 2.1.0 - 2014-06-17
+ - Enable parsing all custom properties, not just X- prefixed ones
+   Requires non-strict parsing
+ - Fixed bugs when using non-MRI ruby interpreters
+ - Fix bug copying OpenStruct-backed value types
+
+## 2.0.1 - 2014-04-27
+ - Re-add support for ruby 1.9.2
+
+## 2.0.0 - 2014-04-22
+ - Add Icalendar.logger class & logging in Parser
+ - Support tzinfo ~> 0.3 and ~> 1.1
+
+## 2.0.0.beta.2 - 2014-04-11
+ - Add uid & acknowledged fields from valarm extensions
+ - Swallow NoMethodError on non-strict parsers
+ - Expose a parse_property method on Icalendar::Parser
+
+## 2.0.0.beta.1 - 2014-03-30
+ - Rewrite for easier development going forward.
+
+## 1.5.2 - 2014-02-22
+ - Output timezone components first
+ - Fix undefined local variable or method 'e' - Jason Stirk
+
+## 1.5.1 - 2014-02-27
+ - Check for dtend existence before setting timezone - Jonas Grau
+ - Clean up and refactor components - Kasper Timm Hansen
+
+## 1.5.0 - 2013-12-06
+ - Support for custom x- properties - Jake Craige
+
+## 1.4.5 - 2013-11-14
+ - Fix Geo accessor methods - bouzuya
+ - Add ical_multiline_property :related_to for Alarm
+ - Allow using multi setters to append single values
+
+## 1.4.4 - 2013-11-05
+ - Allow user to handle TZInfo::AmbiguousTime error - David Bradford
+ - Better handling of multiple exdate and rdate values
+
+## 1.4.3 - 2013-09-18
+ - Fix concatenation of multiple BYWEEK or BYMONTH recurrence rules
+
+## 1.4.2 - 2013-09-11
+ - Double Quote parameter values that contain forbidden characters
+ - Update Component#respond_to? to match Ruby 2.0 - Keith Marcum
+
+## 1.4.1 - 2013-06-25
+ - Don't escape semicolon in GEO property - temirov
+ - Allow access to various parts of RRule class
+
+## 1.4.0 - 2013-05-21
+ - Implement ACKNOWLEDGED property for VALARM - tsuzuki08
+ - Output VERSION property as first line after BEGIN:VCALENDAR
+ - Check for unbounded timezone transitions in tzinfo
+
+## 1.3.0 - 2013-03-31
+ - Lenient parsing mode ignores unknown properties - David Grandinetti
+ - VTIMEZONE positive offsets properly have "+" prepended (Fixed issue
+#18) - Benjamin Jorgensen (sorry for misspelling your last name)
+
+## 1.2.4 - 2013-03-26
+ - Proxy component values now frozen in Ruby 2.0 (Fixed issue #17)
+ - Clean up gemspec for cleaner installing via bundler/git
+
+## 1.2.3 - 2013-03-09
+ - Call `super` from Component#method_missing
+ - Clean up warnings in test suite
+ - Add Gemfile for installing development dependencies
+
+## 1.2.2 - 2013-02-16
+ - added TZURL property to Timezone component - spacepixels
+ - correct days in RRule ("[TU,WE]" -> "TU,WE") - Christoph Finkensiep
+
+## 1.2.1 - 2012-11-12
+ - Adds uid property to alarms to support iCloud - Jeroen Jacobs
+ - Fix up testing docs - Eric Carty-Fickes
+ - Fix parsing property params that have : in them - Sean Dague
+ - Clean up warnings in test suite - Sean Dague
+
+## 1.2.0 - 2012-08-30
+* Fix calendar handling for dates < 1000 - Ryan Ahearn
+* Updated license to GPL/BSD/Ruby at users option
+
+## 1.1.6 - 2011-03-10
+* Fix todo handling (thanks to Frank Schwarz)
+* clean up a number of warnings during test runs
+
+## 1.1.5 - 2010-06-21
+* Fix for windows line endings (thanks to Rowan Collins)
+
+## 1.1.4 - 2010-04-23
+* Fix for RRULE escaping
+* Fix tests so they run under 1.8.7 in multiple environments
+* Readme fix
+
+## 1.1.3 - 2010-03-15
+* Revert component sorting behavior that I was trying to make
+the tests run more consistantly on different platforms.
+* Added new test for multiple events in a calendar which caught that break.
+
+## 1.1.2 - 2010-03-10
+
+* Convert project to newgem to make for easier publishing

data/README.md

@@ -1,7 +1,7 @@
 iCalendar -- Internet calendaring, Ruby style
 ===
 
-[![Build Status](https://travis-ci.com/icalendar/icalendar.svg?branch=master)](https://travis-ci.com/icalendar/icalendar)
+[![Ruby](https://github.com/icalendar/icalendar/actions/workflows/main.yml/badge.svg)](https://github.com/icalendar/icalendar/actions/workflows/main.yml)
 [![Code Climate](https://codeclimate.com/github/icalendar/icalendar.png)](https://codeclimate.com/github/icalendar/icalendar)
 
 <http://github.com/icalendar/icalendar>

data/icalendar.gemspec

@@ -21,7 +21,7 @@ ActiveSupport is required for TimeWithZone support, but not required for general
   EOM
 
   s.metadata = {
-    'changelog_uri' => 'https://github.com/icalendar/icalendar/blob/main/History.txt'
+    'changelog_uri' => 'https://github.com/icalendar/icalendar/blob/main/CHANGELOG.md'
   }
 
   s.files = `git ls-files`.split "\n"
@@ -38,13 +38,13 @@ ActiveSupport is required for TimeWithZone support, but not required for general
 
   # test with all groups of tzinfo dependencies
   # tzinfo 2.x
-  # s.add_development_dependency 'tzinfo', '~> 2.0'
-  # s.add_development_dependency 'tzinfo-data', '~> 1.2020'
-  # tzinfo 1.x
-  s.add_development_dependency 'activesupport', '~> 6.0'
-  s.add_development_dependency 'i18n', '~> 1.8'
-  s.add_development_dependency 'tzinfo', '~> 1.2'
+  s.add_development_dependency 'activesupport', '~> 7.1'
+  s.add_development_dependency 'tzinfo', '~> 2.0'
   s.add_development_dependency 'tzinfo-data', '~> 1.2020'
+  # tzinfo 1.x
+  # s.add_development_dependency 'activesupport', '~> 6.0'
+  # s.add_development_dependency 'tzinfo', '~> 1.2'
+  # s.add_development_dependency 'tzinfo-data', '~> 1.2020'
   # tzinfo 0.x
   # s.add_development_dependency 'tzinfo', '~> 0.3'
   # end tzinfo
@@ -52,4 +52,5 @@ ActiveSupport is required for TimeWithZone support, but not required for general
   s.add_development_dependency 'timecop', '~> 0.9'
   s.add_development_dependency 'rspec', '~> 3.8'
   s.add_development_dependency 'simplecov', '~> 0.16'
+  s.add_development_dependency 'byebug'
 end

data/lib/icalendar/parser.rb

@@ -197,7 +197,7 @@ module Icalendar
         value = parts[:value]
       else
         parts = BAD_LINE_REGEX.match(input) unless strict?
-        parts or fail "Invalid iCalendar input line: #{input}"
+        parts or fail ParseError, "Invalid iCalendar input line: #{input}"
         # Non-strict and bad line so use a value of empty string
         value = ''
       end
@@ -211,7 +211,7 @@ module Icalendar
             param_value = param_value.gsub(PVALUE_GSUB_REGEX, '')
             params[param_name] << param_value
             if param_name == 'tzid'
-              params['x-tz-info'] = timezone_store.retrieve param_value
+              params['x-tz-store'] = timezone_store
             end
           end
         end
@@ -227,5 +227,8 @@ module Icalendar
         value: value
       }
     end
+
+    class ParseError < RuntimeError
+    end
   end
 end

data/lib/icalendar/timezone.rb

@@ -108,15 +108,17 @@ module Icalendar
 
     def standard_for(local)
       possible = standards.map do |std|
-        [std.previous_occurrence(local.to_time), std]
-      end
+        prev = std.previous_occurrence(local.to_time)
+        [prev, std] unless prev.nil?
+      end.compact
       possible.sort_by(&:first).last
     end
 
     def daylight_for(local)
       possible = daylights.map do |day|
-        [day.previous_occurrence(local.to_time), day]
-      end
+        prev = day.previous_occurrence(local.to_time)
+        [prev, day] unless prev.nil?
+      end.compact
       possible.sort_by(&:first).last
     end
   end

data/lib/icalendar/values/date.rb

@@ -10,7 +10,7 @@ module Icalendar
 
       def initialize(value, params = {})
         params.delete 'tzid'
-        params.delete 'x-tz-info'
+        params.delete 'x-tz-store'
         if value.is_a? String
           begin
             parsed_date = ::Date.strptime(value, FORMAT)

data/lib/icalendar/values/helpers/time_with_zone.rb

@@ -20,22 +20,45 @@ module Icalendar
   module Values
     module Helpers
       module TimeWithZone
-        attr_reader :tz_utc
+        attr_reader :tz_utc, :timezone_store
 
         def initialize(value, params = {})
           params = Icalendar::DowncasedHash(params)
           @tz_utc = params['tzid'] == 'UTC'
-          x_tz_info = params.delete 'x-tz-info'
+          @timezone_store = params.delete 'x-tz-store'
+          super (offset_value(value, params) || value), params
+        end
+
+        def __getobj__
+          orig_value = super
+          if set_offset?
+            orig_value
+          else
+            offset = offset_value(orig_value, ical_params)
+            __setobj__(offset) unless offset.nil?
+            offset || orig_value
+          end
+        end
 
-          offset_value = unless params['tzid'].nil?
+        def params_ical
+          ical_params.delete 'tzid' if tz_utc
+          super
+        end
+
+        private
+
+        def offset_value(value, params)
+          @offset_value = unless params.nil? || params['tzid'].nil?
             tzid = params['tzid'].is_a?(::Array) ? params['tzid'].first : params['tzid']
             support_classes_defined = defined?(ActiveSupport::TimeZone) && defined?(ActiveSupportTimeWithZoneAdapter)
             if support_classes_defined && (tz = ActiveSupport::TimeZone[tzid])
+              Icalendar.logger.debug("Plan a - parsing #{value}/#{tzid} as ActiveSupport::TimeWithZone")
               # plan a - use ActiveSupport::TimeWithZone
               ActiveSupportTimeWithZoneAdapter.new(nil, tz, value)
-            elsif !x_tz_info.nil?
+            elsif !timezone_store.nil? && !(x_tz_info = timezone_store.retrieve(tzid)).nil?
               # plan b - use definition from provided `VTIMEZONE`
               offset = x_tz_info.offset_for_local(value).to_s
+              Icalendar.logger.debug("Plan b - parsing #{value} with offset: #{offset}")
               if value.respond_to?(:change)
                 value.change offset: offset
               else
@@ -43,17 +66,19 @@ module Icalendar
               end
             elsif support_classes_defined && (tz = ActiveSupport::TimeZone[tzid.split.first])
               # plan c - try to find an ActiveSupport::TimeWithZone based on the first word of the tzid
+              Icalendar.logger.debug("Plan c - parsing #{value}/#{tz.tzinfo.name} as ActiveSupport::TimeWithZone")
               params['tzid'] = [tz.tzinfo.name]
               ActiveSupportTimeWithZoneAdapter.new(nil, tz, value)
+            else
+              # plan d - just ignore the tzid
+              Icalendar.logger.info("Ignoring timezone #{tzid} for time #{value}")
+              nil
             end
-            # plan d - just ignore the tzid
           end
-          super((offset_value || value), params)
         end
 
-        def params_ical
-          ical_params.delete 'tzid' if tz_utc
-          super
+        def set_offset?
+          !!@offset_value
         end
       end
     end

data/lib/icalendar/version.rb

@@ -2,6 +2,6 @@
 
 module Icalendar
 
-  VERSION = '2.10.0'
+  VERSION = '2.10.2'
 
 end

data/spec/fixtures/reversed_timezone.ics

@@ -0,0 +1,143 @@
+BEGIN:VCALENDAR
+VERSION:2.0
+X-WR-CALNAME:My Calendar
+X-APPLE-CALENDAR-COLOR:#44A703
+BEGIN:VEVENT
+CREATED:20231026T211915Z
+DTEND;TZID=NONSTANDARDTZ:20231025T180000
+DTSTAMP:20231026T211916Z
+DTSTART;TZID=NONSTANDARDTZ:20231025T163000
+LAST-MODIFIED:20231026T211915Z
+LOCATION:Somewhere
+SEQUENCE:0
+SUMMARY:Summary summary summary
+UID:some-unique-uid
+END:VEVENT
+BEGIN:VTIMEZONE
+TZID:NONSTANDARDTZ
+X-LIC-LOCATION:NONSTANDARDTZ
+BEGIN:STANDARD
+DTSTART:18831118T120702
+RDATE:18831118T120702
+TZNAME:PST
+TZOFFSETFROM:-075258
+TZOFFSETTO:-0800
+END:STANDARD
+BEGIN:DAYLIGHT
+DTSTART:19180331T020000
+RRULE:FREQ=YEARLY;UNTIL=19190330T100000Z;BYMONTH=3;BYDAY=-1SU
+TZNAME:PDT
+TZOFFSETFROM:-0800
+TZOFFSETTO:-0700
+END:DAYLIGHT
+BEGIN:STANDARD
+DTSTART:19181027T020000
+RRULE:FREQ=YEARLY;UNTIL=19191026T090000Z;BYMONTH=10;BYDAY=-1SU
+TZNAME:PST
+TZOFFSETFROM:-0700
+TZOFFSETTO:-0800
+END:STANDARD
+BEGIN:DAYLIGHT
+DTSTART:19420209T020000
+RDATE:19420209T020000
+TZNAME:PWT
+TZOFFSETFROM:-0800
+TZOFFSETTO:-0700
+END:DAYLIGHT
+BEGIN:DAYLIGHT
+DTSTART:19450814T160000
+RDATE:19450814T160000
+TZNAME:PPT
+TZOFFSETFROM:-0700
+TZOFFSETTO:-0700
+END:DAYLIGHT
+BEGIN:STANDARD
+DTSTART:19450930T020000
+RDATE:19450930T020000
+RDATE:19490101T020000
+TZNAME:PST
+TZOFFSETFROM:-0700
+TZOFFSETTO:-0800
+END:STANDARD
+BEGIN:STANDARD
+DTSTART:19460101T000000
+RDATE:19460101T000000
+RDATE:19670101T000000
+TZNAME:PST
+TZOFFSETFROM:-0800
+TZOFFSETTO:-0800
+END:STANDARD
+BEGIN:DAYLIGHT
+DTSTART:19480314T020100
+RDATE:19480314T020100
+RDATE:19740106T020000
+RDATE:19750223T020000
+TZNAME:PDT
+TZOFFSETFROM:-0800
+TZOFFSETTO:-0700
+END:DAYLIGHT
+BEGIN:DAYLIGHT
+DTSTART:19500430T010000
+RRULE:FREQ=YEARLY;UNTIL=19660424T090000Z;BYMONTH=4;BYDAY=-1SU
+TZNAME:PDT
+TZOFFSETFROM:-0800
+TZOFFSETTO:-0700
+END:DAYLIGHT
+BEGIN:STANDARD
+DTSTART:19500924T020000
+RRULE:FREQ=YEARLY;UNTIL=19610924T090000Z;BYMONTH=9;BYDAY=-1SU
+TZNAME:PST
+TZOFFSETFROM:-0700
+TZOFFSETTO:-0800
+END:STANDARD
+BEGIN:STANDARD
+DTSTART:19621028T020000
+RRULE:FREQ=YEARLY;UNTIL=19661030T090000Z;BYMONTH=10;BYDAY=-1SU
+TZNAME:PST
+TZOFFSETFROM:-0700
+TZOFFSETTO:-0800
+END:STANDARD
+BEGIN:DAYLIGHT
+DTSTART:19670430T020000
+RRULE:FREQ=YEARLY;UNTIL=19730429T100000Z;BYMONTH=4;BYDAY=-1SU
+TZNAME:PDT
+TZOFFSETFROM:-0800
+TZOFFSETTO:-0700
+END:DAYLIGHT
+BEGIN:STANDARD
+DTSTART:19671029T020000
+RRULE:FREQ=YEARLY;UNTIL=20061029T090000Z;BYMONTH=10;BYDAY=-1SU
+TZNAME:PST
+TZOFFSETFROM:-0700
+TZOFFSETTO:-0800
+END:STANDARD
+BEGIN:DAYLIGHT
+DTSTART:19760425T020000
+RRULE:FREQ=YEARLY;UNTIL=19860427T100000Z;BYMONTH=4;BYDAY=-1SU
+TZNAME:PDT
+TZOFFSETFROM:-0800
+TZOFFSETTO:-0700
+END:DAYLIGHT
+BEGIN:DAYLIGHT
+DTSTART:19870405T020000
+RRULE:FREQ=YEARLY;UNTIL=20060402T100000Z;BYMONTH=4;BYDAY=1SU
+TZNAME:PDT
+TZOFFSETFROM:-0800
+TZOFFSETTO:-0700
+END:DAYLIGHT
+BEGIN:DAYLIGHT
+DTSTART:20070311T020000
+RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=2SU
+TZNAME:PDT
+TZOFFSETFROM:-0800
+TZOFFSETTO:-0700
+END:DAYLIGHT
+BEGIN:STANDARD
+DTSTART:20071104T020000
+RRULE:FREQ=YEARLY;BYMONTH=11;BYDAY=1SU
+TZNAME:PST
+TZOFFSETFROM:-0700
+TZOFFSETTO:-0800
+END:STANDARD
+END:VTIMEZONE
+END:VCALENDAR

data/spec/parser_spec.rb

@@ -5,6 +5,15 @@ describe Icalendar::Parser do
   let(:source) { File.read File.join(File.dirname(__FILE__), 'fixtures', fn) }
 
   describe '#parse' do
+    context 'reversed_timezone.ics' do
+      let(:fn) { 'reversed_timezone.ics' }
+
+      it 'correctly parses the event timezone' do
+        event = subject.parse.first.events.first
+        expect(event.dtstart.utc_offset).to eq -25200
+      end
+    end
+
     context 'single_event.ics' do
       let(:fn) { 'single_event.ics' }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: icalendar
 version: !ruby/object:Gem::Version
-  version: 2.10.0
+  version: 2.10.2
 platform: ruby
 authors:
 - Ryan Ahearn
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-11-01 00:00:00.000000000 Z
+date: 2024-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ice_cube
@@ -58,42 +58,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '7.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.0'
-- !ruby/object:Gem::Dependency
-  name: i18n
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.8'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '7.1'
 - !ruby/object:Gem::Dependency
   name: tzinfo
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: tzinfo-data
   requirement: !ruby/object:Gem::Requirement
@@ -150,6 +136,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.16'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: |
   Implements the iCalendar specification (RFC-5545) in Ruby.  This allows
   for the generation and parsing of .ics files, which are used by a
@@ -163,8 +163,8 @@ files:
 - ".github/workflows/main.yml"
 - ".gitignore"
 - ".rspec"
+- CHANGELOG.md
 - Gemfile
-- History.txt
 - LICENSE
 - README.md
 - Rakefile
@@ -216,6 +216,7 @@ files:
 - spec/fixtures/nondefault_values.ics
 - spec/fixtures/nonstandard.ics
 - spec/fixtures/recurrence.ics
+- spec/fixtures/reversed_timezone.ics
 - spec/fixtures/single_event.ics
 - spec/fixtures/single_event_bad_dtstart.ics
 - spec/fixtures/single_event_bad_line.ics
@@ -248,7 +249,7 @@ licenses:
 - GPL-3.0-only
 - icalendar
 metadata:
-  changelog_uri: https://github.com/icalendar/icalendar/blob/main/History.txt
+  changelog_uri: https://github.com/icalendar/icalendar/blob/main/CHANGELOG.md
 post_install_message: 'ActiveSupport is required for TimeWithZone support, but not
   required for general use.
 
@@ -267,7 +268,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.3.27
 signing_key:
 specification_version: 4
 summary: A ruby implementation of the iCalendar specification (RFC-5545).
@@ -282,6 +283,7 @@ test_files:
 - spec/fixtures/nondefault_values.ics
 - spec/fixtures/nonstandard.ics
 - spec/fixtures/recurrence.ics
+- spec/fixtures/reversed_timezone.ics
 - spec/fixtures/single_event.ics
 - spec/fixtures/single_event_bad_dtstart.ics
 - spec/fixtures/single_event_bad_line.ics

data/History.txt

@@ -1,197 +0,0 @@
-=== Unreleased
-
-=== 2.10.0 2023-11-01
- * Add changelog metadata to gemspec - Juri Hahn
- * Attempt to rescue timezone info when given a nonstandard tzid with no VTIMEZONE
- * Move Values classes that shouldn't be directly used into Helpers module
-
-=== 2.9.0 2023-08-11
- * Always include the VALUE of Event URLs for improved compatibility - Sean Kelley
- * Improved parse performance - Thomas Cannon
- * Add helper methods for other Calendar method verbs
- * bugfix: Require stringio before use in Parser - vwyu
- 
-=== 2.8.0 2022-07-10
- * Fix compatibility with ActiveSupport 7 - Pat Allan
- * Set default action of "DISPLAY" on alarms - Rikson
- * Add license information to gemspec - Robert Reiz
- * Support RFC7986 properties - Daniele Frisanco
-
-=== 2.7.1 2021-03-14
- * Recover from bad line-wrapping code that splits in the middle of Unicode code points
- * Add a verbose option to the Parser to quiet some of the chattier log entries
-
-=== 2.7.0 2020-09-12
- * Handle custom component names, with and without X- prefix
- * Fix Component lookup to avoid namespace collisions
-
-=== 2.6.1 2019-12-07
- * Improve performance when generating large ICS files - Alex Balhatchet
-
-=== 2.6.0 2019-11-26
- * Improve performance for calculating timezone offsets - Justin Howard
- * Make it possible to de/serialize with Marshal - Pawel Niewiadomski
- * Avoid FrozenError when running with frozen_string_literal
- * Update minimum Ruby version to supported versions
-
-=== 2.5.3 2019-03-04
- * Improve parsing performance - nehresma
- * Support tzinfo 2.0 - Misty De Meo
-
-=== 2.5.2 2018-12-08
- * Remove usage of the global TimezoneStore instance, in favor of a local variable in the parser
- * Deprecate TimezoneStore class methods
-
-=== 2.5.1 2018-10-30
- * Fix usage without ActiveSupport installed.
-
-=== 2.5.0 2018-09-10
- * Set timezone information from VTIMEZONE components in cases that ActiveSupport can't figure it out (or isn't installed)
- * Prevent rewinding the Parser IO input during parsing - Niels Laukens
- * Update tested/supported ruby versions & documentation updates.
-
-=== 2.4.1 2016-09-03
- * Fix parsing multiple calendars or components in same file - Patrick Schnetger
- * Fix multi-byte folding bug - Niels Laukens
- * Fix typos across the code - Martin Edenhofer & yuuji.yaginuma
-
-=== 2.4.0 2016-07-04
- * Enable parsing individual ICalendar components - Patrick Schnetger
- * many bug fixes. Thanks to Quan Sun, Garry Shutler, Ryan Bigg, Patrick Schnetger and others
- * README/documentation updates. Thanks to JonMidhir and Hendrik Sollich
-
-=== 2.3.0 2015-04-26
- * fix value parameter for properties with multiple values
- * fix error when assigning Icalendar::Values::Array to a component
- * Fall back to Icalendar::Values::Date if Icalendar::Values::DateTime is not given a properly formatted value
- * Downcase the keys in ical_params to ensure we aren't assigning both tzid and TZID
-
-=== 2.2.2 2014-12-27
- * add a `has_#{component}?` method for testing if component exists - John Hope
- * add documentation & tests for organizer attribute - Ben Walding
-
-=== 2.2.1 2014-12-03
- * Prevent crashes when using ActiveSupport::TimeWithZone in multi-property DateTime fields - Danny (tdg5)
- * Ensure TimeWithZone is loaded before using, not just ActiveSupport - Jeremy Evans
- * Improve error message on unparseable DateTimes - Garry Shutler
-
-=== 2.2.0 2014-09-23
- * Default to non-strict parsing
- * Enable sorting events by dtstart - Mark Rickert
- * Better tolerate malformed lines in parser - Garry Shutler
- * Deduplicate timezone code - Jan Vlnas
- * Eliminate warnings - rochefort
-
-=== 2.1.2 2014-09-10
- * Fix timezone abbreviation generation - Jan Vlnas
- * Fix timezone repeat rules for end of month
-
-=== 2.1.1 2014-07-23
- * Quiet TimeWithZone support logging
- * Use SecureRandom.uuid - antoinelyset
-
-=== 2.1.0 2014-06-17
- * Enable parsing all custom properties, not just X- prefixed ones
-   Requires non-strict parsing
- * Fixed bugs when using non-MRI ruby interpreters
- * Fix bug copying OpenStruct-backed value types
-
-=== 2.0.1 2014-04-27
- * Re-add support for ruby 1.9.2
-
-=== 2.0.0 2014-04-22
- * Add Icalendar.logger class & logging in Parser
- * Support tzinfo ~> 0.3 and ~> 1.1
-
-=== 2.0.0.beta.2 2014-04-11
- * Add uid & acknowledged fields from valarm extensions
- * Swallow NoMethodError on non-strict parsers
- * Expose a parse_property method on Icalendar::Parser
-
-=== 2.0.0.beta.1 2014-03-30
- * Rewrite for easier development going forward.
-
-=== 1.5.2 2014-02-22
- * Output timezone components first
- * Fix undefined local variable or method 'e' - Jason Stirk
-
-=== 1.5.1 2014-02-27
- * Check for dtend existence before setting timezone - Jonas Grau
- * Clean up and refactor components - Kasper Timm Hansen
-
-=== 1.5.0 2013-12-06
- * Support for custom x- properties - Jake Craige
-
-=== 1.4.5 2013-11-14
- * Fix Geo accessor methods - bouzuya
- * Add ical_multiline_property :related_to for Alarm
- * Allow using multi setters to append single values
-
-=== 1.4.4 2013-11-05
- * Allow user to handle TZInfo::AmbiguousTime error - David Bradford
- * Better handling of multiple exdate and rdate values
-
-=== 1.4.3 2013-09-18
- * Fix concatenation of multiple BYWEEK or BYMONTH recurrence rules
-
-=== 1.4.2 2013-09-11
- * Double Quote parameter values that contain forbidden characters
- * Update Component#respond_to? to match Ruby 2.0 - Keith Marcum
-
-=== 1.4.1 2013-06-25
- * Don't escape semicolon in GEO property - temirov
- * Allow access to various parts of RRule class
-
-=== 1.4.0 2013-05-21
- * Implement ACKNOWLEDGED property for VALARM - tsuzuki08
- * Output VERSION property as first line after BEGIN:VCALENDAR
- * Check for unbounded timezone transitions in tzinfo
-
-=== 1.3.0 2013-03-31
- * Lenient parsing mode ignores unknown properties - David Grandinetti
- * VTIMEZONE positive offsets properly have "+" prepended (Fixed issue
-#18) - Benjamin Jorgensen (sorry for misspelling your last name)
-
-=== 1.2.4 2013-03-26
- * Proxy component values now frozen in Ruby 2.0 (Fixed issue #17)
- * Clean up gemspec for cleaner installing via bundler/git
-
-=== 1.2.3 2013-03-09
- * Call `super` from Component#method_missing
- * Clean up warnings in test suite
- * Add Gemfile for installing development dependencies
-
-=== 1.2.2 2013-02-16
- * added TZURL property to Timezone component - spacepixels
- * correct days in RRule ("[TU,WE]" -> "TU,WE") - Christoph Finkensiep
-
-=== 1.2.1 2012-11-12
- * Adds uid property to alarms to support iCloud - Jeroen Jacobs
- * Fix up testing docs - Eric Carty-Fickes
- * Fix parsing property params that have : in them - Sean Dague
- * Clean up warnings in test suite - Sean Dague
-
-=== 1.2.0 2012-08-30
-* Fix calendar handling for dates < 1000 - Ryan Ahearn
-* Updated license to GPL/BSD/Ruby at users option
-
-=== 1.1.6 2011-03-10
-* Fix todo handling (thanks to Frank Schwarz)
-* clean up a number of warnings during test runs
-
-=== 1.1.5 2010-06-21
-* Fix for windows line endings (thanks to Rowan Collins)
-
-=== 1.1.4 2010-04-23
-* Fix for RRULE escaping
-* Fix tests so they run under 1.8.7 in multiple environments
-* Readme fix
-
-=== 1.1.3 2010-03-15
-* Revert component sorting behavior that I was trying to make
-the tests run more consistantly on different platforms.
-* Added new test for multiple events in a calendar which caught that break.
-
-=== 1.1.2 2010-03-10
-
-* Convert project to newgem to make for easier publishing