ibm_db 3.0.4 → 5.0.4

data/test/cases/type/string_test.rb

@@ -2,20 +2,6 @@ require 'cases/helper'
 
 module ActiveRecord
   class StringTypeTest < ActiveRecord::TestCase
-    test "type casting" do
-      type = Type::String.new
-      assert_equal "t", type.type_cast_from_user(true)
-      assert_equal "f", type.type_cast_from_user(false)
-      assert_equal "123", type.type_cast_from_user(123)
-    end
-
-    test "values are duped coming out" do
-      s = "foo"
-      type = Type::String.new
-      assert_not_same s, type.type_cast_from_user(s)
-      assert_not_same s, type.type_cast_from_database(s)
-    end
-
     test "string mutations are detected" do
       klass = Class.new(Base)
       klass.table_name = 'authors'

data/test/cases/type_test.rb

@@ -0,0 +1,39 @@
+require "cases/helper"
+
+class TypeTest < ActiveRecord::TestCase
+  setup do
+    @old_registry = ActiveRecord::Type.registry
+    ActiveRecord::Type.registry = ActiveRecord::Type::AdapterSpecificRegistry.new
+  end
+
+  teardown do
+    ActiveRecord::Type.registry = @old_registry
+  end
+
+  test "registering a new type" do
+    type = Struct.new(:args)
+    ActiveRecord::Type.register(:foo, type)
+
+    assert_equal type.new(:arg), ActiveRecord::Type.lookup(:foo, :arg)
+  end
+
+  test "looking up a type for a specific adapter" do
+    type = Struct.new(:args)
+    pgtype = Struct.new(:args)
+    ActiveRecord::Type.register(:foo, type, override: false)
+    ActiveRecord::Type.register(:foo, pgtype, adapter: :postgresql)
+
+    assert_equal type.new, ActiveRecord::Type.lookup(:foo, adapter: :sqlite)
+    assert_equal pgtype.new, ActiveRecord::Type.lookup(:foo, adapter: :postgresql)
+  end
+
+  test "lookup defaults to the current adapter" do
+    current_adapter = ActiveRecord::Base.connection.adapter_name.downcase.to_sym
+    type = Struct.new(:args)
+    adapter_type = Struct.new(:args)
+    ActiveRecord::Type.register(:foo, type, override: false)
+    ActiveRecord::Type.register(:foo, adapter_type, adapter: current_adapter)
+
+    assert_equal adapter_type.new, ActiveRecord::Type.lookup(:foo)
+  end
+end

data/test/cases/types_test.rb

@@ -3,126 +3,9 @@ require "cases/helper"
 module ActiveRecord
   module ConnectionAdapters
     class TypesTest < ActiveRecord::TestCase
-      def test_type_cast_boolean
-        type = Type::Boolean.new
-        assert type.type_cast_from_user('').nil?
-        assert type.type_cast_from_user(nil).nil?
-
-        assert type.type_cast_from_user(true)
-        assert type.type_cast_from_user(1)
-        assert type.type_cast_from_user('1')
-        assert type.type_cast_from_user('t')
-        assert type.type_cast_from_user('T')
-        assert type.type_cast_from_user('true')
-        assert type.type_cast_from_user('TRUE')
-        assert type.type_cast_from_user('on')
-        assert type.type_cast_from_user('ON')
-
-        # explicitly check for false vs nil
-        assert_equal false, type.type_cast_from_user(false)
-        assert_equal false, type.type_cast_from_user(0)
-        assert_equal false, type.type_cast_from_user('0')
-        assert_equal false, type.type_cast_from_user('f')
-        assert_equal false, type.type_cast_from_user('F')
-        assert_equal false, type.type_cast_from_user('false')
-        assert_equal false, type.type_cast_from_user('FALSE')
-        assert_equal false, type.type_cast_from_user('off')
-        assert_equal false, type.type_cast_from_user('OFF')
-        assert_deprecated do
-          assert_equal false, type.type_cast_from_user(' ')
-          assert_equal false, type.type_cast_from_user("\u3000\r\n")
-          assert_equal false, type.type_cast_from_user("\u0000")
-          assert_equal false, type.type_cast_from_user('SOMETHING RANDOM')
-        end
-      end
-
-      def test_type_cast_float
-        type = Type::Float.new
-        assert_equal 1.0, type.type_cast_from_user("1")
-      end
-
-      def test_changing_float
-        type = Type::Float.new
-
-        assert type.changed?(5.0, 5.0, '5wibble')
-        assert_not type.changed?(5.0, 5.0, '5')
-        assert_not type.changed?(5.0, 5.0, '5.0')
-        assert_not type.changed?(nil, nil, nil)
-      end
-
-      def test_type_cast_binary
-        type = Type::Binary.new
-        assert_equal nil, type.type_cast_from_user(nil)
-        assert_equal "1", type.type_cast_from_user("1")
-        assert_equal 1, type.type_cast_from_user(1)
-      end
-
-      def test_type_cast_time
-        type = Type::Time.new
-        assert_equal nil, type.type_cast_from_user(nil)
-        assert_equal nil, type.type_cast_from_user('')
-        assert_equal nil, type.type_cast_from_user('ABC')
-
-        time_string = Time.now.utc.strftime("%T")
-        assert_equal time_string, type.type_cast_from_user(time_string).strftime("%T")
-      end
-
-      def test_type_cast_datetime_and_timestamp
-        type = Type::DateTime.new
-        assert_equal nil, type.type_cast_from_user(nil)
-        assert_equal nil, type.type_cast_from_user('')
-        assert_equal nil, type.type_cast_from_user('  ')
-        assert_equal nil, type.type_cast_from_user('ABC')
-
-        datetime_string = Time.now.utc.strftime("%FT%T")
-        assert_equal datetime_string, type.type_cast_from_user(datetime_string).strftime("%FT%T")
-      end
-
-      def test_type_cast_date
-        type = Type::Date.new
-        assert_equal nil, type.type_cast_from_user(nil)
-        assert_equal nil, type.type_cast_from_user('')
-        assert_equal nil, type.type_cast_from_user(' ')
-        assert_equal nil, type.type_cast_from_user('ABC')
-
-        date_string = Time.now.utc.strftime("%F")
-        assert_equal date_string, type.type_cast_from_user(date_string).strftime("%F")
-      end
-
-      def test_type_cast_duration_to_integer
-        type = Type::Integer.new
-        assert_equal 1800, type.type_cast_from_user(30.minutes)
-        assert_equal 7200, type.type_cast_from_user(2.hours)
-      end
-
-      def test_string_to_time_with_timezone
-        [:utc, :local].each do |zone|
-          with_timezone_config default: zone do
-            type = Type::DateTime.new
-            assert_equal Time.utc(2013, 9, 4, 0, 0, 0), type.type_cast_from_user("Wed, 04 Sep 2013 03:00:00 EAT")
-          end
-        end
-      end
-
-      def test_type_equality
-        assert_equal Type::Value.new, Type::Value.new
-        assert_not_equal Type::Value.new, Type::Integer.new
-        assert_not_equal Type::Value.new(precision: 1), Type::Value.new(precision: 2)
-      end
-
-      if current_adapter?(:SQLite3Adapter)
-        def test_binary_encoding
-          type = SQLite3Binary.new
-          utf8_string = "a string".encode(Encoding::UTF_8)
-          type_cast = type.type_cast_from_user(utf8_string)
-
-          assert_equal Encoding::ASCII_8BIT, type_cast.encoding
-        end
-      end
-
       def test_attributes_which_are_invalid_for_database_can_still_be_reassigned
         type_which_cannot_go_to_the_database = Type::Value.new
-        def type_which_cannot_go_to_the_database.type_cast_for_database(*)
+        def type_which_cannot_go_to_the_database.serialize(*)
           raise
         end
         klass = Class.new(ActiveRecord::Base) do

data/test/cases/unconnected_test.rb

@@ -4,7 +4,7 @@ class TestRecord < ActiveRecord::Base
 end
 
 class TestUnconnectedAdapter < ActiveRecord::TestCase
-  self.use_transactional_fixtures = false
+  self.use_transactional_tests = false
 
   def setup
     @underlying = ActiveRecord::Base.connection

data/test/cases/validations/absence_validation_test.rb

@@ -0,0 +1,73 @@
+require "cases/helper"
+require 'models/face'
+require 'models/interest'
+require 'models/man'
+require 'models/topic'
+
+class AbsenceValidationTest < ActiveRecord::TestCase
+  def test_non_association
+    boy_klass = Class.new(Man) do
+      def self.name; "Boy" end
+      validates_absence_of :name
+    end
+
+    assert boy_klass.new.valid?
+    assert_not boy_klass.new(name: "Alex").valid?
+  end
+
+  def test_has_one_marked_for_destruction
+    boy_klass = Class.new(Man) do
+      def self.name; "Boy" end
+      validates_absence_of :face
+    end
+
+    boy = boy_klass.new(face: Face.new)
+    assert_not boy.valid?, "should not be valid if has_one association is present"
+    assert_equal 1, boy.errors[:face].size, "should only add one error"
+
+    boy.face.mark_for_destruction
+    assert boy.valid?, "should be valid if association is marked for destruction"
+  end
+
+  def test_has_many_marked_for_destruction
+    boy_klass = Class.new(Man) do
+      def self.name; "Boy" end
+      validates_absence_of :interests
+    end
+    boy = boy_klass.new
+    boy.interests << [i1 = Interest.new, i2 = Interest.new]
+    assert_not boy.valid?, "should not be valid if has_many association is present"
+
+    i1.mark_for_destruction
+    assert_not boy.valid?, "should not be valid if has_many association is present"
+
+    i2.mark_for_destruction
+    assert boy.valid?
+  end
+
+  def test_does_not_call_to_a_on_associations
+    boy_klass = Class.new(Man) do
+      def self.name; "Boy" end
+      validates_absence_of :face
+    end
+
+    face_with_to_a = Face.new
+    def face_with_to_a.to_a; ['(/)', '(\)']; end
+
+    assert_nothing_raised { boy_klass.new(face: face_with_to_a).valid? }
+  end
+
+  def test_validates_absence_of_virtual_attribute_on_model
+    repair_validations(Interest) do
+      Interest.send(:attr_accessor, :token)
+      Interest.validates_absence_of(:token)
+
+      interest = Interest.create!(topic: 'Thought Leadering')
+      assert interest.valid?
+
+      interest.token = 'tl'
+
+      assert interest.invalid?
+    end
+  end
+end

data/test/cases/validations/association_validation_test.rb

@@ -45,12 +45,24 @@ class AssociationValidationTest < ActiveRecord::TestCase
     assert t.valid?
   end
 
+  def test_validates_associated_without_marked_for_destruction
+    reply = Class.new do
+      def valid?
+        true
+      end
+    end
+    Topic.validates_associated(:replies)
+    t = Topic.new
+    t.define_singleton_method(:replies) { [reply.new] }
+    assert t.valid?
+  end
+
   def test_validates_associated_with_custom_message_using_quotes
     Reply.validates_associated :topic, :message=> "This string contains 'single' and \"double\" quotes"
     Topic.validates_presence_of :content
     r = Reply.create("title" => "A reply", "content" => "with content!")
     r.topic = Topic.create("title" => "uhohuhoh")
-    assert !r.valid?
+    assert_not_operator r, :valid?
     assert_equal ["This string contains 'single' and \"double\" quotes"], r.errors[:topic]
   end
 
@@ -82,5 +94,4 @@ class AssociationValidationTest < ActiveRecord::TestCase
       assert interest.valid?, "Expected interest to be valid, but was not. Interest should have a man object associated"
     end
   end
-
 end

data/test/cases/validations/i18n_validation_test.rb

@@ -47,29 +47,25 @@ class I18nValidationTest < ActiveRecord::TestCase
     # [ "given on condition",     {on: :save},                {}]
   ]
 
-  # validates_uniqueness_of w/ mocha
-
   COMMON_CASES.each do |name, validation_options, generate_message_options|
     test "validates_uniqueness_of on generated message #{name}" do
       Topic.validates_uniqueness_of :title, validation_options
       @topic.title = unique_topic.title
-      @topic.errors.expects(:generate_message).with(:title, :taken, generate_message_options.merge(:value => 'unique!'))
-      @topic.valid?
+      assert_called_with(@topic.errors, :generate_message, [:title, :taken, generate_message_options.merge(:value => 'unique!')]) do
+        @topic.valid?
+      end
     end
   end
 
-  # validates_associated w/ mocha
-
   COMMON_CASES.each do |name, validation_options, generate_message_options|
     test "validates_associated on generated message #{name}" do
       Topic.validates_associated :replies, validation_options
-      replied_topic.errors.expects(:generate_message).with(:replies, :invalid, generate_message_options.merge(:value => replied_topic.replies))
-      replied_topic.save
+      assert_called_with(replied_topic.errors, :generate_message, [:replies, :invalid, generate_message_options.merge(:value => replied_topic.replies)]) do
+        replied_topic.save
+      end
     end
   end
 
-  # validates_associated w/o mocha
-
   def test_validates_associated_finds_custom_model_key_translation
     I18n.backend.store_translations 'en', :activerecord => {:errors => {:models => {:topic => {:attributes => {:replies => {:invalid => 'custom message'}}}}}}
     I18n.backend.store_translations 'en', :activerecord => {:errors => {:messages => {:invalid => 'global message'}}}

data/test/cases/validations/length_validation_test.rb

@@ -1,47 +1,79 @@
-# -*- coding: utf-8 -*-
 require "cases/helper"
 require 'models/owner'
 require 'models/pet'
+require 'models/person'
 
 class LengthValidationTest < ActiveRecord::TestCase
   fixtures :owners
-  repair_validations(Owner)
 
-  def test_validates_size_of_association
-    repair_validations Owner do
-      assert_nothing_raised { Owner.validates_size_of :pets, :minimum => 1 }
-      o = Owner.new('name' => 'nopets')
-      assert !o.save
-      assert o.errors[:pets].any?
-      o.pets.build('name' => 'apet')
-      assert o.valid?
+  setup do
+    @owner = Class.new(Owner) do
+      def self.name; 'Owner'; end
     end
   end
 
+
+  def test_validates_size_of_association
+    assert_nothing_raised { @owner.validates_size_of :pets, minimum: 1 }
+    o = @owner.new('name' => 'nopets')
+    assert !o.save
+    assert o.errors[:pets].any?
+    o.pets.build('name' => 'apet')
+    assert o.valid?
+  end
+
   def test_validates_size_of_association_using_within
-    repair_validations Owner do
-      assert_nothing_raised { Owner.validates_size_of :pets, :within => 1..2 }
-      o = Owner.new('name' => 'nopets')
-      assert !o.save
-      assert o.errors[:pets].any?
-
-      o.pets.build('name' => 'apet')
-      assert o.valid?
-
-      2.times { o.pets.build('name' => 'apet') }
-      assert !o.save
-      assert o.errors[:pets].any?
-    end
+    assert_nothing_raised { @owner.validates_size_of :pets, within: 1..2 }
+    o = @owner.new('name' => 'nopets')
+    assert !o.save
+    assert o.errors[:pets].any?
+
+    o.pets.build('name' => 'apet')
+    assert o.valid?
+
+    2.times { o.pets.build('name' => 'apet') }
+    assert !o.save
+    assert o.errors[:pets].any?
   end
 
   def test_validates_size_of_association_utf8
-    repair_validations Owner do
-      assert_nothing_raised { Owner.validates_size_of :pets, :minimum => 1 }
-      o = Owner.new('name' => 'あいうえおかきくけこ')
-      assert !o.save
-      assert o.errors[:pets].any?
-      o.pets.build('name' => 'あいうえおかきくけこ')
-      assert o.valid?
+    @owner.validates_size_of :pets, minimum: 1
+    o = @owner.new('name' => 'あいうえおかきくけこ')
+    assert !o.save
+    assert o.errors[:pets].any?
+    o.pets.build('name' => 'あいうえおかきくけこ')
+    assert o.valid?
+  end
+
+  def test_validates_size_of_respects_records_marked_for_destruction
+    @owner.validates_size_of :pets, minimum: 1
+    owner = @owner.new
+    assert_not owner.save
+    assert owner.errors[:pets].any?
+    pet = owner.pets.build
+    assert owner.valid?
+    assert owner.save
+
+    pet_count = Pet.count
+    assert_not owner.update_attributes pets_attributes: [ {_destroy: 1, id: pet.id} ]
+    assert_not owner.valid?
+    assert owner.errors[:pets].any?
+    assert_equal pet_count, Pet.count
+  end
+
+  def test_validates_length_of_virtual_attribute_on_model
+    repair_validations(Pet) do
+      Pet.send(:attr_accessor, :nickname)
+      Pet.validates_length_of(:name, minimum: 1)
+      Pet.validates_length_of(:nickname, minimum: 1)
+
+      pet = Pet.create!(name: 'Fancy Pants', nickname: 'Fancy')
+
+      assert pet.valid?
+
+      pet.nickname = ''
+
+      assert pet.invalid?
     end
   end
 end