ibanity 0.5 → 1.3

data/lib/ibanity/collection.rb

@@ -0,0 +1,47 @@
+module Ibanity
+  class Collection < DelegateClass(Array)
+    attr_accessor :page_limit,
+      :before_cursor,
+      :after_cursor,
+      :offset,
+      :total,
+      :first_link,
+      :next_link,
+      :previous_link,
+      :latest_synchronization,
+      :synchronized_at
+
+    def initialize(
+      klass:,
+      items:,
+      paging:,
+      links:,
+      synchronized_at:,
+      latest_synchronization:
+    )
+      paging                ||= {}
+      links                 ||= {}
+      @klass                  = klass
+      @page_limit             = paging["limit"]
+      @before_cursor          = paging["before"]
+      @after_cursor           = paging["after"]
+      @offset                 = paging["offset"]
+      @total                  = paging["total"]
+      @first_link             = links["first"]
+      @next_link              = links["next"]
+      @previous_link          = links["prev"]
+      @synchronized_at        = synchronized_at
+      @latest_synchronization = latest_synchronization
+      super(items)
+    end
+
+    def inspect
+      result = "#<#{self.class.name}"
+      instance_variables.each do |instance_variable|
+        result +=" #{instance_variable}=#{instance_variable_get(instance_variable).inspect}"
+      end
+      result += ">"
+      result
+    end
+  end
+end

data/lib/ibanity/error.rb

@@ -2,14 +2,14 @@ module Ibanity
   class Error < StandardError
     attr_reader :errors
 
-    def initialize(errors)
+    def initialize(errors, ibanity_request_id)
       @errors = errors
+      @ibanity_request_id = ibanity_request_id
     end
 
     def to_s
-      if @errors && @errors.size > 0
-        @errors.map do |error|
-          p error
+      if @errors.is_a?(Array) && @errors.size > 0
+        formatted_errors = @errors.map do |error|
           if error["meta"] && error["meta"]["attribute"]
             "* #{error["code"]}: '#{error["meta"]["attribute"]}' #{error["detail"]}"
           elsif error["meta"] && error["meta"]["resource"]
@@ -17,7 +17,11 @@ module Ibanity
           else
             "* #{error["code"]}: #{error["detail"]}"
           end
-        end.join("\n")
+        end
+        formatted_errors << "* ibanity_request_id: #{@ibanity_request_id}"
+        formatted_errors.join("\n")
+      elsif @errors.is_a?(Hash)
+        "* #{@errors["error"]}: #{@errors["error_description"]}\n * Error hint: #{@errors["error_hint"]}\n * ibanity_request_id: #{@ibanity_request_id}"
       else
         super
       end

data/lib/ibanity/http_signature.rb

@@ -1,3 +1,5 @@
+require "base64"
+
 module Ibanity
   class HttpSignature
     def initialize(certificate:, certificate_id:, key:, method:, uri:, query_params:, headers:, payload:)
@@ -13,7 +15,7 @@ module Ibanity
 
     def payload_digest
       digest         = OpenSSL::Digest::SHA512.new
-      string_payload = @payload.nil? ? "" : @payload.to_json
+      string_payload = @payload.nil? ? "" : @payload
       digest.update(string_payload)
       base64 = Base64.urlsafe_encode64(digest.digest)
       "SHA-512=#{base64}"
@@ -33,7 +35,7 @@ module Ibanity
     end
 
     def request_target
-      @uri.query = URI.encode_www_form(URI.decode_www_form(@uri.query.to_s).concat(@query_params.to_a)) if @query_params&.keys&.any?
+      @uri.query = RestClient::Utils.encode_query_string(@query_params) if @query_params&.keys&.any?
       "#{@method} #{@uri.request_uri}"
     end
 

data/lib/ibanity/util.rb

@@ -1,9 +1,16 @@
 module Ibanity
   module Util
-    def self.underscorize_hash(attributes)
-      attributes.keys.reduce({}) do |result, key|
-        result[underscore(key)] = attributes[key]
-        result
+    def self.underscorize(obj)
+      case obj
+      when Array
+        obj.map { |e| underscorize(e) }
+      when Hash
+        obj.keys.reduce({}) do |result, key|
+          result[underscore(key)] = underscorize(obj[key])
+          result
+        end
+      else
+        obj
       end
     end
 

data/lib/ibanity/version.rb

@@ -1,3 +1,3 @@
 module Ibanity
-  VERSION = "0.5"
+  VERSION = "1.3"
 end

data/spec/lib/ibanity/util_spec.rb

@@ -0,0 +1,89 @@
+require 'ibanity/util'
+
+RSpec.describe Ibanity::Util do
+  describe ".underscorize" do
+    it "transforms all keys to snake_case" do
+      hash = {
+        "currency" => "EUR",
+        "amount" => 1,
+        "debtorName" => "Sophie Schowalter",
+        "debtorAccountReference" => "BE59823362319793",
+      }
+
+      expected = {
+        "currency" => "EUR",
+        "amount" => 1,
+        "debtor_name" => "Sophie Schowalter",
+        "debtor_account_reference" => "BE59823362319793",
+      }
+
+      expect(Ibanity::Util.underscorize(hash)).to eq(expected)
+    end
+
+    it "processes hashes recursively" do
+      hash = {
+        "currency" => "EUR",
+        "amount" => 1,
+        "debtorName" => "Sophie Schowalter",
+        "details" => {
+          "debtorAccountReference" => "BE59823362319793"
+        }
+      }
+
+      expected = {
+        "currency" => "EUR",
+        "amount" => 1,
+        "debtor_name" => "Sophie Schowalter",
+        "details" => {
+          "debtor_account_reference" => "BE59823362319793"
+        }
+      }
+
+      expect(Ibanity::Util.underscorize(hash)).to eq(expected)
+    end
+
+    it "processes each array element" do
+      hash = {
+        "currency" => "EUR",
+        "amount" => 1,
+        "debtorName" => "Sophie Schowalter",
+        "details" => [
+          {"debtorAccountReference" => "BE59823362319793"}
+        ]
+      }
+
+      expected = {
+        "currency" => "EUR",
+        "amount" => 1,
+        "debtor_name" => "Sophie Schowalter",
+        "details" => [
+          {"debtor_account_reference" => "BE59823362319793"}
+        ]
+      }
+
+      expect(Ibanity::Util.underscorize(hash)).to eq(expected)
+    end
+
+    it "leaves arrays elements untouched if they are not themselves hashes or arrays" do
+      hash = {
+        "currency" => "EUR",
+        "amount" => 1,
+        "debtorName" => "Sophie Schowalter",
+        "details" => [
+          "BE59823362319793"
+        ]
+      }
+
+      expected = {
+        "currency" => "EUR",
+        "amount" => 1,
+        "debtor_name" => "Sophie Schowalter",
+        "details" => [
+          "BE59823362319793"
+        ]
+      }
+
+      expect(Ibanity::Util.underscorize(hash)).to eq(expected)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,100 @@
+# This file was generated by the `rspec --init` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause
+# this file to always be loaded, without a need to explicitly require it in any
+# files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
+  # have no way to turn it off -- the option exists only for backwards
+  # compatibility in RSpec 3). It causes shared context metadata to be
+  # inherited by the metadata hash of host groups and examples, rather than
+  # triggering implicit auto-inclusion in groups with matching metadata.
+  config.shared_context_metadata_behavior = :apply_to_host_groups
+
+# The settings below are suggested to provide a good initial experience
+# with RSpec, but feel free to customize to your heart's content.
+=begin
+  # This allows you to limit a spec run to individual examples or groups
+  # you care about by tagging them with `:focus` metadata. When nothing
+  # is tagged with `:focus`, all examples get run. RSpec also provides
+  # aliases for `it`, `describe`, and `context` that include `:focus`
+  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  config.filter_run_when_matching :focus
+
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  config.example_status_persistence_file_path = "spec/examples.txt"
+
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
+  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
+  config.disable_monkey_patching!
+
+  # This setting enables warnings. It's recommended, but in some cases may
+  # be too noisy due to issues in dependencies.
+  config.warnings = true
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = "doc"
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+=end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibanity
 version: !ruby/object:Gem::Version
-  version: '0.5'
+  version: '1.3'
 platform: ruby
 authors:
 - Ibanity
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-30 00:00:00.000000000 Z
+date: 2020-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -30,28 +30,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.4.0
+        version: 3.9.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.4.0
-- !ruby/object:Gem::Dependency
-  name: webmock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 1.24.2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 1.24.2
+        version: 3.9.0
 description: A Ruby wrapper for the Ibanity API.
 email:
 - info@ibanity.com
@@ -61,27 +47,62 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".gitkeep"
+- ".rspec"
+- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - ibanity.gemspec
 - lib/ibanity.rb
-- lib/ibanity/api/account.rb
-- lib/ibanity/api/account_information_access_request.rb
 - lib/ibanity/api/base_resource.rb
-- lib/ibanity/api/customer_access_token.rb
-- lib/ibanity/api/financial_institution.rb
-- lib/ibanity/api/financial_institution_account.rb
-- lib/ibanity/api/financial_institution_transaction.rb
-- lib/ibanity/api/financial_institution_user.rb
-- lib/ibanity/api/payment_initiation_request.rb
-- lib/ibanity/api/transaction.rb
+- lib/ibanity/api/consent/consent.rb
+- lib/ibanity/api/consent/processing_operation.rb
+- lib/ibanity/api/isabel_connect/access_token.rb
+- lib/ibanity/api/isabel_connect/account.rb
+- lib/ibanity/api/isabel_connect/account_report.rb
+- lib/ibanity/api/isabel_connect/balance.rb
+- lib/ibanity/api/isabel_connect/bulk_payment_initiation_request.rb
+- lib/ibanity/api/isabel_connect/intraday_transaction.rb
+- lib/ibanity/api/isabel_connect/refresh_token.rb
+- lib/ibanity/api/isabel_connect/transaction.rb
+- lib/ibanity/api/o_auth_resource.rb
+- lib/ibanity/api/ponto_connect/account.rb
+- lib/ibanity/api/ponto_connect/financial_institution.rb
+- lib/ibanity/api/ponto_connect/payment.rb
+- lib/ibanity/api/ponto_connect/sandbox/financial_institution_account.rb
+- lib/ibanity/api/ponto_connect/sandbox/financial_institution_transaction.rb
+- lib/ibanity/api/ponto_connect/synchronization.rb
+- lib/ibanity/api/ponto_connect/token.rb
+- lib/ibanity/api/ponto_connect/transaction.rb
+- lib/ibanity/api/ponto_connect/usage.rb
+- lib/ibanity/api/ponto_connect/user_info.rb
+- lib/ibanity/api/sandbox/financial_institution_account.rb
+- lib/ibanity/api/sandbox/financial_institution_holding.rb
+- lib/ibanity/api/sandbox/financial_institution_transaction.rb
+- lib/ibanity/api/sandbox/financial_institution_user.rb
+- lib/ibanity/api/xs2a/account.rb
+- lib/ibanity/api/xs2a/account_information_access_request.rb
+- lib/ibanity/api/xs2a/account_information_access_request_authorization.rb
+- lib/ibanity/api/xs2a/bulk_payment_initiation_request.rb
+- lib/ibanity/api/xs2a/customer.rb
+- lib/ibanity/api/xs2a/customer_access_token.rb
+- lib/ibanity/api/xs2a/financial_institution.rb
+- lib/ibanity/api/xs2a/holding.rb
+- lib/ibanity/api/xs2a/payment_initiation_request.rb
+- lib/ibanity/api/xs2a/payment_initiation_request_authorization.rb
+- lib/ibanity/api/xs2a/periodic_payment_initiation_request.rb
+- lib/ibanity/api/xs2a/synchronization.rb
+- lib/ibanity/api/xs2a/transaction.rb
 - lib/ibanity/client.rb
+- lib/ibanity/collection.rb
 - lib/ibanity/error.rb
 - lib/ibanity/http_signature.rb
 - lib/ibanity/util.rb
 - lib/ibanity/version.rb
+- spec/lib/ibanity/util_spec.rb
+- spec/spec_helper.rb
 homepage: https://documentation.ibanity.com/api/ruby
 licenses:
 - MIT
@@ -101,9 +122,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
 summary: Ibanity Ruby Client
-test_files: []
+test_files:
+- spec/lib/ibanity/util_spec.rb
+- spec/spec_helper.rb