ibandit 1.7.0 → 1.9.0

data/ibandit.gemspec

@@ -3,13 +3,13 @@
 require File.expand_path("lib/ibandit/version", __dir__)
 
 Gem::Specification.new do |gem|
-  gem.add_development_dependency "gc_ruboconfig",   "~> 2.26.0"
+  gem.add_development_dependency "gc_ruboconfig",   "~> 3.0.0"
   gem.add_development_dependency "nokogiri",        "~> 1.6"
   gem.add_development_dependency "pry",             "~> 0.13"
   gem.add_development_dependency "pry-byebug",      "~> 3.9"
   gem.add_development_dependency "rspec",           "~> 3.3"
   gem.add_development_dependency "rspec-its",       "~> 1.2"
-  gem.add_development_dependency "rspec_junit_formatter", "~> 0.4.1"
+  gem.add_development_dependency "rspec_junit_formatter", "~> 0.5.0"
   gem.add_development_dependency "sax-machine", "~> 1.3"
 
   gem.add_runtime_dependency "i18n"
@@ -28,4 +28,5 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.summary = "Convert national banking details into IBANs, and vice-versa."
   gem.version = Ibandit::VERSION.dup
+  gem.metadata["rubygems_mfa_required"] = "true"
 end

data/lib/ibandit/check_digit.rb

@@ -46,7 +46,7 @@ module Ibandit
         end
       end
 
-      (scaled_values.sum % 26 + 65).chr
+      ((scaled_values.sum % 26) + 65).chr
     end
   end
 end

data/lib/ibandit/german_details_converter.rb

@@ -270,13 +270,15 @@ module Ibandit
         when "13"
           if unpadded_account_number.size.between?(6, 7)
             unpadded_account_number + "00"
-          else @account_number
+          else
+            @account_number
           end
         when "76"
           case unpadded_account_number.size
           when 7..8
             if Check76.new(@account_number).valid? then @account_number
-            else unpadded_account_number + "00"
+            else
+              unpadded_account_number + "00"
             end
           when 5..6 then unpadded_account_number + "00"
           else @account_number

data/lib/ibandit/iban.rb

@@ -405,9 +405,9 @@ module Ibandit
       code_digits = swift_bank_code.chars.map(&:to_i)
       mod =
         (
-          3 * (code_digits[0] + code_digits[3] + code_digits[6]) +
-          7 * (code_digits[1] + code_digits[4] + code_digits[7]) +
-          1 * (code_digits[2] + code_digits[5] + code_digits[8])
+          (3 * (code_digits[0] + code_digits[3] + code_digits[6])) +
+          (7 * (code_digits[1] + code_digits[4] + code_digits[7])) +
+          (1 * (code_digits[2] + code_digits[5] + code_digits[8]))
         ) % 10
 
       @errors[:bank_code] = Ibandit.translate(:is_invalid) unless mod.zero?

data/lib/ibandit/local_details_cleaner.rb

@@ -42,7 +42,8 @@ module Ibandit
         %i[account_number]
       when "GB", "IE", "MT"
         if Ibandit.bic_finder.nil? then %i[bank_code branch_code account_number]
-        else %i[branch_code account_number]
+        else
+          %i[branch_code account_number]
         end
       when "AU"
         %i[branch_code account_number]

data/lib/ibandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ibandit
-  VERSION = "1.7.0"
+  VERSION = "1.9.0"
 end

data/lib/ibandit.rb

@@ -30,8 +30,9 @@ module Ibandit
     end
 
     def structures
-      @structures ||= YAML.load_file(
-        File.expand_path("../data/structures.yml", __dir__),
+      @structures ||= YAML.safe_load(
+        File.read(File.expand_path("../data/structures.yml", __dir__)),
+        permitted_classes: [Range, Symbol],
       )
     end
 

data/spec/ibandit/german_details_converter_spec.rb

@@ -19,7 +19,7 @@ describe Ibandit::GermanDetailsConverter do
 
         convertor.fetch("valid", []).each do |tuple|
           context "bank code: #{tuple['bank_code']} account number " \
-            "#{tuple['account_number']}" do
+                  "#{tuple['account_number']}" do
             let(:bank_code) do
               tuple["bank_code"]
             end
@@ -44,7 +44,7 @@ describe Ibandit::GermanDetailsConverter do
 
         convertor.fetch("invalid", []).each do |tuple|
           context "bank code: #{tuple['bank_code']} account number " \
-            "#{tuple['account_number']}" do
+                  "#{tuple['account_number']}" do
             let(:bank_code) { tuple["bank_code"] || "00000000" }
             let(:account_number) { tuple["account_number"] }
 

data/spec/ibandit/iban_spec.rb

@@ -1061,7 +1061,7 @@ describe Ibandit::IBAN do
           iban.valid_length?
           expect(iban.errors).
             to include(length: "Length doesn't match SWIFT specification " \
-                       "(expected 22 characters, received 20)")
+                               "(expected 22 characters, received 20)")
         end
       end
 
@@ -1313,7 +1313,7 @@ describe Ibandit::IBAN do
           iban.valid_branch_code_length?
           expect(iban.errors).
             to include(branch_code: "is the wrong length (should be 6 " \
-                       "characters)")
+                                    "characters)")
         end
       end
 

data/spec/ibandit/structure_spec.rb

@@ -3,8 +3,8 @@
 require "spec_helper"
 
 describe "structures.yml" do
-  structure_file = File.expand_path("../../data/structures.yml", __dir__)
-  structures = YAML.load_file(structure_file)
+  structure_file = File.read(File.expand_path("../../data/structures.yml", __dir__))
+  structures = YAML.safe_load(structure_file, permitted_classes: [Range, Symbol])
 
   structures.each do |country, rules|
     context country do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.9.0
 platform: ruby
 authors:
 - GoCardless
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-09-10 00:00:00.000000000 Z
+date: 2022-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gc_ruboconfig
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.26.0
+        version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.26.0
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.1
+        version: 0.5.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.1
+        version: 0.5.0
 - !ruby/object:Gem::Dependency
   name: sax-machine
   requirement: !ruby/object:Gem::Requirement
@@ -210,7 +210,8 @@ files:
 homepage: https://github.com/gocardless/ibandit
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -226,7 +227,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.15
+rubygems_version: 3.3.3
 signing_key:
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.