ibandit 1.35.0 → 1.37.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0c66078162418a28f36b4b770f14683b5ef73404be4317d999e104c106887c6d
-  data.tar.gz: 41764feef79fdd0da97fc0a9dd45224d3f49f01599cf21c9b739f73c1b44814b
+  metadata.gz: b92de6a0bd5136fae90ea72a6c9ef38aa44d78adcce93829217f92aaa6e06832
+  data.tar.gz: 397a26e1d180a102c9317527c43849d6c147adc2b30394563046a7214ec292b4
 SHA512:
-  metadata.gz: 990c8803f134029f9c080ee728d4d0a6c419fef6897cac6ecf0021cc93a504700bded9fecf2db7f70fddbf040616ac6ec3257f29eb87434e47fbf6541c4bcc3f
-  data.tar.gz: da30ef6a3c3ed3a6173d197ec2f711ef07b4a6462e12bf2193ebf759daa669ae3eabc4a07ae17ca7bc4da7feabd65d8f0c8831eebf0baebd1429cb8df36ab684
+  metadata.gz: 39fb99232136ee69fc5e8b1d180f952cd31b4031e3e8298325c31647212ec8ae21bb27e0ff2d951917fee0eb58c4027306c5ec306f5a3482c9336e3d1fdbedbf
+  data.tar.gz: f5565d4016415743ec141be5b8df9fa8b4e171139ee0cb9f0160a27eafea107701c0b0da07179364bbda642798aefd876fef343ec0098e5a2117fbdc82369b23

data/.github/workflows/tests.yml

@@ -2,15 +2,31 @@ name: tests
 
 on:
   push:
+    branches:
+      - "master"
+  pull_request:
 
 jobs:
-  validate:
+  rubocop:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v7
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
+          # Maintain consistency with the TargetRubyVersion in .rubocop.yml
+          ruby-version: "3.3"
+      - name: Run rubocop
+        run: bundle exec rubocop --parallel --extra-details --display-style-guide
+
+  tests:
     strategy:
       matrix:
-        ruby-version: ["3.1", "3.2", "3.3", "3.4"]
+        ruby-version: ["3.3", "3.4", "4.0"]
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v7
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -18,5 +34,3 @@ jobs:
           ruby-version: "${{ matrix.ruby-version }}"
       - name: Run tests
         run: bundle exec rspec
-      - name: Run rubocop
-        run: bundle exec rubocop --parallel --extra-details --display-style-guide

data/.rubocop.yml

@@ -4,5 +4,5 @@ inherit_gem:
   gc_ruboconfig: rubocop.yml
 
 AllCops:
-  TargetRubyVersion: 3.2
+  TargetRubyVersion: 3.3
   NewCops: enable

data/.ruby-version

@@ -1 +1 @@
-3.4.1
+4.0.6

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## 1.37.0 - October 29, 2026
+
+- [Breaking] Call the configured modulus checker's `valid_bank_code?` for US details, as is already done for AU, NZ and CA. US routing numbers the checker does not recognise are now invalid.
+
+## 1.36.0 - September 29, 2026
+
+- Add Slovak translations
+- Update German translation for invalid check digits
+- Drop CI testing for Rubies older than 3.3
+
 ## 1.35.0 - September 28, 2026
 
 - Accept one-digit NZ account suffixes and normalise them to the three-digit bank form.

data/Gemfile

@@ -5,7 +5,7 @@ source 'https://rubygems.org'
 gemspec
 
 group :development, :test do
-  gem "gc_ruboconfig", "~> 5.0"
+  gem "gc_ruboconfig", "~> 6.0"
   gem "nokogiri", "~> 1.6"
   gem "pry", "~> 0.13"
   gem "pry-byebug", "~> 3.10"

data/config/locales/de.yml

@@ -1,7 +1,7 @@
 de:
   ibandit:
     invalid_country_code: "'%{country_code}' ist kein gültiges IBAN-Länderkennzeichen gemäß ISO 3166-1"
-    invalid_check_digits: "Prüfziffer hat Betragsprüfung nicht bestanden. (%{expected_check_digits} Zeichen erwartet, %{check_digits} angegeben)."
+    invalid_check_digits: "Prüfsumme ist ungültig (%{expected_check_digits} erwartet, %{check_digits} angegeben)."
     invalid_length: "Länge entspricht nicht der SWIFT-Spezifikation (%{expected_length} Zeichen erwartet, %{length} angegeben)"
     is_required: "ist erforderlich"
     wrong_length: "hat nicht die richtige Länge (sollte %{expected} Zeichen haben)"

data/config/locales/sk.yml

@@ -0,0 +1,21 @@
+sk:
+  ibandit:
+    invalid_country_code: "'%{country_code}' nie je platný ISO 3166-1 IBAN kód krajiny"
+    invalid_check_digits: "Kontrolné číslice neprešli kontrolou modulo. Očakávané '%{expected_check_digits}', zadané '%{check_digits}'."
+    invalid_length: "Dĺžka nezodpovedá špecifikácii SWIFT (očakávaných %{expected_length} znakov, zadaných %{length})"
+    is_required: "je povinné"
+    wrong_length: "má nesprávnu dĺžku (má byť %{expected} znakov)"
+    not_used_in_country: "nie je používaný v %{country_code}"
+    non_alphanumeric_characters: "Nealfanumerické znaky nájdené: %{characters}"
+    invalid_format: "Neočakávaný formát pre %{country_code} IBAN."
+    is_invalid: "je neplatný"
+    does_not_support_payments: "nepodporuje platby"
+    has_invalid_format: "formát je neplatný"
+    failed_checksum_test: "neúspešný test kontrolného súčtu"
+    failed_modulus_check: "neúspešná kontrola modulo"
+    has_invalid_length: "dĺžka je neplatná"
+    bank_code_does_not_exist: "bankový kód neexistuje"
+    has_invalid_clearing_code_length: "dĺžka kódu clearingu je neplatná"
+    has_invalid_serial_number: "sériové číslo je neplatné"
+    branch_code_does_not_exist: "kód pobočky neexistuje"
+

data/lib/ibandit/constants.rb

@@ -27,7 +27,7 @@ module Ibandit
     ).uniq
 
     SUPPORTED_LOCALES = %w[
-      da de en es fr it nb nl pt sl sv
+      da de en es fr it nb nl pt sk sl sv
     ].freeze
   end
 end

data/lib/ibandit/iban.rb

@@ -298,7 +298,7 @@ module Ibandit
       when "AU" then valid_australian_details?
       when "NZ" then valid_nz_details?
       when "CA" then valid_ca_details?
-      when "US" then bank_code_passes_checksum_test?
+      when "US" then valid_us_details?
       else true
       end
     end
@@ -392,6 +392,14 @@ module Ibandit
       valid_modulus_check_branch_code?
     end
 
+    def valid_us_details?
+      return true unless country_code == "US"
+      return false unless bank_code_passes_checksum_test?
+      return true unless Ibandit.modulus_checker
+
+      valid_modulus_check_bank_code?
+    end
+
     def bank_code_passes_checksum_test?
       return false unless swift_bank_code
       return false if swift_bank_code.length != 9

data/lib/ibandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ibandit
-  VERSION = "1.35.0"
+  VERSION = "1.37.0"
 end

data/spec/ibandit/iban_spec.rb

@@ -1936,6 +1936,82 @@ describe Ibandit::IBAN do
     end
   end
 
+  describe "valid_us_details" do
+    subject { iban.valid_us_details? }
+
+    context "with non-US details" do
+      let(:arg) do
+        {
+          country_code: "GB",
+          bank_code: "1234",
+          branch_code: "200000",
+          account_number: "55779911",
+        }
+      end
+
+      it { is_expected.to be(true) }
+    end
+
+    context "with US details" do
+      let(:arg) do
+        {
+          country_code: "US",
+          bank_code: "026073150",
+          account_number: "2715500356",
+        }
+      end
+
+      context "without a modulus checker defined" do
+        it { is_expected.to be(true) }
+      end
+
+      context "with a modulus checker defined" do
+        before do
+          Ibandit.modulus_checker = double(
+            valid_bank_code?: valid_bank_code,
+          )
+          iban.valid_us_details?
+        end
+
+        after { Ibandit.modulus_checker = nil }
+
+        let(:valid_bank_code) { true }
+
+        it "calls valid_bank_code? with an IBAN object" do
+          expect(Ibandit.modulus_checker).
+            to receive(:valid_bank_code?).
+            with(instance_of(described_class))
+
+          iban.valid_us_details?
+        end
+
+        it { is_expected.to be(true) }
+
+        context "with a bank code that does not exist" do
+          let(:valid_bank_code) { false }
+
+          it { is_expected.to be(false) }
+
+          it "sets the errors on the IBAN" do
+            expect(iban.errors).to include(bank_code: "bank code does not exist")
+          end
+        end
+      end
+
+      context "with a bank code that fails the checksum test" do
+        let(:arg) do
+          {
+            country_code: "US",
+            bank_code: "123456789",
+            account_number: "12345678",
+          }
+        end
+
+        it { is_expected.to be(false) }
+      end
+    end
+  end
+
   describe "Pseudo IBAN #valid?" do
     let(:country_code) { "CA" }
     let(:arg) do
@@ -1988,7 +2064,7 @@ describe Ibandit::IBAN do
       context "US" do
         let(:country_code) { "US" }
 
-        specify { expect(iban).to receive(:bank_code_passes_checksum_test?).at_least(1) }
+        specify { expect(iban).to receive(:valid_us_details?).at_least(1) }
       end
     end
   end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 1.35.0
+  version: 1.37.0
 platform: ruby
 authors:
 - GoCardless
 bindir: bin
 cert_chain: []
-date: 2026-09-28 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -55,6 +55,7 @@ files:
 - config/locales/nb.yml
 - config/locales/nl.yml
 - config/locales/pt.yml
+- config/locales/sk.yml
 - config/locales/sl.yml
 - config/locales/sv.yml
 - data/german_iban_rules.yml
@@ -114,7 +115,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 4.0.16
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.
 test_files: []