ibandit 1.34.0 → 1.36.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 94889979e0c49c255ce74acc38b1c9462b36bc4e4d9a80c214ae8905047dba4d
-  data.tar.gz: 4aa46bac681573a174c62ee4879fedefcbe56d11c18e8d6743c67c72e77849c7
+  metadata.gz: d8bfd630aac225e15cb3f9da75e76cdd628ab808f882b6722421f6fea17660fa
+  data.tar.gz: 345b0848da39eed06d67eddd34e89ab9f744730a3a887c92f950778a2a479be3
 SHA512:
-  metadata.gz: 8606eb4bf0b1524196175ddce5e4b0f153d5cbbcda1767ef8985a8bc2df1a3abcbba63847243b15a461b1892f14c89e6c75fbe72815274940275b73afa929e01
-  data.tar.gz: fe4757e398d63e1d9a9552e7a8f4d5e02b2074fa04617b6d4a402d7c615513ded4e09e9cc820483659a649a984c05a67f7356c1453ec49e4e57f7276c8ef8269
+  metadata.gz: 9789b4df93ee4c41d587dfc8272504af058e2b088be8027e938d3ab8bc8da364e9eb9c3e1ace667e267f828236867566c606a14237d1b1440ade115865480e65
+  data.tar.gz: 421bdbf2a1acc66ca3aae3bc0dd2b4c78f2e64b00364da6699d7732596dbeb13053b99b320ed3709d8e6c06994371421714a30ea8ce71ae4894404b4c83ea668

data/.github/workflows/tests.yml

@@ -2,15 +2,31 @@ name: tests
 
 on:
   push:
+    branches:
+      - "master"
+  pull_request:
 
 jobs:
-  validate:
+  rubocop:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v7
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
+          # Maintain consistency with the TargetRubyVersion in .rubocop.yml
+          ruby-version: "3.3"
+      - name: Run rubocop
+        run: bundle exec rubocop --parallel --extra-details --display-style-guide
+
+  tests:
     strategy:
       matrix:
-        ruby-version: ["3.1", "3.2", "3.3", "3.4"]
+        ruby-version: ["3.3", "3.4", "4.0"]
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v7
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -18,5 +34,3 @@ jobs:
           ruby-version: "${{ matrix.ruby-version }}"
       - name: Run tests
         run: bundle exec rspec
-      - name: Run rubocop
-        run: bundle exec rubocop --parallel --extra-details --display-style-guide

data/.rubocop.yml

@@ -4,5 +4,5 @@ inherit_gem:
   gc_ruboconfig: rubocop.yml
 
 AllCops:
-  TargetRubyVersion: 3.2
+  TargetRubyVersion: 3.3
   NewCops: enable

data/.ruby-version

@@ -1 +1 @@
-3.4.1
+4.0.6

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## 1.36.0 - September 29, 2026
+
+- Add Slovak translations
+- Update German translation for invalid check digits
+- Drop CI testing for Rubies older than 3.3
+
+## 1.35.0 - September 28, 2026
+
+- Accept one-digit NZ account suffixes and normalise them to the three-digit bank form.
+
 ## 1.34.0 - September 11, 2026
 
 - [Breaking] Reject NZ account numbers whose 3 digit suffix does not start with a zero

data/Gemfile

@@ -5,7 +5,7 @@ source 'https://rubygems.org'
 gemspec
 
 group :development, :test do
-  gem "gc_ruboconfig", "~> 5.0"
+  gem "gc_ruboconfig", "~> 6.0"
   gem "nokogiri", "~> 1.6"
   gem "pry", "~> 0.13"
   gem "pry-byebug", "~> 3.10"

data/README.md

@@ -548,8 +548,9 @@ iban = Ibandit::IBAN.new(
 iban.pseudo_iban            # => "NZZZ0100043333333044"
 iban.iban                   # => nil
 
-# A 2 digit suffix is padded with a leading zero. A suffix given as 3 digits
-# must already start with that zero: `SS` becomes `0SS`, never `SS0`.
+# A 1 or 2 digit suffix is padded with leading zeroes to the three-digit bank
+# form. A suffix supplied with 3 digits must already start with a zero: `S`
+# becomes `00S`, `SS` becomes `0SS`, never `SS0`.
 
 iban = Ibandit::IBAN.new(
   country_code: 'NZ',

data/config/locales/de.yml

@@ -1,7 +1,7 @@
 de:
   ibandit:
     invalid_country_code: "'%{country_code}' ist kein gültiges IBAN-Länderkennzeichen gemäß ISO 3166-1"
-    invalid_check_digits: "Prüfziffer hat Betragsprüfung nicht bestanden. (%{expected_check_digits} Zeichen erwartet, %{check_digits} angegeben)."
+    invalid_check_digits: "Prüfsumme ist ungültig (%{expected_check_digits} erwartet, %{check_digits} angegeben)."
     invalid_length: "Länge entspricht nicht der SWIFT-Spezifikation (%{expected_length} Zeichen erwartet, %{length} angegeben)"
     is_required: "ist erforderlich"
     wrong_length: "hat nicht die richtige Länge (sollte %{expected} Zeichen haben)"

data/config/locales/sk.yml

@@ -0,0 +1,21 @@
+sk:
+  ibandit:
+    invalid_country_code: "'%{country_code}' nie je platný ISO 3166-1 IBAN kód krajiny"
+    invalid_check_digits: "Kontrolné číslice neprešli kontrolou modulo. Očakávané '%{expected_check_digits}', zadané '%{check_digits}'."
+    invalid_length: "Dĺžka nezodpovedá špecifikácii SWIFT (očakávaných %{expected_length} znakov, zadaných %{length})"
+    is_required: "je povinné"
+    wrong_length: "má nesprávnu dĺžku (má byť %{expected} znakov)"
+    not_used_in_country: "nie je používaný v %{country_code}"
+    non_alphanumeric_characters: "Nealfanumerické znaky nájdené: %{characters}"
+    invalid_format: "Neočakávaný formát pre %{country_code} IBAN."
+    is_invalid: "je neplatný"
+    does_not_support_payments: "nepodporuje platby"
+    has_invalid_format: "formát je neplatný"
+    failed_checksum_test: "neúspešný test kontrolného súčtu"
+    failed_modulus_check: "neúspešná kontrola modulo"
+    has_invalid_length: "dĺžka je neplatná"
+    bank_code_does_not_exist: "bankový kód neexistuje"
+    has_invalid_clearing_code_length: "dĺžka kódu clearingu je neplatná"
+    has_invalid_serial_number: "sériové číslo je neplatné"
+    branch_code_does_not_exist: "kód pobočky neexistuje"
+

data/lib/ibandit/constants.rb

@@ -27,7 +27,7 @@ module Ibandit
     ).uniq
 
     SUPPORTED_LOCALES = %w[
-      da de en es fr it nb nl pt sl sv
+      da de en es fr it nb nl pt sk sl sv
     ].freeze
   end
 end

data/lib/ibandit/local_details_cleaner.rb

@@ -468,12 +468,12 @@ module Ibandit
 
     def self.clean_nz_details(local_details)
       # This method supports being passed the component parts of the NZ account
-      # number, or a single 15/16 digit string (BBbbbb-AAAAAAA-0SS) in the
+      # number, or a single 14/15/16 digit string with a 1/2/3-digit suffix in the
       # account number field.
       #
-      # When given a 15/16 digit string, the component parts (i.e bank_code,
+      # When given a 14/15/16 digit string, the component parts (i.e bank_code,
       # branch_code and account_number) are extracted, with the 7-digit account
-      # number body and 2/3-digit account number suffix making up the actual
+      # number body and 1/2/3-digit account number suffix making up the actual
       # account_number field.
       if local_details[:bank_code] && local_details[:branch_code]
         bank_code = local_details[:bank_code]
@@ -486,7 +486,7 @@ module Ibandit
         account_number = cleaned_account_number[6..]
       end
 
-      if account_number && account_number.length == 9
+      if account_number && [8, 9].include?(account_number.length)
         # > Some banks (such as BNZ) include three digits of the suffix in their
         # > presentation of the account number to the end customer. Other banks
         # > only show the last two digits of the suffix to the end customer.
@@ -494,8 +494,8 @@ module Ibandit
         # > first digit of the suffix is always 0 so it's usually ignored.
         # > [https://en.wikipedia.org/wiki/New_Zealand_bank_account_number]
         #
-        # Here, we insert the zero in cases where it is ignored.
-        account_number = account_number[0..6] + "0" + account_number[7..8]
+        # Here, we restore omitted leading zeros in the suffix.
+        account_number = account_number[0..6] + account_number[7..].rjust(3, "0")
       end
 
       {

data/lib/ibandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ibandit
-  VERSION = "1.34.0"
+  VERSION = "1.36.0"
 end

data/spec/ibandit/iban_spec.rb

@@ -810,6 +810,19 @@ describe Ibandit::IBAN do
         its(:to_s) { is_expected.to eq("") }
       end
 
+      context "with a 1 digit account number suffix" do
+        let(:account_number) { "3333333-1" }
+
+        its(:country_code) { is_expected.to eq("NZ") }
+        its(:bank_code) { is_expected.to eq("11") }
+        its(:branch_code) { is_expected.to eq("2222") }
+        its(:account_number) { is_expected.to eq("3333333") }
+        its(:account_number_suffix) { is_expected.to eq("001") }
+        its(:swift_account_number) { is_expected.to eq("3333333001") }
+        its(:pseudo_iban) { is_expected.to eq("NZZZ1122223333333001") }
+        its(:valid?) { is_expected.to eq(true) }
+      end
+
       context "with a nil account number" do
         let(:account_number) { nil }
 

data/spec/ibandit/local_details_cleaner_spec.rb

@@ -1076,6 +1076,14 @@ describe Ibandit::LocalDetailsCleaner do
       its([:branch_code]) { is_expected.to eq("2222") }
       its([:account_number]) { is_expected.to eq("3333333044") }
 
+      context "with a 1-digit account number suffix" do
+        let(:account_number) { "11-2222-3333333-1" }
+
+        its([:bank_code]) { is_expected.to eq("11") }
+        its([:branch_code]) { is_expected.to eq("2222") }
+        its([:account_number]) { is_expected.to eq("3333333001") }
+      end
+
       context "with a 2-digit account number suffix" do
         let(:account_number) { "11-2222-3333333-44" }
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 1.34.0
+  version: 1.36.0
 platform: ruby
 authors:
 - GoCardless
 bindir: bin
 cert_chain: []
-date: 2026-09-14 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -55,6 +55,7 @@ files:
 - config/locales/nb.yml
 - config/locales/nl.yml
 - config/locales/pt.yml
+- config/locales/sk.yml
 - config/locales/sl.yml
 - config/locales/sv.yml
 - data/german_iban_rules.yml
@@ -114,7 +115,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 4.0.16
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.
 test_files: []