ibandit 1.33.0 → 1.35.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0e64b343d0208a90e559080e123c93ed871ae29c0752109a64d7b585a7745bff
-  data.tar.gz: bb5b4f8a497a9929d2100bbbd59e8eb6e38b7498e6ae49679f9b74053a72fd69
+  metadata.gz: 0c66078162418a28f36b4b770f14683b5ef73404be4317d999e104c106887c6d
+  data.tar.gz: 41764feef79fdd0da97fc0a9dd45224d3f49f01599cf21c9b739f73c1b44814b
 SHA512:
-  metadata.gz: 033a7aa87139f5d02b407e21f94ae69e410a0ce7b8d489e5a271802074aff1a0e9f5baa8dfa0d49d32e259dff0d229b04c79d6803e6b85945831d0cd81261f14
-  data.tar.gz: 5e8ead943cab4950c02ce3854d60197294366096a25547d85703f9a1896943b0da3778765ae57070b5ef1547be3e2192f84d23674a2369cca4ff12b96c5a473f
+  metadata.gz: 990c8803f134029f9c080ee728d4d0a6c419fef6897cac6ecf0021cc93a504700bded9fecf2db7f70fddbf040616ac6ec3257f29eb87434e47fbf6541c4bcc3f
+  data.tar.gz: da30ef6a3c3ed3a6173d197ec2f711ef07b4a6462e12bf2193ebf759daa669ae3eabc4a07ae17ca7bc4da7feabd65d8f0c8831eebf0baebd1429cb8df36ab684

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 1.35.0 - September 28, 2026
+
+- Accept one-digit NZ account suffixes and normalise them to the three-digit bank form.
+
+## 1.34.0 - September 11, 2026
+
+- [Breaking] Reject NZ account numbers whose 3 digit suffix does not start with a zero
+
 ## 1.33.0 - September 2, 2026
 
 - Update BLZ data - BLZ_20260907

data/README.md

@@ -548,20 +548,26 @@ iban = Ibandit::IBAN.new(
 iban.pseudo_iban            # => "NZZZ0100043333333044"
 iban.iban                   # => nil
 
+# A 1 or 2 digit suffix is padded with leading zeroes to the three-digit bank
+# form. A suffix supplied with 3 digits must already start with a zero: `S`
+# becomes `00S`, `SS` becomes `0SS`, never `SS0`.
+
 iban = Ibandit::IBAN.new(
   country_code: 'NZ',
   account_number: '01-0004-3333333-44'
 )
-iban.pseudo_iban          # => "NZZZ0100043333333044"
-iban.bank_code            # => "01"
-iban.branch_code          # => "0004"
-iban.account_number       # => "3333333044"
+iban.pseudo_iban            # => "NZZZ0100043333333044"
+iban.bank_code              # => "01"
+iban.branch_code            # => "0004"
+iban.account_number         # => "3333333"
+iban.account_number_suffix  # => "044"
 
 iban = Ibandit::IBAN.new('NZZZ0100043333333044')
-iban.country_code         # => "NZ"
-iban.bank_code            # => "01"
-iban.branch_code          # => "0004"
-iban.account_number       # => "3333333044"
+iban.country_code           # => "NZ"
+iban.bank_code              # => "01"
+iban.branch_code            # => "0004"
+iban.account_number         # => "3333333"
+iban.account_number_suffix  # => "044"
 
 # USA
 iban = Ibandit::IBAN.new(

data/data/raw/pseudo_ibans.yml

@@ -35,7 +35,7 @@ NZ:
   :account_number_length: 10
   :bank_code_format: "\\d{2}"
   :branch_code_format: "\\d{4}"
-  :account_number_format: "\\d{7}\\d{3}"
+  :account_number_format: "\\d{7}0\\d{2}"
   :pseudo_iban_bank_code_length: 2
   :pseudo_iban_branch_code_length: 4
   :pseudo_iban_account_number_length: 10

data/data/structures.yml

@@ -1598,7 +1598,7 @@ NZ:
   :account_number_length: 10
   :bank_code_format: "\\d{2}"
   :branch_code_format: "\\d{4}"
-  :account_number_format: "\\d{7}\\d{3}"
+  :account_number_format: "\\d{7}0\\d{2}"
   :pseudo_iban_bank_code_length: 2
   :pseudo_iban_branch_code_length: 4
   :pseudo_iban_account_number_length: 10

data/lib/ibandit/local_details_cleaner.rb

@@ -468,12 +468,12 @@ module Ibandit
 
     def self.clean_nz_details(local_details)
       # This method supports being passed the component parts of the NZ account
-      # number, or a single 15/16 digit string (BBbbbb-AAAAAAA-0SS) in the
+      # number, or a single 14/15/16 digit string with a 1/2/3-digit suffix in the
       # account number field.
       #
-      # When given a 15/16 digit string, the component parts (i.e bank_code,
+      # When given a 14/15/16 digit string, the component parts (i.e bank_code,
       # branch_code and account_number) are extracted, with the 7-digit account
-      # number body and 2/3-digit account number suffix making up the actual
+      # number body and 1/2/3-digit account number suffix making up the actual
       # account_number field.
       if local_details[:bank_code] && local_details[:branch_code]
         bank_code = local_details[:bank_code]
@@ -486,7 +486,7 @@ module Ibandit
         account_number = cleaned_account_number[6..]
       end
 
-      if account_number && account_number.length == 9
+      if account_number && [8, 9].include?(account_number.length)
         # > Some banks (such as BNZ) include three digits of the suffix in their
         # > presentation of the account number to the end customer. Other banks
         # > only show the last two digits of the suffix to the end customer.
@@ -494,8 +494,8 @@ module Ibandit
         # > first digit of the suffix is always 0 so it's usually ignored.
         # > [https://en.wikipedia.org/wiki/New_Zealand_bank_account_number]
         #
-        # Here, we insert the zero in cases where it is ignored.
-        account_number = account_number[0..6] + "0" + account_number[7..8]
+        # Here, we restore omitted leading zeros in the suffix.
+        account_number = account_number[0..6] + account_number[7..].rjust(3, "0")
       end
 
       {

data/lib/ibandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ibandit
-  VERSION = "1.33.0"
+  VERSION = "1.35.0"
 end

data/spec/fixtures/germany_integration_test_cases.json

@@ -12,15 +12,6 @@
       { "bank_code": "10060198", "account_number" : "1" }
     ]
   },
-  // {
-  //   "convertor": "000300",
-  //   "valid": [
-  //     { "bank_code": "51010800", "account_number" : "1" }
-  //   ],
-  //   "invalid": [
-  //     { "bank_code": "51010800", "account_number" : "6161604670" }
-  //   ]
-  // },
   {
     "convertor": "000400",
     "valid": [
@@ -91,12 +82,6 @@
       {"bank_code":"51020000","account_number":"30009963","converted_bank_code":"50020200","converted_account_number":"30009963"}
     ]
   },
-  // {
-  //   "convertor": "000900",
-  //   "valid": [
-  //     {"bank_code":"68351976","account_number":"1116232594","converted_bank_code":"68351557","converted_account_number":"3047232594"}
-  //   ]
-  // },
   {
     "convertor": "001001",
     "valid": [
@@ -157,10 +142,4 @@
       { "bank_code": "30060010", "account_number": "12345678", "converted_account_number": "12345678" }
     ]
   }
-  // {
-  //   "convertor": "001900",
-  //   "valid": [
-  //     { "bank_code": "50130100", "account_number": "556", "converted_bank_code": "50120383" }
-  //   ]
-  // }
 ]

data/spec/fixtures/germany_unit_test_cases.json

@@ -136,12 +136,6 @@
       { "bank_code": "10010010", "account_number" : "556", "converted_account_number": "0120440110" }
     ]
   },
-  // {
-  //   "convertor": "001900",
-  //   "valid": [
-  //     { "bank_code": "10010010", "account_number" : "1234567890", "converted_bank_code": "50120383" }
-  //   ]
-  // },
   {
     "convertor": "002002",
     "valid": [

data/spec/ibandit/iban_spec.rb

@@ -764,23 +764,34 @@ describe Ibandit::IBAN do
       end
 
       context "with a 3 digit account number suffix" do
-        let(:account_number) { "3333333-944" }
+        let(:account_number) { "3333333-044" }
 
         its(:country_code) { is_expected.to eq("NZ") }
         its(:bank_code) { is_expected.to eq("11") }
         its(:branch_code) { is_expected.to eq("2222") }
         its(:account_number) { is_expected.to eq("3333333") }
-        its(:account_number_suffix) { is_expected.to eq("944") }
+        its(:account_number_suffix) { is_expected.to eq("044") }
         its(:swift_bank_code) { is_expected.to eq("11") }
         its(:swift_branch_code) { is_expected.to eq("2222") }
-        its(:swift_account_number) { is_expected.to eq("3333333944") }
+        its(:swift_account_number) { is_expected.to eq("3333333044") }
         its(:swift_national_id) { is_expected.to eq("112222") }
         its(:iban) { is_expected.to be_nil }
-        its(:pseudo_iban) { is_expected.to eq("NZZZ1122223333333944") }
+        its(:pseudo_iban) { is_expected.to eq("NZZZ1122223333333044") }
         its(:valid?) { is_expected.to eq(true) }
         its(:to_s) { is_expected.to eq("") }
       end
 
+      context "with a 3 digit account number suffix not starting with a zero" do
+        let(:account_number) { "3333333-500" }
+
+        its(:account_number_suffix) { is_expected.to eq("500") }
+
+        it "is invalid and has the correct errors" do
+          expect(subject.valid?).to eq(false)
+          expect(subject.errors).to eq(account_number: "format is invalid")
+        end
+      end
+
       context "with a 2 digit account number suffix" do
         let(:account_number) { "3333333-44" }
 
@@ -799,6 +810,19 @@ describe Ibandit::IBAN do
         its(:to_s) { is_expected.to eq("") }
       end
 
+      context "with a 1 digit account number suffix" do
+        let(:account_number) { "3333333-1" }
+
+        its(:country_code) { is_expected.to eq("NZ") }
+        its(:bank_code) { is_expected.to eq("11") }
+        its(:branch_code) { is_expected.to eq("2222") }
+        its(:account_number) { is_expected.to eq("3333333") }
+        its(:account_number_suffix) { is_expected.to eq("001") }
+        its(:swift_account_number) { is_expected.to eq("3333333001") }
+        its(:pseudo_iban) { is_expected.to eq("NZZZ1122223333333001") }
+        its(:valid?) { is_expected.to eq(true) }
+      end
+
       context "with a nil account number" do
         let(:account_number) { nil }
 

data/spec/ibandit/local_details_cleaner_spec.rb

@@ -1076,6 +1076,14 @@ describe Ibandit::LocalDetailsCleaner do
       its([:branch_code]) { is_expected.to eq("2222") }
       its([:account_number]) { is_expected.to eq("3333333044") }
 
+      context "with a 1-digit account number suffix" do
+        let(:account_number) { "11-2222-3333333-1" }
+
+        its([:bank_code]) { is_expected.to eq("11") }
+        its([:branch_code]) { is_expected.to eq("2222") }
+        its([:account_number]) { is_expected.to eq("3333333001") }
+      end
+
       context "with a 2-digit account number suffix" do
         let(:account_number) { "11-2222-3333333-44" }
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 1.33.0
+  version: 1.35.0
 platform: ruby
 authors:
 - GoCardless
 bindir: bin
 cert_chain: []
-date: 1980-01-02 00:00:00.000000000 Z
+date: 2026-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -114,7 +114,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 3.6.2
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.
 test_files: []