ibandit 1.23.0 → 1.25.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f204241b08b7d0ea68f567e7a19732be27c58f5a0f7a275ee3c6fb053435e382
-  data.tar.gz: 1e38162054ba85caea8f21aec08545f7ea0906475911ff3e08d5300b6aa1f1d8
+  metadata.gz: 59b71293c8cd665cfb42ceee4f5216553d32246a17a30df647bd7f084c8d8cb1
+  data.tar.gz: b1e0709ad2457b23e89936ece46e70c8f7779b9bbaefb80a23cbad9dae57b3fe
 SHA512:
-  metadata.gz: 813b2693616e4479ff87b66e9e6818fced084999f4082a2df05eb66d024e19693f3cecda440c138e706d0e2798950d957cf88d18a2b39565f13544263b9863b5
-  data.tar.gz: 277e44e26604e9ae6b4708c43e8d153e9ef2fdd73a38a0dec2babdf30c1d6ecab917786d13aacccfb6e70ad654097ac6976bada55aa23c4282c5d862efa21c00
+  metadata.gz: 4e5cd5a8c6be145321f15cbb55da328828df5f089b524e74c33eca4216202fed477e4d881a1d111a53287a22988f828e94fee1ce758c5197781590f5c003b878
+  data.tar.gz: dbe36b9e0396322e9b168647e74cbe86af65c5fb4fcc160385c842db6886ba8932278cd0f3808669734da5f45cfb8aea24484a038349ec3e147c23b59f67288e

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 1.25.0 - February 18, 2025
+
+- `SE` pseudo-ibans no longer fail validation due to the `ZZ` check digit.
+
+## 1.24.0 - February 18, 2025
+
+- Fix validation for SE IBANs where the account number starts with a 0 and the clearing number is not included in the IBAN
+
 ## 1.23.0 - February 14, 2025
 
 - Fix validation for SE IBANs for clearing code 3300 where the account number starts with a 0

data/data/raw/swedish_bank_lookup.yml

@@ -85,7 +85,7 @@
   :bank_code: 300
   :clearing_code_length: 4
   :serial_number_length: 10
-  :zerofill_serial_number: true
+  :zerofill_serial_number: false
   :include_clearing_code: false
   :validation_scheme: '2.1'
 - :range: [3301, 3399]

data/lib/ibandit/iban.rb

@@ -128,6 +128,7 @@ module Ibandit
     end
 
     def valid_check_digits?
+      return true if source == :pseudo_iban && check_digits == Constants::PSEUDO_IBAN_CHECK_DIGITS
       return unless decomposable? && valid_characters?
 
       expected_check_digits = CheckDigit.iban(country_code, bban)

data/lib/ibandit/sweden/validator.rb

@@ -64,7 +64,7 @@ module Ibandit
           length += bank[:clearing_code_length] if bank[:include_clearing_code]
 
           cleaned_account_number = account_number.gsub(/\A0+/, "")
-          if bank[:zerofill_serial_number] && !bank[:include_clearing_code]
+          if !bank[:include_clearing_code]
             cleaned_account_number =
               cleaned_account_number.
                 rjust(bank.fetch(:serial_number_length), "0")

data/lib/ibandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ibandit
-  VERSION = "1.23.0"
+  VERSION = "1.25.0"
 end

data/spec/ibandit/iban_spec.rb

@@ -183,6 +183,75 @@ describe Ibandit::IBAN do
       its(:iban) { is_expected.to eq("SE5412000000012810105723") }
       its(:pseudo_iban) { is_expected.to eq("SEZZX1281XXX0105723") }
       its(:to_s) { is_expected.to eq("SE5412000000012810105723") }
+      its(:valid?) { is_expected.to eq(true) }
+
+      context "and the clearing code is not part of the IBAN" do
+        context "and the branch code allows for zero-filling of short account numbers" do
+          let(:arg) do
+            {
+              country_code: "SE",
+              branch_code: "6000",
+              account_number: "1234567",
+            }
+          end
+
+          its(:country_code) { is_expected.to eq("SE") }
+          its(:bank_code) { is_expected.to be_nil }
+          its(:branch_code) { is_expected.to eq("6000") }
+          its(:account_number) { is_expected.to eq("001234567") }
+          its(:swift_bank_code) { is_expected.to eq("600") }
+          its(:swift_branch_code) { is_expected.to be_nil }
+          its(:swift_account_number) { is_expected.to eq("00000000001234567") }
+          its(:iban) { is_expected.to eq("SE2260000000000001234567") }
+          its(:pseudo_iban) { is_expected.to eq("SEZZX6000X001234567") }
+          its(:to_s) { is_expected.to eq("SE2260000000000001234567") }
+          its(:valid?) { is_expected.to eq(true) }
+        end
+
+        context "and the branch code does not allow for zero-filling of short account numbers" do
+          let(:arg) do
+            {
+              country_code: "SE",
+              branch_code: "3300",
+              account_number: "1234567",
+            }
+          end
+
+          its(:country_code) { is_expected.to eq("SE") }
+          its(:bank_code) { is_expected.to be_nil }
+          its(:branch_code) { is_expected.to eq("3300") }
+          its(:account_number) { is_expected.to eq("1234567") }
+          its(:swift_bank_code) { is_expected.to eq("300") }
+          its(:swift_branch_code) { is_expected.to be_nil }
+          its(:swift_account_number) { is_expected.to eq("00000000001234567") }
+          its(:iban) { is_expected.to eq("SE4130000000000001234567") }
+          its(:pseudo_iban) { is_expected.to eq("SEZZX3300XXX1234567") }
+          its(:to_s) { is_expected.to eq("SE4130000000000001234567") }
+          its(:valid?) { is_expected.to eq(false) }
+        end
+      end
+
+      context "and the clearing code is part of the IBAN" do
+        let(:arg) do
+          {
+            country_code: "SE",
+            branch_code: "3410",
+            account_number: "1234567",
+          }
+        end
+
+        its(:country_code) { is_expected.to eq("SE") }
+        its(:bank_code) { is_expected.to be_nil }
+        its(:branch_code) { is_expected.to eq("3410") }
+        its(:account_number) { is_expected.to eq("1234567") }
+        its(:swift_bank_code) { is_expected.to eq("300") }
+        its(:swift_branch_code) { is_expected.to be_nil }
+        its(:swift_account_number) { is_expected.to eq("00000034101234567") }
+        its(:iban) { is_expected.to eq("SE1030000000034101234567") }
+        its(:pseudo_iban) { is_expected.to eq("SEZZX3410XXX1234567") }
+        its(:to_s) { is_expected.to eq("SE1030000000034101234567") }
+        its(:valid?) { is_expected.to eq(true) }
+      end
     end
 
     context "when the IBAN was created from a pseudo-IBAN" do
@@ -198,9 +267,17 @@ describe Ibandit::IBAN do
       its(:iban) { is_expected.to eq("SE5412000000012810105723") }
       its(:pseudo_iban) { is_expected.to eq("SEZZX1281XXX0105723") }
       its(:to_s) { is_expected.to eq("SE5412000000012810105723") }
+      its(:valid?) { is_expected.to eq(true) }
     end
 
     context "when the IBAN was created from a Swedish IBAN" do
+      context "with check digits that make it look like a pseudo-IBAN" do
+        let(:arg) { "SEZZ30000000031231234567" }
+
+        its(:country_code) { is_expected.to eq("SE") }
+        its(:valid?) { is_expected.to eq(false) }
+      end
+
       context "where the clearing code is part of the account number" do
         let(:arg) { "SE4730000000031231234567" }
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 1.23.0
+  version: 1.25.0
 platform: ruby
 authors:
 - GoCardless
 bindir: bin
 cert_chain: []
-date: 2025-02-14 00:00:00.000000000 Z
+date: 2025-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n