ibandit 1.22.0 → 1.24.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: faf16b69bbbfe2f9e23af48f06e9ef798078f052007d85cd8ab58830f4d89876
-  data.tar.gz: 2555633561836b3f6d4ed7872f8c3d7ea1f59515fa9b8c1ba203e102666f02e8
+  metadata.gz: 6f8f92719cd4de9683bfd0c36a84550b67a0ab89f99ae760f6f2105f9b5ddd62
+  data.tar.gz: 0b1e3547051b10705bfbc75e924611875170b2324085f1db509060ec84c59890
 SHA512:
-  metadata.gz: 2765fcfbd6a091459893507ba8735d2e56b6375b655a0078fd38f5fc1ab70be59b216359f2d2eb9670e753615ecbf5e701cac1d226de35f19312a34b972053d9
-  data.tar.gz: 417c2114fe7ce1734374bff18b83981cea03f4de9a4b6db1c9428f9b4455ab6a13cb724a8f6bb85bc06bf8e9d59df8f0e8e2eea49a448478fabc7f385a51bd30
+  metadata.gz: b368ac91d2fa12f4691a165b0de4150a23e8c5a0a14b04b9ac17d4cc496d594a9cbf0308fec594afccbfed262bb8557bceabfe1a453c11df5e24093fa970783a
+  data.tar.gz: 591482c2f7f33c37515214084c708a061cedce5d0575f20a1fd63bc642b53b7a3a223785640ae7b8736a40ee9de5a0ab30828b0b2d4c27e40f5187f2f38ecfb7

data/.gitignore

@@ -2,3 +2,4 @@ Gemfile.lock
 .bundle
 *.gem
 .DS_Store
+.idea

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 1.24.0 - February 18, 2025
+
+- Fix validation for SE IBANs where the account number starts with a 0 and the clearing number is not included in the IBAN
+
+## 1.23.0 - February 14, 2025
+
+- Fix validation for SE IBANs for clearing code 3300 where the account number starts with a 0
+
 ## 1.22.0 - January 22, 2025
 
 - Remove support for Ruby < 3.1, add support for Ruby >= 3.4

data/data/raw/swedish_bank_lookup.yml

@@ -5,6 +5,8 @@
 # - As of 30/10/2020: https://www.bankgirot.se/globalassets/dokument/anvandarmanualer/bankernaskontonummeruppbyggnad_anvandarmanual_sv.pdf
 # - Swedish Bankers' Association clearing numbers: https://www.swedishbankers.se/media/4245/1906_clearingnummer-institut.pdf
 # - https://transferwise.com/gb/iban/sweden
+# - Bankgirot: https://www.bankgirot.se/globalassets/dokument/anvandarmanualer/bankernaskontonummeruppbyggnad_anvandarmanual_sv.pdf
+# - Svensk betalinfrastruktur: https://www.bankinfrastruktur.se/framtidens-betalningsinfrastruktur/iban-och-svenskt-nationellt-kontonummer
 #
 # Fields:
 # - Range:                  The range of clearing codes for this bank. Used to
@@ -79,6 +81,7 @@
   :bank: Nordea Personkonto
   # NOTE: We're routing Nordea Personkonto to the main Nordea bank code, but
   # it may belong at one of the other Nordea codes we're not currently using.
+  # Account numbers for this clearing number are the same as personal ID numbers.
   :bank_code: 300
   :clearing_code_length: 4
   :serial_number_length: 10
@@ -117,7 +120,7 @@
   :clearing_code_length: 4
   :serial_number_length: 10
   :zerofill_serial_number: false
-  :include_clearing_code: fase
+  :include_clearing_code: false
   :validation_scheme: '2.1'
 - :range: [3783, 3999]
   :bank: Nordea

data/lib/ibandit/sweden/validator.rb

@@ -64,7 +64,7 @@ module Ibandit
           length += bank[:clearing_code_length] if bank[:include_clearing_code]
 
           cleaned_account_number = account_number.gsub(/\A0+/, "")
-          if bank[:zerofill_serial_number] && !bank[:include_clearing_code]
+          if !bank[:include_clearing_code]
             cleaned_account_number =
               cleaned_account_number.
                 rjust(bank.fetch(:serial_number_length), "0")

data/lib/ibandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ibandit
-  VERSION = "1.22.0"
+  VERSION = "1.24.0"
 end

data/spec/ibandit/iban_spec.rb

@@ -183,6 +183,74 @@ describe Ibandit::IBAN do
       its(:iban) { is_expected.to eq("SE5412000000012810105723") }
       its(:pseudo_iban) { is_expected.to eq("SEZZX1281XXX0105723") }
       its(:to_s) { is_expected.to eq("SE5412000000012810105723") }
+
+      context "and the clearing code is not part of the IBAN" do
+        context "and the branch code allows for zero-filling of short account numbers" do
+          let(:arg) do
+            {
+              country_code: "SE",
+              branch_code: "6000",
+              account_number: "1234567",
+            }
+          end
+
+          its(:country_code) { is_expected.to eq("SE") }
+          its(:bank_code) { is_expected.to be_nil }
+          its(:branch_code) { is_expected.to eq("6000") }
+          its(:account_number) { is_expected.to eq("001234567") }
+          its(:swift_bank_code) { is_expected.to eq("600") }
+          its(:swift_branch_code) { is_expected.to be_nil }
+          its(:swift_account_number) { is_expected.to eq("00000000001234567") }
+          its(:iban) { is_expected.to eq("SE2260000000000001234567") }
+          its(:pseudo_iban) { is_expected.to eq("SEZZX6000X001234567") }
+          its(:to_s) { is_expected.to eq("SE2260000000000001234567") }
+          its(:valid?) { is_expected.to eq(true) }
+        end
+
+        context "and the branch code does not allow for zero-filling of short account numbers" do
+          let(:arg) do
+            {
+              country_code: "SE",
+              branch_code: "3300",
+              account_number: "1234567",
+            }
+          end
+
+          its(:country_code) { is_expected.to eq("SE") }
+          its(:bank_code) { is_expected.to be_nil }
+          its(:branch_code) { is_expected.to eq("3300") }
+          its(:account_number) { is_expected.to eq("1234567") }
+          its(:swift_bank_code) { is_expected.to eq("300") }
+          its(:swift_branch_code) { is_expected.to be_nil }
+          its(:swift_account_number) { is_expected.to eq("00000000001234567") }
+          its(:iban) { is_expected.to eq("SE4130000000000001234567") }
+          its(:pseudo_iban) { is_expected.to eq("SEZZX3300XXX1234567") }
+          its(:to_s) { is_expected.to eq("SE4130000000000001234567") }
+          its(:valid?) { is_expected.to eq(false) }
+        end
+      end
+
+      context "and the clearing code is part of the IBAN" do
+        let(:arg) do
+          {
+            country_code: "SE",
+            branch_code: "3410",
+            account_number: "1234567",
+          }
+        end
+
+        its(:country_code) { is_expected.to eq("SE") }
+        its(:bank_code) { is_expected.to be_nil }
+        its(:branch_code) { is_expected.to eq("3410") }
+        its(:account_number) { is_expected.to eq("1234567") }
+        its(:swift_bank_code) { is_expected.to eq("300") }
+        its(:swift_branch_code) { is_expected.to be_nil }
+        its(:swift_account_number) { is_expected.to eq("00000034101234567") }
+        its(:iban) { is_expected.to eq("SE1030000000034101234567") }
+        its(:pseudo_iban) { is_expected.to eq("SEZZX3410XXX1234567") }
+        its(:to_s) { is_expected.to eq("SE1030000000034101234567") }
+        its(:valid?) { is_expected.to eq(true) }
+      end
     end
 
     context "when the IBAN was created from a pseudo-IBAN" do
@@ -200,6 +268,90 @@ describe Ibandit::IBAN do
       its(:to_s) { is_expected.to eq("SE5412000000012810105723") }
     end
 
+    context "when the IBAN was created from a Swedish IBAN" do
+      context "where the clearing code is part of the account number" do
+        let(:arg) { "SE4730000000031231234567" }
+
+        its(:country_code) { is_expected.to eq("SE") }
+        its(:bank_code) { is_expected.to be_nil }
+        its(:branch_code) { is_expected.to be_nil }
+        its(:account_number) { is_expected.to be_nil }
+        its(:swift_bank_code) { is_expected.to eq("300") }
+        its(:swift_branch_code) { is_expected.to be_nil }
+        its(:swift_account_number) { is_expected.to eq("00000031231234567") }
+        its(:iban) { is_expected.to eq("SE4730000000031231234567") }
+        its(:pseudo_iban) { is_expected.to be_nil }
+        its(:to_s) { is_expected.to eq("SE4730000000031231234567") }
+        its(:valid?) { is_expected.to eq(true) }
+      end
+
+      context "where the clearing code is not part of the account number" do
+        let(:arg) { "SE7160000000000123456789" }
+
+        its(:country_code) { is_expected.to eq("SE") }
+        its(:bank_code) { is_expected.to be_nil }
+        its(:branch_code) { is_expected.to be_nil }
+        its(:account_number) { is_expected.to be_nil }
+        its(:swift_bank_code) { is_expected.to eq("600") }
+        its(:swift_branch_code) { is_expected.to be_nil }
+        its(:swift_account_number) { is_expected.to eq("00000000123456789") }
+        its(:iban) { is_expected.to eq("SE7160000000000123456789") }
+        its(:pseudo_iban) { is_expected.to be_nil }
+        its(:to_s) { is_expected.to eq("SE7160000000000123456789") }
+        its(:valid?) { is_expected.to eq(true) }
+      end
+
+      context "where the clearing code is 3300, and therefore the account number is the national ID" do
+        context "where the person was born in the 1990s" do
+          let(:arg) { "SE2130000000009308127392" }
+
+          its(:country_code) { is_expected.to eq("SE") }
+          its(:bank_code) { is_expected.to be_nil }
+          its(:branch_code) { is_expected.to be_nil }
+          its(:account_number) { is_expected.to be_nil }
+          its(:swift_bank_code) { is_expected.to eq("300") }
+          its(:swift_branch_code) { is_expected.to be_nil }
+          its(:swift_account_number) { is_expected.to eq("00000009308127392") }
+          its(:iban) { is_expected.to eq("SE2130000000009308127392") }
+          its(:pseudo_iban) { is_expected.to be_nil }
+          its(:to_s) { is_expected.to eq("SE2130000000009308127392") }
+          its(:valid?) { is_expected.to eq(true) }
+        end
+
+        context "where the person was born in the 2000s" do
+          let(:arg) { "SE9430000000000607274287" }
+
+          its(:country_code) { is_expected.to eq("SE") }
+          its(:bank_code) { is_expected.to be_nil }
+          its(:branch_code) { is_expected.to be_nil }
+          its(:account_number) { is_expected.to be_nil }
+          its(:swift_bank_code) { is_expected.to eq("300") }
+          its(:swift_branch_code) { is_expected.to be_nil }
+          its(:swift_account_number) { is_expected.to eq("00000000607274287") }
+          its(:iban) { is_expected.to eq("SE9430000000000607274287") }
+          its(:pseudo_iban) { is_expected.to be_nil }
+          its(:to_s) { is_expected.to eq("SE9430000000000607274287") }
+          its(:valid?) { is_expected.to eq(true) }
+        end
+
+        context "where the person was born in the year 2000" do
+          let(:arg) { "SE3830000000000007134937" }
+
+          its(:country_code) { is_expected.to eq("SE") }
+          its(:bank_code) { is_expected.to be_nil }
+          its(:branch_code) { is_expected.to be_nil }
+          its(:account_number) { is_expected.to be_nil }
+          its(:swift_bank_code) { is_expected.to eq("300") }
+          its(:swift_branch_code) { is_expected.to be_nil }
+          its(:swift_account_number) { is_expected.to eq("00000000007134937") }
+          its(:iban) { is_expected.to eq("SE3830000000000007134937") }
+          its(:pseudo_iban) { is_expected.to be_nil }
+          its(:to_s) { is_expected.to eq("SE3830000000000007134937") }
+          its(:valid?) { is_expected.to eq(true) }
+        end
+      end
+    end
+
     context "when the IBAN was created with local details for Australia" do
       let(:arg) do
         {

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 1.22.0
+  version: 1.24.0
 platform: ruby
 authors:
 - GoCardless
 bindir: bin
 cert_chain: []
-date: 2025-01-23 00:00:00.000000000 Z
+date: 2025-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n