ibandit 1.21.0 → 1.27.0

data/spec/ibandit/iban_spec.rb

@@ -11,9 +11,7 @@ describe Ibandit::IBAN do
   its(:iban) { is_expected.to eq(iban_code) }
 
   context "with locales" do
-    all_keys = YAML.safe_load(
-      File.read("config/locales/en.yml"),
-    )["en"]["ibandit"].keys
+    all_keys = YAML.safe_load_file("config/locales/en.yml")["en"]["ibandit"].keys
 
     Ibandit::Constants::SUPPORTED_LOCALES.each do |locale|
       context "for #{locale}", locale: locale do
@@ -129,19 +127,19 @@ describe Ibandit::IBAN do
     end
 
     context "when the IBAN was created from a Belgian IBAN" do
-      let(:iban_code) { "BE62510007547061" }
+      let(:iban_code) { "BE68539007547034" }
 
       its(:country_code) { is_expected.to eq("BE") }
-      its(:bank_code) { is_expected.to eq("510") }
+      its(:bank_code) { is_expected.to eq("539") }
       its(:branch_code) { is_expected.to be_nil }
-      its(:account_number) { is_expected.to eq("510007547061") }
+      its(:account_number) { is_expected.to eq("539007547034") }
       its(:account_number_suffix) { is_expected.to be_nil }
-      its(:swift_bank_code) { is_expected.to eq("510") }
+      its(:swift_bank_code) { is_expected.to eq("539") }
       its(:swift_branch_code) { is_expected.to be_nil }
-      its(:swift_account_number) { is_expected.to eq("510007547061") }
-      its(:swift_national_id) { is_expected.to eq("510") }
-      its(:local_check_digits) { is_expected.to eq("61") }
-      its(:bban) { is_expected.to eq("510007547061") }
+      its(:swift_account_number) { is_expected.to eq("539007547034") }
+      its(:swift_national_id) { is_expected.to eq("539") }
+      its(:local_check_digits) { is_expected.to eq("34") }
+      its(:bban) { is_expected.to eq("539007547034") }
     end
 
     context "when the IBAN was created with local details" do
@@ -185,6 +183,75 @@ describe Ibandit::IBAN do
       its(:iban) { is_expected.to eq("SE5412000000012810105723") }
       its(:pseudo_iban) { is_expected.to eq("SEZZX1281XXX0105723") }
       its(:to_s) { is_expected.to eq("SE5412000000012810105723") }
+      its(:valid?) { is_expected.to eq(true) }
+
+      context "and the clearing code is not part of the IBAN" do
+        context "and the branch code allows for zero-filling of short account numbers" do
+          let(:arg) do
+            {
+              country_code: "SE",
+              branch_code: "6000",
+              account_number: "1234567",
+            }
+          end
+
+          its(:country_code) { is_expected.to eq("SE") }
+          its(:bank_code) { is_expected.to be_nil }
+          its(:branch_code) { is_expected.to eq("6000") }
+          its(:account_number) { is_expected.to eq("001234567") }
+          its(:swift_bank_code) { is_expected.to eq("600") }
+          its(:swift_branch_code) { is_expected.to be_nil }
+          its(:swift_account_number) { is_expected.to eq("00000000001234567") }
+          its(:iban) { is_expected.to eq("SE2260000000000001234567") }
+          its(:pseudo_iban) { is_expected.to eq("SEZZX6000X001234567") }
+          its(:to_s) { is_expected.to eq("SE2260000000000001234567") }
+          its(:valid?) { is_expected.to eq(true) }
+        end
+
+        context "and the branch code does not allow for zero-filling of short account numbers" do
+          let(:arg) do
+            {
+              country_code: "SE",
+              branch_code: "3300",
+              account_number: "1234567",
+            }
+          end
+
+          its(:country_code) { is_expected.to eq("SE") }
+          its(:bank_code) { is_expected.to be_nil }
+          its(:branch_code) { is_expected.to eq("3300") }
+          its(:account_number) { is_expected.to eq("1234567") }
+          its(:swift_bank_code) { is_expected.to eq("300") }
+          its(:swift_branch_code) { is_expected.to be_nil }
+          its(:swift_account_number) { is_expected.to eq("00000000001234567") }
+          its(:iban) { is_expected.to eq("SE4130000000000001234567") }
+          its(:pseudo_iban) { is_expected.to eq("SEZZX3300XXX1234567") }
+          its(:to_s) { is_expected.to eq("SE4130000000000001234567") }
+          its(:valid?) { is_expected.to eq(false) }
+        end
+      end
+
+      context "and the clearing code is part of the IBAN" do
+        let(:arg) do
+          {
+            country_code: "SE",
+            branch_code: "3410",
+            account_number: "1234567",
+          }
+        end
+
+        its(:country_code) { is_expected.to eq("SE") }
+        its(:bank_code) { is_expected.to be_nil }
+        its(:branch_code) { is_expected.to eq("3410") }
+        its(:account_number) { is_expected.to eq("1234567") }
+        its(:swift_bank_code) { is_expected.to eq("300") }
+        its(:swift_branch_code) { is_expected.to be_nil }
+        its(:swift_account_number) { is_expected.to eq("00000034101234567") }
+        its(:iban) { is_expected.to eq("SE1030000000034101234567") }
+        its(:pseudo_iban) { is_expected.to eq("SEZZX3410XXX1234567") }
+        its(:to_s) { is_expected.to eq("SE1030000000034101234567") }
+        its(:valid?) { is_expected.to eq(true) }
+      end
     end
 
     context "when the IBAN was created from a pseudo-IBAN" do
@@ -200,6 +267,98 @@ describe Ibandit::IBAN do
       its(:iban) { is_expected.to eq("SE5412000000012810105723") }
       its(:pseudo_iban) { is_expected.to eq("SEZZX1281XXX0105723") }
       its(:to_s) { is_expected.to eq("SE5412000000012810105723") }
+      its(:valid?) { is_expected.to eq(true) }
+    end
+
+    context "when the IBAN was created from a Swedish IBAN" do
+      context "with check digits that make it look like a pseudo-IBAN" do
+        let(:arg) { "SEZZ30000000031231234567" }
+
+        its(:country_code) { is_expected.to eq("SE") }
+        its(:valid?) { is_expected.to eq(false) }
+      end
+
+      context "where the clearing code is part of the account number" do
+        let(:arg) { "SE4730000000031231234567" }
+
+        its(:country_code) { is_expected.to eq("SE") }
+        its(:bank_code) { is_expected.to be_nil }
+        its(:branch_code) { is_expected.to be_nil }
+        its(:account_number) { is_expected.to be_nil }
+        its(:swift_bank_code) { is_expected.to eq("300") }
+        its(:swift_branch_code) { is_expected.to be_nil }
+        its(:swift_account_number) { is_expected.to eq("00000031231234567") }
+        its(:iban) { is_expected.to eq("SE4730000000031231234567") }
+        its(:pseudo_iban) { is_expected.to be_nil }
+        its(:to_s) { is_expected.to eq("SE4730000000031231234567") }
+        its(:valid?) { is_expected.to eq(true) }
+      end
+
+      context "where the clearing code is not part of the account number" do
+        let(:arg) { "SE7160000000000123456789" }
+
+        its(:country_code) { is_expected.to eq("SE") }
+        its(:bank_code) { is_expected.to be_nil }
+        its(:branch_code) { is_expected.to be_nil }
+        its(:account_number) { is_expected.to be_nil }
+        its(:swift_bank_code) { is_expected.to eq("600") }
+        its(:swift_branch_code) { is_expected.to be_nil }
+        its(:swift_account_number) { is_expected.to eq("00000000123456789") }
+        its(:iban) { is_expected.to eq("SE7160000000000123456789") }
+        its(:pseudo_iban) { is_expected.to be_nil }
+        its(:to_s) { is_expected.to eq("SE7160000000000123456789") }
+        its(:valid?) { is_expected.to eq(true) }
+      end
+
+      context "where the clearing code is 3300, and therefore the account number is the national ID" do
+        context "where the person was born in the 1990s" do
+          let(:arg) { "SE2130000000009308127392" }
+
+          its(:country_code) { is_expected.to eq("SE") }
+          its(:bank_code) { is_expected.to be_nil }
+          its(:branch_code) { is_expected.to be_nil }
+          its(:account_number) { is_expected.to be_nil }
+          its(:swift_bank_code) { is_expected.to eq("300") }
+          its(:swift_branch_code) { is_expected.to be_nil }
+          its(:swift_account_number) { is_expected.to eq("00000009308127392") }
+          its(:iban) { is_expected.to eq("SE2130000000009308127392") }
+          its(:pseudo_iban) { is_expected.to be_nil }
+          its(:to_s) { is_expected.to eq("SE2130000000009308127392") }
+          its(:valid?) { is_expected.to eq(true) }
+        end
+
+        context "where the person was born in the 2000s" do
+          let(:arg) { "SE9430000000000607274287" }
+
+          its(:country_code) { is_expected.to eq("SE") }
+          its(:bank_code) { is_expected.to be_nil }
+          its(:branch_code) { is_expected.to be_nil }
+          its(:account_number) { is_expected.to be_nil }
+          its(:swift_bank_code) { is_expected.to eq("300") }
+          its(:swift_branch_code) { is_expected.to be_nil }
+          its(:swift_account_number) { is_expected.to eq("00000000607274287") }
+          its(:iban) { is_expected.to eq("SE9430000000000607274287") }
+          its(:pseudo_iban) { is_expected.to be_nil }
+          its(:to_s) { is_expected.to eq("SE9430000000000607274287") }
+          its(:valid?) { is_expected.to eq(true) }
+        end
+
+        context "where the person was born in the year 2000" do
+          let(:arg) { "SE3830000000000007134937" }
+
+          its(:country_code) { is_expected.to eq("SE") }
+          its(:bank_code) { is_expected.to be_nil }
+          its(:branch_code) { is_expected.to be_nil }
+          its(:account_number) { is_expected.to be_nil }
+          its(:swift_bank_code) { is_expected.to eq("300") }
+          its(:swift_branch_code) { is_expected.to be_nil }
+          its(:swift_account_number) { is_expected.to eq("00000000007134937") }
+          its(:iban) { is_expected.to eq("SE3830000000000007134937") }
+          its(:pseudo_iban) { is_expected.to be_nil }
+          its(:to_s) { is_expected.to eq("SE3830000000000007134937") }
+          its(:valid?) { is_expected.to eq(true) }
+        end
+      end
     end
 
     context "when the IBAN was created with local details for Australia" do
@@ -640,6 +799,24 @@ describe Ibandit::IBAN do
         its(:to_s) { is_expected.to eq("") }
       end
 
+      context "with a nil account number" do
+        let(:account_number) { nil }
+
+        its(:country_code) { is_expected.to eq("NZ") }
+        its(:bank_code) { is_expected.to eq("11") }
+        its(:branch_code) { is_expected.to eq("2222") }
+        its(:account_number) { is_expected.to eq(nil) }
+        its(:account_number_suffix) { is_expected.to eq(nil) }
+        its(:swift_bank_code) { is_expected.to eq("11") }
+        its(:swift_branch_code) { is_expected.to eq("2222") }
+        its(:swift_account_number) { is_expected.to eq(nil) }
+        its(:swift_national_id) { is_expected.to eq("112222") }
+        its(:iban) { is_expected.to be_nil }
+        its(:pseudo_iban) { is_expected.to eq(nil) }
+        its(:valid?) { is_expected.to eq(false) }
+        its(:to_s) { is_expected.to eq("") }
+      end
+
       context "with bank and branch code embedded in account_number field" do
         let(:arg) do
           {
@@ -869,6 +1046,23 @@ describe Ibandit::IBAN do
         expect(subject.errors).to eq(account_number: "format is invalid")
       end
     end
+
+    # Spanish IBANs have recently switched to 8 character national IDs
+    context "with a Spanish IBAN" do
+      let(:iban_code) { "ES9121000418450200051332" }
+
+      its(:country_code) { is_expected.to eq("ES") }
+      its(:bank_code) { is_expected.to eq("2100") }
+      its(:branch_code) { is_expected.to eq("0418") }
+      its(:account_number) { is_expected.to eq("450200051332") }
+      its(:account_number_suffix) { is_expected.to be_nil }
+      its(:swift_bank_code) { is_expected.to eq("2100") }
+      its(:swift_branch_code) { is_expected.to eq("0418") }
+      its(:swift_account_number) { is_expected.to eq("450200051332") }
+      its(:swift_national_id) { is_expected.to eq("21000418") }
+      its(:local_check_digits) { is_expected.to eq("45") }
+      its(:bban) { is_expected.to eq("21000418450200051332") }
+    end
   end
 
   describe "#to_s" do
@@ -1318,12 +1512,11 @@ describe Ibandit::IBAN do
           valid_branch_code?: valid_branch_code,
           valid_account_number?: valid_account_number,
         )
+        iban.valid_local_modulus_check?
       end
 
       after { Ibandit.modulus_checker = nil }
 
-      before { iban.valid_local_modulus_check? }
-
       context "with an invalid bank code" do
         let(:iban_code) { "AT611904300234573201" }
         let(:valid_bank_code) { false }
@@ -1351,12 +1544,13 @@ describe Ibandit::IBAN do
         let(:valid_branch_code) { false }
         let(:valid_account_number) { true }
 
-        before { Ibandit.bic_finder = double(call: "BARCGB22XXX") }
+        before do
+          Ibandit.bic_finder = double(call: "BARCGB22XXX")
+          iban.valid_local_modulus_check?
+        end
 
         after { Ibandit.bic_finder = nil }
 
-        before { iban.valid_local_modulus_check? }
-
         it "calls valid_branch_code? with an IBAN object" do
           expect(Ibandit.modulus_checker).
             to receive(:valid_branch_code?).
@@ -2235,6 +2429,31 @@ describe Ibandit::IBAN do
       let(:valid_iban) { "RU0204452560040702810412345678901" }
       let(:invalid_iban) { "RUXX0204452560040702810412345678901" }
     end
+
+    it_behaves_like "a country's IBAN", "SO" do
+      let(:valid_iban) { "SO211000001001000100141" }
+      let(:invalid_iban) { "SO411000001001000100141" }
+    end
+
+    it_behaves_like "a country's IBAN", "NI" do
+      let(:valid_iban) { "NI45BAPR00000013000003558124" }
+      let(:invalid_iban) { "NI55BAPR00000013000003558124" }
+    end
+
+    it_behaves_like "a country's IBAN", "FK" do
+      let(:valid_iban) { "FK88SC123456789012" }
+      let(:invalid_iban) { "FK8SC123456789012" }
+    end
+
+    it_behaves_like "a country's IBAN", "OM" do
+      let(:valid_iban) { "OM810180000001299123456" }
+      let(:invalid_iban) { "OM10180000001299123456" }
+    end
+
+    it_behaves_like "a country's IBAN", "YE" do
+      let(:valid_iban) { "YE15CBYE0001018861234567891234" }
+      let(:invalid_iban) { "YE1CBYE0001018861234567891234" }
+    end
   end
 
   describe "#local_check_digits" do

metadata

@@ -1,113 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 1.21.0
+  version: 1.27.0
 platform: ruby
 authors:
 - GoCardless
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-08-06 00:00:00.000000000 Z
+date: 2025-09-08 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: gc_ruboconfig
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.0'
-- !ruby/object:Gem::Dependency
-  name: nokogiri
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.6'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.6'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.13'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.13'
-- !ruby/object:Gem::Dependency
-  name: pry-byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.10'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.10'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.12'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.12'
-- !ruby/object:Gem::Dependency
-  name: rspec-its
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.2'
-- !ruby/object:Gem::Dependency
-  name: sax-machine
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
@@ -157,7 +58,7 @@ files:
 - config/locales/sl.yml
 - config/locales/sv.yml
 - data/german_iban_rules.yml
-- data/raw/BLZ2.txt
+- data/raw/BLZ2.xml
 - data/raw/IBANSTRUCTURE.xml
 - data/raw/IBAN_Registry.txt
 - data/raw/pseudo_ibans.yml
@@ -199,7 +100,6 @@ licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -214,8 +114,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
-signing_key:
+rubygems_version: 3.6.2
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.
 test_files: []