ibandit 1.2.1 → 1.4.1

data/lib/ibandit/errors.rb

@@ -2,5 +2,6 @@
 
 module Ibandit
   class InvalidCharacterError < StandardError; end
+
   class UnsupportedAccountDetails < StandardError; end
 end

data/lib/ibandit/german_details_converter.rb

@@ -307,7 +307,7 @@ module Ibandit
         end
 
         def sum_of_weighted_values
-          weighted_values.reduce(0, &:+)
+          weighted_values.sum
         end
 
         def weighted_values
@@ -550,7 +550,7 @@ module Ibandit
         end
 
         def sum_of_weighted_digits
-          weighted_digits.reduce(0, &:+)
+          weighted_digits.sum
         end
 
         def weighted_digits

data/lib/ibandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ibandit
-  VERSION = "1.2.1"
+  VERSION = "1.4.1"
 end

data/spec/fixtures/germany_integration_test_cases.json

@@ -134,7 +134,7 @@
   {
     "convertor": "001400",
     "valid": [
-      { "bank_code": "10090603", "account_number": "60624", "converted_bank_code": "30060601" }
+      { "bank_code": "30060601", "account_number": "60624", "converted_bank_code": "30060601" }
     ]
   },
   {

data/spec/ibandit/iban_assembler_spec.rb

@@ -11,7 +11,7 @@ describe Ibandit::IBANAssembler do
         account_number: iban.swift_account_number,
         branch_code: iban.swift_branch_code,
         bank_code: iban.swift_bank_code,
-      }.reject { |_key, value| value.nil? }
+      }.compact
     end
 
     it "successfully reconstructs the IBAN" do

data/spec/ibandit/iban_spec.rb

@@ -422,7 +422,7 @@ describe Ibandit::IBAN do
         its(:swift_bank_code) { is_expected.to eq("0036") }
         its(:swift_branch_code) { is_expected.to eq("00063") }
         its(:swift_account_number) { is_expected.to eq("000000123456") }
-        its(:swift_national_id) { is_expected.to eq("0036") }
+        its(:swift_national_id) { is_expected.to eq("003600063") }
         its(:pseudo_iban) { is_expected.to eq("CAZZ003600063000000123456") }
 
         its(:iban) { is_expected.to be_nil }
@@ -441,7 +441,7 @@ describe Ibandit::IBAN do
         its(:swift_bank_code) { is_expected.to eq("36") }
         its(:swift_branch_code) { is_expected.to eq("00063") }
         its(:swift_account_number) { is_expected.to eq("000000123456") }
-        its(:swift_national_id) { is_expected.to eq("3600") }
+        its(:swift_national_id) { is_expected.to eq("3600063") }
         its(:pseudo_iban) { is_expected.to eq("CAZZ__3600063000000123456") }
 
         its(:iban) { is_expected.to be_nil }
@@ -460,7 +460,7 @@ describe Ibandit::IBAN do
         its(:swift_bank_code) { is_expected.to eq("0036") }
         its(:swift_branch_code) { is_expected.to eq("00063") }
         its(:swift_account_number) { is_expected.to eq("000000123456") }
-        its(:swift_national_id) { is_expected.to eq("0036") }
+        its(:swift_national_id) { is_expected.to eq("003600063") }
         its(:pseudo_iban) { is_expected.to eq("CAZZ003600063000000123456") }
 
         its(:iban) { is_expected.to be_nil }
@@ -486,7 +486,7 @@ describe Ibandit::IBAN do
         its(:swift_bank_code) { is_expected.to eq("0036") }
         its(:swift_branch_code) { is_expected.to eq("00063") }
         its(:swift_account_number) { is_expected.to eq("012345678900") }
-        its(:swift_national_id) { is_expected.to eq("0036") }
+        its(:swift_national_id) { is_expected.to eq("003600063") }
         its(:pseudo_iban) { is_expected.to eq("CAZZ003600063012345678900") }
 
         its(:iban) { is_expected.to be_nil }
@@ -3132,7 +3132,7 @@ describe Ibandit::IBAN do
     end
 
     context "for a valid Belgian IBAN" do
-      let(:iban_code) { "BE62 5100 0754 7061" }
+      let(:iban_code) { "BE68 5390 0754 7034" }
 
       it { is_expected.to be_valid }
     end
@@ -3179,6 +3179,18 @@ describe Ibandit::IBAN do
       it { is_expected.to_not be_valid }
     end
 
+    context "for a valid Costa Rican IBAN" do
+      let(:iban_code) { "CR05 0152 0200 1026 2840 66" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "for an invalid Costa Rican IBAN" do
+      let(:iban_code) { "CR05 0152 0200 1026 2840" }
+
+      it { is_expected.to_not be_valid }
+    end
+
     context "for a valid Cypriot IBAN" do
       let(:iban_code) { "CY17 0020 0128 0000 0012 0052 7600" }
 
@@ -3215,6 +3227,18 @@ describe Ibandit::IBAN do
       it { is_expected.to_not be_valid }
     end
 
+    context "for a valid Dominican Republic IBAN" do
+      let(:iban_code) { "DO28 BAGR 0000 0001 2124 5361 1324" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "for an invalid Dominican Republic IBAN" do
+      let(:iban_code) { "DO28 BAGR 0000 0001 2124 5361" }
+
+      it { is_expected.to_not be_valid }
+    end
+
     context "for a valid Estonian IBAN" do
       let(:iban_code) { "EE38 2200 2210 2014 5685" }
 
@@ -3599,6 +3623,18 @@ describe Ibandit::IBAN do
       it { is_expected.to_not be_valid }
     end
 
+    context "for a valid Palestinian IBAN" do
+      let(:iban_code) { "PS92 PALS 0000 0000 0400 1234 5670 2" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "for an invalid Palestinian IBAN" do
+      let(:iban_code) { "PS92 PALS 0000 0000 0400 1234 5670" }
+
+      it { is_expected.to_not be_valid }
+    end
+
     context "for a valid Potuguese IBAN" do
       let(:iban_code) { "PT50 0002 0123 1234 5678 9015 4" }
 
@@ -3623,6 +3659,30 @@ describe Ibandit::IBAN do
       it { is_expected.to_not be_valid }
     end
 
+    context "for a valid Kosovan IBAN" do
+      let(:iban_code) { "XK05 1212 0123 4567 8906" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "for an invalid Kosovan IBAN" do
+      let(:iban_code) { "XK05 1212 0123 4567 890" }
+
+      it { is_expected.to_not be_valid }
+    end
+
+    context "for a valid Timor-Leste IBAN" do
+      let(:iban_code) { "TL38 0080 0123 4567 8910 157" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "for an invalid Timor-Leste IBAN" do
+      let(:iban_code) { "TL38 0080 0123 4567 8910" }
+
+      it { is_expected.to_not be_valid }
+    end
+
     context "for a valid Romanian IBAN" do
       let(:iban_code) { "RO49 AAAA 1B31 0075 9384 0000" }
 
@@ -3778,6 +3838,114 @@ describe Ibandit::IBAN do
 
       it { is_expected.to_not be_valid }
     end
+
+    context "with a valid LC iban" do
+      let(:iban_code) { "LC55 HEMM 0001 0001 0012 0012 0002 3015" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "with an invalid LC iban" do
+      let(:iban_code) { "LC55 HEMM 0001 0001 0012 0012 0002" }
+
+      it { is_expected.to_not be_valid }
+    end
+
+    context "with a valid UA iban" do
+      let(:iban_code) { "UA21 3223 1300 0002 6007 2335 6600 1" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "with an invalid UA iban" do
+      let(:iban_code) { "UA21 3223 1300 0002 6007 2335 6600 " }
+
+      it { is_expected.to_not be_valid }
+    end
+
+    context "with a valid ST iban" do
+      let(:iban_code) { "ST23 0001 0001 0051 8453 1014 6" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "with an invalid ST iban" do
+      let(:iban_code) { "ST23 0001 0001 0051 8453 1014" }
+
+      it { is_expected.to_not be_valid }
+    end
+
+    context "with a valid SC iban" do
+      let(:iban_code) { "SC18 SSCB 1101 0000 0000 0000 1497 USD" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "with an invalid SC iban" do
+      let(:iban_code) { "SC18 SSCB 1101 0000 0000 0000 USD" }
+
+      it { is_expected.to_not be_valid }
+    end
+
+    context "with a valid IQ iban" do
+      let(:iban_code) { "IQ98 NBIQ 8501 2345 6789 012" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "with an invalid IQ iban" do
+      let(:iban_code) { "IQ98 NBIQ 8501 2345 6789" }
+
+      it { is_expected.to_not be_valid }
+    end
+
+    context "with a valid SV iban" do
+      let(:iban_code) { "SV 62 CENR 00000000000000700025" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "with an invalid SV iban" do
+      let(:iban_code) { "SV 62 CENR 00000000000000700" }
+
+      it { is_expected.to_not be_valid }
+    end
+
+    context "with a valid BY iban" do
+      let(:iban_code) { "BY13 NBRB 3600 9000 0000 2Z00 AB00" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "with an invalid BY iban" do
+      let(:iban_code) { "BY13 NBRB 3600 9000 0000 2Z00" }
+
+      it { is_expected.to_not be_valid }
+    end
+
+    context "with a valid VA iban" do
+      let(:iban_code) { "VA59 001 1230 0001 2345 678" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "with an invalid VA iban" do
+      let(:iban_code) { "VA59 001 1230 0001 2345" }
+
+      it { is_expected.to_not be_valid }
+    end
+
+    context "with a valid EG iban" do
+      let(:iban_code) { "EG380019000500000000263180002" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "with an invalid EG iban" do
+      let(:iban_code) { "EG3800190005000000002631800" }
+
+      it { is_expected.to_not be_valid }
+    end
   end
 
   describe "#local_check_digits" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.4.1
 platform: ruby
 authors:
 - GoCardless
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-09-01 00:00:00.000000000 Z
+date: 2021-03-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gc_ruboconfig
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.17.0
+        version: 2.24.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.17.0
+        version: 2.24.0
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -149,6 +149,7 @@ files:
 - ".gitignore"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
+- ".ruby-version"
 - CHANGELOG.md
 - Gemfile
 - LICENSE
@@ -224,7 +225,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.2.3
 signing_key:
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.