ibandit 1.19.0 → 1.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 47171b99a86687a326f6f674684d5faa489f4aef980e623e2f43d3ffdf841d84
-  data.tar.gz: 6074f09b34e39a205fdacabbc1a7376dfec8ac38f2821cbfd1d7ae6a8ba683cf
+  metadata.gz: 2c3c4654f26735c5412bd2cf3f02c1c5802d1fb2c6c9f775f1472ea0660cc0c3
+  data.tar.gz: d67a80fea5521e0eac1f1486aefaf584b886ebf846a5d05e3bce8ec6fee21182
 SHA512:
-  metadata.gz: 9f2ff5eb107524c44c68118315f916d86c7550335bae82747165edbfcf4f11d196b29cd3ec6f130babbf7765866925768dca7b5532357510248e8994e9bca0ae
-  data.tar.gz: 0a66dd61f63feeb8534a6b48de006c64928c6f43bf65463ca8e24ccd412d13aa87fc8b8102a4fb54d5585d70a96df91db50be8117c7c025ac576fb0d033c4909
+  metadata.gz: 8c092c285a2923177c42b7deb1e305e9a2b4b1625d642da44a1bca3adac3667276216f187e947fe3f90009ec4f1b190898cf12236dac52e202ba8df61e99fe45
+  data.tar.gz: f1fcb038c96b3ba56fe53fe92688b2c19e25a9dfcbdc423d387fbceca835afa4e78337bf87ec3f9dee71d5bd5880837ac4f0728a4f67a45a7a2de0135aa230a7

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.20.0 - October 13, 2023
+
+- Do not allow all 0 transit numbers in CA
+
 ## 1.19.0 - October 3, 2023
 
 - Do not allow all-0 account numbers for CA

data/data/raw/pseudo_ibans.yml

@@ -20,7 +20,7 @@ CA:
     end: 12
     excl: false
   :bank_code_format: "\\d{4}"
-  :branch_code_format: "\\d{5}"
+  :branch_code_format: "0{0,4}[1-9][0-9]{0,4}"
   :account_number_format: "(?!0+\\z)\\d{7,12}"
   :national_id_length: 9
   :pseudo_iban_bank_code_length: 4

data/data/structures.yml

@@ -1500,7 +1500,7 @@ CA:
     end: 12
     excl: false
   :bank_code_format: "\\d{4}"
-  :branch_code_format: "\\d{5}"
+  :branch_code_format: 0{0,4}[1-9][0-9]{0,4}
   :account_number_format: "(?!0+\\z)\\d{7,12}"
   :national_id_length: 9
   :pseudo_iban_bank_code_length: 4

data/lib/ibandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ibandit
-  VERSION = "1.19.0"
+  VERSION = "1.20.0"
 end

data/spec/ibandit/iban_spec.rb

@@ -422,10 +422,55 @@ describe Ibandit::IBAN do
         {
           country_code: "CA",
           bank_code: bank_code,
-          branch_code: "00063",
+          branch_code: branch_code,
           account_number: account_number,
         }
       end
+      let(:branch_code) { "00063" }
+
+      context "and a 5 digit branch code" do
+        let(:account_number) { "0123456" }
+        let(:bank_code) { "036" }
+        let(:branch_code) { "00063" }
+
+        its(:country_code) { is_expected.to eq("CA") }
+        its(:bank_code) { is_expected.to eq("0036") }
+        its(:branch_code) { is_expected.to eq("00063") }
+        its(:account_number) { is_expected.to eq("0123456") }
+        its(:swift_bank_code) { is_expected.to eq("0036") }
+        its(:swift_branch_code) { is_expected.to eq("00063") }
+        its(:swift_account_number) { is_expected.to eq("0123456") }
+        its(:swift_national_id) { is_expected.to eq("003600063") }
+        its(:pseudo_iban) { is_expected.to eq("CAZZ003600063_____0123456") }
+
+        its(:iban) { is_expected.to be_nil }
+        its(:valid?) { is_expected.to eq(true) }
+        its(:to_s) { is_expected.to eq("") }
+      end
+
+      context "for an all zero transit number" do
+        let(:account_number) { "0123456" }
+        let(:bank_code) { "036" }
+        let(:branch_code) { "00000" }
+
+        it "is invalid and has the correct errors" do
+          expect(subject.valid?).to eq(false)
+          expect(subject.errors).
+            to eq(branch_code: "format is invalid")
+        end
+      end
+
+      context "and a 4 digit branch code" do
+        let(:account_number) { "0123456" }
+        let(:bank_code) { "036" }
+        let(:branch_code) { "0063" }
+
+        it "is invalid and has the correct errors" do
+          expect(subject.valid?).to eq(false)
+          expect(subject.errors).
+            to eq(branch_code: "is the wrong length (should be 5 characters)")
+        end
+      end
 
       context "and a 3 digit bank code" do
         let(:account_number) { "0123456" }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 1.19.0
+  version: 1.20.0
 platform: ruby
 authors:
 - GoCardless
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-03 00:00:00.000000000 Z
+date: 2023-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gc_ruboconfig