ibandit 1.18.0 → 1.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2b8d022291e78a27b3f3b8dbfdae181ef51a16e40a0a6c3c0635703ea6a683ad
-  data.tar.gz: a231a9d66818be2adbf1b3f94dda0ebc5f9c67aea2b61a0c82d6e5f4b6df96a9
+  metadata.gz: 2c3c4654f26735c5412bd2cf3f02c1c5802d1fb2c6c9f775f1472ea0660cc0c3
+  data.tar.gz: d67a80fea5521e0eac1f1486aefaf584b886ebf846a5d05e3bce8ec6fee21182
 SHA512:
-  metadata.gz: 1ad4e13578ab1109950350378fb8f065eef1fb022be994a81fd11f5badbefa788a9e38b536fdc2f233f1098bee73bbd3a9854194f76c01bbfaccf5438208e162
-  data.tar.gz: 031a842efe2feeb64ba57036547df074b55adf23399979b856b457aa97d90b20d6ee4da811de7c5c09e881a61d383132a52c44c59475d7cf468da0652923c20a
+  metadata.gz: 8c092c285a2923177c42b7deb1e305e9a2b4b1625d642da44a1bca3adac3667276216f187e947fe3f90009ec4f1b190898cf12236dac52e202ba8df61e99fe45
+  data.tar.gz: f1fcb038c96b3ba56fe53fe92688b2c19e25a9dfcbdc423d387fbceca835afa4e78337bf87ec3f9dee71d5bd5880837ac4f0728a4f67a45a7a2de0135aa230a7

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 1.20.0 - October 13, 2023
+
+- Do not allow all 0 transit numbers in CA
+
+## 1.19.0 - October 3, 2023
+
+- Do not allow all-0 account numbers for CA
+
 ## 1.18.0 - Sept 4, 2023
 
 - Remove Ruby 2.6 support

data/data/raw/pseudo_ibans.yml

@@ -7,7 +7,7 @@ AU:
     end: 10
     excl: false
   :branch_code_format: "\\d{6}"
-  :account_number_format: "[A-Z0-9]{5,10}"
+  :account_number_format: "(?!0+\\z)[A-Z0-9]{5,10}"
   :pseudo_iban_bank_code_length: 0
   :pseudo_iban_branch_code_length: 6
   :pseudo_iban_account_number_length: 10
@@ -20,8 +20,8 @@ CA:
     end: 12
     excl: false
   :bank_code_format: "\\d{4}"
-  :branch_code_format: "\\d{5}"
-  :account_number_format: "\\d{7,12}"
+  :branch_code_format: "0{0,4}[1-9][0-9]{0,4}"
+  :account_number_format: "(?!0+\\z)\\d{7,12}"
   :national_id_length: 9
   :pseudo_iban_bank_code_length: 4
   :pseudo_iban_branch_code_length: 5

data/data/structures.yml

@@ -1487,7 +1487,7 @@ AU:
     end: 10
     excl: false
   :branch_code_format: "\\d{6}"
-  :account_number_format: "[A-Z0-9]{5,10}"
+  :account_number_format: "(?!0+\\z)[A-Z0-9]{5,10}"
   :pseudo_iban_bank_code_length: 0
   :pseudo_iban_branch_code_length: 6
   :pseudo_iban_account_number_length: 10
@@ -1500,8 +1500,8 @@ CA:
     end: 12
     excl: false
   :bank_code_format: "\\d{4}"
-  :branch_code_format: "\\d{5}"
-  :account_number_format: "\\d{7,12}"
+  :branch_code_format: 0{0,4}[1-9][0-9]{0,4}
+  :account_number_format: "(?!0+\\z)\\d{7,12}"
   :national_id_length: 9
   :pseudo_iban_bank_code_length: 4
   :pseudo_iban_branch_code_length: 5

data/lib/ibandit/iban.rb

@@ -386,12 +386,6 @@ module Ibandit
 
     def valid_australian_details?
       return true unless country_code == "AU"
-
-      bsb_check? && account_number_not_all_zeros?
-    end
-
-    def bsb_check?
-      return true unless country_code == "AU"
       return true unless Ibandit.modulus_checker
 
       valid_modulus_check_branch_code?
@@ -550,12 +544,5 @@ module Ibandit
 
       input.slice(2, 2) == Constants::PSEUDO_IBAN_CHECK_DIGITS
     end
-
-    def account_number_not_all_zeros?
-      return true if @swift_account_number.to_s.chars.uniq != ["0"]
-
-      @errors[:account_number] = Ibandit.translate(:is_invalid)
-      false
-    end
   end
 end

data/lib/ibandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ibandit
-  VERSION = "1.18.0"
+  VERSION = "1.20.0"
 end

data/spec/ibandit/iban_spec.rb

@@ -422,10 +422,55 @@ describe Ibandit::IBAN do
         {
           country_code: "CA",
           bank_code: bank_code,
-          branch_code: "00063",
+          branch_code: branch_code,
           account_number: account_number,
         }
       end
+      let(:branch_code) { "00063" }
+
+      context "and a 5 digit branch code" do
+        let(:account_number) { "0123456" }
+        let(:bank_code) { "036" }
+        let(:branch_code) { "00063" }
+
+        its(:country_code) { is_expected.to eq("CA") }
+        its(:bank_code) { is_expected.to eq("0036") }
+        its(:branch_code) { is_expected.to eq("00063") }
+        its(:account_number) { is_expected.to eq("0123456") }
+        its(:swift_bank_code) { is_expected.to eq("0036") }
+        its(:swift_branch_code) { is_expected.to eq("00063") }
+        its(:swift_account_number) { is_expected.to eq("0123456") }
+        its(:swift_national_id) { is_expected.to eq("003600063") }
+        its(:pseudo_iban) { is_expected.to eq("CAZZ003600063_____0123456") }
+
+        its(:iban) { is_expected.to be_nil }
+        its(:valid?) { is_expected.to eq(true) }
+        its(:to_s) { is_expected.to eq("") }
+      end
+
+      context "for an all zero transit number" do
+        let(:account_number) { "0123456" }
+        let(:bank_code) { "036" }
+        let(:branch_code) { "00000" }
+
+        it "is invalid and has the correct errors" do
+          expect(subject.valid?).to eq(false)
+          expect(subject.errors).
+            to eq(branch_code: "format is invalid")
+        end
+      end
+
+      context "and a 4 digit branch code" do
+        let(:account_number) { "0123456" }
+        let(:bank_code) { "036" }
+        let(:branch_code) { "0063" }
+
+        it "is invalid and has the correct errors" do
+          expect(subject.valid?).to eq(false)
+          expect(subject.errors).
+            to eq(branch_code: "is the wrong length (should be 5 characters)")
+        end
+      end
 
       context "and a 3 digit bank code" do
         let(:account_number) { "0123456" }
@@ -491,6 +536,17 @@ describe Ibandit::IBAN do
         its(:valid?) { is_expected.to be false }
       end
 
+      context "and account number has only zeroes in it" do
+        let(:account_number) { "0000000" }
+        let(:bank_code) { "0036" }
+
+        it "is invalid and has the correct errors" do
+          expect(subject.valid?).to eq(false)
+          expect(subject.errors).
+            to eq(account_number: "format is invalid")
+        end
+      end
+
       context "and a 12 digit account number" do
         let(:account_number) { "012345678900" }
         let(:bank_code) { "0036" }
@@ -1662,10 +1718,68 @@ describe Ibandit::IBAN do
     end
   end
 
-  describe "#valid?" do
+  describe "Pseudo IBAN #valid?" do
+    let(:country_code) { "CA" }
+    let(:arg) do
+      {
+        country_code: country_code,
+        bank_code: "0036",
+        branch_code: "00063",
+        account_number: "1234567",
+      }
+    end
+
+    describe "validations called" do
+      after { iban.valid? }
+
+      specify { expect(iban).to receive(:valid_pseudo_iban?).at_least(1) }
+      specify { expect(iban).to receive(:valid_pseudo_iban_check_digits?).at_least(1) }
+      specify { expect(iban).to receive(:valid_country_code?).at_least(1) }
+      specify { expect(iban).to receive(:valid_bank_code_length?).at_least(1) }
+      specify { expect(iban).to receive(:valid_branch_code_length?).at_least(1) }
+      specify { expect(iban).to receive(:valid_account_number_length?).at_least(1) }
+      specify { expect(iban).to receive(:valid_bank_code_format?).at_least(1) }
+      specify { expect(iban).to receive(:valid_branch_code_format?).at_least(1) }
+      specify { expect(iban).to receive(:valid_account_number_format?).at_least(1) }
+      specify { expect(iban).to receive(:passes_country_specific_checks?).at_least(1) }
+
+      context "SE" do
+        let(:country_code) { "SE" }
+
+        specify { expect(iban).to receive(:valid_swedish_details?).at_least(1) }
+      end
+
+      context "AU" do
+        let(:country_code) { "AU" }
+
+        specify { expect(iban).to receive(:valid_australian_details?).at_least(1) }
+      end
+
+      context "NZ" do
+        let(:country_code) { "NZ" }
+
+        specify { expect(iban).to receive(:valid_nz_details?).at_least(1) }
+      end
+
+      context "CA" do
+        let(:country_code) { "CA" }
+
+        specify { expect(iban).to receive(:valid_ca_details?).at_least(1) }
+      end
+
+      context "US" do
+        let(:country_code) { "US" }
+
+        specify { expect(iban).to receive(:bank_code_passes_checksum_test?).at_least(1) }
+      end
+    end
+  end
+
+  describe "IBAN #valid?" do
     describe "validations called" do
       after { iban.valid? }
 
+      specify { expect(iban).to receive(:valid_iban?).at_least(1) }
       specify { expect(iban).to receive(:valid_country_code?).at_least(1) }
       specify { expect(iban).to receive(:valid_characters?).at_least(1) }
       specify { expect(iban).to receive(:valid_check_digits?).at_least(1) }
@@ -1697,6 +1811,18 @@ describe Ibandit::IBAN do
       it "runs country specific checks" do
         expect(iban).to receive(:passes_country_specific_checks?).at_least(1)
       end
+
+      context "DE" do
+        let(:arg) do
+          {
+            country_code: "DE",
+            bank_code: "20000000",
+            account_number: "7955791111",
+          }
+        end
+
+        specify { expect(iban).to receive(:supports_iban_determination?).at_least(1) }
+      end
     end
 
     RSpec.shared_examples "a country's IBAN" do |country_code|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 1.18.0
+  version: 1.20.0
 platform: ruby
 authors:
 - GoCardless
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-09-04 00:00:00.000000000 Z
+date: 2023-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gc_ruboconfig