ibandit 1.13.0 → 1.15.0

data/lib/ibandit/constants.rb

@@ -2,7 +2,7 @@
 
 module Ibandit
   module Constants
-    CONSTRUCTABLE_IBAN_COUNTRY_CODES = %w[AT BE BG CY CZ DE DK EE ES FI FR GB GR
+    CONSTRUCTABLE_IBAN_COUNTRY_CODES = %w[AT BE BG CY CZ DE DK EE ES FI FO FR GB GL GR
                                           HR HU IE IS IT LT LU LV MC MT NL NO PL
                                           PT RO SE SI SK SM].freeze
 
@@ -25,5 +25,9 @@ module Ibandit
       DECONSTRUCTABLE_IBAN_COUNTRY_CODES +
       PSEUDO_IBAN_COUNTRY_CODES
     ).uniq
+
+    SUPPORTED_LOCALES = %w[
+      da de en es fr it nb nl pt sl sv
+    ].freeze
   end
 end

data/lib/ibandit/iban.rb

@@ -64,7 +64,7 @@ module Ibandit
     def account_number_suffix
       return nil unless country_code == "NZ"
 
-      @account_number[7..-1]
+      @account_number[7..]
     end
 
     def local_check_digits
@@ -77,7 +77,7 @@ module Ibandit
     end
 
     def bban
-      iban[4..-1] unless iban.nil?
+      iban[4..] unless iban.nil?
     end
 
     def pseudo_iban
@@ -247,7 +247,7 @@ module Ibandit
       )
         true
       else
-        @errors[:bank_code] = Ibandit.translate(:is_invalid)
+        @errors[:bank_code] = Ibandit.translate(:has_invalid_format)
         false
       end
     end
@@ -261,7 +261,7 @@ module Ibandit
       )
         true
       else
-        @errors[:branch_code] = Ibandit.translate(:is_invalid)
+        @errors[:branch_code] = Ibandit.translate(:has_invalid_format)
         false
       end
     end
@@ -274,7 +274,7 @@ module Ibandit
       )
         true
       else
-        @errors[:account_number] = Ibandit.translate(:is_invalid)
+        @errors[:account_number] = Ibandit.translate(:has_invalid_format)
         false
       end
     end
@@ -332,7 +332,7 @@ module Ibandit
     def valid_swedish_swift_details?
       unless Sweden::Validator.bank_code_exists?(swift_bank_code)
         bank_code_field = bank_code.nil? ? :account_number : :bank_code
-        @errors[bank_code_field] = Ibandit.translate(:is_invalid)
+        @errors[bank_code_field] = Ibandit.translate(:bank_code_does_not_exist)
         @errors.delete(:bank_code) if bank_code.nil?
         return false
       end
@@ -344,7 +344,7 @@ module Ibandit
         )
 
       unless length_valid
-        @errors[:account_number] = Ibandit.translate(:is_invalid)
+        @errors[:account_number] = Ibandit.translate(:has_invalid_length)
         return false
       end
 
@@ -353,7 +353,7 @@ module Ibandit
 
     def valid_swedish_local_details?
       unless Sweden::Validator.valid_clearing_code_length?(branch_code)
-        @errors[:branch_code] = Ibandit.translate(:is_invalid)
+        @errors[:branch_code] = Ibandit.translate(:has_invalid_clearing_code_length)
         return false
       end
 
@@ -363,7 +363,7 @@ module Ibandit
       )
 
       unless valid_serial_number
-        @errors[:account_number] = Ibandit.translate(:is_invalid)
+        @errors[:account_number] = Ibandit.translate(:has_invalid_serial_number)
         return false
       end
 
@@ -410,7 +410,7 @@ module Ibandit
           (1 * (code_digits[2] + code_digits[5] + code_digits[8]))
         ) % 10
 
-      @errors[:bank_code] = Ibandit.translate(:is_invalid) unless mod.zero?
+      @errors[:bank_code] = Ibandit.translate(:failed_checksum_test) unless mod.zero?
 
       mod.zero?
     end
@@ -518,21 +518,21 @@ module Ibandit
     def valid_modulus_check_bank_code?
       return true if Ibandit.modulus_checker.valid_bank_code?(self)
 
-      @errors[:bank_code] = Ibandit.translate(:is_invalid)
+      @errors[:bank_code] = Ibandit.translate(:failed_modulus_check)
       false
     end
 
     def valid_modulus_check_branch_code?
       return true if Ibandit.modulus_checker.valid_branch_code?(self)
 
-      @errors[:branch_code] = Ibandit.translate(:is_invalid)
+      @errors[:branch_code] = Ibandit.translate(:failed_modulus_check)
       false
     end
 
     def valid_modulus_check_account_number?
       return true if Ibandit.modulus_checker.valid_account_number?(self)
 
-      @errors[:account_number] = Ibandit.translate(:is_invalid)
+      @errors[:account_number] = Ibandit.translate(:failed_modulus_check)
       false
     end
 

data/lib/ibandit/iban_assembler.rb

@@ -89,7 +89,7 @@ module Ibandit
 
     def self.required_fields(country_code)
       case country_code
-      when "AT", "CY", "CZ", "DE", "DK", "EE", "FI", "HR", "IS", "LT", "LU",
+      when "AT", "CY", "CZ", "DE", "DK", "EE", "FO", "FI", "GL", "HR", "IS", "LT", "LU",
            "LV", "NL", "NO", "PL", "RO", "SE", "SI", "SK"
         %i[bank_code account_number]
       when "BE"

data/lib/ibandit/local_details_cleaner.rb

@@ -132,7 +132,7 @@ module Ibandit
         if local_details[:branch_code]
           local_details[:branch_code]
         elsif cleaned_bank_code.length > 3
-          cleaned_bank_code[3..-1]
+          cleaned_bank_code[3..]
         end
       account_number =
         if local_details[:account_number].length >= 7
@@ -247,7 +247,7 @@ module Ibandit
 
         bank_code      = cleaned_account_number.slice(0, 4)
         branch_code    = cleaned_account_number.slice(4, 4)
-        account_number = cleaned_account_number[8..-1]
+        account_number = cleaned_account_number[8..]
       end
 
       {
@@ -265,7 +265,7 @@ module Ibandit
         if %w[4 5 6].include?(local_details[:bank_code][0])
           [
             local_details[:account_number][0],
-            local_details[:account_number][1..-1].rjust(7, "0"),
+            local_details[:account_number][1..].rjust(7, "0"),
           ].join
         else
           local_details[:account_number].rjust(8, "0")
@@ -380,7 +380,7 @@ module Ibandit
         bank_code, *parts = local_details[:account_number].split("-")
       else
         bank_code = local_details[:account_number].slice(0, 4)
-        parts = Array(local_details[:account_number][4..-1])
+        parts = Array(local_details[:account_number][4..])
       end
 
       {
@@ -457,7 +457,7 @@ module Ibandit
         cleaned_acct_number = local_details[:account_number].gsub(/[-.\s]/, "")
 
         bank_code      = cleaned_acct_number.slice(0, 4)
-        account_number = cleaned_acct_number[4..-1]
+        account_number = cleaned_acct_number[4..]
       end
 
       {
@@ -483,7 +483,7 @@ module Ibandit
         cleaned_account_number = local_details[:account_number].tr("-", "")
         bank_code = cleaned_account_number.slice(0, 2)
         branch_code = cleaned_account_number.slice(2, 4)
-        account_number = cleaned_account_number[6..-1]
+        account_number = cleaned_account_number[6..]
       end
 
       if account_number && account_number.length == 9
@@ -515,7 +515,7 @@ module Ibandit
         cleaned_acct_number = local_details[:account_number].gsub(/\s/, "")
 
         bank_code      = cleaned_acct_number.slice(2, 8)
-        account_number = cleaned_acct_number[10..-1]
+        account_number = cleaned_acct_number[10..]
       end
 
       {

data/lib/ibandit/sweden/local_details_converter.rb

@@ -73,7 +73,7 @@ module Ibandit
 
       def serial_number
         serial_number = if @branch_code.nil?
-                          cleaned_account_number[clearing_code_length..-1]
+                          cleaned_account_number[clearing_code_length..]
                         else
                           cleaned_account_number
                         end

data/lib/ibandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ibandit
-  VERSION = "1.13.0"
+  VERSION = "1.15.0"
 end

data/lib/ibandit.rb

@@ -37,7 +37,7 @@ module Ibandit
     end
 
     def translate(key, options = {})
-      I18n.translate(key, scope: [:ibandit], **options)
+      I18n.translate(key, scope: [:ibandit], **options.merge(raise: true))
     end
   end
 end

data/spec/ibandit/iban_assembler_spec.rb

@@ -210,6 +210,54 @@ describe Ibandit::IBANAssembler do
       end
     end
 
+    context "with FO as the country_code" do
+      let(:args) do
+        { country_code: "FO",
+          bank_code: "1199",
+          account_number: "0003179680" }
+      end
+
+      it { is_expected.to eq("FO9111990003179680") }
+
+      it_behaves_like "allows round trips", "FO91 1199 0003 1796 80"
+
+      context "without a bank_code" do
+        before { args.delete(:bank_code) }
+
+        it { is_expected.to be_nil }
+      end
+
+      context "without an account_number" do
+        before { args.delete(:account_number) }
+
+        it { is_expected.to be_nil }
+      end
+    end
+
+    context "with GL as the country_code" do
+      let(:args) do
+        { country_code: "GL",
+          bank_code: "1199",
+          account_number: "0003179680" }
+      end
+
+      it { is_expected.to eq("GL9111990003179680") }
+
+      it_behaves_like "allows round trips", "GL91 1199 0003 1796 80"
+
+      context "without a bank_code" do
+        before { args.delete(:bank_code) }
+
+        it { is_expected.to be_nil }
+      end
+
+      context "without an account_number" do
+        before { args.delete(:account_number) }
+
+        it { is_expected.to be_nil }
+      end
+    end
+
     context "with EE as the country_code" do
       let(:args) do
         {