ibandit 1.12.0 → 1.14.0

data/ibandit.gemspec

@@ -3,7 +3,7 @@
 require File.expand_path("lib/ibandit/version", __dir__)
 
 Gem::Specification.new do |gem|
-  gem.add_development_dependency "gc_ruboconfig",   "~> 3.3.0"
+  gem.add_development_dependency "gc_ruboconfig",   "~> 3.6.2"
   gem.add_development_dependency "nokogiri",        "~> 1.6"
   gem.add_development_dependency "pry",             "~> 0.13"
   gem.add_development_dependency "pry-byebug",      "~> 3.9"

data/lib/ibandit/constants.rb

@@ -2,7 +2,7 @@
 
 module Ibandit
   module Constants
-    CONSTRUCTABLE_IBAN_COUNTRY_CODES = %w[AT BE BG CY CZ DE DK EE ES FI FR GB GR
+    CONSTRUCTABLE_IBAN_COUNTRY_CODES = %w[AT BE BG CY CZ DE DK EE ES FI FO FR GB GL GR
                                           HR HU IE IS IT LT LU LV MC MT NL NO PL
                                           PT RO SE SI SK SM].freeze
 

data/lib/ibandit/iban.rb

@@ -64,7 +64,7 @@ module Ibandit
     def account_number_suffix
       return nil unless country_code == "NZ"
 
-      @account_number[7..-1]
+      @account_number[7..]
     end
 
     def local_check_digits
@@ -77,7 +77,7 @@ module Ibandit
     end
 
     def bban
-      iban[4..-1] unless iban.nil?
+      iban[4..] unless iban.nil?
     end
 
     def pseudo_iban

data/lib/ibandit/iban_assembler.rb

@@ -89,7 +89,7 @@ module Ibandit
 
     def self.required_fields(country_code)
       case country_code
-      when "AT", "CY", "CZ", "DE", "DK", "EE", "FI", "HR", "IS", "LT", "LU",
+      when "AT", "CY", "CZ", "DE", "DK", "EE", "FO", "FI", "GL", "HR", "IS", "LT", "LU",
            "LV", "NL", "NO", "PL", "RO", "SE", "SI", "SK"
         %i[bank_code account_number]
       when "BE"

data/lib/ibandit/local_details_cleaner.rb

@@ -132,7 +132,7 @@ module Ibandit
         if local_details[:branch_code]
           local_details[:branch_code]
         elsif cleaned_bank_code.length > 3
-          cleaned_bank_code[3..-1]
+          cleaned_bank_code[3..]
         end
       account_number =
         if local_details[:account_number].length >= 7
@@ -247,7 +247,7 @@ module Ibandit
 
         bank_code      = cleaned_account_number.slice(0, 4)
         branch_code    = cleaned_account_number.slice(4, 4)
-        account_number = cleaned_account_number[8..-1]
+        account_number = cleaned_account_number[8..]
       end
 
       {
@@ -265,7 +265,7 @@ module Ibandit
         if %w[4 5 6].include?(local_details[:bank_code][0])
           [
             local_details[:account_number][0],
-            local_details[:account_number][1..-1].rjust(7, "0"),
+            local_details[:account_number][1..].rjust(7, "0"),
           ].join
         else
           local_details[:account_number].rjust(8, "0")
@@ -294,7 +294,7 @@ module Ibandit
         bank_code = local_details[:bank_code]
       else
         bic = Ibandit.find_bic("GB", branch_code)
-        bank_code = bic.nil? ? nil : bic.slice(0, 4)
+        bank_code = bic&.slice(0, 4)
       end
 
       account_number = local_details[:account_number].gsub(/[-\s]/, "")
@@ -359,7 +359,7 @@ module Ibandit
         bank_code = local_details[:bank_code]
       else
         bic = Ibandit.find_bic("IE", branch_code)
-        bank_code = bic.nil? ? nil : bic.slice(0, 4)
+        bank_code = bic&.slice(0, 4)
       end
 
       account_number = local_details[:account_number].gsub(/[-\s]/, "")
@@ -380,7 +380,7 @@ module Ibandit
         bank_code, *parts = local_details[:account_number].split("-")
       else
         bank_code = local_details[:account_number].slice(0, 4)
-        parts = Array(local_details[:account_number][4..-1])
+        parts = Array(local_details[:account_number][4..])
       end
 
       {
@@ -426,7 +426,7 @@ module Ibandit
         bank_code = local_details[:bank_code]
       else
         bic = Ibandit.find_bic("MT", branch_code)
-        bank_code = bic.nil? ? nil : bic.slice(0, 4)
+        bank_code = bic&.slice(0, 4)
       end
 
       account_number = local_details[:account_number].gsub(/[-\s]/, "")
@@ -457,7 +457,7 @@ module Ibandit
         cleaned_acct_number = local_details[:account_number].gsub(/[-.\s]/, "")
 
         bank_code      = cleaned_acct_number.slice(0, 4)
-        account_number = cleaned_acct_number[4..-1]
+        account_number = cleaned_acct_number[4..]
       end
 
       {
@@ -483,7 +483,7 @@ module Ibandit
         cleaned_account_number = local_details[:account_number].tr("-", "")
         bank_code = cleaned_account_number.slice(0, 2)
         branch_code = cleaned_account_number.slice(2, 4)
-        account_number = cleaned_account_number[6..-1]
+        account_number = cleaned_account_number[6..]
       end
 
       if account_number && account_number.length == 9
@@ -515,7 +515,7 @@ module Ibandit
         cleaned_acct_number = local_details[:account_number].gsub(/\s/, "")
 
         bank_code      = cleaned_acct_number.slice(2, 8)
-        account_number = cleaned_acct_number[10..-1]
+        account_number = cleaned_acct_number[10..]
       end
 
       {

data/lib/ibandit/sweden/local_details_converter.rb

@@ -73,7 +73,7 @@ module Ibandit
 
       def serial_number
         serial_number = if @branch_code.nil?
-                          cleaned_account_number[clearing_code_length..-1]
+                          cleaned_account_number[clearing_code_length..]
                         else
                           cleaned_account_number
                         end

data/lib/ibandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ibandit
-  VERSION = "1.12.0"
+  VERSION = "1.14.0"
 end

data/spec/ibandit/iban_assembler_spec.rb

@@ -210,6 +210,54 @@ describe Ibandit::IBANAssembler do
       end
     end
 
+    context "with FO as the country_code" do
+      let(:args) do
+        { country_code: "FO",
+          bank_code: "1199",
+          account_number: "0003179680" }
+      end
+
+      it { is_expected.to eq("FO9111990003179680") }
+
+      it_behaves_like "allows round trips", "FO91 1199 0003 1796 80"
+
+      context "without a bank_code" do
+        before { args.delete(:bank_code) }
+
+        it { is_expected.to be_nil }
+      end
+
+      context "without an account_number" do
+        before { args.delete(:account_number) }
+
+        it { is_expected.to be_nil }
+      end
+    end
+
+    context "with GL as the country_code" do
+      let(:args) do
+        { country_code: "GL",
+          bank_code: "1199",
+          account_number: "0003179680" }
+      end
+
+      it { is_expected.to eq("GL9111990003179680") }
+
+      it_behaves_like "allows round trips", "GL91 1199 0003 1796 80"
+
+      context "without a bank_code" do
+        before { args.delete(:bank_code) }
+
+        it { is_expected.to be_nil }
+      end
+
+      context "without an account_number" do
+        before { args.delete(:account_number) }
+
+        it { is_expected.to be_nil }
+      end
+    end
+
     context "with EE as the country_code" do
       let(:args) do
         {

data/spec/ibandit/iban_spec.rb

@@ -946,8 +946,8 @@ describe Ibandit::IBAN do
           iban.valid_check_digits?
           expect(iban.errors).
             to include(check_digits: "Verifique os dígitos. A verificação " \
-                                     "do módulo falhou. '82' esperados, '12'" \
-                                     " recebidos.")
+                                     "do módulo falhou. '82' esperados, '12' " \
+                                     "recebidos.")
         end
       end
 
@@ -1070,8 +1070,8 @@ describe Ibandit::IBAN do
           iban.valid_length?
           expect(iban.errors).
             to include(length: "La longueur ne correspond pas à la " \
-                               "spécification SWIFT (22 caractères attendus," \
-                               " 20 reçus)")
+                               "spécification SWIFT (22 caractères attendus, " \
+                               "20 reçus)")
         end
       end
 
@@ -1089,9 +1089,9 @@ describe Ibandit::IBAN do
         it "sets errors on the IBAN" do
           iban.valid_length?
           expect(iban.errors).
-            to include(length: "O comprimento não corresponde à especificação" \
-                               " do código SWIFT (22 caracteres esperados, 20" \
-                               " recebidos)")
+            to include(length: "O comprimento não corresponde à especificação " \
+                               "do código SWIFT (22 caracteres esperados, 20 " \
+                               "recebidos)")
         end
       end
 
@@ -1099,8 +1099,8 @@ describe Ibandit::IBAN do
         it "sets errors on the IBAN" do
           iban.valid_length?
           expect(iban.errors).
-            to include(length: "La longitud no coincide con la especificación" \
-                               " SWIFT (se esperaban 22 caracteres, pero se " \
+            to include(length: "La longitud no coincide con la especificación " \
+                               "SWIFT (se esperaban 22 caracteres, pero se " \
                                "han recibido 20)")
         end
       end
@@ -1148,8 +1148,8 @@ describe Ibandit::IBAN do
         it "sets errors on the IBAN" do
           iban.valid_length?
           expect(iban.errors).
-            to include(length: "Længden modsvarer ikke SWIFT-specifikation" \
-                               " (forventede 22 tegn, modtog 20)")
+            to include(length: "Længden modsvarer ikke SWIFT-specifikation " \
+                               "(forventede 22 tegn, modtog 20)")
         end
       end
 
@@ -1588,8 +1588,8 @@ describe Ibandit::IBAN do
         it "sets errors on the IBAN" do
           iban.valid_account_number_length?
           expect(iban.errors).
-            to include(account_number: "je napačne dolžine (biti mora 8" \
-                                       " znakov)")
+            to include(account_number: "je napačne dolžine (biti mora 8 " \
+                                       "znakov)")
         end
       end
 
@@ -1597,8 +1597,8 @@ describe Ibandit::IBAN do
         it "sets errors on the IBAN" do
           iban.valid_account_number_length?
           expect(iban.errors).
-            to include(account_number: "har forkert længde (skulle være 8" \
-                                       " tegn)")
+            to include(account_number: "har forkert længde (skulle være 8 " \
+                                       "tegn)")
         end
       end
 
@@ -3396,7 +3396,7 @@ describe Ibandit::IBAN do
     end
 
     context "for a valid Italian IBAN" do
-      let(:iban_code) { "IT40 S054 2811 1010 0000 0123 456" }
+      let(:iban_code) { "IT60 X054 2811 1010 0000 0123 456" }
 
       it { is_expected.to be_valid }
     end
@@ -3946,6 +3946,66 @@ describe Ibandit::IBAN do
 
       it { is_expected.to_not be_valid }
     end
+
+    context "with a valid LY iban" do
+      let(:iban_code) { "LY83002048000020100120361" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "with an invalid LY iban" do
+      let(:iban_code) { "LY830020480000120361" }
+
+      it { is_expected.to_not be_valid }
+    end
+
+    context "with a valid SD iban" do
+      let(:iban_code) { "SD2129010501234001" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "with an invalid SD iban" do
+      let(:iban_code) { "SD21290104001" }
+
+      it { is_expected.to_not be_valid }
+    end
+
+    context "with a valid BI iban" do
+      let(:iban_code) { "BI4210000100010000332045181" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "with an invalid BI iban" do
+      let(:iban_code) { "BI4210000100000332045181" }
+
+      it { is_expected.to_not be_valid }
+    end
+
+    context "with a valid DJ iban" do
+      let(:iban_code) { "DJ2100010000000154000100186" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "with an invalid DJ iban" do
+      let(:iban_code) { "DJ2100010000000000100186" }
+
+      it { is_expected.to_not be_valid }
+    end
+
+    context "with a valid RU iban" do
+      let(:iban_code) { "RU0204452560040702810412345678901" }
+
+      it { is_expected.to be_valid }
+    end
+
+    context "with an invalid RU iban" do
+      let(:iban_code) { "RU1704452522540817810538091310419" }
+
+      it { is_expected.to_not be_valid }
+    end
   end
 
   describe "#local_check_digits" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 1.12.0
+  version: 1.14.0
 platform: ruby
 authors:
 - GoCardless
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-12-06 00:00:00.000000000 Z
+date: 2023-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gc_ruboconfig
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.3.0
+        version: 3.6.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.3.0
+        version: 3.6.2
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -174,6 +174,7 @@ files:
 - data/raw/BLZ2.txt
 - data/raw/IBANSTRUCTURE.xml
 - data/raw/IBAN_Registry.txt
+- data/raw/pseudo_ibans.yml
 - data/raw/structure_additions.yml
 - data/raw/swedish_bank_lookup.yml
 - data/structures.yml
@@ -227,7 +228,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.3
+rubygems_version: 3.4.6
 signing_key:
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.