ibandit 1.11.0 → 1.13.0

data/ibandit.gemspec

@@ -3,13 +3,13 @@
 require File.expand_path("lib/ibandit/version", __dir__)
 
 Gem::Specification.new do |gem|
-  gem.add_development_dependency "gc_ruboconfig",   "~> 3.3.0"
+  gem.add_development_dependency "gc_ruboconfig",   "~> 3.6.2"
   gem.add_development_dependency "nokogiri",        "~> 1.6"
   gem.add_development_dependency "pry",             "~> 0.13"
   gem.add_development_dependency "pry-byebug",      "~> 3.9"
   gem.add_development_dependency "rspec",           "~> 3.3"
   gem.add_development_dependency "rspec-its",       "~> 1.2"
-  gem.add_development_dependency "rspec_junit_formatter", "~> 0.5.0"
+  gem.add_development_dependency "rspec_junit_formatter", "~> 0.6.0"
   gem.add_development_dependency "sax-machine", "~> 1.3"
 
   gem.add_runtime_dependency "i18n"

data/lib/ibandit/local_details_cleaner.rb

@@ -294,7 +294,7 @@ module Ibandit
         bank_code = local_details[:bank_code]
       else
         bic = Ibandit.find_bic("GB", branch_code)
-        bank_code = bic.nil? ? nil : bic.slice(0, 4)
+        bank_code = bic&.slice(0, 4)
       end
 
       account_number = local_details[:account_number].gsub(/[-\s]/, "")
@@ -359,7 +359,7 @@ module Ibandit
         bank_code = local_details[:bank_code]
       else
         bic = Ibandit.find_bic("IE", branch_code)
-        bank_code = bic.nil? ? nil : bic.slice(0, 4)
+        bank_code = bic&.slice(0, 4)
       end
 
       account_number = local_details[:account_number].gsub(/[-\s]/, "")
@@ -426,7 +426,7 @@ module Ibandit
         bank_code = local_details[:bank_code]
       else
         bic = Ibandit.find_bic("MT", branch_code)
-        bank_code = bic.nil? ? nil : bic.slice(0, 4)
+        bank_code = bic&.slice(0, 4)
       end
 
       account_number = local_details[:account_number].gsub(/[-\s]/, "")

data/lib/ibandit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ibandit
-  VERSION = "1.11.0"
+  VERSION = "1.13.0"
 end

data/spec/ibandit/iban_spec.rb

@@ -946,8 +946,8 @@ describe Ibandit::IBAN do
           iban.valid_check_digits?
           expect(iban.errors).
             to include(check_digits: "Verifique os dígitos. A verificação " \
-                                     "do módulo falhou. '82' esperados, '12'" \
-                                     " recebidos.")
+                                     "do módulo falhou. '82' esperados, '12' " \
+                                     "recebidos.")
         end
       end
 
@@ -1070,8 +1070,8 @@ describe Ibandit::IBAN do
           iban.valid_length?
           expect(iban.errors).
             to include(length: "La longueur ne correspond pas à la " \
-                               "spécification SWIFT (22 caractères attendus," \
-                               " 20 reçus)")
+                               "spécification SWIFT (22 caractères attendus, " \
+                               "20 reçus)")
         end
       end
 
@@ -1089,9 +1089,9 @@ describe Ibandit::IBAN do
         it "sets errors on the IBAN" do
           iban.valid_length?
           expect(iban.errors).
-            to include(length: "O comprimento não corresponde à especificação" \
-                               " do código SWIFT (22 caracteres esperados, 20" \
-                               " recebidos)")
+            to include(length: "O comprimento não corresponde à especificação " \
+                               "do código SWIFT (22 caracteres esperados, 20 " \
+                               "recebidos)")
         end
       end
 
@@ -1099,8 +1099,8 @@ describe Ibandit::IBAN do
         it "sets errors on the IBAN" do
           iban.valid_length?
           expect(iban.errors).
-            to include(length: "La longitud no coincide con la especificación" \
-                               " SWIFT (se esperaban 22 caracteres, pero se " \
+            to include(length: "La longitud no coincide con la especificación " \
+                               "SWIFT (se esperaban 22 caracteres, pero se " \
                                "han recibido 20)")
         end
       end
@@ -1148,8 +1148,8 @@ describe Ibandit::IBAN do
         it "sets errors on the IBAN" do
           iban.valid_length?
           expect(iban.errors).
-            to include(length: "Længden modsvarer ikke SWIFT-specifikation" \
-                               " (forventede 22 tegn, modtog 20)")
+            to include(length: "Længden modsvarer ikke SWIFT-specifikation " \
+                               "(forventede 22 tegn, modtog 20)")
         end
       end
 
@@ -1588,8 +1588,8 @@ describe Ibandit::IBAN do
         it "sets errors on the IBAN" do
           iban.valid_account_number_length?
           expect(iban.errors).
-            to include(account_number: "je napačne dolžine (biti mora 8" \
-                                       " znakov)")
+            to include(account_number: "je napačne dolžine (biti mora 8 " \
+                                       "znakov)")
         end
       end
 
@@ -1597,8 +1597,8 @@ describe Ibandit::IBAN do
         it "sets errors on the IBAN" do
           iban.valid_account_number_length?
           expect(iban.errors).
-            to include(account_number: "har forkert længde (skulle være 8" \
-                                       " tegn)")
+            to include(account_number: "har forkert længde (skulle være 8 " \
+                                       "tegn)")
         end
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 1.11.0
+  version: 1.13.0
 platform: ruby
 authors:
 - GoCardless
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-05 00:00:00.000000000 Z
+date: 2023-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gc_ruboconfig
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.3.0
+        version: 3.6.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.3.0
+        version: 3.6.2
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.6.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: sax-machine
   requirement: !ruby/object:Gem::Requirement
@@ -145,8 +145,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".circleci/config.yml"
 - ".github/dependabot.yml"
+- ".github/workflows/tests.yml"
 - ".gitignore"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
@@ -227,7 +227,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.3
+rubygems_version: 3.4.6
 signing_key:
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.

data/.circleci/config.yml

@@ -1,37 +0,0 @@
-version: 2.1
-
-jobs:
-  test:
-    docker:
-      - image: cimg/ruby:<< parameters.ruby-version >>
-    parameters:
-      ruby-version:
-        type: string
-    steps:
-      - checkout
-      - restore_cache:
-          keys:
-            - bundle-v1-<< parameters.ruby-version >>-{{ checksum "ibandit.gemspec" }}
-            - bundle-v1-<< parameters.ruby-version >>-
-      - run:
-          name: Install dependencies
-          command: bundle install --clean --no-cache --path vendor/bundle --jobs=4 --retry=3
-      - save_cache:
-          key: bundle-v1-<< parameters.ruby-version >>-{{ checksum "ibandit.gemspec" }}
-          paths:
-            - vendor/bundle
-      - run:
-          name: Run tests
-          command: bundle exec rspec
-      - run:
-          name: Run rubocop
-          command: bundle exec rubocop --parallel --extra-details --display-style-guide
-
-workflows:
-  default:
-    jobs:
-      - test:
-          name: Ruby << matrix.ruby-version >>
-          matrix:
-            parameters:
-              ruby-version: ["2.6.7", "2.7.3", "3.0.1", "3.1.0"]