ibandit 0.8.1 → 0.8.2

data/spec/ibandit/local_details_cleaner_spec.rb

@@ -955,12 +955,12 @@ describe Ibandit::LocalDetailsCleaner do
 
   context 'Sweden' do
     let(:country_code) { 'SE' }
-    let(:bank_code) { '501' }
+    let(:bank_code) { nil }
     let(:account_number) { '5013-1007270' }
 
     its([:account_number]) { is_expected.to eq('1007270') }
     its([:branch_code]) { is_expected.to eq('5013') }
-    its([:swift_bank_code]) { is_expected.to eq('501') }
+    its([:swift_bank_code]) { is_expected.to eq('500') }
     its([:swift_account_number]) { is_expected.to eq('00000050131007270') }
 
     context 'without an account number' do
@@ -968,12 +968,14 @@ describe Ibandit::LocalDetailsCleaner do
       it { is_expected.to eq(local_details) }
     end
 
-    context 'without a bank code' do
-      let(:bank_code) { nil }
+    context 'with a bank code' do
+      let(:bank_code) { '501' }
 
-      its([:swift_bank_code]) { is_expected.to eq('500') }
-      its([:account_number]) { is_expected.to eq('1007270') }
-      its([:swift_account_number]) { is_expected.to eq('00000050131007270') }
+      # Doesn't do any conversion
+      its([:swift_bank_code]) { is_expected.to eq('501') }
+      its([:bank_code]) { is_expected.to eq('501') }
+      its([:account_number]) { is_expected.to eq('5013-1007270') }
+      its([:swift_account_number]) { is_expected.to eq('5013-1007270') }
     end
   end
 

data/spec/ibandit/{swedish_details_converter_spec.rb → sweden/local_details_converter_spec.rb}

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Ibandit::SwedishDetailsConverter do
+describe Ibandit::Sweden::LocalDetailsConverter do
   subject(:converter) do
     described_class.new(account_number: account_number,
                         branch_code: branch_code)
@@ -56,15 +56,6 @@ describe Ibandit::SwedishDetailsConverter do
         its([:swift_account_number]) { is_expected.to eq('00000012810105723') }
       end
 
-      context 'that has been zero-padded' do
-        let(:account_number) { '000012810105723' }
-
-        its([:account_number]) { is_expected.to eq('0105723') }
-        its([:branch_code]) { is_expected.to eq('1281') }
-        its([:swift_bank_code]) { is_expected.to eq('120') }
-        its([:swift_account_number]) { is_expected.to eq('00000012810105723') }
-      end
-
       context 'that needs the account number part to be zero-padded' do
         let(:account_number) { '1281-1' }
 
@@ -205,108 +196,4 @@ describe Ibandit::SwedishDetailsConverter do
       its([:swift_account_number]) { is_expected.to eq('00099603401258276') }
     end
   end
-
-  describe '.valid_length?' do
-    subject do
-      described_class.valid_length?(bank_code: bank_code,
-                                    account_number: account_number)
-    end
-
-    context 'without a bank code' do
-      let(:account_number) { '12810105723' }
-      let(:bank_code) { nil }
-      it { is_expected.to eq(nil) }
-    end
-
-    context 'with an impossible bank code' do
-      let(:account_number) { '12810105723' }
-      let(:bank_code) { '500' }
-      it { is_expected.to eq(nil) }
-    end
-
-    context 'with a normal type-1 account number' do
-      let(:account_number) { '00000054391024039' }
-      let(:bank_code) { '500' }
-      it { is_expected.to eq(true) }
-
-      context 'that has a 6 digit serial number' do
-        let(:account_number) { '00000005439102403' }
-        let(:bank_code) { '500' }
-        it { is_expected.to eq(false) }
-      end
-
-      context 'that has an 8 digit serial number' do
-        let(:account_number) { '00000543910240391' }
-        let(:bank_code) { '500' }
-        it { is_expected.to eq(false) }
-      end
-    end
-
-    context 'without a Danske bank account' do
-      let(:account_number) { '12810105723' }
-      let(:bank_code) { '120' }
-      it { is_expected.to eq(true) }
-
-      context 'that has an 8 digit serial number' do
-        let(:account_number) { '00000128101057231' }
-        let(:bank_code) { '120' }
-        it { is_expected.to eq(false) }
-      end
-
-      context 'that has a 6 digit serial number' do
-        let(:account_number) { '00000001281010572' }
-        let(:bank_code) { '120' }
-        # This passes because it could be a 10 digit account number from the
-        # clearing code range 9180-9189.
-        it { is_expected.to eq(true) }
-      end
-    end
-
-    context 'with a Handelsbanken account number' do
-      let(:bank_code) { '600' }
-      let(:account_number) { '00000000219161038' }
-      it { is_expected.to eq(true) }
-
-      context 'that is only 8 characters long' do
-        let(:account_number) { '00000000021916103' }
-        it { is_expected.to eq(true) }
-      end
-
-      context 'that is 10 characters long' do
-        let(:account_number) { '00000002191610381' }
-        it { is_expected.to eq(false) }
-      end
-    end
-
-    context 'without a Nordea PlusGirot account number' do
-      let(:bank_code) { '950' }
-      let(:account_number) { '00099603401258276' }
-      it { is_expected.to eq(true) }
-    end
-  end
-
-  describe '.valid_bank_code?' do
-    subject do
-      described_class.valid_bank_code?(bank_code: bank_code,
-                                       account_number: account_number)
-    end
-
-    context 'without a bank code' do
-      let(:account_number) { '12810105723' }
-      let(:bank_code) { nil }
-      it { is_expected.to eq(false) }
-    end
-
-    context 'with an impossible bank code' do
-      let(:account_number) { '12810105723' }
-      let(:bank_code) { '500' }
-      it { is_expected.to eq(false) }
-    end
-
-    context 'with a possible bank code' do
-      let(:account_number) { '12810105723' }
-      let(:bank_code) { '120' }
-      it { is_expected.to eq(true) }
-    end
-  end
 end

data/spec/ibandit/sweden/validator_spec.rb

@@ -0,0 +1,223 @@
+require 'spec_helper'
+
+describe Ibandit::Sweden::Validator do
+  describe '.bank_code_exists_for_clearing_code?' do
+    subject do
+      described_class.bank_code_exists_for_clearing_code?(clearing_code)
+    end
+
+    context 'without a clearing code' do
+      let(:clearing_code) { nil }
+      it { is_expected.to eq(false) }
+    end
+
+    context 'with an impossible clearing code' do
+      let(:clearing_code) { '1001' }
+      it { is_expected.to eq(false) }
+    end
+
+    context 'with a possible clearing code' do
+      let(:clearing_code) { '1101' }
+      it { is_expected.to eq(true) }
+    end
+  end
+
+  describe '.valid_clearing_code_length?' do
+    subject { described_class.valid_clearing_code_length?(clearing_code) }
+
+    context 'without a clearing code' do
+      let(:clearing_code) { nil }
+      it { is_expected.to eq(nil) }
+    end
+
+    context 'with an impossible clearing code' do
+      let(:clearing_code) { '1001' }
+      it { is_expected.to eq(nil) }
+    end
+
+    context 'with a correct length 4-digit clearing code' do
+      let(:clearing_code) { '1101' }
+      it { is_expected.to eq(true) }
+    end
+
+    context 'with a correct length 5-digit clearing code' do
+      let(:clearing_code) { '80001' }
+      it { is_expected.to eq(true) }
+    end
+
+    context 'with an incorrect length 5-digit clearing code' do
+      let(:clearing_code) { '40001' }
+      it { is_expected.to eq(false) }
+    end
+  end
+
+  describe '.valid_serial_number_length?' do
+    subject do
+      described_class.valid_serial_number_length?(clearing_code: clearing_code,
+                                                  serial_number: serial_number)
+    end
+
+    context 'without a clearing code' do
+      let(:clearing_code) { nil }
+      let(:serial_number) { '1234567' }
+      it { is_expected.to eq(nil) }
+    end
+
+    context 'with an impossible clearing code' do
+      let(:clearing_code) { '1001' }
+      let(:serial_number) { '1234567' }
+      it { is_expected.to eq(nil) }
+    end
+
+    context 'with a correct length serial number' do
+      let(:clearing_code) { '1101' }
+      let(:serial_number) { '1234567' }
+      it { is_expected.to eq(true) }
+    end
+
+    context 'with an incorrect length serial number' do
+      let(:clearing_code) { '1101' }
+      let(:serial_number) { '123456' }
+      it { is_expected.to eq(false) }
+    end
+
+    context 'with a short serial number for a clearing code that zerofills' do
+      let(:clearing_code) { '9960' }
+      let(:serial_number) { '123456' }
+      it { is_expected.to eq(true) }
+    end
+
+    context 'with a long serial number for a clearing code that zerofills' do
+      let(:clearing_code) { '9960' }
+      let(:serial_number) { '12345678901' }
+      it { is_expected.to eq(false) }
+    end
+  end
+
+  describe '.bank_code_exists?' do
+    subject { described_class.bank_code_exists?(bank_code) }
+
+    context 'without a bank code' do
+      let(:bank_code) { nil }
+      it { is_expected.to eq(false) }
+    end
+
+    context 'with an impossible bank code' do
+      let(:bank_code) { '123' }
+      it { is_expected.to eq(false) }
+    end
+
+    context 'with a possible bank code' do
+      let(:bank_code) { '120' }
+      it { is_expected.to eq(true) }
+    end
+  end
+
+  describe '.bank_code_possible_for_account_number?' do
+    subject do
+      described_class.bank_code_possible_for_account_number?(
+        bank_code: bank_code,
+        account_number: account_number
+      )
+    end
+
+    context 'without a bank code' do
+      let(:account_number) { '12810105723' }
+      let(:bank_code) { nil }
+      it { is_expected.to eq(nil) }
+    end
+
+    context 'with an impossible bank code' do
+      let(:account_number) { '12810105723' }
+      let(:bank_code) { '500' }
+      it { is_expected.to eq(false) }
+    end
+
+    context 'with a possible bank code' do
+      let(:account_number) { '12810105723' }
+      let(:bank_code) { '120' }
+      it { is_expected.to eq(true) }
+    end
+  end
+
+  describe '.account_number_length_valid_for_bank_code?' do
+    subject do
+      described_class.account_number_length_valid_for_bank_code?(
+        bank_code: bank_code,
+        account_number: account_number
+      )
+    end
+
+    context 'without a bank code' do
+      let(:account_number) { '12810105723' }
+      let(:bank_code) { nil }
+      it { is_expected.to eq(nil) }
+    end
+
+    context 'with an impossible bank code' do
+      let(:account_number) { '12810105723' }
+      let(:bank_code) { '500' }
+      it { is_expected.to eq(nil) }
+    end
+
+    context 'with a normal type-1 account number' do
+      let(:account_number) { '00000054391024039' }
+      let(:bank_code) { '500' }
+      it { is_expected.to eq(true) }
+
+      context 'that has a 6 digit serial number' do
+        let(:account_number) { '00000005439102403' }
+        let(:bank_code) { '500' }
+        it { is_expected.to eq(false) }
+      end
+
+      context 'that has an 8 digit serial number' do
+        let(:account_number) { '00000543910240391' }
+        let(:bank_code) { '500' }
+        it { is_expected.to eq(false) }
+      end
+    end
+
+    context 'with a Danske bank account' do
+      let(:account_number) { '12810105723' }
+      let(:bank_code) { '120' }
+      it { is_expected.to eq(true) }
+
+      context 'that has an 8 digit serial number' do
+        let(:account_number) { '00000128101057231' }
+        let(:bank_code) { '120' }
+        it { is_expected.to eq(false) }
+      end
+
+      context 'that has a 6 digit serial number' do
+        let(:account_number) { '00000001281010572' }
+        let(:bank_code) { '120' }
+        # This passes because it could be a 10 digit account number from the
+        # clearing code range 9180-9189.
+        it { is_expected.to eq(true) }
+      end
+    end
+
+    context 'with a Handelsbanken account number' do
+      let(:bank_code) { '600' }
+      let(:account_number) { '00000000219161038' }
+      it { is_expected.to eq(true) }
+
+      context 'that is only 8 characters long' do
+        let(:account_number) { '00000000021916103' }
+        it { is_expected.to eq(true) }
+      end
+
+      context 'that is 10 characters long' do
+        let(:account_number) { '00000002191610381' }
+        it { is_expected.to eq(false) }
+      end
+    end
+
+    context 'without a Nordea PlusGirot account number' do
+      let(:bank_code) { '950' }
+      let(:account_number) { '00099603401258276' }
+      it { is_expected.to eq(true) }
+    end
+  end
+end

metadata

@@ -1,97 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.2
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-14 00:00:00.000000000 Z
+date: 2015-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.3'
 - !ruby/object:Gem::Dependency
   name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.2'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.33.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.33.0
 - !ruby/object:Gem::Dependency
   name: sax-machine
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.7.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.7.0
 description: Ibandit is a Ruby library for manipulating and validating IBANs. It allows
@@ -103,10 +103,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rubocop.yml"
-- ".rubocop_todo.yml"
-- ".travis.yml"
+- .gitignore
+- .rubocop.yml
+- .rubocop_todo.yml
+- .travis.yml
 - CHANGELOG.md
 - Gemfile
 - LICENSE
@@ -140,7 +140,9 @@ files:
 - lib/ibandit/local_details_cleaner.rb
 - lib/ibandit/pseudo_iban_assembler.rb
 - lib/ibandit/pseudo_iban_splitter.rb
-- lib/ibandit/swedish_details_converter.rb
+- lib/ibandit/sweden/bank_lookup.rb
+- lib/ibandit/sweden/local_details_converter.rb
+- lib/ibandit/sweden/validator.rb
 - lib/ibandit/version.rb
 - spec/fixtures/germany_integration_test_cases.json
 - spec/fixtures/germany_unit_test_cases.json
@@ -151,7 +153,8 @@ files:
 - spec/ibandit/local_details_cleaner_spec.rb
 - spec/ibandit/pseudo_iban_assembler_spec.rb
 - spec/ibandit/pseudo_iban_splitter_spec.rb
-- spec/ibandit/swedish_details_converter_spec.rb
+- spec/ibandit/sweden/local_details_converter_spec.rb
+- spec/ibandit/sweden/validator_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/gocardless/ibandit
 licenses:
@@ -163,17 +166,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.