ibandit 0.7.0 → 0.8.0

data/spec/ibandit/pseudo_iban_assembler_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+
+describe Ibandit::PseudoIBANAssembler do
+  subject(:pseudo_iban) { described_class.new(local_details).assemble }
+
+  context 'for Sweden' do
+    context 'with valid parameters' do
+      let(:local_details) do
+        {
+          country_code: 'SE',
+          branch_code: '1281',
+          account_number: '0105723'
+        }
+      end
+
+      it { is_expected.to eq('SEZZX1281XXX0105723') }
+    end
+
+    context 'without a branch code' do
+      let(:local_details) do
+        {
+          country_code: 'SE',
+          account_number: '0105723'
+        }
+      end
+
+      it { is_expected.to be_nil }
+    end
+
+    context 'without an account number' do
+      let(:local_details) do
+        {
+          country_code: 'SE',
+          branch_code: '1281'
+        }
+      end
+
+      it { is_expected.to be_nil }
+    end
+  end
+
+  context 'for a country that does not have pseudo-IBANs' do
+    let(:local_details) do
+      {
+        country_code: 'GB',
+        bank_code: 'WEST',
+        branch_code: '123456',
+        account_number: '98765432'
+      }
+    end
+
+    it { is_expected.to be_nil }
+  end
+end

data/spec/ibandit/pseudo_iban_splitter_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe Ibandit::PseudoIBANSplitter do
+  subject(:splitter) { described_class.new(pseudo_iban) }
+
+  describe '#split' do
+    subject(:local_details) { splitter.split }
+
+    context 'for a valid pseudo-IBAN' do
+      let(:pseudo_iban) { 'SEZZX1281XXX0105723' }
+
+      its([:country_code]) { is_expected.to eq('SE') }
+      its([:bank_code]) { is_expected.to be_nil }
+      its([:branch_code]) { is_expected.to eq('1281') }
+      its([:account_number]) { is_expected.to eq('0105723') }
+    end
+
+    context 'for an unsupported country' do
+      let(:pseudo_iban) { 'GBZZX1281XXX0105723' }
+
+      it { is_expected.to be_nil }
+    end
+
+    context 'with invalid check digits' do
+      let(:pseudo_iban) { 'SEYYX1281XXX0105723' }
+
+      it { is_expected.to be_nil }
+    end
+
+    context 'with the wrong length' do
+      let(:pseudo_iban) { 'SEYYX1281XXX010572' }
+
+      it { is_expected.to be_nil }
+    end
+  end
+end

data/spec/ibandit/swedish_details_converter_spec.rb

@@ -1,133 +1,208 @@
 require 'spec_helper'
 
 describe Ibandit::SwedishDetailsConverter do
+  subject(:converter) do
+    described_class.new(account_number: account_number,
+                        branch_code: branch_code)
+  end
+
+  let(:branch_code) { nil }
+
   describe '.convert' do
-    subject { described_class.convert(account_number) }
+    subject { converter.convert }
 
     context 'with a type-1 account number' do
       let(:account_number) { '12810105723' }
 
-      its([:bank_code]) { is_expected.to eq('120') }
-      its([:account_number]) { is_expected.to eq('00000012810105723') }
+      its([:account_number]) { is_expected.to eq('0105723') }
+      its([:branch_code]) { is_expected.to eq('1281') }
+      its([:swift_bank_code]) { is_expected.to eq('120') }
+      its([:swift_account_number]) { is_expected.to eq('00000012810105723') }
 
       context 'that includes hyphens' do
         let(:account_number) { '1281-0105723' }
 
-        its([:bank_code]) { is_expected.to eq('120') }
-        its([:account_number]) { is_expected.to eq('00000012810105723') }
+        its([:account_number]) { is_expected.to eq('0105723') }
+        its([:branch_code]) { is_expected.to eq('1281') }
+        its([:swift_bank_code]) { is_expected.to eq('120') }
+        its([:swift_account_number]) { is_expected.to eq('00000012810105723') }
+      end
+
+      context 'with a separate branch code' do
+        let(:branch_code) { '1281' }
+        let(:account_number) { '0105723' }
+
+        its([:account_number]) { is_expected.to eq('0105723') }
+        its([:branch_code]) { is_expected.to eq('1281') }
+        its([:swift_bank_code]) { is_expected.to eq('120') }
+        its([:swift_account_number]) { is_expected.to eq('00000012810105723') }
       end
 
       context 'that includes spaces' do
         let(:account_number) { '1281 0105723' }
 
-        its([:bank_code]) { is_expected.to eq('120') }
-        its([:account_number]) { is_expected.to eq('00000012810105723') }
+        its([:account_number]) { is_expected.to eq('0105723') }
+        its([:branch_code]) { is_expected.to eq('1281') }
+        its([:swift_bank_code]) { is_expected.to eq('120') }
+        its([:swift_account_number]) { is_expected.to eq('00000012810105723') }
       end
 
       context 'that includes full stops' do
         let(:account_number) { '1281.010.572.3' }
 
-        its([:bank_code]) { is_expected.to eq('120') }
-        its([:account_number]) { is_expected.to eq('00000012810105723') }
+        its([:account_number]) { is_expected.to eq('0105723') }
+        its([:branch_code]) { is_expected.to eq('1281') }
+        its([:swift_bank_code]) { is_expected.to eq('120') }
+        its([:swift_account_number]) { is_expected.to eq('00000012810105723') }
       end
 
       context 'that has been zero-padded' do
         let(:account_number) { '000012810105723' }
 
-        its([:bank_code]) { is_expected.to eq('120') }
-        its([:account_number]) { is_expected.to eq('00000012810105723') }
+        its([:account_number]) { is_expected.to eq('0105723') }
+        its([:branch_code]) { is_expected.to eq('1281') }
+        its([:swift_bank_code]) { is_expected.to eq('120') }
+        its([:swift_account_number]) { is_expected.to eq('00000012810105723') }
       end
 
       context 'that needs the account number part to be zero-padded' do
         let(:account_number) { '1281-1' }
 
-        its([:bank_code]) { is_expected.to eq('120') }
-        its([:account_number]) { is_expected.to eq('00000000000012811') }
+        its([:account_number]) { is_expected.to eq('1') }
+        its([:branch_code]) { is_expected.to eq('1281') }
+        its([:swift_bank_code]) { is_expected.to eq('120') }
+        its([:swift_account_number]) { is_expected.to eq('00000000000012811') }
       end
 
       context 'from SEB' do
         let(:account_number) { '5439-10 240 39' }
 
-        its([:bank_code]) { is_expected.to eq('500') }
-        its([:account_number]) { is_expected.to eq('00000054391024039') }
+        its([:account_number]) { is_expected.to eq('1024039') }
+        its([:branch_code]) { is_expected.to eq('5439') }
+        its([:swift_bank_code]) { is_expected.to eq('500') }
+        its([:swift_account_number]) { is_expected.to eq('00000054391024039') }
+
+        context 'with a separate branch code' do
+          let(:branch_code) { '5439' }
+          let(:account_number) { '1024039' }
+
+          its([:account_number]) { is_expected.to eq('1024039') }
+          its([:branch_code]) { is_expected.to eq('5439') }
+          its([:swift_bank_code]) { is_expected.to eq('500') }
+          its([:swift_account_number]) do
+            is_expected.to eq('00000054391024039')
+          end
+        end
       end
     end
 
     context "with a clearing code that doesn't match any banks" do
       let(:account_number) { '1001-1' }
 
-      its([:bank_code]) { is_expected.to eq(nil) }
-      its([:account_number]) { is_expected.to eq('00000000000010011') }
+      its([:account_number]) { is_expected.to eq(nil) }
+      its([:branch_code]) { is_expected.to eq(nil) }
+      its([:swift_bank_code]) { is_expected.to eq(nil) }
+      its([:swift_account_number]) { is_expected.to eq('00000000000010011') }
     end
 
     context 'with a Swedbank clearing code' do
       let(:account_number) { '7507-1211203' }
 
-      its([:bank_code]) { is_expected.to eq('800') }
-      its([:account_number]) { is_expected.to eq('00000075071211203') }
+      its([:account_number]) { is_expected.to eq('1211203') }
+      its([:branch_code]) { is_expected.to eq('7507') }
+      its([:swift_bank_code]) { is_expected.to eq('800') }
+      its([:swift_account_number]) { is_expected.to eq('00000075071211203') }
 
       context 'in the 8000s range' do
         let(:account_number) { '8327-9 33395390-9' }
 
-        its([:bank_code]) { is_expected.to eq('800') }
-        its([:account_number]) { is_expected.to eq('00832790333953909') }
+        its([:account_number]) { is_expected.to eq('0333953909') }
+        its([:branch_code]) { is_expected.to eq('83279') }
+        its([:swift_bank_code]) { is_expected.to eq('800') }
+        its([:swift_account_number]) { is_expected.to eq('00832790333953909') }
       end
 
       context 'another in the 8000s range' do
         let(:account_number) { '8201-6 914357963-0' }
 
-        its([:bank_code]) { is_expected.to eq('800') }
-        its([:account_number]) { is_expected.to eq('00820169143579630') }
+        its([:account_number]) { is_expected.to eq('9143579630') }
+        its([:branch_code]) { is_expected.to eq('82016') }
+        its([:swift_bank_code]) { is_expected.to eq('800') }
+        its([:swift_account_number]) { is_expected.to eq('00820169143579630') }
+      end
+
+      context 'with an explicit branch code' do
+        let(:branch_code) { '8201-6' }
+        let(:account_number) { '914357963-0' }
+
+        its([:account_number]) { is_expected.to eq('9143579630') }
+        its([:branch_code]) { is_expected.to eq('82016') }
+        its([:swift_bank_code]) { is_expected.to eq('800') }
+        its([:swift_account_number]) { is_expected.to eq('00820169143579630') }
       end
     end
 
     context 'with a Sparbanken Öresund clearing code' do
       let(:account_number) { '9300-35299478' }
 
-      its([:bank_code]) { is_expected.to eq('930') }
-      its([:account_number]) { is_expected.to eq('00000000035299478') }
+      its([:account_number]) { is_expected.to eq('35299478') }
+      its([:branch_code]) { is_expected.to eq('9300') }
+      its([:swift_bank_code]) { is_expected.to eq('930') }
+      its([:swift_account_number]) { is_expected.to eq('00000000035299478') }
 
       context 'with clearing number 9330 or above' do
         let(:account_number) { '9330-5930160535' }
 
-        its([:bank_code]) { is_expected.to eq('933') }
-        its([:account_number]) { is_expected.to eq('00000005930160535') }
+        its([:account_number]) { is_expected.to eq('5930160535') }
+        its([:branch_code]) { is_expected.to eq('9330') }
+        its([:swift_bank_code]) { is_expected.to eq('933') }
+        its([:swift_account_number]) { is_expected.to eq('00000005930160535') }
       end
     end
 
     context 'with a Sparbanken Syd clearing code' do
       let(:account_number) { '9570-5250093407' }
 
-      its([:bank_code]) { is_expected.to eq('957') }
-      its([:account_number]) { is_expected.to eq('00000005250093407') }
+      its([:account_number]) { is_expected.to eq('5250093407') }
+      its([:branch_code]) { is_expected.to eq('9570') }
+      its([:swift_bank_code]) { is_expected.to eq('957') }
+      its([:swift_account_number]) { is_expected.to eq('00000005250093407') }
     end
 
     context 'with a Handelsbanken clearing code' do
       let(:account_number) { '6000-806967498' }
 
-      its([:bank_code]) { is_expected.to eq('600') }
-      its([:account_number]) { is_expected.to eq('00000000806967498') }
+      its([:account_number]) { is_expected.to eq('806967498') }
+      its([:branch_code]) { is_expected.to eq('6000') }
+      its([:swift_bank_code]) { is_expected.to eq('600') }
+      its([:swift_account_number]) { is_expected.to eq('00000000806967498') }
 
       context 'that has clearing code 6240' do
         let(:account_number) { '6240-219161038' }
 
-        its([:bank_code]) { is_expected.to eq('600') }
-        its([:account_number]) { is_expected.to eq('00000000219161038') }
+        its([:account_number]) { is_expected.to eq('219161038') }
+        its([:branch_code]) { is_expected.to eq('6240') }
+        its([:swift_bank_code]) { is_expected.to eq('600') }
+        its([:swift_account_number]) { is_expected.to eq('00000000219161038') }
       end
 
       context 'that only has an 8 digit serial number' do
         let(:account_number) { '6240-21916103' }
 
-        its([:bank_code]) { is_expected.to eq('600') }
-        its([:account_number]) { is_expected.to eq('00000000021916103') }
+        its([:account_number]) { is_expected.to eq('021916103') }
+        its([:branch_code]) { is_expected.to eq('6240') }
+        its([:swift_bank_code]) { is_expected.to eq('600') }
+        its([:swift_account_number]) { is_expected.to eq('00000000021916103') }
       end
     end
 
     context 'with a Nordea PlusGirot clearing code' do
       let(:account_number) { '9960-3401258276' }
 
-      its([:bank_code]) { is_expected.to eq('950') }
-      its([:account_number]) { is_expected.to eq('00099603401258276') }
+      its([:account_number]) { is_expected.to eq('3401258276') }
+      its([:branch_code]) { is_expected.to eq('9960') }
+      its([:swift_bank_code]) { is_expected.to eq('950') }
+      its([:swift_account_number]) { is_expected.to eq('00099603401258276') }
     end
   end
 

metadata

@@ -1,97 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-11 00:00:00.000000000 Z
+date: 2015-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.3'
 - !ruby/object:Gem::Dependency
   name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '1.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '1.2'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.30.1
+        version: 0.33.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.30.1
+        version: 0.33.0
 - !ruby/object:Gem::Dependency
   name: sax-machine
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.7.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.7.0
 description: Ibandit is a Ruby library for manipulating and validating IBANs. It allows
@@ -103,10 +103,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rubocop.yml
-- .rubocop_todo.yml
-- .travis.yml
+- ".gitignore"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE
@@ -131,12 +131,15 @@ files:
 - ibandit.gemspec
 - lib/ibandit.rb
 - lib/ibandit/check_digit.rb
+- lib/ibandit/constants.rb
 - lib/ibandit/errors.rb
 - lib/ibandit/german_details_converter.rb
 - lib/ibandit/iban.rb
 - lib/ibandit/iban_assembler.rb
 - lib/ibandit/iban_splitter.rb
 - lib/ibandit/local_details_cleaner.rb
+- lib/ibandit/pseudo_iban_assembler.rb
+- lib/ibandit/pseudo_iban_splitter.rb
 - lib/ibandit/swedish_details_converter.rb
 - lib/ibandit/version.rb
 - spec/fixtures/germany_integration_test_cases.json
@@ -146,6 +149,8 @@ files:
 - spec/ibandit/iban_spec.rb
 - spec/ibandit/iban_splitter_spec.rb
 - spec/ibandit/local_details_cleaner_spec.rb
+- spec/ibandit/pseudo_iban_assembler_spec.rb
+- spec/ibandit/pseudo_iban_splitter_spec.rb
 - spec/ibandit/swedish_details_converter_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/gocardless/ibandit
@@ -158,17 +163,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.