ibandit 0.6.6 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f800e698be58f3378b478f197526c5d2bdec8770
-  data.tar.gz: f8650d0eca790ea52617ea1b46da45c5c7f47f3a
+  metadata.gz: 53b3af5d1ef9ac7b61de43b1cc268380af1e1242
+  data.tar.gz: 751d53c25ff31c8a44f7cd334f76dac3389d8c0e
 SHA512:
-  metadata.gz: 07b6d6a4a99a90ebb8810b11aed7c8de97d8ce27c5c25a12902761650c49a88a2cd947f9e1fda776917a90d57cb20f55d9f871cd2d3977baf971bb831a9e9955
-  data.tar.gz: 0b895a47575ec3722376372b938218363d7bd996345932d4e6627242e5ca50b47680f7fd3cd425fca02769a59e42f7f08344660e8025d1b4068177e317576f35
+  metadata.gz: a8c6fa27a0efa6909f0783d5257bcce17ade3e21a1030078056854e8f3638e27568c61fe27485ab594f17bb9a0ce818206b521a463821e45f711fb23a50d1af8
+  data.tar.gz: bf770b81e770a5ed0037ae3b8ef810e84043f9355eadef160fe8cfcde8fd8321c34a8d2be3392a39dc97ebdb15fd879b4907fef7196571a5523b691ec4d1cc79

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.7.0 - August 11, 2015
+- Remove all unused `CheckDigit` methods
+
 ## 0.6.6 - July 31, 2015
 - Add Croatia to LocalDetailsCleaner and IBANAssembler
 - Add Czech Republic to LocalDetailsCleaner and IBANAssembler

data/lib/ibandit/check_digit.rb

@@ -1,7 +1,7 @@
 module Ibandit
   module CheckDigit
-    def self.mod_97_10(string)
-      chars = string + '00'
+    def self.iban(country_code, bban)
+      chars = bban + country_code + '00'
       digits = chars.bytes.map do |byte|
         case byte
         when 48..57 then byte.chr           # 0..9
@@ -15,23 +15,6 @@ module Ibandit
       format('%02d', 98 - remainder)
     end
 
-    # Currently unused in this gem. This method calculates a mod 11
-    # check digit from the string of digits passed in. These check
-    # digits are used in the 1st and 2nd digits of local Spanish
-    # account numbers.
-    def self.spanish(string)
-      padded_string = string.rjust(10, '0')
-      scaled_values = padded_string.chars.map.with_index do |digit, index|
-        unless digit.to_i.to_s == digit
-          raise InvalidCharacterError,
-                "Unexpected non-numeric character '#{digit}'"
-        end
-        Integer(digit) * (2**index % 11)
-      end
-      result = 11 - scaled_values.inject(:+) % 11
-      result < 10 ? result.to_s : (11 - result).to_s
-    end
-
     def self.italian(string)
       odd_mapping = {
         'A' => 1,  'B' => 0,  'C' => 5,  'D' => 7,  'E' => 9,  'F' => 13,
@@ -58,204 +41,5 @@ module Ibandit
 
       (scaled_values.inject(:+) % 26 + 65).chr
     end
-
-    # Currently unused in this gem. This method calculates the last two digits
-    # of a Belgian account number when given the first ten digits.
-    def self.belgian(string)
-      remainder = string.to_i % 97
-      return format('%02d', remainder) unless remainder.zero?
-      '97'
-    end
-
-    # Currently unused in this gem. This method calculates the last digit
-    # of a Estonian account number when given the initial digits.
-    def self.estonian(string)
-      weights = [7, 3, 1]
-
-      scaled_values = string.reverse.chars.map.with_index do |char, index|
-        unless char.to_i.to_s == char
-          raise InvalidCharacterError,
-                "Unexpected non-numeric character '#{char}'"
-        end
-
-        char.to_i * weights[index % weights.size]
-      end
-
-      (scaled_values.inject(:+) % 10).to_s
-    end
-
-    # Currently unused in this gem. This method calculates the last digit
-    # of a Hungarian account number when given the initial digits.
-    def self.hungarian(string)
-      weights = [9, 7, 3, 1]
-
-      scaled_values = string.chars.map.with_index do |char, index|
-        unless char.to_i.to_s == char
-          raise InvalidCharacterError,
-                "Unexpected non-numeric character '#{char}'"
-        end
-
-        char.to_i * weights[index % weights.size]
-      end
-
-      result = 10 - scaled_values.inject(:+) % 10
-      result < 10 ? result.to_s : '0'
-    end
-
-    # Currently unused in this gem. This method calculates the last digit
-    # of a Croatian account number when given the initial digits.
-    def self.croatian(string)
-      calculation =  string.chars.map.reduce(10) do |total, char|
-        unless char.to_i.to_s == char
-          raise InvalidCharacterError,
-                "Unexpected non-numeric character '#{char}'"
-        end
-
-        calc = (char.to_i + total) % 10
-        calc = calc == 0 ? 10 : calc
-        (calc * 2) % 11
-      end
-
-      ((11 - calculation) % 10).to_s
-    end
-
-    # Currently unused in this gem. This method calculates the penultimate digit
-    # of an Icelandic kennitala (included in the account number) when given the
-    # first 8 digits.
-    def self.icelandic(string)
-      weights = [3, 2, 7, 6, 5, 4, 3, 2]
-
-      scaled_values = string.chars.map.with_index do |char, index|
-        unless char.to_i.to_s == char
-          raise InvalidCharacterError,
-                "Unexpected non-numeric character '#{char}'"
-        end
-
-        char.to_i * weights[index % weights.size]
-      end
-
-      result = 11 - scaled_values.inject(:+) % 11
-      result < 10 ? result.to_s : '0'
-    end
-
-    # Currently unused in this gem. This method calculates the last digit
-    # of a Slovakian account number (basic) when given the initial digits.
-    def self.slovakian_prefix(string)
-      weights = [10, 5, 8, 4, 2]
-
-      scaled_values = string.chars.map.with_index do |char, index|
-        unless char.to_i.to_s == char
-          raise InvalidCharacterError,
-                "Unexpected non-numeric character '#{char}'"
-        end
-
-        char.to_i * weights[index]
-      end
-
-      (11 - scaled_values.inject(:+) % 11).to_s
-    end
-
-    # Currently unused in this gem. This method calculates the last digit
-    # of a Slovakian account number prefix when given the initial digits.
-    def self.slovakian_basic(string)
-      weights = [6, 3, 7, 9, 10, 5, 8, 4, 2]
-
-      scaled_values = string.chars.map.with_index do |char, index|
-        unless char.to_i.to_s == char
-          raise InvalidCharacterError,
-                "Unexpected non-numeric character '#{char}'"
-        end
-
-        char.to_i * weights[index]
-      end
-
-      (11 - scaled_values.inject(:+) % 11).to_s
-    end
-
-    # Currently unused in this gem. This method calculates the last digit
-    # of a Dutch account number when given the first nine digits.
-    def self.dutch(string)
-      scaled_values = string.reverse.chars.map.with_index do |char, index|
-        unless char.to_i.to_s == char
-          raise InvalidCharacterError,
-                "Unexpected non-numeric character '#{char}'"
-        end
-
-        char.to_i * (index + 2)
-      end
-
-      result = 11 - scaled_values.inject(:+) % 11
-      result < 10 ? result.to_s : (11 - result).to_s
-    end
-
-    # Currently unused in this gem. This method calculates the last digit
-    # of a Norwegian account number when given the initial digits.
-    def self.norwegian(string)
-      weights = [5, 4, 3, 2, 7, 6, 5, 4, 3, 2]
-
-      scaled_values = string.chars.map.with_index do |char, index|
-        unless char.to_i.to_s == char
-          raise InvalidCharacterError,
-                "Unexpected non-numeric character '#{char}'"
-        end
-
-        char.to_i * weights[index % weights.size]
-      end
-
-      if scaled_values[4] == 0 && scaled_values[5] == 0
-        scaled_values = scaled_values[6..-1]
-      end
-
-      result = 11 - scaled_values.inject(:+) % 11
-      result < 10 ? result.to_s : '0'
-    end
-
-    # Currently unused in this gem. This method calculates the last digit
-    # of a Finnish account number when given the initial digits (in electronic
-    # format).
-    def self.lund(string)
-      weights = [2, 1]
-
-      scaled_values = string.reverse.chars.map.with_index do |char, index|
-        unless char.to_i.to_s == char
-          raise InvalidCharacterError,
-                "Unexpected non-numeric character '#{char}'"
-        end
-
-        scaled_value = char.to_i * weights[index % weights.size]
-        scaled_value < 10 ? scaled_value : scaled_value % 10 + 1
-      end
-
-      (10 - scaled_values.inject(:+) % 10).to_s
-    end
-
-    def self.rib(bank_code, branch_code, account_number)
-      remainder = 97 - (89 * rib_value(bank_code) +
-                        15 * rib_value(branch_code) +
-                        3 * rib_value(account_number)) % 97
-      format('%02d', remainder)
-    end
-
-    def self.iban(country_code, bban)
-      mod_97_10(bban + country_code)
-    end
-
-    def self.rib_value(string)
-      rib_mapping = {
-        'A' => 1, 'B' => 2, 'C' => 3, 'D' => 4, 'E' => 5, 'F' => 6, 'G' => 7,
-        'H' => 8, 'I' => 9, 'J' => 1, 'K' => 2, 'L' => 3, 'M' => 4, 'N' => 5,
-        'O' => 6, 'P' => 7, 'Q' => 8, 'R' => 9, 'S' => 2, 'T' => 3, 'U' => 4,
-        'V' => 5, 'W' => 6, 'X' => 7, 'Y' => 8, 'Z' => 9, '0' => 0, '1' => 1,
-        '2' => 2, '3' => 3, '4' => 4, '5' => 5, '6' => 6, '7' => 7, '8' => 8,
-        '9' => 9
-      }
-
-      string.chars.map do |character|
-        unless rib_mapping[character]
-          raise InvalidCharacterError, "Unexpected byte '#{character}' in RIB"
-        end
-        rib_mapping[character]
-      end.join.to_i
-    end
   end
 end

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = '0.6.6'.freeze
+  VERSION = '0.7.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.6.6
+  version: 0.7.0
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-31 00:00:00.000000000 Z
+date: 2015-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -141,7 +141,6 @@ files:
 - lib/ibandit/version.rb
 - spec/fixtures/germany_integration_test_cases.json
 - spec/fixtures/germany_unit_test_cases.json
-- spec/ibandit/check_digit_spec.rb
 - spec/ibandit/german_details_converter_spec.rb
 - spec/ibandit/iban_assembler_spec.rb
 - spec/ibandit/iban_spec.rb

data/spec/ibandit/check_digit_spec.rb

@@ -1,238 +0,0 @@
-require 'spec_helper'
-
-describe Ibandit::CheckDigit do
-  describe '.mod_97_10' do
-    subject { described_class.mod_97_10(account_number) }
-
-    context 'with a non-numeric character' do
-      let(:account_number) { 'hhhh' }
-      specify { expect { subject }.to raise_error(/non-alphanumeric/) }
-    end
-  end
-
-  describe '.spanish' do
-    subject { described_class.spanish(account_number) }
-
-    context 'sequence that should give a check digit of 0' do
-      let(:account_number) { '12345678' }
-      it { is_expected.to eq('0') }
-    end
-
-    context 'sequence that should give a check digit of 8' do
-      let(:account_number) { '0000012345' }
-      it { is_expected.to eq('8') }
-    end
-
-    context 'with a non-numeric character' do
-      let(:account_number) { '000001234A' }
-      it 'raises an error' do
-        expect { subject }.to raise_error(Ibandit::InvalidCharacterError)
-      end
-    end
-
-    context 'with a string that is fewer than 10 characters' do
-      let(:account_number) { '20386010' }
-
-      it 'zero-pads the string to get the correct check digit' do
-        expect(subject).to eq('5')
-      end
-    end
-  end
-
-  describe '.belgian' do
-    subject { described_class.belgian(account_number) }
-
-    let(:account_number) { '5100075470' }
-    it { is_expected.to eq('61') }
-
-    context 'with an account number which is a factor of 97' do
-      let(:account_number) { '1030343409' }
-      it { is_expected.to eq('97') }
-    end
-  end
-
-  describe '.lund' do
-    subject { described_class.lund(account_number) }
-
-    let(:account_number) { '1200300002088' }
-    it { is_expected.to eq('3') }
-
-    context 'with another account number (double checking!)' do
-      let(:account_number) { '1428350017114' }
-      it { is_expected.to eq('1') }
-    end
-
-    context 'with a non-numeric character' do
-      let(:account_number) { '1BAD2014' }
-      specify { expect { subject }.to raise_error(/non-numeric character/) }
-    end
-  end
-
-  describe '.estonian' do
-    subject { described_class.estonian(account_number) }
-
-    context "with an account_number that doesn't start with a zero" do
-      let(:account_number) { '22102014568' }
-      it { is_expected.to eq('5') }
-    end
-
-    context 'with leading zeros' do
-      let(:account_number) { '0022102014568' }
-      it { is_expected.to eq('5') }
-    end
-
-    context 'with a non-numeric character' do
-      let(:account_number) { '1BAD2014' }
-      specify { expect { subject }.to raise_error(/non-numeric character/) }
-    end
-  end
-
-  describe '.dutch' do
-    subject { described_class.dutch(account_number) }
-
-    let(:account_number) { '041716430' }
-    it { is_expected.to eq('0') }
-
-    context 'with another account number (double checking!)' do
-      let(:account_number) { '030006526' }
-      it { is_expected.to eq('4') }
-    end
-
-    context 'with a non-numeric character' do
-      let(:account_number) { '1BAD2014' }
-      specify { expect { subject }.to raise_error(/non-numeric character/) }
-    end
-  end
-
-  describe '.hungarian' do
-    subject { described_class.hungarian(account_number) }
-
-    let(:account_number) { '1234567' }
-    it { is_expected.to eq('6') }
-
-    context 'with another account number (double checking!)' do
-      let(:account_number) { '1111101' }
-      it { is_expected.to eq('8') }
-    end
-
-    context 'with all zeros' do
-      let(:account_number) { '0000000' }
-      it { is_expected.to eq('0') }
-    end
-
-    context 'with a non-numeric character' do
-      let(:account_number) { '1BAD2014' }
-      specify { expect { subject }.to raise_error(/non-numeric character/) }
-    end
-  end
-
-  describe '.croatian' do
-    subject { described_class.croatian(account_number) }
-
-    let(:account_number) { '0823' }
-    it { is_expected.to eq('5') }
-
-    context 'with another account number (double checking!)' do
-      let(:account_number) { '100100' }
-      it { is_expected.to eq('5') }
-    end
-
-    context 'with all zeros' do
-      let(:account_number) { '186300016' }
-      it { is_expected.to eq('0') }
-    end
-
-    context 'with a non-numeric character' do
-      let(:account_number) { '1BAD2014' }
-      specify { expect { subject }.to raise_error(/non-numeric character/) }
-    end
-  end
-
-  describe '.icelandic' do
-    subject { described_class.icelandic(kennitala) }
-
-    let(:kennitala) { '52121206' }
-    it { is_expected.to eq('3') }
-
-    context 'with another kennitala (double checking!)' do
-      let(:kennitala) { '42027802' }
-      it { is_expected.to eq('0') }
-    end
-
-    context 'with a third kennitala (triple checking!)' do
-      let(:kennitala) { '12017433' }
-      it { is_expected.to eq('9') }
-    end
-
-    context 'with a non-numeric character' do
-      let(:kennitala) { '1BAD2014' }
-      specify { expect { subject }.to raise_error(/non-numeric character/) }
-    end
-  end
-
-  describe '.norwegian' do
-    subject { described_class.norwegian(account_number) }
-
-    let(:account_number) { '8601111794' }
-    it { is_expected.to eq('7') }
-
-    context 'with another account number (double checking!)' do
-      let(:account_number) { '8601549472' }
-      it { is_expected.to eq('9') }
-    end
-
-    context 'with a third account number (triple checking!)' do
-      let(:account_number) { '3000501790' }
-      it { is_expected.to eq('0') }
-    end
-
-    context 'with a non-numeric character' do
-      let(:account_number) { '1BAD2014' }
-      specify { expect { subject }.to raise_error(/non-numeric character/) }
-    end
-  end
-
-  describe '.slovakian_prefix' do
-    subject { described_class.slovakian_prefix(account_number) }
-
-    let(:account_number) { '00001' }
-    it { is_expected.to eq('9') }
-
-    context 'with a non-numeric character' do
-      let(:account_number) { '1BAD2014' }
-      specify { expect { subject }.to raise_error(/non-numeric character/) }
-    end
-  end
-
-  describe '.slovakian_basic' do
-    subject { described_class.slovakian_basic(account_number) }
-
-    let(:account_number) { '874263754' }
-    it { is_expected.to eq('1') }
-
-    context 'with a non-numeric character' do
-      let(:account_number) { '1BAD2014' }
-      specify { expect { subject }.to raise_error(/non-numeric character/) }
-    end
-  end
-
-  describe '.rib' do
-    subject { described_class.rib(bank_code, branch_code, account_number) }
-
-    context 'with some non-numeric characters' do
-      let(:bank_code) { '12BD4' }
-      let(:branch_code) { '367WX' }
-      let(:account_number) { '12345678912' }
-
-      it { is_expected.to eq('20') }
-    end
-
-    context 'with numeric characters' do
-      let(:bank_code) { '12244' }
-      let(:branch_code) { '36767' }
-      let(:account_number) { '12345678912' }
-
-      it { is_expected.to eq('20') }
-    end
-  end
-end