ibandit 0.6.5 → 0.6.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 823a2e3a40462ece9f02dca4e2442017d1372b57
-  data.tar.gz: 153d927db1dc73912738f0f49396a97fb8e17024
+  metadata.gz: f800e698be58f3378b478f197526c5d2bdec8770
+  data.tar.gz: f8650d0eca790ea52617ea1b46da45c5c7f47f3a
 SHA512:
-  metadata.gz: 14cc8a274cd0b5d41249a4d3d043a582aba730b096438d206de9aa008f88672f8f451e0ba196b1780443b13cb592af93b3706c3125ee05e6531989ff80c20239
-  data.tar.gz: 7c060ed0b1a379d0617210c8ab0e485a5c1f4ee32e66c706a27fbdd774c9c9926a8311f5ebac4aa3fb7d1d9005ce3ba9399a9b3baa4dd8c9a0a8734405a04e5a
+  metadata.gz: 07b6d6a4a99a90ebb8810b11aed7c8de97d8ce27c5c25a12902761650c49a88a2cd947f9e1fda776917a90d57cb20f55d9f871cd2d3977baf971bb831a9e9955
+  data.tar.gz: 0b895a47575ec3722376372b938218363d7bd996345932d4e6627242e5ca50b47680f7fd3cd425fca02769a59e42f7f08344660e8025d1b4068177e317576f35

data/CHANGELOG.md

@@ -1,4 +1,6 @@
-## Unreleased
+## 0.6.6 - July 31, 2015
+- Add Croatia to LocalDetailsCleaner and IBANAssembler
+- Add Czech Republic to LocalDetailsCleaner and IBANAssembler
 
 ## 0.6.5 - July 30, 2015
 - Add Romania to LocalDetailsCleaner and IBANAssembler

data/README.md

@@ -183,6 +183,13 @@ iban = Ibandit::IBAN.new(
 )
 iban.iban                     # => "BG80BNBG96611020345678"
 
+# Croatia
+iban = Ibandit::IBAN.new(
+  country_code: 'HR',
+  account_number: '1001005-1863000160',
+)
+iban.iban                     # => "HR1210010051863000160"
+
 # Cyprus
 iban = Ibandit::IBAN.new(
   country_code: 'CY',
@@ -192,13 +199,14 @@ iban = Ibandit::IBAN.new(
 )
 iban.iban                     # => "CY17002001280000001200527600"
 
-# Germany
+# Czech Republic
 iban = Ibandit::IBAN.new(
-  country_code: 'DE',
-  bank_code: '37040044',
-  account_number: '0532013000'
+  country_code: 'CZ',
+  bank_code: '0800',
+  account_number_prefix: '19',
+  account_number: '2000145399'
 )
-iban.iban                     # => "DE89370400440532013000"
+iban.iban                     # => "CZ6508000000192000145399"
 
 # Denmark
 iban = Ibandit::IBAN.new(
@@ -231,14 +239,13 @@ iban = Ibandit::IBAN.new(
 )
 iban.iban                     # => "FR1420041010050500013M02606"
 
-# United Kingdom
+# Germany
 iban = Ibandit::IBAN.new(
-  country_code: 'GB',
-  bank_code: 'BARC', # optional if a BIC finder is configured
-  branch_code: '200000',
-  account_number: '55779911'
+  country_code: 'DE',
+  bank_code: '37040044',
+  account_number: '0532013000'
 )
-iban.iban                     # => "GB60BARC20000055779911"
+iban.iban                     # => "DE89370400440532013000"
 
 # Greece
 iban = Ibandit::IBAN.new(
@@ -390,15 +397,6 @@ iban = Ibandit::IBAN.new(
 iban.iban                     # => "SI56191000000123438"
 
 # Spain
-iban = Ibandit::IBAN.new(
-  country_code: 'ES',
-  bank_code: '2310',
-  branch_code: '0001',
-  account_number: '180000012345'
-)
-iban.iban                     # => "ES8023100001180000012345"
-
-# Spain with 20 digit account number
 iban = Ibandit::IBAN.new(
   country_code: 'ES',
   account_number: '23100001180000012345'
@@ -411,6 +409,15 @@ iban = Ibandit::IBAN.new(
   account_number: '7507-1211203'
 )
 iban.iban                     # => "SE2680000000075071211203"
+
+# United Kingdom
+iban = Ibandit::IBAN.new(
+  country_code: 'GB',
+  bank_code: 'BARC', # optional if a BIC finder is configured
+  branch_code: '200000',
+  account_number: '55779911'
+)
+iban.iban                     # => "GB60BARC20000055779911"
 ```
 
 ## Other libraries

data/lib/ibandit/check_digit.rb

@@ -102,6 +102,23 @@ module Ibandit
       result < 10 ? result.to_s : '0'
     end
 
+    # Currently unused in this gem. This method calculates the last digit
+    # of a Croatian account number when given the initial digits.
+    def self.croatian(string)
+      calculation =  string.chars.map.reduce(10) do |total, char|
+        unless char.to_i.to_s == char
+          raise InvalidCharacterError,
+                "Unexpected non-numeric character '#{char}'"
+        end
+
+        calc = (char.to_i + total) % 10
+        calc = calc == 0 ? 10 : calc
+        (calc * 2) % 11
+      end
+
+      ((11 - calculation) % 10).to_s
+    end
+
     # Currently unused in this gem. This method calculates the penultimate digit
     # of an Icelandic kennitala (included in the account number) when given the
     # first 8 digits.

data/lib/ibandit/iban_assembler.rb

@@ -1,7 +1,7 @@
 module Ibandit
   module IBANAssembler
-    SUPPORTED_COUNTRY_CODES = %w(AT BE BG CY DE DK EE ES FI FR GB GR HU IE IS IT
-                                 LT LU LV MC MT NL NO PL PT RO SE SI SK
+    SUPPORTED_COUNTRY_CODES = %w(AT BE BG CY CZ DE DK EE ES FI FR GB GR HR HU IE
+                                 IS IT LT LU LV MC MT NL NO PL PT RO SE SI SK
                                  SM).freeze
 
     EXCEPTION_COUNTRY_CODES = %w(IT SM BE).freeze
@@ -85,7 +85,7 @@ module Ibandit
 
     def self.required_fields(country_code)
       case country_code
-      when *%w(AT CY DE DK EE FI IS LT LU LV NL NO PL RO SE SI SK)
+      when *%w(AT CY CZ DE DK EE FI HR IS LT LU LV NL NO PL RO SE SI SK)
         %i(bank_code account_number)
       when 'BE'
         %i(account_number)
@@ -100,7 +100,7 @@ module Ibandit
       when 'BE' then %i(bank_code account_number)
       when 'CY' then %i(bank_code branch_code account_number)
       when 'IT' then %i(bank_code branch_code account_number check_digit)
-      when 'SK' then %i(bank_code account_number account_number_prefix)
+      when 'CZ', 'SK' then %i(bank_code account_number account_number_prefix)
       else required_fields(country_code)
       end
     end

data/lib/ibandit/local_details_cleaner.rb

@@ -1,7 +1,7 @@
 module Ibandit
   module LocalDetailsCleaner
-    SUPPORTED_COUNTRY_CODES = %w(AT BE BG CY DE DK EE ES FI FR GB GR HU IE IS IT
-                                 LT LU LV MC MT NL NO PL PT RO SE SI SK
+    SUPPORTED_COUNTRY_CODES = %w(AT BE BG CY CZ DE DK EE ES FI FR GB GR HR HU IE
+                                 IS IT LT LU LV MC MT NL NO PL PT RO SE SI SK
                                  SM).freeze
 
     def self.clean(local_details)
@@ -30,7 +30,7 @@ module Ibandit
       case country_code
       when 'AT', 'CY', 'DE', 'FI', 'LT', 'LU', 'LV', 'NL', 'RO', 'SI', 'SK'
         %i(bank_code account_number)
-      when 'BE', 'DK', 'EE', 'ES', 'HU', 'IS', 'NO', 'PL', 'SE'
+      when 'BE', 'CZ', 'DK', 'EE', 'ES', 'HR', 'HU', 'IS', 'NO', 'PL', 'SE'
         %i(account_number)
       when 'GB', 'IE', 'MT'
         if Ibandit.bic_finder.nil? then %i(bank_code branch_code account_number)
@@ -95,6 +95,26 @@ module Ibandit
       }
     end
 
+    def self.clean_cz_details(local_details)
+      #   The SWIFT definition of a Czech IBAN includes both the account
+      #   number prefix and the account number. This method therefore supports
+      #   passing those fields concatenated.
+      account_number =
+        if local_details.include?(:account_number_prefix)
+          [
+            local_details[:account_number_prefix].rjust(6, '0'),
+            local_details[:account_number].rjust(10, '0')
+          ].join
+        else
+          local_details[:account_number].tr('-', '').rjust(16, '0')
+        end
+
+      {
+        bank_code:      local_details[:bank_code],
+        account_number: account_number
+      }
+    end
+
     def self.clean_de_details(local_details)
       # Account number may be up to 10 digits long.
       # Add leading zeros to account number if < 10 digits.
@@ -233,6 +253,20 @@ module Ibandit
       local_details
     end
 
+    def self.clean_hr_details(local_details)
+      # This method supports being passed the component IBAN parts, as defined
+      # by SWIFT, or a single traditional-format string split by a '-'.
+      return local_details if local_details[:bank_code]
+      return local_details unless local_details[:account_number].include?('-')
+
+      bank_code, account_number = local_details[:account_number].split('-', 2)
+
+      {
+        bank_code:      bank_code,
+        account_number: account_number
+      }
+    end
+
     def self.clean_hu_details(local_details)
       # This method supports being passed the component IBAN parts, as defined
       # by SWIFT, or a single 16 or 24 digit string.
@@ -423,23 +457,8 @@ module Ibandit
     end
 
     def self.clean_sk_details(local_details)
-      #   The SWIFT definition of a Slovakian IBAN includes both the account
-      #   number prefix and the account number. This method therefore supports
-      #   passing those fields concatenated.
-      account_number =
-        if local_details.include?(:account_number_prefix)
-          [
-            local_details[:account_number_prefix].rjust(6, '0'),
-            local_details[:account_number].rjust(10, '0')
-          ].join
-        else
-          local_details[:account_number].tr('-', '').rjust(16, '0')
-        end
-
-      {
-        bank_code:      local_details[:bank_code],
-        account_number: account_number
-      }
+      # Slovakia uses the same local details method as the Czech Republic
+      clean_cz_details(local_details)
     end
 
     def self.clean_sm_details(local_details)

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = '0.6.5'.freeze
+  VERSION = '0.6.6'.freeze
 end

data/spec/ibandit/check_digit_spec.rb

@@ -126,6 +126,28 @@ describe Ibandit::CheckDigit do
     end
   end
 
+  describe '.croatian' do
+    subject { described_class.croatian(account_number) }
+
+    let(:account_number) { '0823' }
+    it { is_expected.to eq('5') }
+
+    context 'with another account number (double checking!)' do
+      let(:account_number) { '100100' }
+      it { is_expected.to eq('5') }
+    end
+
+    context 'with all zeros' do
+      let(:account_number) { '186300016' }
+      it { is_expected.to eq('0') }
+    end
+
+    context 'with a non-numeric character' do
+      let(:account_number) { '1BAD2014' }
+      specify { expect { subject }.to raise_error(/non-numeric character/) }
+    end
+  end
+
   describe '.icelandic' do
     subject { described_class.icelandic(kennitala) }
 

data/spec/ibandit/iban_assembler_spec.rb

@@ -123,6 +123,30 @@ describe Ibandit::IBANAssembler do
       end
     end
 
+    context 'with CZ as the country_code' do
+      let(:args) do
+        {
+          country_code: 'CZ',
+          bank_code: '0800',
+          account_number: '0000192000145399'
+        }
+      end
+
+      it { is_expected.to eq('CZ6508000000192000145399') }
+
+      it_behaves_like 'allows round trips', 'CZ65 0800 0000 1920 0014 5399'
+
+      context 'without a bank_code' do
+        before { args.delete(:bank_code) }
+        it { is_expected.to be_nil }
+      end
+
+      context 'without an account_number' do
+        before { args.delete(:account_number) }
+        it { is_expected.to be_nil }
+      end
+    end
+
     context 'with DE as the country_code' do
       let(:args) do
         { country_code: 'DE',
@@ -339,6 +363,28 @@ describe Ibandit::IBANAssembler do
       end
     end
 
+    context 'with HR as the country_code' do
+      let(:args) do
+        { country_code: 'HR',
+          bank_code: '1001005',
+          account_number: '1863000160' }
+      end
+
+      it { is_expected.to eq('HR1210010051863000160') }
+
+      it_behaves_like 'allows round trips', 'HR12 1001 0051 8630 0016 0'
+
+      context 'without a bank_code' do
+        before { args.delete(:bank_code) }
+        it { is_expected.to be_nil }
+      end
+
+      context 'without an account_number' do
+        before { args.delete(:account_number) }
+        it { is_expected.to be_nil }
+      end
+    end
+
     context 'with HU as the country_code' do
       let(:args) do
         {

data/spec/ibandit/local_details_cleaner_spec.rb

@@ -152,6 +152,37 @@ describe Ibandit::LocalDetailsCleaner do
     end
   end
 
+  context 'Czech Republic' do
+    let(:country_code) { 'CZ' }
+    let(:bank_code) { '0800' }
+    let(:account_number) { '0000192000145399' }
+
+    it { is_expected.to eq(local_details) }
+
+    context 'with an account number prefix' do
+      let(:prefix) { '000019' }
+      let(:account_number) { '2000145399' }
+      before { local_details.merge!(account_number_prefix: prefix) }
+
+      its([:account_number]) { is_expected.to eq('0000192000145399') }
+
+      context 'which needs zero-padding' do
+        let(:prefix) { '19' }
+        its([:account_number]) { is_expected.to eq('0000192000145399') }
+      end
+    end
+
+    context 'without a bank code' do
+      let(:bank_code) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+
+    context 'without an account number' do
+      let(:account_number) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+  end
+
   context 'Germany' do
     let(:country_code) { 'DE' }
     let(:bank_code) { '37040044' }
@@ -422,6 +453,33 @@ describe Ibandit::LocalDetailsCleaner do
     end
   end
 
+  context 'Croatia' do
+    let(:country_code) { 'HR' }
+    let(:bank_code) { '1001005' }
+    let(:account_number) { '1863000160' }
+
+    it { is_expected.to eq(local_details) }
+
+    context 'with bank code in the account number' do
+      let(:bank_code) { nil }
+      let(:branch_code) { nil }
+      let(:account_number) { '1001005-1863000160' }
+
+      its([:bank_code]) { is_expected.to eq('1001005') }
+      its([:account_number]) { is_expected.to eq('1863000160') }
+
+      context 'with a badly formatted account number' do
+        let(:account_number) { '1863000160' }
+        it { is_expected.to eq(local_details) }
+      end
+    end
+
+    context 'without an account number' do
+      let(:account_number) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+  end
+
   context 'Hungary' do
     let(:country_code) { 'HU' }
     let(:bank_code) { '117' }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.6.5
+  version: 0.6.6
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-30 00:00:00.000000000 Z
+date: 2015-07-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec