ibandit 0.6.3 → 0.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6e6050324d2f310c77a0a54383362e1dd827ed94
-  data.tar.gz: b59ac5d70f28fdda7e1b38d1308e976b4e229435
+  metadata.gz: 70681e650c635f6195db9716fc93ad3ddc4d6587
+  data.tar.gz: 8e3a5e7e949b8c55ab06e566a20aa509b73e8175
 SHA512:
-  metadata.gz: 5fd009bce7b5802bd35d188948736f64668fe1aa28e1bc553fd221b9a8cf49d26ea9a69fb9be0cc2bf1dcfc0fb1de5fd692280527c69c8e381feefb32647f2ee
-  data.tar.gz: e74d733a37d3178b0600bfe64697bd77c29c0eab197aeb0886b100cdd6afe1325bbeb407cecce383cdae4acbdd205238956b19e4ffa7e6aac0d3d21d83c714b9
+  metadata.gz: 270c923322faa85318a8b58fa0d4cc3dc68e00111d116918b4fbc54c9fc305175873d062955bf9630c025355c812ffb34f8a542ba72eaac40b806a8061de4e2d
+  data.tar.gz: ef757fd03c27b661e0e98a9f84f3b2c871fb20ac0166d686f9d25fb55e047a354481056f423a49cd2a882769d4a7edcd9ff288870a76a5efdc0063e0d25b3274

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.6.4 - July 28, 2015
+
+- Add Poland to LocalDetailsCleaner and IBANAssembler
+- Add Iceland to LocalDetailsCleaner and IBANAssembler
+
 ## 0.6.3 - July 25, 2015
 
 - Strip out additional '-' characters from Danish account numbers

data/README.md

@@ -249,6 +249,14 @@ iban = Ibandit::IBAN.new(
 )
 iban.iban                     # => "IE29AIBK93115212345678"
 
+# Iceland
+iban = Ibandit::IBAN.new(
+  country_code: 'IS',
+  bank_code: '1175'
+  account_number: '26-19530-670269-6399'
+)
+iban.iban                     # => "IS501175260195306702696399"
+
 # Italy
 iban = Ibandit::IBAN.new(
   country_code: 'IT',
@@ -315,6 +323,13 @@ iban = Ibandit::IBAN.new(
 )
 iban.iban                     # => "NO9386011117947"
 
+# Poland
+iban = Ibandit::IBAN.new(
+  country_code: 'PL',
+  account_number: '60102010260000042270201111',
+)
+iban.iban                     # => "PL60102010260000042270201111"
+
 # Portugal
 iban = Ibandit::IBAN.new(
   country_code: 'PT',

data/data/raw/structure_additions.yml

@@ -40,6 +40,9 @@ GB:
 HU:
   :bban_format: \d{3}\d{4}\d{1}\d{15}\d{1}
   :account_number_format: \d{1}\d{15}\d{1}
+IS:
+  :local_check_digit_position: 25
+  :local_check_digit_length: 1
 IT:
   :local_check_digit_position: 5
   :local_check_digit_length: 1

data/data/structures.yml

@@ -418,6 +418,8 @@ IS:
   :bban_format: \d{4}\d{2}\d{6}\d{10}
   :bank_code_format: \d{4}
   :account_number_format: \d{2}\d{6}\d{10}
+  :local_check_digit_position: 25
+  :local_check_digit_length: 1
 IT:
   :bank_code_position: 6
   :bank_code_length: 5

data/lib/ibandit/check_digit.rb

@@ -84,6 +84,25 @@ module Ibandit
       (scaled_values.inject(:+) % 10).to_s
     end
 
+    # Currently unused in this gem. This method calculates the penultimate digit
+    # of an Icelandic kennitala (included in the account number) when given the
+    # first 8 digits.
+    def self.icelandic(string)
+      weights = [3, 2, 7, 6, 5, 4, 3, 2]
+
+      scaled_values = string.chars.map.with_index do |char, index|
+        unless char.to_i.to_s == char
+          raise InvalidCharacterError,
+                "Unexpected non-numeric character '#{char}'"
+        end
+
+        char.to_i * weights[index % weights.size]
+      end
+
+      result = 11 - scaled_values.inject(:+) % 11
+      result < 10 ? result.to_s : '0'
+    end
+
     # Currently unused in this gem. This method calculates the last digit
     # of a Slovakian account number (basic) when given the initial digits.
     def self.slovakian_prefix(string)

data/lib/ibandit/iban_assembler.rb

@@ -1,7 +1,7 @@
 module Ibandit
   module IBANAssembler
-    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE DK EE ES FI FR GB GR IE IT LT LU LV
-                                 MC MT NL NO PT SE SI SK SM).freeze
+    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE DK EE ES FI FR GB GR IE IS IT LT LU
+                                 LV MC MT NL NO PL PT SE SI SK SM).freeze
 
     EXCEPTION_COUNTRY_CODES = %w(IT SM BE).freeze
 
@@ -84,7 +84,7 @@ module Ibandit
 
     def self.required_fields(country_code)
       case country_code
-      when *%w(AT CY DE EE FI LT LU LV NL NO SE SI SK DK)
+      when *%w(AT CY DE EE FI IS LT LU LV NL NO PL SE SI SK DK)
         %i(bank_code account_number)
       when 'BE'
         %i(account_number)

data/lib/ibandit/local_details_cleaner.rb

@@ -1,7 +1,7 @@
 module Ibandit
   module LocalDetailsCleaner
-    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE DK EE ES FI FR GB GR IE IT LT LU LV
-                                 MC MT NL NO PT SE SI SK SM).freeze
+    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE DK EE ES FI FR GB GR IE IS IT LT LU
+                                 LV MC MT NL NO PL PT SE SI SK SM).freeze
 
     def self.clean(local_details)
       country_code = local_details[:country_code]
@@ -29,7 +29,7 @@ module Ibandit
       case country_code
       when 'AT', 'CY', 'DE', 'FI', 'LT', 'LU', 'LV', 'NL', 'SI', 'SK'
         %i(bank_code account_number)
-      when 'BE', 'EE', 'ES', 'SE', 'NO', 'DK'
+      when 'BE', 'DK', 'EE', 'ES', 'SE', 'NO', 'PL', 'IS'
         %i(account_number)
       when 'GB', 'IE', 'MT'
         if Ibandit.bic_finder.nil? then %i(bank_code branch_code account_number)
@@ -248,6 +248,23 @@ module Ibandit
       }
     end
 
+    def self.clean_is_details(local_details)
+      if local_details[:bank_code]
+        bank_code = local_details[:bank_code]
+        parts = local_details[:account_number].split('-')
+      elsif local_details[:account_number].include?('-')
+        bank_code, *parts = local_details[:account_number].split('-')
+      else
+        bank_code = local_details[:account_number].slice(0, 4)
+        parts = Array(local_details[:account_number][4..-1])
+      end
+
+      {
+        bank_code:      bank_code.rjust(4, '0'),
+        account_number: pad_is_account_number(parts)
+      }
+    end
+
     def self.clean_it_details(local_details)
       # Add leading zeros to account number if < 12 digits.
       {
@@ -325,6 +342,25 @@ module Ibandit
       }
     end
 
+    def self.clean_pl_details(local_details)
+      # This method supports being passed the component IBAN parts, as defined
+      # by SWIFT, or a single 26 digit string.
+      if local_details[:bank_code]
+        bank_code      = local_details[:bank_code]
+        account_number = local_details[:account_number]
+      else
+        cleaned_acct_number = local_details[:account_number].gsub(/[\s]/, '')
+
+        bank_code      = cleaned_acct_number.slice(2, 8)
+        account_number = cleaned_acct_number[10..-1]
+      end
+
+      {
+        bank_code:      bank_code,
+        account_number: account_number
+      }
+    end
+
     def self.clean_pt_details(local_details)
       local_details
     end
@@ -373,5 +409,17 @@ module Ibandit
       # San Marino uses the same local details method as France
       clean_it_details(local_details)
     end
+
+    def self.pad_is_account_number(parts)
+      hufo           = parts[0].nil? ? '' : parts[0].rjust(2, '0')
+      reikningsnumer = parts[1].nil? ? '' : parts[1].rjust(6, '0')
+      ken_1          = parts[2].nil? ? '' : parts[2].rjust(6, '0')
+      ken_2          = parts[3].nil? ? '' : parts[3].rjust(4, '0')
+
+      kennitala      = ken_1.empty? ? '' : (ken_1 + ken_2).rjust(10, '0')
+
+      hufo + reikningsnumer + kennitala
+    end
+    private_class_method :pad_is_account_number
   end
 end

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = '0.6.3'.freeze
+  VERSION = '0.6.4'.freeze
 end

data/spec/ibandit/check_digit_spec.rb

@@ -104,6 +104,28 @@ describe Ibandit::CheckDigit do
     end
   end
 
+  describe '.icelandic' do
+    subject { described_class.icelandic(kennitala) }
+
+    let(:kennitala) { '52121206' }
+    it { is_expected.to eq('3') }
+
+    context 'with another kennitala (double checking!)' do
+      let(:kennitala) { '42027802' }
+      it { is_expected.to eq('0') }
+    end
+
+    context 'with a third kennitala (triple checking!)' do
+      let(:kennitala) { '12017433' }
+      it { is_expected.to eq('9') }
+    end
+
+    context 'with a non-numeric character' do
+      let(:kennitala) { '1BAD2014' }
+      specify { expect { subject }.to raise_error(/non-numeric character/) }
+    end
+  end
+
   describe '.norwegian' do
     subject { described_class.norwegian(account_number) }
 

data/spec/ibandit/iban_assembler_spec.rb

@@ -342,6 +342,30 @@ describe Ibandit::IBANAssembler do
       end
     end
 
+    context 'with IS as the country_code' do
+      let(:args) do
+        {
+          country_code: 'IS',
+          account_number: '260195306702696399',
+          bank_code: '1175'
+        }
+      end
+
+      it { is_expected.to eq('IS501175260195306702696399') }
+
+      it_behaves_like 'allows round trips', 'IS50 1175 2601 9530 6702 6963 99'
+
+      context 'without an account_number' do
+        before { args.delete(:account_number) }
+        it { is_expected.to be_nil }
+      end
+
+      context 'without a bank_code' do
+        before { args.delete(:bank_code) }
+        it { is_expected.to be_nil }
+      end
+    end
+
     context 'with IT as the country_code' do
       let(:args) do
         {
@@ -572,6 +596,32 @@ describe Ibandit::IBANAssembler do
       end
     end
 
+    context 'with PL as the country_code' do
+      let(:args) do
+        {
+          country_code: 'PL',
+          bank_code: '10201026',
+          account_number: '0000042270201111'
+        }
+      end
+
+      it { is_expected.to eq('PL60102010260000042270201111') }
+
+      it_behaves_like 'allows round trips', 'PL60 1020 1026 0000 0422 7020 1111'
+
+      context 'without a bank_code' do
+        before { args.delete(:bank_code) }
+        before { args[:account_number] = '60102010260000042270201111' }
+
+        it { is_expected.to be_nil }
+      end
+
+      context 'without an account_number' do
+        before { args.delete(:account_number) }
+        it { is_expected.to be_nil }
+      end
+    end
+
     context 'with PT as the country_code' do
       let(:args) do
         {

data/spec/ibandit/iban_spec.rb

@@ -1725,6 +1725,16 @@ describe Ibandit::IBAN do
       its(:local_check_digits) { is_expected.to eq('54') }
     end
 
+    context 'with a Norwegian IBAN' do
+      let(:iban_code) { 'NO9386011117947' }
+      its(:local_check_digits) { is_expected.to eq('7') }
+    end
+
+    context 'with an Icelandic IBAN' do
+      let(:iban_code) { 'IS250311260024684606972049' }
+      its(:local_check_digits) { is_expected.to eq('4') }
+    end
+
     context 'with a Slovakian IBAN' do
       let(:iban_code) { 'SK3112000000198742637541' }
       its(:local_check_digits) { is_expected.to eq('9') }

data/spec/ibandit/local_details_cleaner_spec.rb

@@ -472,6 +472,52 @@ describe Ibandit::LocalDetailsCleaner do
     end
   end
 
+  context 'Iceland' do
+    let(:country_code) { 'IS' }
+    let(:bank_code) { '311' }
+    let(:account_number) { '26-2468-460697-2049' }
+
+    its([:bank_code]) { is_expected.to eq('0311') }
+    its([:account_number]) { is_expected.to eq('260024684606972049') }
+
+    context 'with bank code in the account number' do
+      let(:bank_code) { nil }
+      let(:account_number) { '311-26-2468-460697-2049' }
+
+      its([:bank_code]) { is_expected.to eq('0311') }
+      its([:account_number]) { is_expected.to eq('260024684606972049') }
+
+      context 'and no hyphens' do
+        let(:account_number) { '0311260024684606972049' }
+
+        its([:bank_code]) { is_expected.to eq('0311') }
+        its([:account_number]) { is_expected.to eq('260024684606972049') }
+      end
+    end
+
+    context 'with no hyphen in the kennitala' do
+      let(:account_number) { '26-2468-4606972049' }
+
+      its([:account_number]) { is_expected.to eq('260024684606972049') }
+    end
+
+    context 'with a short kennitala' do
+      let(:account_number) { '26-2468-60697-2049' }
+
+      its([:account_number]) { is_expected.to eq('260024680606972049') }
+
+      context 'without a hyphen' do
+        let(:account_number) { '26-2468-606972049' }
+        its([:account_number]) { is_expected.to eq('260024680606972049') }
+      end
+    end
+
+    context 'without an account number' do
+      let(:account_number) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+  end
+
   context 'Italy' do
     let(:country_code) { 'IT' }
     let(:bank_code) { '05428' }
@@ -703,6 +749,28 @@ describe Ibandit::LocalDetailsCleaner do
     end
   end
 
+  context 'Poland' do
+    let(:country_code) { 'PL' }
+    let(:bank_code) { '10201026' }
+    let(:account_number) { '0000042270201111' }
+
+    it { is_expected.to eq(local_details) }
+
+    context 'with a full length account number' do
+      let(:bank_code) { nil }
+      let(:branch_code) { nil }
+      let(:account_number) { '60102010260000042270201111' }
+
+      its([:bank_code]) { is_expected.to eq('10201026') }
+      its([:account_number]) { is_expected.to eq('0000042270201111') }
+    end
+
+    context 'without an account number' do
+      let(:account_number) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+  end
+
   context 'Portugal' do
     let(:country_code) { 'PT' }
     let(:bank_code) { '0002' }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.6.3
+  version: 0.6.4
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-25 00:00:00.000000000 Z
+date: 2015-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec