ibandit 0.6.1 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b6b28e164036f1f3d80a9e52b12af42cc8452a37
-  data.tar.gz: 4e9aa3c2e839cbc7ba9e133c8f4151fe90f19dfb
+  metadata.gz: d371335a59f94320ee6d0d47b0387e3e240b48d9
+  data.tar.gz: a340177bde1374d3b6cea5fec8450560978d87d1
 SHA512:
-  metadata.gz: 7dd754b8daf06d399f2332c2ad55bfb57a1630708567ba3e08d96f68c33040faf46feb2ce0732e569cde3ec3e92f8c9b0137246ba79ae3978165bf7f85405340
-  data.tar.gz: ce8aa651ef4e7d42c92f9a5f75863cd8f0141064ca79ec4a450a0a1207f12e5e169fac46cf8cf4bc1c4d71fbf2df3ee7d0df6199506fcd122ce5c0f8913d7368
+  metadata.gz: 65c97889796f5c1e7b14b60da0e7d8a16fc750e5d9d8879d5722d5a86ef7cdb9666481ed07e66b32f04ed75c8de8dcdfa1e30a3b87a9b844ae9edc7bac184b19
+  data.tar.gz: 7e0cfce671a59389f8d254dcd5c35d4c1f75af538ba070bf050eee0153cc891eecffe21a51a120400980f00fff23c57579db7b50a6382debd2b711a100626cfb

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.6.2 - July 21, 2015
+
+- Add Denmark to LocalDetailsCleaner and IBANAssembler
+
 ## 0.6.1 - July 21, 2015
 
 - Add Norway to LocalDetailsCleaner and IBANAssembler

data/README.md

@@ -191,6 +191,13 @@ iban = Ibandit::IBAN.new(
 )
 iban.iban                     # => "DE89370400440532013000"
 
+# Denmark
+iban = Ibandit::IBAN.new(
+  country_code: 'DK',
+  account_number: '345-3179681',
+)
+iban.iban                     # => "DK8003450003179681"
+
 # Estonia
 iban = Ibandit::IBAN.new(
   country_code: 'EE',
@@ -302,14 +309,6 @@ iban = Ibandit::IBAN.new(
 iban.iban                     # => "NL91ABNA0417164300"
 
 # Norway
-iban = Ibandit::IBAN.new(
-  country_code: 'NO',
-  account_number: '1117947',
-  bank_code: '8601'
-)
-iban.iban                     # => "NO9386011117947"
-
-# Norway with 11 digit account number
 iban = Ibandit::IBAN.new(
   country_code: 'NO',
   account_number: '8601.1117947',

data/lib/ibandit/iban_assembler.rb

@@ -1,7 +1,7 @@
 module Ibandit
   module IBANAssembler
-    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE EE ES FI FR GB GR IE IT LT LU LV MC
-                                 MT NL NO PT SE SI SK SM).freeze
+    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE DK EE ES FI FR GB GR IE IT LT LU LV
+                                 MC MT NL NO PT SE SI SK SM).freeze
 
     EXCEPTION_COUNTRY_CODES = %w(IT SM BE).freeze
 
@@ -84,7 +84,7 @@ module Ibandit
 
     def self.required_fields(country_code)
       case country_code
-      when *%w(AT CY DE EE FI LT LU LV NL NO SE SI SK)
+      when *%w(AT CY DE EE FI LT LU LV NL NO SE SI SK DK)
         %i(bank_code account_number)
       when 'BE'
         %i(account_number)

data/lib/ibandit/local_details_cleaner.rb

@@ -1,7 +1,7 @@
 module Ibandit
   module LocalDetailsCleaner
-    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE EE ES FI FR GB GR IE IT LT LU LV MC
-                                 MT NL NO PT SE SI SK SM).freeze
+    SUPPORTED_COUNTRY_CODES = %w(AT BE CY DE DK EE ES FI FR GB GR IE IT LT LU LV
+                                 MC MT NL NO PT SE SI SK SM).freeze
 
     def self.clean(local_details)
       country_code = local_details[:country_code]
@@ -29,7 +29,7 @@ module Ibandit
       case country_code
       when 'AT', 'CY', 'DE', 'FI', 'LT', 'LU', 'LV', 'NL', 'SI', 'SK'
         %i(bank_code account_number)
-      when 'BE', 'EE', 'ES', 'SE', 'NO'
+      when 'BE', 'EE', 'ES', 'SE', 'NO', 'DK'
         %i(account_number)
       when 'GB', 'IE', 'MT'
         if Ibandit.bic_finder.nil? then %i(bank_code branch_code account_number)
@@ -111,6 +111,22 @@ module Ibandit
       }
     end
 
+    def self.clean_dk_details(local_details)
+      # This method supports being passed the component IBAN parts, as defined
+      # by SWIFT, or a single traditional-format string split by a '-'.
+      if local_details[:bank_code]
+        bank_code      = local_details[:bank_code].rjust(4, '0')
+        account_number = local_details[:account_number].rjust(10, '0')
+      else
+        bank_code, account_number = local_details[:account_number].split('-', 2)
+      end
+
+      {
+        bank_code:      bank_code.rjust(4, '0'),
+        account_number: account_number.rjust(10, '0')
+      }
+    end
+
     def self.clean_ee_details(local_details)
       # Account number may be up to 14 characters long.
       # Add leading zeros to account number if < 14 digits.

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = '0.6.1'.freeze
+  VERSION = '0.6.2'.freeze
 end

data/spec/ibandit/iban_assembler_spec.rb

@@ -120,6 +120,28 @@ describe Ibandit::IBANAssembler do
       end
     end
 
+    context 'with DK as the country_code' do
+      let(:args) do
+        { country_code: 'DK',
+          bank_code: '1199',
+          account_number: '0003179680' }
+      end
+
+      it { is_expected.to eq('DK2411990003179680') }
+
+      it_behaves_like 'allows round trips', 'DK24 1199 0003 1796 80'
+
+      context 'without a bank_code' do
+        before { args.delete(:bank_code) }
+        it { is_expected.to be_nil }
+      end
+
+      context 'without an account_number' do
+        before { args.delete(:account_number) }
+        it { is_expected.to be_nil }
+      end
+    end
+
     context 'with EE as the country_code' do
       let(:args) do
         {

data/spec/ibandit/local_details_cleaner_spec.rb

@@ -164,6 +164,29 @@ describe Ibandit::LocalDetailsCleaner do
     end
   end
 
+  context 'Denmark' do
+    let(:country_code) { 'DK' }
+    let(:bank_code) { '40' }
+    let(:account_number) { '440116243' }
+
+    its([:bank_code]) { is_expected.to eq('0040') }
+    its([:account_number]) { is_expected.to eq('0440116243') }
+
+    context 'with bank and branch codes in the account number' do
+      let(:bank_code) { nil }
+      let(:branch_code) { nil }
+      let(:account_number) { '345-3179681' }
+
+      its([:bank_code]) { is_expected.to eq('0345') }
+      its([:account_number]) { is_expected.to eq('0003179681') }
+    end
+
+    context 'without an account number' do
+      let(:account_number) { nil }
+      it { is_expected.to eq(local_details) }
+    end
+  end
+
   context 'Estonia' do
     let(:country_code) { 'EE' }
     let(:account_number) { '0221020145685' }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - Grey Baker