ibandit 0.4.5 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f88c8589210ccf1f924f9549ed48d364d4b0b8e4
-  data.tar.gz: 50fb4d41cefdd0e1c783707773b0d77b7ae81f83
+  metadata.gz: fc1eddf185fe692eb8722cb1d94f8069e21f80df
+  data.tar.gz: b9df021973596bdfa6df1f554685af30b2038059
 SHA512:
-  metadata.gz: 2ce1ae1432a7d4d244b2c66e1cbb2d9fd54f9f7bd1e27f1bea4624c48b2b6e9e3a4016770aba09d887f8219dce3d5f3564e42a9d0783504e0b4bffe62a48142e
-  data.tar.gz: 1783cc91ad10bac4e939a9dfc26f1e78b9fe8fe1248e71cbf2249a9f7ec650010d5c239f2856a47ddc54fe4d568e65825adc34b9575d9976bcccae4a97002d34
+  metadata.gz: 20535679cd0fcdd19e0ce57398d3bc0f4fa539761edb4706a466c34b4934347559903a63612db1a19d73f264490896efa33285220354cc00298a5bf0518ca593
+  data.tar.gz: aff6275493f96d55daf9a8a840b622b8c1fa97181762b0f8ef83a2e91a2f48a0d5bd868e6ef44cf48564557041c1654555ab0636059a23e2b8930d5a747f0a47

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.5.0 - July 12, 2015
+
+- Add an error for unsupported German bank details, and stop raising whilst
+  cleaning them
+
 ## 0.4.5 - June 25, 2015
 
 - Add Dutch translation

data/config/locales/de.yml

@@ -1,11 +1,12 @@
 de:
   ibandit:
-    is_required: 'muss ausgefüllt werden'
-    wrong_length: 'hat die falsche Länge (muss genau %{expected} Zeichen haben)'
-    is_invalid: 'ist nicht gültig'
     invalid_country_code: "'%{country_code}' ist keine gültige IBAN Länderkennung"
     invalid_check_digits: "Die Prüfzahlen sind inkorrekt. Erwartet wurde '%{expected_check_digits}', tatsächlich erhalten '%{check_digits}'."
     invalid_length: "Die Länge stimmt nicht mit der SWIFT Spezifikation überein (erwartet wurden %{expected_length} Zeichen, tatsächlich erhalten %{length})"
+    is_required: 'muss ausgefüllt werden'
+    wrong_length: 'hat die falsche Länge (muss genau %{expected} Zeichen haben)'
     not_used_in_country: "wird in %{country_code} nicht benutzt"
     non_alphanumeric_characters: "Nicht-alphanumerische Zeichen gefunden: %{characters}"
     invalid_format: "Unerwartetes Format für eine %{country_code} IBAN."
+    is_invalid: 'ist nicht gültig'
+    does_not_support_payments: "nicht Zahlungsverkehr unterstützt"

data/config/locales/en.yml

@@ -9,3 +9,4 @@ en:
     non_alphanumeric_characters: "Non-alphanumeric characters found: %{characters}"
     invalid_format: "Unexpected format for a %{country_code} IBAN."
     is_invalid: "is invalid"
+    does_not_support_payments: "does not support payments"

data/config/locales/es.yml

@@ -9,3 +9,4 @@ es:
     non_alphanumeric_characters: "Se han econtrado símbolos no alfanuméricos: %{characters}"
     invalid_format: "Formato inesperado para un IBAN de %{country_code}."
     is_invalid: "es inválido"
+    does_not_support_payments: "no admite pagos"

data/config/locales/fr.yml

@@ -9,3 +9,4 @@ fr:
     non_alphanumeric_characters: "Caractères non alphanumériques présents : %{characters}"
     invalid_format: "Format inconnu pour l'IBAN %{country_code}."
     is_invalid: "est invalide"
+    does_not_support_payments: "ne supporte pas les paiements"

data/config/locales/it.yml

@@ -9,3 +9,4 @@ it:
     non_alphanumeric_characters: "Un carattere non-alfanumerico è stato trovato: %{characters}"
     invalid_format: "Formato non atteso per un IBAN %{country_code}."
     is_invalid: "non è valido"
+    does_not_support_payments: "non supporta pagamenti"

data/config/locales/nl.yml

@@ -9,3 +9,4 @@ nl:
     non_alphanumeric_characters: "Niet-alfanumerieke tekens gevonden: %{characters}"
     invalid_format: "Onverwachte formaat voor een %{country_code} IBAN."
     is_invalid: "is ongeldig"
+    does_not_support_payments: "ondersteunt geen betalingen"

data/config/locales/pt.yml

@@ -9,3 +9,4 @@ pt:
     non_alphanumeric_characters: "Caracteres não alfanuméricos encontrados: %{characters}"
     invalid_format: "Formato errado para um IBAN %{country_code}."
     is_invalid: "é inválido"
+    does_not_support_payments: "não suporta pagamentos"

data/lib/ibandit/errors.rb

@@ -1,6 +1,4 @@
 module Ibandit
-  class BicNotFoundError < StandardError; end
   class InvalidCharacterError < StandardError; end
-  class UnsupportedCountryError < StandardError; end
   class UnsupportedAccountDetails < StandardError; end
 end

data/lib/ibandit/iban.rb

@@ -68,7 +68,8 @@ module Ibandit
         valid_bank_code_format?,
         valid_branch_code_format?,
         valid_account_number_format?,
-        valid_local_modulus_check?
+        valid_local_modulus_check?,
+        supports_iban_determination?
       ].all?
     end
 
@@ -224,6 +225,23 @@ module Ibandit
       valid_modulus_check_bank_code? && valid_modulus_check_account_number?
     end
 
+    def supports_iban_determination?
+      return unless valid_format?
+      return true unless country_code == 'DE'
+
+      begin
+        GermanDetailsConverter.convert(
+          country_code: country_code,
+          bank_code: bank_code,
+          account_number: account_number
+        )
+        true
+      rescue UnsupportedAccountDetails
+        @errors[:account_number] = Ibandit.translate(:does_not_support_payments)
+        false
+      end
+    end
+
     ###################
     # Private methods #
     ###################

data/lib/ibandit/local_details_cleaner.rb

@@ -96,7 +96,12 @@ module Ibandit
       # There are many exceptions to the way German bank details translate
       # into an IBAN, detailed into a 200 page document compiled by the
       # Bundesbank, and handled by the GermanDetailsConverter class.
-      converted_details = GermanDetailsConverter.convert(local_details)
+      converted_details =
+        begin
+          GermanDetailsConverter.convert(local_details)
+        rescue UnsupportedAccountDetails
+          local_details.dup
+        end
 
       return {} unless converted_details[:account_number].length >= 4
 

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = '0.4.5'.freeze
+  VERSION = '0.5.0'.freeze
 end

data/spec/ibandit/iban_spec.rb

@@ -1220,6 +1220,78 @@ describe Ibandit::IBAN do
         end
       end
     end
+
+    describe 'supports_iban_determination?' do
+      subject(:valid_local_modulus_check?) { iban.supports_iban_determination? }
+
+      context 'with unsupported account details' do
+        let(:arg) do
+          {
+            country_code: 'DE',
+            bank_code: '20000000',
+            account_number: '7955791111'
+          }
+        end
+
+        it { is_expected.to eq(false) }
+
+        context 'locale en', locale: :en do
+          specify do
+            iban.supports_iban_determination?
+            expect(iban.errors).
+              to include(account_number: 'does not support payments')
+          end
+        end
+
+        context 'locale fr', locale: :fr do
+          specify do
+            iban.supports_iban_determination?
+            expect(iban.errors).
+              to include(account_number: 'ne supporte pas les paiements')
+          end
+        end
+
+        context 'locale de', locale: :de do
+          specify do
+            iban.supports_iban_determination?
+            expect(iban.errors).
+              to include(account_number: 'nicht Zahlungsverkehr unterstützt')
+          end
+        end
+
+        context 'locale pt', locale: :pt do
+          specify do
+            iban.supports_iban_determination?
+            expect(iban.errors).
+              to include(account_number: 'não suporta pagamentos')
+          end
+        end
+
+        context 'locale es', locale: :es do
+          specify do
+            iban.supports_iban_determination?
+            expect(iban.errors).
+              to include(account_number: 'no admite pagos')
+          end
+        end
+
+        context 'locale it', locale: :it do
+          specify do
+            iban.supports_iban_determination?
+            expect(iban.errors).
+              to include(account_number: 'non supporta pagamenti')
+          end
+        end
+
+        context 'locale nl', locale: :nl do
+          specify do
+            iban.supports_iban_determination?
+            expect(iban.errors).
+              to include(account_number: 'ondersteunt geen betalingen')
+          end
+        end
+      end
+    end
   end
 
   describe '#valid?' do

data/spec/ibandit/local_details_cleaner_spec.rb

@@ -156,6 +156,12 @@ describe Ibandit::LocalDetailsCleaner do
       its([:bank_code]) { is_expected.to eq(bank_code) }
       its([:account_number]) { is_expected.to eq('0215022000') }
     end
+
+    context 'with unsupported account details' do
+      let(:account_number) { '7955791111' }
+      let(:bank_code) { '20000000' }
+      it { is_expected.to eq(local_details) }
+    end
   end
 
   context 'Estonia' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.4.5
+  version: 0.5.0
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-25 00:00:00.000000000 Z
+date: 2015-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec