ibandit 0.2.1 → 0.3.0

data/spec/ibandit/iban_spec.rb

@@ -1,7 +1,8 @@
 require 'spec_helper'
 
 describe Ibandit::IBAN do
-  subject(:iban) { described_class.new(iban_code) }
+  subject(:iban) { described_class.new(arg) }
+  let(:arg) { iban_code }
   let(:iban_code) { 'GB82WEST12345698765432' }
 
   its(:iban) { is_expected.to eq(iban_code) }
@@ -12,8 +13,34 @@ describe Ibandit::IBAN do
   end
 
   context 'with nil' do
-    let(:iban_code) { nil }
-    its(:iban) { is_expected.to eq('') }
+    let(:arg) { nil }
+    specify { expect { iban }.to raise_error(TypeError) }
+  end
+
+  context 'with local details' do
+    let(:arg) do
+      {
+        country_code: 'GB',
+        bank_code: 'WEST',
+        branch_code: '123456',
+        account_number: '98765432'
+      }
+    end
+
+    its(:iban) { is_expected.to eq('GB82WEST12345698765432') }
+  end
+
+  context 'with nil local details' do
+    let(:arg) do
+      {
+        country_code: nil,
+        bank_code: nil,
+        branch_code: nil,
+        account_number: nil
+      }
+    end
+
+    it { is_expected.to_not be_valid }
   end
 
   describe 'it decomposes the IBAN' do
@@ -23,19 +50,35 @@ describe Ibandit::IBAN do
     its(:branch_code) { is_expected.to eq('123456') }
     its(:account_number) { is_expected.to eq('98765432') }
     its(:iban_national_id) { is_expected.to eq('WEST123456') }
-    its(:local_check_digits) { is_expected.to eq('') }
+    its(:local_check_digits) { is_expected.to be_nil }
 
     context 'when the IBAN is blank' do
       let(:iban_code) { '' }
 
-      its(:country_code) { is_expected.to eq('') }
-      its(:check_digits) { is_expected.to eq('') }
-      its(:bank_code) { is_expected.to eq('') }
-      its(:branch_code) { is_expected.to eq('') }
-      its(:account_number) { is_expected.to eq('') }
-      its(:iban_national_id) { is_expected.to eq('') }
-      its(:bban) { is_expected.to eq('') }
-      its(:local_check_digits) { is_expected.to eq('') }
+      its(:country_code) { is_expected.to be_nil }
+      its(:check_digits) { is_expected.to be_nil }
+      its(:bank_code) { is_expected.to be_nil }
+      its(:branch_code) { is_expected.to be_nil }
+      its(:account_number) { is_expected.to be_nil }
+      its(:iban_national_id) { is_expected.to be_nil }
+      its(:bban) { is_expected.to be_nil }
+      its(:local_check_digits) { is_expected.to be_nil }
+    end
+
+    context 'when the IBAN was created with local details' do
+      let(:arg) do
+        {
+          country_code: 'GB',
+          bank_code: 'WES',
+          branch_code: '1234',
+          account_number: '5678'
+        }
+      end
+
+      its(:country_code) { is_expected.to eq(arg[:country_code]) }
+      its(:bank_code) { is_expected.to eq(arg[:bank_code]) }
+      its(:branch_code) { is_expected.to eq(arg[:branch_code]) }
+      its(:account_number) { is_expected.to eq(arg[:account_number]) }
     end
   end
 
@@ -48,6 +91,12 @@ describe Ibandit::IBAN do
     end
 
     specify { expect { iban.to_s(:russian) }.to raise_error ArgumentError }
+
+    context 'with the IBAN is nil' do
+      let(:arg) { { country_code: 'GB' } }
+      its(:to_s) { is_expected.to_not be_nil }
+      specify { expect(iban.to_s(:formatted)).to be_empty }
+    end
   end
 
   ###############
@@ -120,7 +169,6 @@ describe Ibandit::IBAN do
     subject { iban.valid_length? }
 
     context 'with valid details' do
-      let(:iban_code) { 'GB82WEST12345698765432' }
       it { is_expected.to eq(true) }
     end
 
@@ -145,6 +193,100 @@ describe Ibandit::IBAN do
     end
   end
 
+  describe '#valid_bank_code_length?' do
+    subject { iban.valid_bank_code_length? }
+
+    context 'with valid details' do
+      it { is_expected.to eq(true) }
+    end
+
+    context 'with invalid details' do
+      before { allow(iban).to receive(:bank_code).and_return('WES') }
+      it { is_expected.to eq(false) }
+
+      it 'sets errors on the IBAN' do
+        iban.valid_bank_code_length?
+        expect(iban.errors).to include(:bank_code)
+      end
+    end
+
+    context 'with an invalid country_code' do
+      before { allow(iban).to receive(:country_code).and_return('AA') }
+      it { is_expected.to be_nil }
+
+      it 'does not set errors on the IBAN' do
+        iban.valid_bank_code_length?
+        expect(iban.errors).to_not include(:bank_code)
+      end
+    end
+  end
+
+  describe '#valid_branch_code_length?' do
+    subject { iban.valid_branch_code_length? }
+
+    context 'with valid details' do
+      it { is_expected.to eq(true) }
+    end
+
+    context 'with invalid details' do
+      before { allow(iban).to receive(:branch_code).and_return('12345') }
+      it { is_expected.to eq(false) }
+
+      it 'sets errors on the IBAN' do
+        iban.valid_branch_code_length?
+        expect(iban.errors).to include(:branch_code)
+      end
+    end
+
+    context 'without a branch code' do
+      before { allow(iban).to receive(:branch_code).and_return(nil) }
+      it { is_expected.to eq(false) }
+
+      it 'sets errors on the IBAN' do
+        iban.valid_branch_code_length?
+        expect(iban.errors).to include(:branch_code)
+      end
+    end
+
+    context 'with an invalid country_code' do
+      before { allow(iban).to receive(:country_code).and_return('AA') }
+      it { is_expected.to be_nil }
+
+      it 'does not set errors on the IBAN' do
+        iban.valid_branch_code_length?
+        expect(iban.errors).to_not include(:branch_code)
+      end
+    end
+  end
+
+  describe '#valid_account_number_length?' do
+    subject { iban.valid_account_number_length? }
+
+    context 'with valid details' do
+      it { is_expected.to eq(true) }
+    end
+
+    context 'with an invalid account_number' do
+      before { allow(iban).to receive(:account_number).and_return('1234567') }
+      it { is_expected.to eq(false) }
+
+      it 'sets errors on the IBAN' do
+        iban.valid_account_number_length?
+        expect(iban.errors).to include(:account_number)
+      end
+    end
+
+    context 'with an invalid country_code' do
+      before { allow(iban).to receive(:country_code).and_return('AA') }
+      it { is_expected.to be_nil }
+
+      it 'does not set errors on the IBAN' do
+        iban.valid_account_number_length?
+        expect(iban.errors).to_not include(:account_number)
+      end
+    end
+  end
+
   describe '#valid_characters?' do
     subject { iban.valid_characters? }
 
@@ -193,6 +335,127 @@ describe Ibandit::IBAN do
     end
   end
 
+  describe '#valid_bank_code_format?' do
+    subject { iban.valid_bank_code_format? }
+
+    context 'GB numeric bank code' do
+      let(:arg) do
+        {
+          country_code: 'GB',
+          bank_code: '1234',
+          branch_code: '200000',
+          account_number: '55779911'
+        }
+      end
+
+      it { is_expected.to eq(false) }
+
+      it 'sets errors on the IBAN' do
+        iban.valid_bank_code_format?
+        expect(iban.errors).to include(:bank_code)
+      end
+    end
+
+    context 'with an invalid country code' do
+      let(:iban_code) { 'AA821234BANK121234567B' }
+
+      it { is_expected.to be_nil }
+    end
+
+    context 'with a wrong-length bank code' do
+      let(:arg) do
+        {
+          country_code: 'FR',
+          bank_code: '1234',
+          branch_code: '12345',
+          account_number: '123456789123'
+        }
+      end
+
+      it { is_expected.to be_nil }
+    end
+  end
+
+  describe '#valid_branch_code_format?' do
+    subject { iban.valid_branch_code_format? }
+
+    context 'IT non-numeric branch code' do
+      let(:arg) do
+        {
+          country_code: 'IT',
+          bank_code: '12345',
+          branch_code: 'ABCDE',
+          account_number: '123456789012'
+        }
+      end
+
+      it { is_expected.to eq(false) }
+
+      it 'sets errors on the IBAN' do
+        iban.valid_branch_code_format?
+        expect(iban.errors).to include(:branch_code)
+      end
+    end
+
+    context 'with an invalid country code' do
+      let(:iban_code) { 'AA821234BANK121234567B' }
+
+      it { is_expected.to be_nil }
+    end
+
+    context 'with a wrong-length branch code' do
+      let(:arg) do
+        {
+          country_code: 'PT',
+          bank_code: '1234',
+          branch_code: 'ABC',
+          account_number: '123456789123'
+        }
+      end
+
+      it { is_expected.to be_nil }
+    end
+  end
+
+  describe '#valid_account_number_format?' do
+    subject { iban.valid_account_number_format? }
+
+    context 'DE non-numeric account number' do
+      let(:arg) do
+        {
+          country_code: 'DE',
+          bank_code: '12345678',
+          account_number: '55779911AA'
+        }
+      end
+
+      it { is_expected.to eq(false) }
+
+      it 'sets errors on the IBAN' do
+        iban.valid_account_number_format?
+        expect(iban.errors).to include(:account_number)
+      end
+    end
+
+    context 'with an invalid country code' do
+      let(:iban_code) { 'AA821234BANK121234567B' }
+
+      it { is_expected.to be_nil }
+    end
+
+    context 'with a wrong-length account number' do
+      let(:arg) do
+        {
+          country_code: 'NL',
+          bank_code: 'ABCD',
+          account_number: nil
+        }
+      end
+
+      it { is_expected.to be_nil }
+    end
+  end
+
   describe '#valid?' do
     describe 'validations called' do
       after { iban.valid? }
@@ -201,7 +464,25 @@ describe Ibandit::IBAN do
       specify { expect(iban).to receive(:valid_characters?).at_least(1) }
       specify { expect(iban).to receive(:valid_check_digits?).at_least(1) }
       specify { expect(iban).to receive(:valid_length?).at_least(1) }
+      specify { expect(iban).to receive(:valid_bank_code_length?).at_least(1) }
       specify { expect(iban).to receive(:valid_format?).at_least(1) }
+      specify { expect(iban).to receive(:valid_bank_code_format?).at_least(1) }
+
+      it 'validates the branch code length' do
+        expect(iban).to receive(:valid_branch_code_length?).at_least(1)
+      end
+
+      it 'validates the account number length' do
+        expect(iban).to receive(:valid_account_number_length?).at_least(1)
+      end
+
+      it 'validates the branch code format' do
+        expect(iban).to receive(:valid_branch_code_format?).at_least(1)
+      end
+
+      it 'validates the account number format' do
+        expect(iban).to receive(:valid_account_number_format?).at_least(1)
+      end
     end
 
     context 'for a valid Albanian IBAN' do

data/spec/ibandit/iban_splitter_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe Ibandit::IBANSplitter do
+  subject(:split) { described_class.split(iban_code) }
+
+  context 'with a valid IBAN' do
+    let(:iban_code) { 'GB82WEST12345698765432' }
+    its([:country_code]) { is_expected.to eq('GB') }
+    its([:check_digits]) { is_expected.to eq('82') }
+    its([:bank_code]) { is_expected.to eq('WEST') }
+    its([:branch_code]) { is_expected.to eq('123456') }
+    its([:account_number]) { is_expected.to eq('98765432') }
+  end
+
+  context 'with nil' do
+    let(:iban_code) { nil }
+    its([:country_code]) { is_expected.to eq(nil) }
+    its([:check_digits]) { is_expected.to eq(nil) }
+    its([:bank_code]) { is_expected.to eq(nil) }
+    its([:branch_code]) { is_expected.to eq(nil) }
+    its([:account_number]) { is_expected.to eq(nil) }
+  end
+
+  context 'with an empty string' do
+    let(:iban_code) { '' }
+    its([:country_code]) { is_expected.to eq(nil) }
+    its([:check_digits]) { is_expected.to eq(nil) }
+    its([:bank_code]) { is_expected.to eq(nil) }
+    its([:branch_code]) { is_expected.to eq(nil) }
+    its([:account_number]) { is_expected.to eq(nil) }
+  end
+
+  context 'with an invalid length IBAN' do
+    let(:iban_code) { 'MC9320052222100112233M445' }
+    its([:country_code]) { is_expected.to eq('MC') }
+    its([:check_digits]) { is_expected.to eq(nil) }
+    its([:bank_code]) { is_expected.to eq(nil) }
+    its([:branch_code]) { is_expected.to eq(nil) }
+    its([:account_number]) { is_expected.to eq(nil) }
+  end
+end