ibandit 0.11.28 → 1.1.0.1

data/spec/ibandit/pseudo_iban_assembler_spec.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Ibandit::PseudoIBANAssembler do
-  subject(:pseudo_iban) { described_class.new(local_details).assemble }
+  subject(:pseudo_iban) { described_class.new(**local_details).assemble }
 
   context "for Sweden" do
     context "with valid parameters" do

data/spec/ibandit/pseudo_iban_splitter_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Ibandit::PseudoIBANSplitter do

data/spec/ibandit/structure_spec.rb

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe "structures.yml" do
-  FILE = File.expand_path("../../../data/structures.yml", __FILE__)
-  STRUCTURES = YAML.load_file(FILE)
+  structure_file = File.expand_path("../../data/structures.yml", __dir__)
+  structures = YAML.load_file(structure_file)
 
-  STRUCTURES.each do |country, rules|
+  structures.each do |country, rules|
     context country do
       rules.each do |rule, value|
-        next unless rule =~ /_format$/
+        next unless rule.to_s.end_with?("_format")
 
         it "builds #{rule} rule" do
           expect { Regexp.new(value) }.to_not raise_exception

data/spec/ibandit/sweden/local_details_converter_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Ibandit::Sweden::LocalDetailsConverter do
@@ -80,6 +82,7 @@ describe Ibandit::Sweden::LocalDetailsConverter do
           its([:account_number]) { is_expected.to eq("1024039") }
           its([:branch_code]) { is_expected.to eq("5439") }
           its([:swift_bank_code]) { is_expected.to eq("500") }
+
           its([:swift_account_number]) do
             is_expected.to eq("00000054391024039")
           end

data/spec/ibandit/sweden/validator_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Ibandit::Sweden::Validator do
@@ -8,16 +10,19 @@ describe Ibandit::Sweden::Validator do
 
     context "without a clearing code" do
       let(:clearing_code) { nil }
+
       it { is_expected.to eq(false) }
     end
 
     context "with an impossible clearing code" do
       let(:clearing_code) { "1001" }
+
       it { is_expected.to eq(false) }
     end
 
     context "with a possible clearing code" do
       let(:clearing_code) { "1101" }
+
       it { is_expected.to eq(true) }
     end
   end
@@ -27,26 +32,31 @@ describe Ibandit::Sweden::Validator do
 
     context "without a clearing code" do
       let(:clearing_code) { nil }
+
       it { is_expected.to eq(nil) }
     end
 
     context "with an impossible clearing code" do
       let(:clearing_code) { "1001" }
+
       it { is_expected.to eq(nil) }
     end
 
     context "with a correct length 4-digit clearing code" do
       let(:clearing_code) { "1101" }
+
       it { is_expected.to eq(true) }
     end
 
     context "with a correct length 5-digit clearing code" do
       let(:clearing_code) { "80001" }
+
       it { is_expected.to eq(true) }
     end
 
     context "with an incorrect length 5-digit clearing code" do
       let(:clearing_code) { "40001" }
+
       it { is_expected.to eq(false) }
     end
   end
@@ -60,42 +70,49 @@ describe Ibandit::Sweden::Validator do
     context "without a clearing code" do
       let(:clearing_code) { nil }
       let(:serial_number) { "1234567" }
+
       it { is_expected.to eq(nil) }
     end
 
     context "with an impossible clearing code" do
       let(:clearing_code) { "1001" }
       let(:serial_number) { "1234567" }
+
       it { is_expected.to eq(nil) }
     end
 
     context "with a correct length serial number" do
       let(:clearing_code) { "1101" }
       let(:serial_number) { "1234567" }
+
       it { is_expected.to eq(true) }
     end
 
     context "with an incorrect length serial number" do
       let(:clearing_code) { "1101" }
       let(:serial_number) { "123456" }
+
       it { is_expected.to eq(false) }
     end
 
     context "with a short serial number for a clearing code that zerofills" do
       let(:clearing_code) { "9960" }
       let(:serial_number) { "123456" }
+
       it { is_expected.to eq(true) }
     end
 
     context "with a long serial number for a clearing code that zerofills" do
       let(:clearing_code) { "9960" }
       let(:serial_number) { "12345678901" }
+
       it { is_expected.to eq(false) }
     end
 
     context "without a serial number" do
       let(:clearing_code) { "9960" }
       let(:serial_number) { nil }
+
       it { is_expected.to eq(false) }
     end
   end
@@ -105,16 +122,19 @@ describe Ibandit::Sweden::Validator do
 
     context "without a bank code" do
       let(:bank_code) { nil }
+
       it { is_expected.to eq(false) }
     end
 
     context "with an impossible bank code" do
       let(:bank_code) { "123" }
+
       it { is_expected.to eq(false) }
     end
 
     context "with a possible bank code" do
       let(:bank_code) { "120" }
+
       it { is_expected.to eq(true) }
     end
   end
@@ -130,18 +150,21 @@ describe Ibandit::Sweden::Validator do
     context "without a bank code" do
       let(:account_number) { "12810105723" }
       let(:bank_code) { nil }
+
       it { is_expected.to eq(nil) }
     end
 
     context "with an impossible bank code" do
       let(:account_number) { "12810105723" }
       let(:bank_code) { "500" }
+
       it { is_expected.to eq(false) }
     end
 
     context "with a possible bank code" do
       let(:account_number) { "12810105723" }
       let(:bank_code) { "120" }
+
       it { is_expected.to eq(true) }
     end
   end
@@ -157,29 +180,34 @@ describe Ibandit::Sweden::Validator do
     context "without a bank code" do
       let(:account_number) { "12810105723" }
       let(:bank_code) { nil }
+
       it { is_expected.to eq(nil) }
     end
 
     context "with an impossible bank code" do
       let(:account_number) { "12810105723" }
       let(:bank_code) { "500" }
+
       it { is_expected.to eq(nil) }
     end
 
     context "with a normal type-1 account number" do
       let(:account_number) { "00000054391024039" }
       let(:bank_code) { "500" }
+
       it { is_expected.to eq(true) }
 
       context "that has a 6 digit serial number" do
         let(:account_number) { "00000005439102403" }
         let(:bank_code) { "500" }
+
         it { is_expected.to eq(false) }
       end
 
       context "that has an 8 digit serial number" do
         let(:account_number) { "00000543910240391" }
         let(:bank_code) { "500" }
+
         it { is_expected.to eq(false) }
       end
     end
@@ -187,11 +215,13 @@ describe Ibandit::Sweden::Validator do
     context "with a Danske bank account" do
       let(:account_number) { "12810105723" }
       let(:bank_code) { "120" }
+
       it { is_expected.to eq(true) }
 
       context "that has an 8 digit serial number" do
         let(:account_number) { "00000128101057231" }
         let(:bank_code) { "120" }
+
         it { is_expected.to eq(false) }
       end
 
@@ -200,6 +230,7 @@ describe Ibandit::Sweden::Validator do
         let(:bank_code) { "120" }
         # This passes because it could be a 10 digit account number from the
         # clearing code range 9180-9189.
+
         it { is_expected.to eq(true) }
       end
     end
@@ -207,15 +238,18 @@ describe Ibandit::Sweden::Validator do
     context "with a Handelsbanken account number" do
       let(:bank_code) { "600" }
       let(:account_number) { "00000000219161038" }
+
       it { is_expected.to eq(true) }
 
       context "that is only 8 characters long" do
         let(:account_number) { "00000000021916103" }
+
         it { is_expected.to eq(true) }
       end
 
       context "that is 10 characters long" do
         let(:account_number) { "00000002191610381" }
+
         it { is_expected.to eq(false) }
       end
     end
@@ -223,6 +257,7 @@ describe Ibandit::Sweden::Validator do
     context "without a Nordea PlusGirot account number" do
       let(:bank_code) { "950" }
       let(:account_number) { "00099603401258276" }
+
       it { is_expected.to eq(true) }
     end
   end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "ibandit"
 require "rspec/its"
 require "json"

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.11.28
+  version: 1.1.0.1
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-30 00:00:00.000000000 Z
+date: 2020-06-17 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: gc_ruboconfig
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.12.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.12.0
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -81,19 +95,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.2'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: rspec_junit_formatter
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.52.0
+        version: 0.4.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.52.0
+        version: 0.4.1
 - !ruby/object:Gem::Dependency
   name: sax-machine
   requirement: !ruby/object:Gem::Requirement
@@ -131,10 +145,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".gitignore"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE
@@ -209,8 +223,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2.3
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.

data/.travis.yml

@@ -1,16 +0,0 @@
-language: ruby
-
-matrix:
-  allow_failures:
-
-rvm:
-  - 2.1.10
-  - 2.2.7
-  - 2.3.4
-  - 2.4.1
-
-sudo: false
-
-script:
-  - bundle exec rubocop
-  - bundle exec rspec spec