ibandit 0.11.28 → 1.0.0

data/lib/ibandit/pseudo_iban_assembler.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ibandit
   class PseudoIBANAssembler
     def initialize(country_code: nil,
@@ -53,7 +55,8 @@ module Ibandit
 
     def param_valid?(value, length_key)
       return true unless value.nil?
-      return true if structure[length_key] == 0
+      return true if structure[length_key]&.zero?
+
       false
     end
 
@@ -71,6 +74,7 @@ module Ibandit
 
     def pad(number, length_key)
       return if number.nil?
+
       number.rjust(structure[length_key], padding_character)
     end
 

data/lib/ibandit/pseudo_iban_splitter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ibandit
   class PseudoIBANSplitter
     def initialize(pseudo_iban)
@@ -26,16 +28,19 @@ module Ibandit
 
     def bank_code
       return unless country_code_valid?
+
       pseudo_iban_part(bank_code_start_index, :pseudo_iban_bank_code_length)
     end
 
     def branch_code
       return unless country_code_valid?
+
       pseudo_iban_part(branch_code_start_index, :pseudo_iban_branch_code_length)
     end
 
     def account_number
       return unless country_code_valid?
+
       remove_leading_padding(
         @pseudo_iban.slice(account_number_start_index, @pseudo_iban.length),
       )
@@ -43,7 +48,7 @@ module Ibandit
 
     def pseudo_iban_part(start_index, length_key)
       length = structure.fetch(length_key)
-      return if length == 0
+      return if length&.zero?
 
       remove_leading_padding(@pseudo_iban.slice(start_index, length))
     end
@@ -74,6 +79,7 @@ module Ibandit
 
     def remove_leading_padding(input)
       return unless padding_character
+
       input.gsub(/\A#{padding_character}+/, "")
     end
   end

data/lib/ibandit/sweden/bank_lookup.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ibandit
   module Sweden
     class BankLookup

data/lib/ibandit/sweden/local_details_converter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ibandit
   module Sweden
     class LocalDetailsConverter
@@ -44,6 +46,7 @@ module Ibandit
 
       def remove_bad_chars(number)
         return if number.nil?
+
         number.gsub(/[-.\s]/, "")
       end
 
@@ -76,7 +79,8 @@ module Ibandit
                         end
 
         return serial_number unless bank_info.fetch(:zerofill_serial_number)
-        serial_number && serial_number.rjust(serial_number_length, "0")
+
+        serial_number&.rjust(serial_number_length, "0")
       end
 
       def swift_account_number
@@ -84,7 +88,7 @@ module Ibandit
             clearing_code && serial_number
           (clearing_code + serial_number).rjust(17, "0")
         else
-          serial_number && serial_number.rjust(17, "0")
+          serial_number&.rjust(17, "0")
         end
       end
     end

data/lib/ibandit/sweden/validator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ibandit
   module Sweden
     class Validator

data/lib/ibandit/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ibandit
-  VERSION = "0.11.28".freeze
+  VERSION = "1.0.0"
 end

data/spec/ibandit/constants_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Ibandit::Constants do

data/spec/ibandit/german_details_converter_spec.rb

@@ -1,15 +1,17 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Ibandit::GermanDetailsConverter do
   shared_examples "json based fixture" do |json_fixture_file|
     json_fixture(json_fixture_file).each do |convertor|
       context "Rule #{convertor['convertor']}" do
+        subject { test_subject }
+
         let(:klass) do
           described_class.const_get("Rule#{convertor['convertor']}")
         end
 
-        subject { test_subject }
-
         before do
           expect_any_instance_of(klass).to receive(:converted_details).
             and_call_original
@@ -30,8 +32,9 @@ describe Ibandit::GermanDetailsConverter do
             let(:converted_account_number) do
               tuple["converted_account_number"] || account_number
             end
+
             it do
-              is_expected.to eq(
+              expect(subject).to eq(
                 bank_code: converted_bank_code,
                 account_number: converted_account_number,
               )
@@ -44,6 +47,7 @@ describe Ibandit::GermanDetailsConverter do
             "#{tuple['account_number']}" do
             let(:bank_code) { tuple["bank_code"] || "00000000" }
             let(:account_number) { tuple["account_number"] }
+
             it "raises UnsupportedAccountDetails" do
               expect { subject }.
                 to raise_error(Ibandit::UnsupportedAccountDetails)
@@ -88,6 +92,7 @@ describe Ibandit::GermanDetailsConverter do
     valid_account_numbers.each do |number|
       context number.to_s do
         let(:account_number) { number }
+
         it { is_expected.to be_valid }
       end
     end
@@ -95,6 +100,7 @@ describe Ibandit::GermanDetailsConverter do
     invalid_account_numbers.each do |number|
       context number.to_s do
         let(:account_number) { number }
+
         it { is_expected.to_not be_valid }
       end
     end

data/spec/ibandit/iban_assembler_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Ibandit::IBANAssembler do
@@ -5,10 +7,10 @@ describe Ibandit::IBANAssembler do
     let(:iban) { Ibandit::IBAN.new(iban_code) }
     let(:args) do
       {
-        country_code:   iban.country_code,
+        country_code: iban.country_code,
         account_number: iban.swift_account_number,
-        branch_code:    iban.swift_branch_code,
-        bank_code:      iban.swift_bank_code,
+        branch_code: iban.swift_branch_code,
+        bank_code: iban.swift_bank_code,
       }.reject { |_key, value| value.nil? }
     end
 
@@ -19,15 +21,18 @@ describe Ibandit::IBANAssembler do
 
   describe ".assemble" do
     subject(:assemble) { described_class.assemble(args) }
+
     let(:args) { { country_code: "ES" } }
 
     context "without a country_code" do
       let(:args) { { bank_code: 1 } }
+
       it { is_expected.to be_nil }
     end
 
     context "with an unsupported country_code" do
       let(:args) { { country_code: "FU" } }
+
       it { is_expected.to be_nil }
     end
 
@@ -46,11 +51,13 @@ describe Ibandit::IBANAssembler do
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -64,6 +71,7 @@ describe Ibandit::IBANAssembler do
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -84,11 +92,13 @@ describe Ibandit::IBANAssembler do
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -109,16 +119,19 @@ describe Ibandit::IBANAssembler do
 
       context "without an branch_code" do
         before { args.delete(:branch_code) }
+
         it { is_expected.to eq("CY040020000001200527600") }
       end
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -138,11 +151,13 @@ describe Ibandit::IBANAssembler do
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -160,11 +175,13 @@ describe Ibandit::IBANAssembler do
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -182,11 +199,13 @@ describe Ibandit::IBANAssembler do
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -206,6 +225,7 @@ describe Ibandit::IBANAssembler do
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -226,7 +246,9 @@ describe Ibandit::IBANAssembler do
 
       context "without a bank_code or branch code" do
         before { args.delete(:bank_code) }
+
         before { args.delete(:branch_code) }
+
         before { args[:account_number] = "23100001180000012345" }
 
         it { is_expected.to be_nil }
@@ -234,6 +256,7 @@ describe Ibandit::IBANAssembler do
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -249,11 +272,13 @@ describe Ibandit::IBANAssembler do
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -274,21 +299,25 @@ describe Ibandit::IBANAssembler do
 
       context "without the rib key in the account number" do
         before { args[:account_number] = "0500013M026" }
+
         specify { expect(Ibandit::IBAN.new(assemble)).to_not be_valid }
       end
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a branch_code" do
         before { args.delete(:branch_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -309,26 +338,31 @@ describe Ibandit::IBANAssembler do
 
       context "with the bank_code supplied manually" do
         before { args.merge!(bank_code: "BARC") }
+
         it { is_expected.to eq("GB07BARC20000000579135") }
       end
 
       context "without a branch_code" do
         before { args.delete(:branch_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "with a non-numeric branch code" do
         before { args[:branch_code] = "abc123" }
+
         it { is_expected.to be_nil }
       end
     end
@@ -349,16 +383,19 @@ describe Ibandit::IBANAssembler do
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a branch_code" do
         before { args.delete(:branch_code) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -376,11 +413,13 @@ describe Ibandit::IBANAssembler do
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -401,7 +440,9 @@ describe Ibandit::IBANAssembler do
 
       context "without a bank_code or branch_code" do
         before { args.delete(:bank_code) }
+
         before { args.delete(:branch_code) }
+
         before { args[:account_number] = "11773016-11111018-00000000" }
 
         it { is_expected.to be_nil }
@@ -409,6 +450,7 @@ describe Ibandit::IBANAssembler do
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         before { args[:account_number] = "11773016-11111018-00000000" }
 
         it { is_expected.to be_nil }
@@ -416,6 +458,7 @@ describe Ibandit::IBANAssembler do
 
       context "without a branch_code" do
         before { args.delete(:branch_code) }
+
         before { args[:account_number] = "11773016-11111018-00000000" }
 
         it { is_expected.to be_nil }
@@ -423,6 +466,7 @@ describe Ibandit::IBANAssembler do
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -441,16 +485,19 @@ describe Ibandit::IBANAssembler do
 
       context "without a branch_code" do
         before { args.delete(:branch_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -470,11 +517,13 @@ describe Ibandit::IBANAssembler do
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -495,31 +544,37 @@ describe Ibandit::IBANAssembler do
 
       context "with an explicitly passed check digit" do
         before { args[:check_digit] = "Y" }
+
         it { is_expected.to eq("IT64Y0542811101000000123456") }
       end
 
       context "with a bad character in an odd position" do
         before { args[:account_number] = "000000123h00" }
+
         it { is_expected.to be_nil }
       end
 
       context "with a bad character in an even position" do
         before { args[:account_number] = "0000001230h0" }
+
         it { is_expected.to be_nil }
       end
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a branch_code" do
         before { args.delete(:branch_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -539,11 +594,13 @@ describe Ibandit::IBANAssembler do
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -563,11 +620,13 @@ describe Ibandit::IBANAssembler do
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -587,11 +646,13 @@ describe Ibandit::IBANAssembler do
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -612,21 +673,25 @@ describe Ibandit::IBANAssembler do
 
       context "without the rib key in the account number" do
         before { args[:account_number] = "0500013M026" }
+
         specify { expect(Ibandit::IBAN.new(assemble)).to_not be_valid }
       end
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a branch_code" do
         before { args.delete(:branch_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -650,21 +715,25 @@ describe Ibandit::IBANAssembler do
 
       context "without a branch_code" do
         before { args.delete(:branch_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "with a non-numeric branch code" do
         before { args[:branch_code] = "abc123" }
+
         it { is_expected.to be_nil }
       end
     end
@@ -684,11 +753,13 @@ describe Ibandit::IBANAssembler do
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -708,6 +779,7 @@ describe Ibandit::IBANAssembler do
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         before { args[:account_number] = "86011117947" }
 
         it { is_expected.to be_nil }
@@ -715,6 +787,7 @@ describe Ibandit::IBANAssembler do
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -734,6 +807,7 @@ describe Ibandit::IBANAssembler do
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         before { args[:account_number] = "60102010260000042270201111" }
 
         it { is_expected.to be_nil }
@@ -741,6 +815,7 @@ describe Ibandit::IBANAssembler do
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -761,16 +836,19 @@ describe Ibandit::IBANAssembler do
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a branch_code" do
         before { args.delete(:branch_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -790,11 +868,13 @@ describe Ibandit::IBANAssembler do
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -814,11 +894,13 @@ describe Ibandit::IBANAssembler do
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -838,11 +920,13 @@ describe Ibandit::IBANAssembler do
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -862,11 +946,13 @@ describe Ibandit::IBANAssembler do
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end
@@ -887,16 +973,19 @@ describe Ibandit::IBANAssembler do
 
       context "without a bank_code" do
         before { args.delete(:bank_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without a branch_code" do
         before { args.delete(:branch_code) }
+
         it { is_expected.to be_nil }
       end
 
       context "without an account_number" do
         before { args.delete(:account_number) }
+
         it { is_expected.to be_nil }
       end
     end