ibandit 0.11.26 → 0.11.27

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 73a5ffec9e66a0ebf5dccf613bedb5e0da311444
-  data.tar.gz: a6d3de9434b4b87e3df2b9a6a4e6c841331b949c
+  metadata.gz: 0ef65b4d6eedd45de97dbe15a3b2b3996df05e1c
+  data.tar.gz: 9e886c94b5513ad76d1d3941f1924db6a011608b
 SHA512:
-  metadata.gz: ce3d098232431f5d49b2c533afe6eac7ca260cabfcda9add4ff4cc2b3b0a3bb1bae8d98e3a0bfda1416d5ea0c96533bb9b31b38ab4f5cc06800a49e93d7f19f0
-  data.tar.gz: 6612b734b2bad0b49af6d2460b4536a26bea154ed81011c654c02202c68bc3d34db4b290dc1731831c0b77480202dc7f32c88bb86f507894a3bc3d23f9b4ddae
+  metadata.gz: 7b292f452af4977a2799591335975db4cec051ad0a8ce2c686eb89de0e8439476855885ed820f021508fca1f127b0622b098320855bc71e8e957e9f099049b8f
+  data.tar.gz: d01ef104eb0fad531e3b79dbf1973e9cfc94b786de4403915bbb95ba59060ef7f4d20e2719330f44aef9dc2b70b6f0456269342859592720f362ff0a1f3c6032

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.11.27 - February 22, 2019
+
+- Update US account number format validation to allow digits-only
+
 ## 0.11.26 - January 30, 2019
 
 - Add support for US pseudo-IBANs

data/data/structures.yml

@@ -902,8 +902,7 @@ US:
   :branch_code_length: 0
   :account_number_length: 17
   :bank_code_format: "\\d{9}"
-  # TODO: update account number format based on inputs from user research
-  :account_number_format: ".{1,17}"
+  :account_number_format: "\\A_*\\d{1,17}\\z"
   :national_id_length: 9
   :pseudo_iban_bank_code_length: 9
   :pseudo_iban_branch_code_length: 0

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = "0.11.26".freeze
+  VERSION = "0.11.27".freeze
 end

data/spec/ibandit/iban_spec.rb

@@ -724,7 +724,7 @@ describe Ibandit::IBAN do
       its(:to_s) { is_expected.to eq("") }
     end
 
-    context "when the input is an invalid US pseudo-IBAN" do
+    context "when the input pseudo-IBAN has an invalid US bank_code" do
       let(:arg) { "USZZ__012345601234567890123456" }
 
       it "is invalid and has the correct errors" do
@@ -733,6 +733,15 @@ describe Ibandit::IBAN do
           to eq(bank_code: "is the wrong length (should be 9 characters)")
       end
     end
+
+    context "when the input pseudo-IBAN has an invalid US account_number" do
+      let(:arg) { "USZZ965498456ABC01234567890123" }
+
+      it "is invalid and has an error populated" do
+        expect(subject.valid?).to eq(false)
+        expect(subject.errors).to eq(account_number: "is invalid")
+      end
+    end
   end
 
   describe "#to_s" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.11.26
+  version: 0.11.27
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-30 00:00:00.000000000 Z
+date: 2019-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri