ibandit 0.11.23 → 0.11.24

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 0a541f50d4ef769df481b72fb36721389dee789f3b1999f20de23775f7523ef4
-  data.tar.gz: 6e4317de4d3169b29dc6622ee30fbcd8c8b35be6d442ce3a26a4368b5618c8d9
+SHA1:
+  metadata.gz: 668b1fb51b7cf069a3571031168991cdb97f0ea2
+  data.tar.gz: 4bfe3207906007a781617a7dbff3bbbe6bb82f25
 SHA512:
-  metadata.gz: d1e7d29847abf410e11231539ba884fd0e542ea897a7ced9a888a737514fd33d76a8f5a67fbc66a87a1c714a89a39eab7fe9e44341e6073ab5fa7dafd7f5b459
-  data.tar.gz: c690750c7f99853e34f08d973f02e02da391e7e7b7795c4d16e2abdde2be577d1ade377a42d289092df012a3ef3b4c0d0c24f17081693f2d3ce7ecb630e9d174
+  metadata.gz: bb3d8b5054d45f508f88a686040dfc51a8a3e4bd1971fe54300c31015cc5cd34ed81a8788740574f703d59738651b49f1852db0156bd22d35c4c8afdd6f19a5c
+  data.tar.gz: fe66a3af2e980f0f40d09e4db3b99391cfa3442cd23ce14a31e780b9d6a1ee0bcbc3e0c05f112d387b820b03fb7fe4dffedc6360eca2273832d881503fd8b466

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.11.24 - December 13, 2018
+
+- Add support for 3-digit financial institution numbers in Canada
+
 ## 0.11.23 - December 5, 2018
 
 - Add support for validating Canadian branch codes if a modulus checker is configured

data/README.md

@@ -523,7 +523,7 @@ iban.iban                     # => nil
 # Canada
 iban = Ibandit::IBAN.new(
   country_code: 'CA',
-  bank_code: '0036',          # 4 Financial Institution number
+  bank_code: '0036',          # 3 or 4 digit Financial Institution number
   branch_code: '00063',       # 5 digit Branch Transit number
   account_number: '0123456'   # 7 to 12 digits
 )

data/lib/ibandit/local_details_cleaner.rb

@@ -87,7 +87,16 @@ module Ibandit
     def self.clean_ca_details(local_details)
       return {} if local_details[:account_number].length < 7 # minimum length
 
-      { account_number: local_details[:account_number].rjust(12, "0") }
+      bank_code = if local_details[:bank_code].length == 3
+                    local_details[:bank_code].rjust(4, "0")
+                  else
+                    local_details[:bank_code]
+                  end
+
+      {
+        account_number: local_details[:account_number].rjust(12, "0"),
+        bank_code: bank_code,
+      }
     end
 
     def self.clean_bg_details(local_details)

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = "0.11.23".freeze
+  VERSION = "0.11.24".freeze
 end

data/spec/ibandit/iban_spec.rb

@@ -362,14 +362,53 @@ describe Ibandit::IBAN do
       let(:arg) do
         {
           country_code: "CA",
-          bank_code: "0036",
+          bank_code: bank_code,
           branch_code: "00063",
           account_number: account_number,
         }
       end
 
+      context "and a 3 digit bank code" do
+        let(:account_number) { "0123456" }
+        let(:bank_code) { "036" }
+
+        its(:country_code) { is_expected.to eq("CA") }
+        its(:bank_code) { is_expected.to eq("0036") }
+        its(:branch_code) { is_expected.to eq("00063") }
+        its(:account_number) { is_expected.to eq("000000123456") }
+        its(:swift_bank_code) { is_expected.to eq("0036") }
+        its(:swift_branch_code) { is_expected.to eq("00063") }
+        its(:swift_account_number) { is_expected.to eq("000000123456") }
+        its(:swift_national_id) { is_expected.to eq("0036") }
+        its(:pseudo_iban) { is_expected.to eq("CAZZ003600063000000123456") }
+
+        its(:iban) { is_expected.to be_nil }
+        its(:valid?) { is_expected.to eq(true) }
+        its(:to_s) { is_expected.to eq("") }
+      end
+
+      context "and a 2 digit bank code" do
+        let(:account_number) { "0123456" }
+        let(:bank_code) { "36" }
+
+        its(:country_code) { is_expected.to eq("CA") }
+        its(:bank_code) { is_expected.to eq("36") }
+        its(:branch_code) { is_expected.to eq("00063") }
+        its(:account_number) { is_expected.to eq("000000123456") }
+        its(:swift_bank_code) { is_expected.to eq("36") }
+        its(:swift_branch_code) { is_expected.to eq("00063") }
+        its(:swift_account_number) { is_expected.to eq("000000123456") }
+        its(:swift_national_id) { is_expected.to eq("3600") }
+        its(:pseudo_iban) { is_expected.to eq("CAZZ__3600063000000123456") }
+
+        its(:iban) { is_expected.to be_nil }
+        its(:valid?) { is_expected.to eq(false) }
+        its(:to_s) { is_expected.to eq("") }
+      end
+
       context "and a 7 digit account number" do
         let(:account_number) { "0123456" }
+        let(:bank_code) { "0036" }
 
         its(:country_code) { is_expected.to eq("CA") }
         its(:bank_code) { is_expected.to eq("0036") }
@@ -388,6 +427,7 @@ describe Ibandit::IBAN do
 
       context "and a 12 digit account number" do
         let(:account_number) { "012345678900" }
+        let(:bank_code) { "0036" }
 
         its(:country_code) { is_expected.to eq("CA") }
         its(:bank_code) { is_expected.to eq("0036") }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.11.23
+  version: 0.11.24
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-05 00:00:00.000000000 Z
+date: 2018-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -210,7 +210,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.5.2.3
 signing_key: 
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.